- 19 Mar, 2020 40 commits
-
-
Xing Liu authored
This CL adds image cache protobuf and store interfaces. No implementation is added yet. The raw bytes are saved in a separate store, which only supports loading one image at a time in its API. Bug: 1058534 Change-Id: I0646b9906b81432e39f29dd5f235481d12a756c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108180Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751729}
-
Jeff Yoon authored
additional compile targets cause tests that use the test template in test.gni to generate more than once, making ninja unhappy as there are multiple rules that generate the script. The underlying test wrapper was using root_build_dir. Swapping to root_out_dir Bug: 1063028 Change-Id: I4dffec31bd366ae6811307bae1acd5046d10ea97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109463 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751728}
-
Fergal Daly authored
As discussed in http://docs/document/u/1/d/1ZHWWEYT1L5Zgh2lpC7DHXXZjKcptI877KKOqjqxE2Ns/edit we will not have 3 boolean flags for enabled new-RFH behaviour, instead we will have a level param from all-disabled to all-enabled. Add a RenderDocumentLevel enum, controlling what is enabled. Move uses of IsRenderDocumentEnabled to IsRenderDocumentEnabledForSubFrame and implements that and IsRenderDocumentEnabledForCrashedFrame in terms of level. Since there are now a lot of parameterized tests all parameterized by the same list of strings, this also adds some test helper code to ensure consistency. I will submit a change to the finch config before submitting this. Bug: 981339 Change-Id: I9340a89c22703018c515edd97ba8580abc2e7e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098156 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751727}
-
Garrett Beaty authored
Change-Id: I7f8bf64cbe8db266f0cc1654204712c9db8ae090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107768 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#751726}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bc98fbeec99b..fb670f56acbd git log bc98fbeec99b..fb670f56acbd --date=short --first-parent --format='%ad %ae %s' 2020-03-19 amaiorano@google.com marl: manually apply partial patch to fix x86 crashes Created with: gclient setdep -r src/third_party/swiftshader@fb670f56acbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia8e7bd4ba48117b8d12867a9d5162ff102e74984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751725}
-
W. James MacLean authored
This CL temporarily re-enables PDFExtensionTestWithTestGuestViewManager. PdfExtensionLoadedInGuest in order to collect some diagnostic data, since reproducing the flake locally has been unsuccessful. Bug: 1034972 Change-Id: If2fc14acb655d692414a70b890218321ccf6844f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110072 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751724}
-
Paulo Warren authored
This CL begins the work of adding a Skia usable shared image created via a Ozone surface factory. ProduceSkia is able to be used in a GL context but the Vulkan path is not complete yet. Bug: 1023997 Change-Id: I83432a7a9e265a691adb9d1139bb31a1aafe33b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067448 Commit-Queue: Paulo Warren <pwarren@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#751723}
-
Juanmi Huertas authored
Added CreateCanvasResourceProvider2d and 3d methods to split a large method, and reordering a part of it to simplify future changes. Bug: 1035589 Change-Id: Icc6aa07ca15cbedd6194eef6c542ba48fde4a563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106322 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751722}
-
Robert Liao authored
This change moves long switch statements into separate helper functions to make it easier to see GetAuraColor's control flow. BUG= Change-Id: I203ee8dc54020e4ce60924511363a5cb19269e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108821 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751721}
-
Vadym Doroshenko authored
Bug:959776 Change-Id: I631d11703f796b00b3053b3b977ef2b78f2b5277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108510 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#751720}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ie3f7ec0b298fe89ac3d9d60ed59dcdd5cd88477b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109030Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#751719}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/829a21222fe3..f845b816079e git log 829a21222fe3..f845b816079e --date=short --first-parent --format='%ad %ae %s' 2020-03-18 ahassani@chromium.org cros_generate_update_payload: Some cleanup 2020-03-18 gredelston@google.com Implement ChromitePytest API 2020-03-18 bpastene@chromium.org cros_test: Push chromite's scripts dir onto PATH during Tast tests. Created with: gclient setdep -r src/third_party/chromite@f845b816079e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ic7e7a260d45c578442801dd8230d717b595dba42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110030Reviewed-by:
-
Mark Yacoub authored
If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset Commit instead of legacy SetCRTC. (reverted on crrev.com/c/2080775) BUG=987274 TEST=displays should start and continue to function normally for devices supporting atomic APIs. HardwareDisplayControllerTest.CheckModesettingSetsProps HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset Change-Id: If08b015d1e62f51e9ec3c243c1e5a2965449345e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106476 Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#751717}
-
Peter Kasting authored
* Comment changes * Consistent type for function pointers ("decltype(&name)") * Update some variable names Bug: none Change-Id: Ibf2fdd47fbe3aef92c61554f9b7ab812d29809da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106824 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751716}
-
Xiaocheng Hu authored
This patch eliminates the deprecated function, together with its last callers. Now we can ensure that we never switch FontSelector for any Font and FontFallbackList objects. For the last callers in FontBuilder, since it needs to setup FontSelector as part of the font-related style computation, we expose SetFontInternal() from ComputedStyle to it. Bug: 1049295 Change-Id: Iea40e7150389bf0db1d10d0e0269d579bd2948fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109259Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751715}
-
Victor Hugo Vianna Silva authored
In case the user is not opted in to "passwords account storage", the button in the autofill dropdown menu used to generate passwords will now have a different UI and prompt a reauth flow to opt in the user to the feature. This new button can be shown simultaneously with the pre-existing button for opting in then displaying password suggestions. Bug: 1060131 Change-Id: Ibcd85f831f3b81ab28fcb69d4ca0ff02bf4d9c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107620Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#751714}
-
Andrew Grieve authored
This reverts commit 036098e4. Reason for revert: No changes to this commit. Fixed by: 02aeb6b2 Original change's description: > Revert "Reland "Make java_deobfuscate not require being built first"" > > This reverts commit d80699f2. > > Reason for revert: Broke swarming again: > https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel/783 > > Original change's description: > > Reland "Make java_deobfuscate not require being built first" > > > > This reverts commit 0b8c0e6a. > > > > Reason for revert: Fixed runtime deps > > > > Original change's description: > > > Revert "Make java_deobfuscate not require being built first" > > > > > > This reverts commit 962e7030. > > > > > > Reason for revert: Failing on swarming > > > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747 > > > > > > Original change's description: > > > > Make java_deobfuscate not require being built first > > > > > > > > Makes the tool easier to use, and easier to document how to use by not > > > > requiring it to be built first. We have only a single non-prebuilt .java > > > > file, so it's easy enough to just check in the .class file for it. > > > > Bug: 995290 > > Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Sam Maier <smaier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#751322} > > TBR=agrieve@chromium.org,smaier@chromium.org > > Change-Id: I7510d193931940176178ad6f68122f634ed59e93 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 995290 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108612 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751394} TBR=agrieve@chromium.org,smaier@chromium.org Bug: 995290 Change-Id: Ia51d50638d859d27e081ff0689b4c5877a02e8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109817 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751713}
-
Ali Juma authored
This reverts commit 6a3e1c15. Reason for revert: We've branched for M83, so we're ready to make full-hash requests again and re-enable unit tests. Original change's description: > [iOS] Disable Safe Browsing full-hash requests > > This temporarily disables making full-hash requests on iOS, allowing > the rest of the Safe Browsing code to be exercised. > > Since this change breaks unit tests, this CL also stops running > Safe Browsing database unit tests on iOS for now. > > Bug: 1028755 > Change-Id: Id772d4682bd9a3443b8d6b7042b0b5aecaaff80e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088349 > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748049} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028755 Change-Id: I3d4e64e9c6818e1dcbf66a8a21aa48df98c8e87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108096Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#751712}
-
rbpotter authored
The Polymer 2 local chromium.patch file contains a change to paper-tooltip that was not yet in the Polymer 3 chromium.patch file. Port this missing patch, as this is used by chrome://settings. Bug: 1025402 Change-Id: Ia33503edca6dbc5bc17e29d9997a7aac6fe2b8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109263Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#751711}
-
Andrey Kosyakov authored
This reverts commit 6ba92a23. Reason for revert: causes a crash, see bug BUG: 1063063 Original change's description: > Migrate device emulation to mojom > > - introduce DeviceEmulator, make it navigation-associated > - move WebDeviceEmulationParams to blink/public/common/devtools > - use base::Optional<WebDeviceEmulationParams> to represent emulation > enabled/disabled state through most interfaces. > > Change-Id: Ic743a1af02019610149e1c4a765696c9d8711e5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092938 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751492} TBR=dgozman@chromium.org,danakj@chromium.org,caseq@chromium.org,estark@chromium.org,mkwst@chromium.org Change-Id: I8280c3aabc829245209d8db3d7d1915ddad8d8e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110213Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751710}
-
Danyao Wang authored
This reverts commit 7f5e20cc. Reason for revert: caused a new crash: crbug.com/1063048 Original change's description: > [Payment Request] Fixed potential use-after-free of RenderFrameHost. > > InstallablePaymentAppCrawler stores a RenderFrameHost raw pointer and > uses it in asynchronously when DownloadAndDecodeWebAppIcon() is run as > a callback for downloading the web app manifest. This creates a possible > use-after-free situation. > > This CL applies a limited fix: the RenderFrameHost* is converted to its > GlobalFrameRoutingId to be stored inside InstallablePaymentAppCrawler. > > A better fix is to use WeakPtr<RenderFrameHost> everywhere in payments > code. However, this requires changing the content public API to expose > a RenderFrameHost::GetWeakPtr() method. Since this CL is intended to be > merged to M82, this more risky work is left as a followup for > crbug.com/1058840. > > The instantiation of InstallablePaymentAppCrawler happens synchronously > with the instantiation of PaymentRequest, the risk of use-after-free as > a result of PaymentRequest's storage of RenderFrameHost* is small. > > Bug: 1061110 > Change-Id: I1428c6006201834ee341dd4546bd297116a5f380 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106387 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751454} TBR=rouslan@chromium.org,danyao@chromium.org Change-Id: Iacb8ff851af05e01503630d671547f8d19dda05c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109828Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751709}
-
Theresa authored
This reverts commit 23c738ec. Reason for revert: Broke compilation Original change's description: > Update some callbacks to Once/Repeating in //remoting/protocol > > Bug: 1007826 > Change-Id: Ie65fbc4382a397145e085081cca188b37138d5dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106393 > Commit-Queue: Joe Downing <joedow@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Auto-Submit: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751684} TBR=estade@chromium.org,joedow@chromium.org Change-Id: Ie492bcdd65a8f875412747c8a62c721ce56461ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109825Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751708}
-
Javier Ernesto Flores Robles authored
TBR=eugenebut@chromium.org Bug: 1063015 Change-Id: Ic74d8e26f365daad546ce35b210b1d856d8d7225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110021Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#751707}
-
Tommy Steimel authored
This CL adds a new UKM event to record when an action button is pressed within the Global Media Controls dialog. This records which button was pressed. Bug: 1050077 Change-Id: Ib3c8eb1264d92569fd3a587d7667dc64a49a5e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092421 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751706}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dadeffa315e7..a38e20e4b435 git log dadeffa315e7..a38e20e4b435 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 440fc9959f06..bc98fbeec99b (3 commits) Created with: gclient setdep -r src/third_party/angle@a38e20e4b435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: If280608243aba904e02f0dd6ff7b436960b171cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109888Reviewed-by:
-
Zhenyao Mo authored
This makes it easier to view and compare test results. BUG=1026447 TEST=manual R=backer@chromium.org,magchen@chromium.org Change-Id: I6fd4cb70add1316059f47b660c68c65f0bce0b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109454 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751704}
-
Peter Wen authored
I am familiar with many of the local modifications for robolectric. Bug: None Change-Id: Ia7ae390ad9bd172cc238de2bc64cb3c7af5e9619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109811 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Avery Musbach authored
The function by the same name in overview_test_util.h and .cc is fine. Bug: None Change-Id: Ic47a050f9c547fa9353dde74127c08ebc087346e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109253Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#751702}
-
David Dorwin authored
Tests now override a variable used by this function rather than the function checking whether a test has overridden an environment variable. This also allowed simplification of the function. Also made "time zone" consistently two words. Bug: fuchsia:37487 Change-Id: Ib040dd07dee239faa5f41f9e5c5070309a265a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102077 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#751701}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3ac36c8..63323405 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b16255f458b88f08e2c87fbe4e9c61af0222c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108847Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751700}
-
Avery Musbach authored
Bug: None Change-Id: Ic0d85fafae91d15e2c6b8300c20c3d10bbd4b800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109278Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e55f0c338495..2507f8cdc979 git log e55f0c338495..2507f8cdc979 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 peah@webrtc.org APM: Replace all remaining usage of AudioFrame outside interfaces 2020-03-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d69529f5..4b28405b (751530:751644) 2020-03-19 peah@webrtc.org Correct the storing of the processed output in aecdumps 2020-03-19 magjed@webrtc.org Android: Synchronize EGL14.eglDestroyContext calls 2020-03-19 phoglund@webrtc.org Write pb perf output files on iOS. Created with: gclient setdep -r src/third_party/webrtc@2507f8cdc979 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e1c4c986c93f563e0ac069619fe1d6ebe4402bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109887Reviewed-by:
-
Evan Stade authored
TBR=jam@chromium.org Bug: 1058600 Change-Id: I742b5512c7565ea353f5bbed602b744817eed9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103310Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#751697}
-
Yann Dago authored
There are 2 tabs that need to be preserved. There might be a 3rd tab, about:blank that is opened by the test itself. That 3rd tab may or may not have been opened at the time we validate the first 2. Bug: 1062701 Change-Id: I4bac4aaa0b97ccc5170f64b92df311541092a555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106572Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#751696}
-
Allen Bauer authored
Bug: 1061849 Change-Id: I6a63abe67dd022e6ca70d39647e18d0aa7eaff71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106890Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751695}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1f9b5960d8b2..81bcbbc20ee5 git log 1f9b5960d8b2..81bcbbc20ee5 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 rharrison@chromium.org Add storage texture format reflection to spvc path Created with: gclient setdep -r src/third_party/dawn@81bcbbc20ee5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6b6614228f3e317d480f0928e6dbf3ed14cda786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109886Reviewed-by:
-
Dave Tapuska authored
This will simplify some code in the future when we remove APIs off the blink public surface. Change-Id: I64fa0907158252a0ec73cba81c8bbd06273eb419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109135Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751693}
-
Dominic Mazzoni authored
A line containing the string <-- End-of-file --> is included in the output of DumpAccessibilityTree tests, but it's not supposed to be checked in. This change removes those lines. A follow-up will fix the diffing algorithm and make it so that rebasing tests won't keep adding those lines to expectations files. Bug: None Change-Id: I7bd3186793651e7c4c8361882444b6da9c3d35dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109176 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751692}
-
Ali Juma authored
This adds an about:flags entry for Safe Browsing, to make it easier to enable and test. Bug: 1028755 Change-Id: I48bb2c6d20a707a2f44810e71403abd2eb8dda3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105797 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751691}
-
Theodore Olsauskas-Warren authored
This CL extends the capabilities of the collapse_radio_button to allow it to display a policy indicator, as well as sets it's disabled state to align with expectations for when a control is managed by policy. To achieve this a policy-indicator-type property is added to the collapse-radio-button which controls the indicator displayed by the newly added cr-policy-indicator element. A no-collapse property is also added to the collapse-radio-button element to support situations where no additional content is required. This allows a radio group containing both collapsing and non-collapsing radio buttons to use the same element for all entries. A screenshot example of these indicators in use is available on the bug. Bug: 1061947 Change-Id: Ie2f3ab02b805210fe165435163fa3734bb62b213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107556Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
-
