- 27 Sep, 2018 40 commits
-
-
Elly Fong-Jones authored
This change: 1) Adds support to MenuClosureAnimationMac for animating menu closure without animating selecting an item; 2) Has MenuController use MenuClosureAnimationMac to animate cancels caused by outside clicks Bug: 833856 Change-Id: I9743b396798e4b125c038b35decc9aceb083926d Reviewed-on: https://chromium-review.googlesource.com/1231837 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#594738}
-
David Benjamin authored
Cryptography is timing-sensitive. MACs should never be compared with usual string comparison functions, only constant-time checks. Use HMAC::Verify. Bug: none Change-Id: Ic1b164441396e4a4a853f1a50d91bc8f5c7fa18e Reviewed-on: https://chromium-review.googlesource.com/1246323Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#594737}
-
Yoichi Osato authored
HasMarkers and its caller InlineTextBoxPainter::PaintsMarkerHighlights is not called anywhere. Remove them. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2ad088d8637d461178e7e3af3017c923b6c1f4c3 Reviewed-on: https://chromium-review.googlesource.com/1248282Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594736}
-
Allen Webb authored
This reverts commit 098b2caf. Reason for revert: This is no longer needed because of go/crosr/1199443 Original change's description: > anonymizer_tool: Added pattern to remove usbguard serial numbers. > > The usbguard-daemon prints serial numbers of USB devices to > /var/log/messages. This change adds a pattern to anonymize those > serial numbers to prevent leaking PII. > > BUG=None > TEST=Generate a report with logs and verify usbguard-daemon log > lines are properly anonymized. > > Signed-off-by: Allen Webb <allenwebb@google.com> > Change-Id: Ifd41c8208b4d14bb3fafbf38198b04da6a8babd6 > Reviewed-on: https://chromium-review.googlesource.com/1160935 > Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580946} TBR=rkc@chromium.org,mnissler@chromium.org,allenwebb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I4af62c2af7d9dc569175e5e68393c9e2a7ebb5e6 Reviewed-on: https://chromium-review.googlesource.com/1220095Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#594735}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4034a5cf..99b1fae1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I243f13f6e4a8ba97cd575e72f61bf46926f96cea Reviewed-on: https://chromium-review.googlesource.com/1249312Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594734}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 779dead9. With Chromium commits locally applied on WPT: 16f78349 "Move target-in-different-window.html into wpt/" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25391 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I8152cea831525ada1548548a2c8827a2b1891dd6 Reviewed-on: https://chromium-review.googlesource.com/1249521 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594733}
-
Trent Apted authored
It's effectively the default. Only a few places using gfx::Typesetter::NATIVE explicitly should be using RenderTextMac now. Bug: 798944, 889152 Change-Id: I3318676b14b938607de9413130627dc1581b2289 Reviewed-on: https://chromium-review.googlesource.com/1248263 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#594732}
-
Xu Xing authored
The idea is from: TODO(weiliangc): GL Renderer has optimization that when Render Pass has a single quad inside we would draw that directly. We could add similar optimization here by using the quad's SkImage. BUG=888930 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I42717c8a3fcfd93671db4ccff04acb76c005fa6a Reviewed-on: https://chromium-review.googlesource.com/1242303Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#594731}
-
Hugo Holgersson authored
Scenario: activeElement (focus) resides in an *offscreen* iframe's viewport. Problem: Spatnav only checked if activeElement was visible in its localmost frame. Even if that frame wasn't visible to the user, activeElement was used as the starting point in the search for focus candidates. Solution: Do not only ensure that activeElement is visible in its own frame: Also ensure that activeElement is being visible through the root frame. We do this by testing visibility through VisualViewport. Note: Element::VisibleBoundsInVisualViewport() returns an empty rect if an element is clipped by an iframe but VBIVV does not return an empty rect if the element is clipped by an overflow div. That's why we first still check the node's LayoutObject's VisualRectInDocument(). Let's fix this problem in Issue 889840. Bug: 881721 Change-Id: I091d07a4f1f909e947fce11a335e3e6fe756ce18 Reviewed-on: https://chromium-review.googlesource.com/1243246 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594730}
-
Eugene But authored
This adds a new value to Download.IOSDownloadMimeType histogram. text/calendar could be a common email attachment and this histogram will allow to understand if Chrome should support "Add To Calendar" UI for these downloads. Bug: 666211 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iafd9d30b1b3c565b38fd5c324bb8767ac1bc61b2 Reviewed-on: https://chromium-review.googlesource.com/1247064Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#594729}
-
Eugene But authored
Sylvain did codereviews for most of the CLs CL in this directory, which is more than 5-10 reviews. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I120e618bed1f8ed1f6526c4ab204ad2341229191 Reviewed-on: https://chromium-review.googlesource.com/1246294 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Micah Morton authored
This flag allows users to work around a shill-related breakage due to sandboxing, by forcing the feature disabled. It also allows testers to toggle the feature during testing without needing to modify /etc/chrome-dev.conf. Having this flag in the chrome://flags will allow a user to manually enable/disable shill sandboxing without needing a VariationsService update, which might be infeasible if network connectivity is lost. BUG=chromium:649417 Change-Id: I6de9e11a605a53f206996a7b3acdd10849daa3a9 Reviewed-on: https://chromium-review.googlesource.com/1246830Reviewed-by:
-
Justin DeWitt authored
- The ExploreSitesService is configured to start on startup if the feature is enabled, and will schedule the daily task directly in the service factory. - The task will cancel itself if it runs and the feature is disabled. Bug: 867488 Change-Id: I38b55c97d9b2d26a3c94cdff5bcce03bf341d404 Reviewed-on: https://chromium-review.googlesource.com/1244738 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#594726}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /components/download. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=shaktisahu@chromium.org TBR=shaktisahu@chromium.org Bug: 874080 Change-Id: Icf3e527d0d344e099a9debe054a8046273baebef Reviewed-on: https://chromium-review.googlesource.com/1191096 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594725}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/80564a56ec85..a78fa0978d64 git log 80564a56ec85..a78fa0978d64 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 33432579+alan-baker@users.noreply.github.com Set the C++ version to C++11 (#1933) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a78fa0978d64 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I692bca1481e95041d91bb80ece423983f836e625 Reviewed-on: https://chromium-review.googlesource.com/1249502Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594724}
-
Matt Falkenhagen authored
Before this CL, the test makes a frame which posts a message to the test window. But if the test fails, we might not consume the message with `await` and move on the next test. It's possible the next test gets an unexpected message from the previous test. I think a related issue caused the timeout after the Clients variant was added to the test, since the message handler was created after the frame was created and it was possible the message arrived after that. Fix things by explicitly asking the frame for the message when we're ready for it. Bug: 876223, 778497 Change-Id: I82b8685df2977aeadea7475965ecccf69bd33111 Reviewed-on: https://chromium-review.googlesource.com/1249423Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#594723}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e9a7e90625fe..529d0d9795b8 git log e9a7e90625fe..529d0d9795b8 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 nisse@webrtc.org Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config. 2018-09-27 kron@webrtc.org Remove failing RTC_DCHECK in nack_module.cc. Created with: gclient setdep -r src/third_party/webrtc@529d0d9795b8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf38727d7064dda17d6c5b05db88fa9c228c960b Reviewed-on: https://chromium-review.googlesource.com/1249501Reviewed-by:
-
Sylvain Defresne authored
The documentation says that the parameter must not be empty, so add a DCHECK instead of a check. This is safe as the underlying method in KSF DCHECK too. Bug: 809610 Change-Id: Ib7c8b15d1bbc3f82ee3403f530a0167020cfee53 Reviewed-on: https://chromium-review.googlesource.com/1248629Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594721}
-
Marc Treib authored
Bug: none Change-Id: I9a1bd69329e187e39d82edb20c913d947fd9b588 Reviewed-on: https://chromium-review.googlesource.com/1249069Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594720}
-
Marina Ciocea authored
Disabled tests: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler TBR=shimazu@chromium.org Bug: 889855 Change-Id: I7215b4e074da8932725a2d6540cccf29eea823a3 Reviewed-on: https://chromium-review.googlesource.com/1249083Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594719}
-
Leonard Grey authored
No behavior change intended, just pushing some code into the function from the callsite. This will allow Mac to use the same interface, but with mouse events targeting widgets instead of aura::Windows. Bug: 769352 Change-Id: Ibfec8c567b6e28b1d9b77bf6a7c388e1b69e3395 Reviewed-on: https://chromium-review.googlesource.com/1237115 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#594718}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: Id9ffa19550de44af7e4f89bc8f3d4439e572398f Reviewed-on: https://chromium-review.googlesource.com/1248784 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594717}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic82c971941b125a31c1fa0a6377b1e451fa045fb Reviewed-on: https://chromium-review.googlesource.com/1249384 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594716}
-
Marc Treib authored
It was used to back a policy which was removed in https://crrev.com/c/1224033, and supervised user creation itself has been gone for way longer. Bug: 828890 Change-Id: I3a764e88f72599799263d1dc141d88e5e8b85a91 Reviewed-on: https://chromium-review.googlesource.com/1245708Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594715}
-
Marc Treib authored
This fixes one (small) issue where the next_token_request_time didn't get cleared if the retry timer called us while there was already a request ongoing. It also adds a bunch of DCHECKs to hopefully catch any other cases I might have missed. Inspired by some recent bug reports that showed a "Next Token Request" time in the past on about:sync-internals. Bug: 889859 Change-Id: I8cd189c0e4acccc4af0d38a3ce9da6ccbd3cac7a Reviewed-on: https://chromium-review.googlesource.com/1249067Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594714}
-
Mario Sanchez Prada authored
This hasn't yet been migrated from OAuth2AccessTokenConsumer::TokenResponse and it will be useful at least to determine whether we are under advanced protection from AdvancedProtectionStatusManager once a token is fetched. Additional test coverage will be added in a follow-up patch. TBR=thestig@chromium.org Bug: 889764 Change-Id: Id9a8bcc7b2e3a5238b7a1c98f7787a8e905b6add Reviewed-on: https://chromium-review.googlesource.com/1248625 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Rayan Kanso authored
Set a per-origin limit (5) for how many active background fetch registrations an origin can have. This is to avoid a potential abuse vector until a more concrete permission model is in place. With this, an origin can't keep registering fetches and permanently have a notification shown, also blocking other origins from starting a background fetch. Bug: 889401 Change-Id: I9aeac7121c46ffdd3910b3b891051e9c4951bc6e Reviewed-on: https://chromium-review.googlesource.com/1245369 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594712}
-
timidger authored
This allows the Chrome Cleanup Tool to request Chrome to delete extensions it finds. This was put in the mojom interface because it's the simplest way to add to the CCT interface to Chrome. This has no real dependency on the chrome prompt workflow. Also changes the chrome cleaner to only build on platforms that support extensions as it was breaking on android (which we don't support). R=joenotcharles@chromium.org, joenotcharles@google.com, kinuko@chromium.org, reillyg@chromium.org Bug: 889568 Change-Id: Idbbebda824e3d7764940773964f50045639617bd Reviewed-on: https://chromium-review.googlesource.com/1207219 Commit-Queue: Preston Carpenter <timidger@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594711}
-
Jonathan Metzman authored
Bug: 884560 Change-Id: I7e6ac6869b2e2e068214cc5944d73a22549e5a70 Reviewed-on: https://chromium-review.googlesource.com/1247189Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594710}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3e48afc936d..227d4e10276c git log b3e48afc936d..227d4e10276c --date=short --no-merges --format='%ad %ae %s' 2018-09-27 scroggo@google.com encodedProfile can be null, so check for that Created with: gclient setdep -r src/third_party/skia@227d4e10276c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/116608007 TBR=bsalomon@chromium.org Change-Id: I9d547ab395024639cf48edd467d61ce8e596e531 Reviewed-on: https://chromium-review.googlesource.com/1249310Reviewed-by:
-
Mark Cogan authored
Move infobar_close into downloads/, which is the only place where it's used, and rename it. Bug: 884722 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I539058203790b7ba7b0e28e94e989ce32e0e95fd Reviewed-on: https://chromium-review.googlesource.com/1248704 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594708}
-
Mikel Astiz authored
This changes the behavior of TabNodePool::AssociateWithFreeTabNode() to always return the smallest available ID, resulting in a more compact distribution of sync IDs too, hence a lower number of sync entities. This will allow, in future patches, the deletion of arbitrary tab entities, without incurring an increase of the number of session sync entities. Bug: 882489 Change-Id: I11ac5167f6971dbd8239b530a87a49eb51f20261 Reviewed-on: https://chromium-review.googlesource.com/1242883Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95c25ea38fcf..5d8c6f4f9d8f Created with: gclient setdep -r src-internal@5d8c6f4f9d8f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1d2c80e7adc203c8824fe6bb654fcf238b27a25f Reviewed-on: https://chromium-review.googlesource.com/1249308Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594706}
-
Thomas Tangl authored
The signin-allowed policy is now tied to the new pref signin.allowed_on_next_startup. This means that changes only take effect on the next startup. Note: This change only affects Desktop. Additional change: - Move the signin-allowed toggle to the top of the privacy page. Screenshot: https://drive.google.com/file/d/1FD0gQRmwlnIFeiAMpU7U_3x4ErUu91Tb/view?usp=sharing TBR=scottchen@chromium.org Bug: 888776 Change-Id: I4f7281a3b7eee8e799c48cf829dde12c7e9cbcc8 Reviewed-on: https://chromium-review.googlesource.com/1249021Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#594705}
-
Oskar Sundbom authored
When an input stream is being processed in the audio service, its InputController monitors an output stream (actually, its OutputController) to get the audio it needs to perform echo cancellation. When the output stream is replaced, the input controller should stop monitoring the old output stream and start monitoring the new one. If the creation and destruction of these streams are interleaved, this would break, as the input controller would start monitoring the new stream, then stop monitoring any stream as the old output stream was destroyed. This CL ensures the input controller only stops monitoring if the destroyed stream is the one it's currently monitoring. Bug: 883651 Change-Id: I5731840d8af11ecd76ecd1a25126034c5ff496ac Reviewed-on: https://chromium-review.googlesource.com/1245711 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594704}
-
Eric Stevenson authored
Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1232018. Change-Id: I79982c7e0879af5d2a68d60bbd165164762c6a30 Reviewed-on: https://chromium-review.googlesource.com/1246831Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#594703}
-
Mikel Astiz authored
There is no need to cast SyncableService instances to interface SyncChangeProcessor, neither do these services need to implement any functions in there, since they are not exercised. One exception is SyncChangeProcessor::UpdateDataTypeContext(), which is called from SharedChangeProcessor, but there is no SyncableService that implements any functionality in such function. In order to keep the patch less intrusive, GetAllSyncData() is kept around, now moved to SyncableService, since all implementations provide such functionality. However, we don't seem to call that function from anywhere, so a TODO has been added to simplify that in future patches. TBR=groby@chromium.org Bug: 870624 Change-Id: I54b33cdd1ecc5584a806d3ff0fc0f3f6708467ca Reviewed-on: https://chromium-review.googlesource.com/1243809Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
Change-Id: Id13a8add39f1d8591d837db322f33dcc5b4335d7 Reviewed-on: https://chromium-review.googlesource.com/1248623Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3c7694137a0e..e9a7e90625fe git log 3c7694137a0e..e9a7e90625fe --date=short --no-merges --format='%ad %ae %s' 2018-09-27 devicentepena@webrtc.org AEC3: ERLE: Allowing increases of the ERLE estimate for low render signals. 2018-09-27 jonaso@webrtc.org Add GetSources to VideoRtpReceiver Created with: gclient setdep -r src/third_party/webrtc@e9a7e90625fe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I571658577df50b70210d63ab17a637368e4e857f Reviewed-on: https://chromium-review.googlesource.com/1249306Reviewed-by:
-
Vadym Doroshenko authored
Password Manager sends crowdsourcing votes for sign-in forms with labeling of fields with Autofill votes. The idea to use autofill votes in such situation is deprecated now. And moreover on the CL https://chromium-review.googlesource.com/c/chromium/src/+/1219710 it's allowed to send normal Password Manager votes for sign-in forms. So in order to avoid double vote sending and decrease code complexity it's now time to remove sign-in vote sending. Bug: 889472, 875768 Change-Id: Ibad10f13b69776a433f6c0a2e2017f234b85a6ec Reviewed-on: https://chromium-review.googlesource.com/1248626 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594699}
-
