- 16 Nov, 2020 40 commits
-
-
Adrienne Walker authored
This is a little bit awkward for native file system handles, which aren't related to blob writing failures. However, these are already returned as "failure to write blobs", so it's not too far afield. Bug: 1144131 Change-Id: I800445b39a93e7fda9d36480092d2cff55760f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538155 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827874}
-
Corentin Wallez authored
The PSA in https://hackmd.io/uH1MI9cnQBG9GGOZG20COw deprecates a number of WebGPU APIs. Now that we are past the removal deadline we can remove them from Blink and only keep the supported paths. Bug: dawn:22 Change-Id: I9241e78db5578d6cb97593e9e3363b493fed481c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521120 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#827873}
-
Mark Pearson authored
This reverts commit aa74ca79. Reason for revert: Due to a bug in the original changelist, these histograms were never emitted. In particular, they weren't emitted because the implementation classes (the ones that actually emit the metrics) aren't part of the class. In other words, they're not overriding the parent class behavior and thus not getting called. When I fixed the bug and tested the fix, I realized that the way I hooked up the metrics emitting code is wrong. I expected the UnsentLogs.Sent-emitting code to be run only when persisted logs (logs from past sessions) were going to be sent. However, it records all logs that are sent, not only persisted ones. For example, it records (i) the initial stability log and (ii) the logs that happen at regular intervals. Neither of those are counted in UnsentLogs.IntendingToSend. Long story short: bug in original changelist. Fixing the bug is non-trivial and requires substantial changes. Reverting to start over fro a clean slate. Reverting the histograms.xml change is safe because these histograms were never logged. BUG=1148523 Original change's description: > Add Metrics about Uploading UMA Records from Previous Sessions > > Change-Id: I908a337129062e882b185a08329fecfd7db6c496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504593 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822037} TBR=mpearson@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie44b8bac5948cb19af245800ac42e6b5bab11996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537604Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827872}
-
dpapad authored
The logo image was accidentally only included for optimize_webui=false at r827003. Bug: 1149235 Change-Id: Ie6a965529e9d31cebcffc0a75672b3a505cc6411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538397 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#827871}
-
Christopher Cameron authored
This function used to use the helper functions CopyToByteArray and ConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat to first copy the data, then the convert formats. The function PaintImage::readPixels can do the copy and conversion simultaneously. Use that instead. Add the capability to read to uint16 (as well as uint8 and float16), since getImageData will be changed to allow specifying the type. Remove a bunch of unused helper functions left behind. Bug: 1115317 Change-Id: I88e637c2f314385c62b1a450ea2c0c9e7fc29ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533833Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#827870}
-
Angus L. M. McLean IV authored
Bug: 1071218 Change-Id: I79da1693562db63262084853b1d3c35cdb97518e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537936 Commit-Queue: Angus McLean <angusmclean@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827869}
-
Peter Kvitek authored
This is required because inbound Mojo messages which do not have a registered handler are considered an error, and the render process is terminated. Bug: 1090429 Change-Id: I6979013e55a32f30bb32f2918df5fde8ba852dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530198 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#827868}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=djacobo@chromium.org Bug: 1145565 Change-Id: I436bf817ddb0820060ddcc817c324cf2ae5c9cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532715Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827867}
-
manukh authored
Does not add logging for split rich autocompletion, only title and non-prefix autocompletion. Will only trigger if a rich autocompleted suggestion is actually the default suggestion during a session as otherwise they have no impact. Bug: 1062446 Change-Id: Idd6f11f94195fdae76a78dde70ec57f8725601ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465804Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827866}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8dceaddf8503..3e551b3ce67d 2020-11-16 capn@google.com Work around LLVM ORCv2 issue affecting Cuttlefish If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5b1c2ecbe4247ea94d638da74ac9cfcf70d1650a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827865}
-
cfredric authored
Change-Id: Ic2fdb5d1adb515af42735a7af1b563dd0aba8ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540571 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#827864}
-
Jeffrey Young authored
Previously monitored prefs only if ambient mode was already enabled. BUG=b:169579102 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I287ab1e710b8c45b6fb2b90ba6879fb5726fc2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535111 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827863}
-
Clark DuVall authored
This change kicks off native library loading as early as possible in a separate thread, to reduce startup latency. There may be a few activities that don't actually need native libs, but the vast majority of the time we end up loading the native lib, and this seems like a good trade off for the perf improvements. Pinpoint results for messageloop_start_time in mobile.startup: Android Go: Cold start: -11.3% https://pinpoint-dot-chromeperf.appspot.com/job/10e6fbf3520000 Warm start: -23%: https://pinpoint-dot-chromeperf.appspot.com/job/1227a4cd520000 Pixel 2: Cold start: -0.3% https://pinpoint-dot-chromeperf.appspot.com/job/11822b23520000 Warm start: -1.7% https://pinpoint-dot-chromeperf.appspot.com/job/154a85cb520000 Bug: 1148803 Change-Id: I70256509cad47c20ec047222ba7bd0f576abe548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535732 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#827862}
-
Keishi Hattori authored
When using a binary operand with CheckedPtr and std::string, you get an invalid operands to binary expression error. With this CL, the rewriter matches CheckedPtr used with a std::string and adds .get() so the std::string/char* operator overrides gets used. Bug: 1073933 Change-Id: I4854d4d272ba1d9a107e7e346bfbe363e6861c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535908Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827861}
-
Etienne Bergeron authored
This CL is adding code coverage with unittests for whitespace elision. The intend is to ensure the code semantic stay the same while doing the eliding refactoring. R=gab@chromium.org,msw@chromium.org Bug: 1085014 Change-Id: I8a092e8d2c15449e80ba0508c854aca71dd7892d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533533 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827860}
-
Leonard Grey authored
This reverts commit bbf9dd65. Reason for revert: new test is failing on at least a few (maybe all) Mac builders. Example: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/39329 Original change's description: > Portals: Fix a11y for orphaned portals > > Orphaned portals [1] don't have a RWHV (but did at some point), and can > have AXTree updates sent from its renderer process which would be > subsequently ignored in the browser process (due to there being no RWHV). > Once an orphaned portal is inserted into the DOM tree, we create a RWHV > for it, and at this point any new AXTree updates received will be invalid > as the browser's tree state is different from the renderer's. > > To fix this, this CL makes BrowserAccessibilityManager creation > independent of a view being present. The view is only used on android > to pass it a pointer to WCAXAndroid, and we now do this through > a BrowserAccessibilityDelegate method. > > [1] See "orphaned" here: https://wicg.github.io/portals/#concepts > > Bug: 1139784 > Change-Id: Ifdebe1f05e37a6f704b937101ea44bb824cf045b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499861 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827803} TBR=dmazzoni@chromium.org,acolwell@chromium.org,adithyas@chromium.org,mcnee@chromium.org Change-Id: I617e4b9e6a56fd3c23b56f7620df9206628d4030 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1139784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541647Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827859}
-
Kevin Ellis authored
The CompositeRelativeKeyframes feature was turned on in stable in the following CL. https://chromium-review.googlesource.com/c/chromium/src/+/2495604 This change introduced a regression (crbug.com/1149012) in which the animation onfinished event is not being fired. Disabling the feature while we determine why the event is not firing. Bug: 1149012, 389359 Change-Id: Ibe789132f0782fa12b129045777c53bd46596697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540568Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#827858}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I31d070f7b47d676076dd5c7d2bc7ce69004340a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540368Reviewed-by:
-
Ben Pastene authored
To hopefully help avoid high pending times -> low cache hit -> increased build durations. crrev.com/i/3402719 allocates the machines for this builder. Bug: 1140727 Change-Id: Ieb64b7e2a9ea829540d42878d0adb3f8b6c98eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540922Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#827856}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=rushans@google.com Bug: 1145565 Change-Id: I760ad7d03410e304b00db5497fb44120e9768fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532959 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#827855}
-
Ian Kilpatrick authored
This block-stretching logic as: https://chromium-review.googlesource.com/c/chromium/src/+/2513771 ... did for the inline-axis. Previously we didn't have the concept of "stretching" the block-axis instead relying on the parent layout algorithm to set a fixed block-size. This allow stretching (similar to the inline-dimension). The failing tests (which I'll update in the test expectations) are due to this specification issue: https://github.com/w3c/csswg-drafts/issues/5713 The changes in layout_replaced.cc are needed to transfer the stretched size through the aspect-ratio. Bug: 1045599 Change-Id: Ifdd8653d81a1ead84a0afbf5ebd31ba0b75dc8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523743 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827854}
-
Austin Eng authored
--enable-toggles=skip_validation,foo,bar is the new way to enable toggles in Dawn's tests. The other command line flags will be removed. Bug: dawn:571 Change-Id: Ia917943fb07abb53346ffe0022ff27b01db6f4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538482Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#827853}
-
Wan-Teh Chang authored
Change AVIFImageDecoder::OnSetData() to parse the image metadata automatically when all data is received. This meets the expectations of ImageFrameGenerator::GetYUVAInfo() and ImageFrameGenerator::DecodeToYUV(). In the ReadYUV() function in avif_image_decoder_test.cc, change the IsSizeAvailable() call (which calls DecodeSize()) to IsDecodedSizeAvailable() (which has no side effects) and call a few more getter methods related to DecodeToYUV() to emulate the code in ImageFrameGenerator::GetYUVAInfo() and ImageFrameGenerator::DecodeToYUV(). Bug: 1149144 Bug: 1136922 Change-Id: I3790de99fd0e9745c4b3ab9555aa027f25a6d374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539329Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#827852}
-
Boris Sazonov authored
This reverts commit dbf8c7e8. Reason for revert: caused crashes and test failures (https://crbug.com/1149348, https://crbug.com/1149382). Original change's description: > [ToolbarMVC] Move child coordinator initialization and ownership to LBC > > This puts LocationBarCoordinator in charge of constructing and > destroying UrlBarCoordinator, StatusCoordinator, and > AutocompleteCoordinator. This allows us to wire a few more > dependencies into constructors instead of via setters. The > coordinators are still passed to LocationBarLayout for it to use via > a new initialize() method that consolidates a few different setter > methods on LocationBarLayout. initialize() helps avoid bugs that > could arise when calling these setters out of order. There is an > additional change to LocationBarLayoutTest that fixes a DCHECK when > running tests on a debug build. > > Bug: 1146057, 1146062 > > Change-Id: Ie6c7e871d6cb0eb4bbffff0ab3ed275968d84e85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495969 > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Tomasz Wiszkowski <ender@google.com> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827494} TBR=fgorski@chromium.org,tedchoc@chromium.org,peconn@chromium.org,pnoland@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146057, 1146062, 11493484, 1149382 Change-Id: Ie6578c072ab9bc1d5da8f9a5e29676ba3321442d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540587 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827851}
-
Brandon Wylie authored
mocks: https://www.figma.com/file/b1CT6jM3mj0MdBvgQicy4b Bug: 1117271 Change-Id: I67cba57fce298e5ddf83edef10d331ee136cf289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538356Reviewed-by:
-
Mike Dougherty authored
CRWContextMenuController was previously used with WKWebViews which were not associated with a WebState. This added complexity to the context menu feature which is no longer necessary. Bug: None Change-Id: I8c07675da49dd0a9cf07b14e9b14ce73d14c9ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523754 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#827849}
-
Leonard Grey authored
This reverts commit 11191b81. Reason for revert: Causing checkdeps failures on linux-trusty-rel Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863455424170691152/+/steps/checkdeps/0/stdout Original change's description: > Correct c/b/c/input_method/DEPS > > - fix the regex that was matching against .*(...|)\.(cc|h) > (aka all *.cc, *.h). > - add a rule for dependees of tts_controller.h with commentary. > > Bug: 1148093, b/173144152 > > Change-Id: I0e1ca36fdeec5e838fa845f6f9520d130f11a68d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538141 > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827804} TBR=avi@chromium.org,dtseng@chromium.org,shend@chromium.org Change-Id: I102b9b65dfb5e34b0c6a24b5f8baec0c02ae645d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148093 Bug: b/173144152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541922Reviewed-by:
-
Boris Sazonov authored
This reverts commit 7c26f582. Reason for revert: this CL depends depends on https://crrev.com/c/2495969 that has to be reverted due to test failures and crashes (https://crbug.com/1149348, https://crbug.com/1149382). Please contact bsazonov@chromium.org or pnoland@chromium.org if you have any questions. Original change's description: > [ToolbarMVC] Observe incognito state changes in location bar. > > This lets us remove LocationBar#updateMicButtonState() which was > a "poke" method on the interface. > > Do not submit before M88 branch point (Nov 12th) > > Bug: 1142883 > Change-Id: If7564ac95e6ca69e28e6de7a609f0db9fa916c9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518202 > Commit-Queue: bttk <bttk@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827544} TBR=fgorski@chromium.org,pnoland@chromium.org,bttk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142883, 11493484, 1149382 Change-Id: Ia30a5089a20687be350892b75411eec2a27f7691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540528Reviewed-by:
bttk <bttk@chromium.org> Reviewed-by:
-
Nico Weber authored
This key's value makes the build output machine-dependent, and it's not clear that we need to set it. So try not setting it. Keep setting it in iOS builds, since the key might be used by the app store submission process, and the iOS build doesn't use a hermetic Xcode anyways. Bug: 1149401 Change-Id: I86f804e60f4ba1a9dcefa46cd3f14910b654ae9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540578 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827846}
-
Henrique Nakashima authored
https://chromium-review.googlesource.com/c/chromium/src/+/2538118 will use this parameter, but it needs to be added preemptively so that the recipe can be updated preemptively. Bug: 1146478 Change-Id: Ie9a3bc8d1885ae42fb921844bda4ae3131230ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538312Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827845}
-
Dave Tapuska authored
We can move this implementation into base and DCHECK that it is only called for subframes. BUG=1097816 Change-Id: I0b89c52f1574507d5aea0b04ba4bcb4fb95bc8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536509 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827844}
-
yjliu authored
This flag indicates if a render pass draw quad intersects the damage from other quads under it rendering to the same target. Previously this flag was only used to tell if a backdrop filter on a render pass needed to recompute or if it could use the cached texture computed from the previous frame. In face, this flag can also be used for optimization during surface aggregation where damage on non-root render passes has been cleared out. Renaming the flag to improve readability and facilitate easier understanding in the corresponding contexts. Bug: 1142892 Change-Id: I1a3f7973bc2c23aa6a54e5c86396f95f5b302c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538997Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827843}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9474249e20d..1e5da6b5b505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hkamila@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144732 Tbr: hkamila@google.com,lgrey@google.com Change-Id: I82e24c15f745495d1cd80aadadc4cd3268b5ada2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538127Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827842}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I1c7d6c834958298ff1b369f47be2efd2a8227338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508187Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827841}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dc4637c1a983..c4294f0266f1 2020-11-16 tvanderlippe@chromium.org Typecheck sources/NavigatorView.js with TypeScript 2020-11-16 tvanderlippe@chromium.org Update Rollup and rollup-plugin-terser 2020-11-16 tvanderlippe@chromium.org Typecheck object_ui/JavaScriptAutocomplete.js with TypeScript 2020-11-16 kimanh@chromium.org [e2e] Temporarily disable flaky color swatch test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:11493585 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2ed0888735046fc97bbc66b0469cd2d0ccf03f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540648Reviewed-by:
-
Liquan (Max) Gu authored
In an effort to move the following showAppSelector logic into PRService: - mJourneyLogger.setNotShown(NotShownReason.OTHER); - disconnectFromClientWithDebugMessage(error); - mObserverForTest.onPaymentRequestServiceShowFailed(); this CL moves this logic out of buildUi() for the convenience of further moving. Bug: 1148902 Change-Id: Iaea07a8d2c71cd3523b59401ce3faf44d517fc80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537114 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827839}
-
Alice Wang authored
This CL modularized the incognito_interstial package with its source files, resource file and junit tests. Bug: 1148766 Change-Id: I5ddc9a8734ff6ee7ea39d2701fe096ac39a41816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540469Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827838}
-
bttk authored
Before this change there are two files named LocationBarModelTest.java Touching either of these files triggers a presubmit warning: WARNING: multiple definitions of org.ch.c.b.toolbar.LocationBarModelTest: _/src/c/a/javatests/src/org/ch/c/b/toolbar/LocationBarModelTest.java _/src/c/a/junit/src/org/ch/c/b/toolbar/LocationBarModelTest.java Now the file in junit is renamed to LocationBarModelUnitTest.java Change-Id: I10b746ae043a05414433835c33c70062b7f71f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538016 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds all server predictions to the log output in chrome://password-manager-internals. Before: Server predictions: { Signature of form: 8608767706003284200 - 193 Origin: https://www.dkb.de/ Action: https://www.dkb.de/ Form fields: j_username: 94183295, type=text, renderer_id = 59, autocomplete=off, SERVER_PREDICTION: NAME_FULL j_password: 1796512061, type=password, renderer_id = 60, autocomplete=off, SERVER_PREDICTION: PASSWORD } After: Server predictions: { Signature of form: 8608767706003284200 - 193 Origin: https://www.dkb.de/ Action: https://www.dkb.de/ Form fields: j_username: 94183295, type=text, renderer_id = 31, autocomplete=off, Server Type: NAME_FULL, All Server Predictions: [NAME_FULL, USERNAME] j_password: 1796512061, type=password, renderer_id = 32, autocomplete=off, Server Type: PASSWORD, All Server Predictions: [PASSWORD] } Bug: 1140493 Change-Id: I3a6e685e02e7d960d4df053cd1b9885c1f509a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540610Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#827836}
-
Evan Stade authored
This removes a dependency on Chrome code and makes AppBannerManager one step closer to componentization. No behavioral change is expected. Bug: 1147268 Change-Id: Ibee4bc572cba7089591ec217abce8e6446f56aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538040Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827835}
-
