- 17 Jul, 2020 40 commits
-
-
rbpotter authored
These flags aren't needed once Polymer 3 code is fully checked in, except for cases where import paths don't match the source tree structure (e.g. Print Preview). Bug: None Change-Id: Ie040cbb7498afc0aa2ec847b0993f6fcaac9aed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303308Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789693}
-
Clark DuVall authored
This callback should never be null. Bug: 1062962 Change-Id: Ie81c2f52914823df3fa2e55a0d2633779d18a826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305117 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789692}
-
Emily Stark authored
In the simplified domain field trials, the path, scheme, and optionally subdomains get faded to transparent when the user interacts with the page or after the user hovers and exits the mouse. But there are various ways that it's possible to transition from this state (path, scheme, subdomains faded out) to showing the full URL. However, the method that shows the full URL wasn't applying any color changes, only changing the display area/offset. This could lead to some situations where the full URL is scrolled into view, but some parts of it were still transparent (see bug for repro). To fix this, ShowFullURL() now resets the text color and applies emphasis by calling EmphasizeURLComponents(). This ensures that all components of the URL are not just scrolled into the display area but also colored properly and not transparent. Bug: 1106478 Change-Id: Ifc57b33c8e6604764ca004a7035c382465711b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305031 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#789691}
-
Mohamed Heikal authored
A collection of bugfixes for creating R.java in java_library_impl targets: - test libraries support. - apk under test R.java shadowing bugfix. - always generate onResourcesLoaded like package resources did. - Fix issue where R.java is not generated for the apk package name. Bug: 1073476 Change-Id: I0cebd9626b0ce9049554f8345af516f7bd0ec2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789690}
-
Piotr Bialecki authored
Changes: - Roll ARCore SDK to version 1.18. - Updated device implementation to opt in to use 30FPS. - Updated ARCore APK version to 1.18.200603086 for the test bots to use. - Updated ARCore session recording - now that the code opts in to use 30FPS, the recordings need to be done at 30FPS as well, otherwise the camera configuration will fail. ~3kb since it needs to consume newly introduced APIs to configure AR session. The remaining size increase can be mostly attributed to the dependency growing (+8kb) and overhead (~4kb) - see breakdown for details. Binary-Size: Size increase is unavoidable. The product code increased by Change-Id: Ied48a1d4e6203e697ff5489547f7e9a67be6af0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300808 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Edward Lesmes authored
It was moved to the infra repo [1] so that it could be used by projects other than chromium. [1] https://chromium.googlesource.com/infra/infra/+/HEAD/go/src/infra/tools/dirmd/README.md Bug: 1102997 Change-Id: Idef030d4630d2408acf803e405f3e3b5b06d223c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304105Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#789688}
-
shrekshao authored
Sync with spec update: https://github.com/KhronosGroup/WebGL/pull/3115 Bug: angleproject:4838 Change-Id: Iefa754f90b42f8557c4aa088d0bad5b0d2013317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304134Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#789687}
-
Xiaoling Bao authored
1) Copy raw bytes from std::string to NSData when making request. 2) Copy raw bytes from NSMutableData to std::string when post response back to caller. 3) Forward additional post headers to NSMutableURLRequest so they can be actually sent. Bug: 1106820 Change-Id: I4517abea4ffb087f4bd433dcea85ff0e1a0427d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304994 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789686}
-
Ian Kilpatrick authored
This reverts commit d73ae868. The issue which caused the bot failures was due to a difference in logic between 32bit, and 64bit arch. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304143 This patch has remained unchanged except for part which landed before to fix another unrelated issue. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304659 Original change's description: > Revert "[LayoutNG] Move relative position calculation into NG." > > This reverts commit 27880cb4. > > Reason for revert: > > Suspect of blink_web_tests failures in a lot of bots, like this one: > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/70261 > > Unexpected Failures: > * fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html > * fast/css/relative-positioned-block-nested-with-inline-parent.html > * paint/invalidation/compositing/composited-float-under-composited-inline-individual.html > * paint/invalidation/compositing/composited-float-under-composited-inline.html > * paint/invalidation/compositing/stacked-float-under-composited-inline.html > > Original change's description: > > [LayoutNG] Move relative position calculation into NG. > > > > This patch moves the relative position calculation into NG. Previously > > we needed to manually account for the relative position of an object > > in many different places, overflow calculation, geometry APIs etc. > > > > This patch directly updates the child's offset (relative to its parent) > > to directly incorporate this additional offset. > > > > This calculation occurs within the NGBoxFragmentBuilder, and if an > > object is *placed* by LayoutNG... > > ...LayoutBoxModelObject::RelativePositionOffset returns an empty offset. > > > > This fixes a few small issues where previously we didn't resolve > > percentages against the correct available size when contained within > > an anonymous block. > > > > Bug: 1070822, 1058690 > > Change-Id: I2c623b02cc5a4605d310596f5c60353a21236bff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214608 > > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787991} > > TBR=yosin@chromium.org,wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,yosin@google.com,mstensho@chromium.org > > Change-Id: I5ca67701222509693d3020fa068c279cef39ecbb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1070822, 1058690 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296628 > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788228} Bug: 1070822, 1058690 Change-Id: I85a51c06d47c9eb451e8e7b77418913e288b7758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300667Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789685}
-
Alex Cooper authored
https://crrev.com/c/2304097 updated the tests that originally required this exception to be added so that they now automatically skip/pass on Windows 7, so we don't need to keep these exceptions anymore. Bug: 1106809 Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789684}
-
Gabriel Charette authored
R=mpearson@chromium.org Bug: 969934 Change-Id: I422cc9030ea6c48870a3c82df85ce343b92f0607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304168 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#789683}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id3b57710dde76947090ebcc89c00fb1384a2a7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305014Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789682}
-
Yuke Liao authored
The existing setup of enabling code coverage in try builder is incorrect, and this CL fixes the issue with the following steps: 1. 'Win x64 Builder', 'Win10 x64 Release (NVIDIA)' and 'Win10 Tests x64' have isolate_profile_data mixin. 2. 'win10_chromium_x64_rel_ng' is switched to mirror the builders mentioned in 1 instead of their code coverage counterparts. 3. Remove the code coverage counterparts of the builders in 1. Bug: 1004523 Change-Id: I34348739e7ef9ea608593ba75f31781d1b84d486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197858 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789681}
-
Brian Sheedy authored
Makes the following changes to //content/test/gpu: 1. Adds an explanation for why too-few-public-methods shouldn't be removed. 2. Removes the general broad-except disable and inline disables it in the few valid use cases we have. 3. Removes the general too-many-branches disable and inline disables or fixes the resulting errors. Bug: 1076144 Change-Id: If357e34f3e935464db54136b87f7c260ba4e5e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303597Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789680}
-
David Maunder authored
Currently PersistedTabData is in chrome/android. This causes problems as we migrate tab fields to the CriticalPersistedTabData UserData object. Bug: 1105667 Change-Id: I4364df3dc70723f2f522714afac64ee4d2c1d757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300328Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789679}
-
Sebastien Lalancette authored
TBR=robertma@chromium.org Bug: 1106861 Change-Id: Idd91371a1d9e6bb4013e3d7b147ecdbe4b6461d2 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304103 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789678}
-
Reilly Grant authored
This change enhances the cancel() method on SerialPort.readable so that is requests a flush of the serial port's receive buffer as required by the draft specification[1]. [1]: https://reillyeon.github.io/serial/#dfn-serialportsourcecancelalgorithm Bug: 989653 Change-Id: I8f6550ea6ac7093a04ca814b1f1b6b8d5d08ee76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250366 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789677}
-
Sonny Sasaka authored
This CL adds BluetoothBatteryClient which is a proxy to BlueZ's org.bluez.Battery1 interface. Future CLs will interact with this new interface to get battery level of Bluetooth devices and store the value to BluetoothDevice object. Battery API Doc: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/refs/heads/chromeos-5.54/doc/battery-api.txt Bug: b:160905767 Change-Id: I2bee100b25518b48a296b87657026769058384d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296266 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#789676}
-
Scott Violet authored
This is in preparation for using favicons in WebLayer, which won't use history. BUG=1076463 TEST=covered by tests Change-Id: I4adc5bd015cfdda16e3189f30df5a854dc0a4a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305038Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9109ad22..c80db6e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8853506baf40fdbbca7b3df04929b4a3ae5f0d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303704Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789674}
-
Ben Joyce authored
Jacoco is not generating .exec files for junit targets. I traced the root of the issue to the out/Debug/lib.java/base/base_java.jar (and other host jars) not being run through jacoco. Less redundant code would be to set the _previous_output_jar to the results of the host_filter jar, but then that'd get run through desugar, which was the reason for the changes in the first place (see https://chromium-review.googlesource.com/c/chromium/src/+/2241865) We were running on-the-fly code coverage with a javaagent sent as an arg to the jvm, but that did not generate the desired coverage data so we're going to use all offline. Bug: 1097815 Change-Id: I0d9b4a48f921b743ee5179345fd6a81fa9437cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291835 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Currently being used for MessagePump jank investigations R=chromium-metrics-reviews@google.com, fdoray@chromium.org Bug: 1104928 Change-Id: I97cd90523dad2fc561155b0e45d4fcc9be855be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305033 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789672}
-
Dean Michael Berris authored
In the ReportSender API, the callbacks are semantically called once and therefore should be base::OnceCallback instances instead of base::Callback (an alias to base::RepeatingCallback). Bug: chromium:1007815 Change-Id: I2a2f1d79f2c6c6dba1282174e71108b2c8e66c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291307 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dean Berris <dberris@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789671}
-
George Steel authored
The vscode clangd extension now uses this directory. Change-Id: I0232a3ac556ddbe2b867e8db508e1a86380fd6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297814Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789670}
-
Ian Kilpatrick authored
Previously we used slightly different logic for storing ink-overflow in the compressed "outsets" format, and the "NGSingleInkOverflow" object format. This resulted in differences in when running a 64bit binary (typical) vs. a 32bit binary with large ink-overflows (which are relative uncommon). This patch changes the "NGSingleInkOverflow" to have the same outset logic. Change-Id: If9d5146ec3fad1de27cfda2c13980312886b1e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304143Reviewed-by:
-
James Cook authored
set_sources_assignment_filter() causes files to be magically excluded from sources lists based on path (e.g. *_win*). It is considered a misfeature of gn, see bug or docs/no_sources_assignment_filter.md Convert BUILD.gn to use conditionals to include source files only on the platform where they are used. Bug: 1018739, 1096762 Test: compiles Change-Id: Ic5563a3558d9bdc8b9bc22bb6275d869a0985c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303463 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789668}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaca01acfdb0fab350ca38a6d96e042e3d33f7356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789667}
-
Alexander Cooper authored
Converts the OpenLoginTabCallback from Callback to RepeatingCallback. Converts base::Bind calls that were being passed to methods that take RepeatingCallback's to BindRepeating. Converts a few Callbacks being used as OpenLoginTabCallback in chrome/browser as well, since that is how the initial need for changes was discovered. Bug: 1007635,714018 Change-Id: I3a514a2eff2d821e2a34d9537440407eab1619e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297565 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#789666}
-
Haiyang Pan authored
For the following OSes: android, chromiumos, fuchsia, linux, and win. And remove the change in luci.chromium.try Bug: 1098927 Change-Id: I6a547e24c645128e3bef5368cf8117269dd0de47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286191Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#789665}
-
Quinten Yearsley authored
Change-Id: I5c2d041663d700b1b2860b20e73f6017c374e663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304965Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#789664}
-
David Schinazi authored
This CL fixes a linker issue where apps were failing to link CronetStatic due to missing symbol base::mac::CxxPersonalityRoutine. The fix explicitly adds the file containing that symbol. Thanks to mef@chromium.org and justincohen@chromium.org for finding this fix. R=zhongyi@chromium.org Bug: 1106056 Change-Id: Ifa2095f9c24de456b27eb1dd49c78ba94dd0900b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304966Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789663}
-
Noah Rose Ledesma authored
Regardless of how the UI is laid out, media playback controls should be laid out in a left-to-right manner, as suggested by the material.io bidirectionality guide. Additionally, the images for playback control buttons will no longer be mirrored about their horizontal axes in an RTL layout. This includes the play button and the PiP button. The PiP button is not mirrored because the PiP display is always in the bottom right corner regardless of UI layout. Finally, after having worked with l10n and talking to UX engineers in Israel, we have determined that the appropriate focus order for this dialog should traverse the playback controls left-to-right first and then focus the picture-in-picture button. This CL implements this order. Bug: 1040021 Change-Id: I0a57ec7d879ab312ec1ce7bb592d8f79edceaa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253134 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789662}
-
Andre Le authored
1. Fix padding and layout. 2. Make it a button that takes user to management setting page. Change-Id: Iddc81f1b6b3762249e6046484cce96128e3651c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303050 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d7afd4824c6..d0c9d0cb7ffa 2020-07-17 nifong@google.com Replace arcTo with three functions for it's overloads. 2020-07-17 csmartdalton@google.com Bind deferred vertex buffers during GrGLOpsRenderPass::onDrawIndirect 2020-07-17 fmalita@chromium.org [skottie] Fix analytical mask fill type 2020-07-17 johnstiles@google.com Add an input FP to the GrProcessorTestData. 2020-07-17 robertphillips@google.com Clean up some GrContext uses in the GMs 2020-07-17 adlai@google.com Remove two unused deprecated SkImage functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Id1e85a51798d15f77faa00b38719ed792ef0e25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305052Reviewed-by:
-
Jimmy Gong authored
- Removes extra indent of print job entries. Screenshot: https://screenshot.googleplex.com/4T27OJb9MT9 Bug: 1106167 Change-Id: I75ff3989e94b88766989d22be2e2ac1757bbc412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303872Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#789659}
-
Etienne Pierre-doray authored
Log actual values of max_concurrency, expected_max_concurrency and should yield. Change-Id: I4151e8812d58c30311111d07d06844d2f4ce60e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303986 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789658}
-
Maksim Ivanov authored
Log the error details, including the key, when crashing in base::PathService::CheckedGet(). Bug: none Change-Id: I69386d92cc335c82012a247c9cef255d8fefea57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291150Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789657}
-
Koji Ishii authored
|PostLayout| was limited to |LayoutBlockFlow| because crbug.com/965639 could happen only to|LayoutBlockFlow|, but following conditions have changed: * Only |LayoutBlockFlow| could be relayout boundary, until r772560 <crrev.com/c/2219312>. * Only |LayoutBlockFlow| was laid out by LayoutNG, until |LayoutNGFlexibleBox| inherits from |LayoutBlock|. This patch changes |PostLayout| to work for |LayoutBox|. In doing so, two changes were made: 1. |CurrentFragment| is replaced with |GetPhysicalFragment| because the former is not available for |LayoutBox|. 2. Stopped checking |IsRelayoutBoundary|. Though it is the only case crbug.com/965639 can happen as far as we're aware of, checking |NGPhysicalFragment| is more essential and sufficient. The change 1 also helps <crbug.com/1061423>, but we may need different approach to support block fragmentation. Bug: 1102151, 965639 Change-Id: Id83be614066392a4c58c8b03bd16ee57ad82e145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302984Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789656}
-
Michael Spang authored
This should work like other platforms, and give a Viz process that doesn't require a hardware GPU, e.g. for running tests on infra. This fixes an infinite loop when --disable-gpu is passed in such builds, where we try to start a GPU process but this is rejected by GpuProcessStartAllowed() == false. This started happening (or at least became severe enough to break our tests) after 966e62f6 ("[scheduler] Enable prioritize until begin main frame by default."). Change-Id: I67c4f819e0383950d1c876bc34b799fb794bd5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304154Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789655}
-
Chris Hamilton authored
This is similar to util::IdType<...>, except it adapts StrongAlias wrappers of base::UnguessableTokens, for code that wants to use a token as an identifier. This will be used in upcoming work to migrate much of current base::UnguessableToken usage to be strongly-typed. BUG=1096617 Change-Id: Icba4d6ace622dc7cc55cf731fc85d15aa12443b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302727Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#789654}
-
