- 17 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/71a18f6f4b01..3787dee78156 git log 71a18f6f4b01..3787dee78156 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 tneda@google.com Merge "perfetto-ui: Changing message for heap profiles in heap profile panel" Created with: gclient setdep -r src/third_party/perfetto@3787dee78156 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2042d7cbb0d7942fbdf626da9706eba093da8801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706859}
-
Peter Kasting authored
Bug: 82078 Change-Id: I13e7bd190e628d85f3bacbaca5e33108f94337f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866266 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706858}
-
Andreas Haas authored
When the DataHandle is created in ArrayBufferContents::CreateDataHandle, the provided {data} allocated with AllocateMemoryOrNull can be nullptr. If so, we don't want to store the length in the new DataHandle. To avoid an inconsistent state. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Ia9bb106a82b5c2f884b8a4e09ebd4f6ca0be9152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865220Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706857}
-
Fergal Daly authored
passing locally. Change-Id: I9b92a41da7aa590a000cb1cfa193e0bf338abbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866102Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706856}
-
Ricky Liang authored
We now have GpuMemoryBuffer support in fake and file video capture devices, so we can re-enable native input mode in RTCVideoEncoder without causing test regression. Bug: 1014209, 982201 Test: Verify that tast.webrtc.DecodeAccelUsedVP8 passes Change-Id: Ica0b61865aa97105f8dde6258f901bbf20d8aa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864503 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706855}
-
Maksim Ivanov authored
Temporarily remove the check of the AttestationEnabledForUser's pref/policy level from the chrome.enteprise.platformKeys implementation, since this check was not present before (until r701979), and since this isn't compatible with the current corp policies. This is a temporary workaround that will need to be reverted in the future, once the corp policies are fixed to have the AttestationEnabledForUser policy configured at the "mandatory", not "recommended", level. Bug: 1000589, b:142616571 Test: set the AttestationEnabledForUser to the recommended level, open corp cert enrollment extension's background page in DevTools, run "chromecert.Request.testOnly.getEuk("")", check that it doesn't fail with "Remote attestation is not enabled for your account." Change-Id: I0087364882728fdc63e84a789313e525c24a21d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865340 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#706854}
-
Jeonghee Ahn authored
Some web-sites may handle the arrow keys themselves for moving focus. Unfortunately some of them do not call preventDefault. In this case, the focus moves twice. (ex. Buttons of https://expedia.com (class="tabs cf col")) This patch prevents duplicate focus moving by checking that the current fucused element matches the event target element. Change-Id: If97fd4d81f3eabf7fc015aa464b6d121f30458fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859425 Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706853}
-
Andreas Haas authored
Instead we can allocate ArrayBufferContents directly. I also added a check if allocation failed. I also changed the allocation to not initialize the memory. It is overwritten immediately afterwards anyways. R=jbroman Bug: chromium:1008840 Change-Id: I046c30f499f67ff437e481c907efdd38fa0d0045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864788Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706852}
-
Guido Urdaneta authored
Bug: 1011888 Change-Id: I22726dea99926d06fb3f405aff4bdc257a6e61d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865221Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#706851}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check. Change-Id: I9c0370ebc71fdd8526c6619a1e63da4d9d05a928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866492Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#706850}
-
Shik Chen authored
Refine the 3A metadata shown in expert mode based on the feedback from the image tuning engineer. Bug: b:134636934 Test: Manually. Change-Id: I1e932fe51a55df1ce4dc185a04c023c21f4ada59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866100Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#706849}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I3569851e78754461b63e0d0fc1978b5140d63029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865311Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#706848}
-
Nick Burris authored
Fix the behavior where fragment anchors were only kept alive if a scroll was needed, as is the behavior of element fragment anchors. This caused text fragment anchors not to be kept alive and we didn't highlight on reload. Note that *sometimes* we would highlight on reload, due to a race condition with fragment anchors, where we process the fragment before restoring scroll position (which is where should_scroll becomes false), see crbug/839292. This change makes it so we highlight on reload independent of whether a scroll is needed. Bug: 932551 Change-Id: I38cc82c4920255d8bcae9f8b55ac80f24d1465da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864714 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706847}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d91cd688. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I95b41ba902397e77208fb907a93238b3c8c2c0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866032Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706846}
-
nancy authored
BUG=1009248 Change-Id: I15e467a7efdaf88967f9d40ef48033a6605c6d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862870 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#706845}
-
Julie Jeongeun Kim authored
This CL converts ProxyResolvingSocket to new Mojo types using PendingRemote, PendingReceiver, UniqueReceiverSet, and Remote. Bug: 955171 Change-Id: Ic9024aa535f170e3a200329e0fba44a9dcaf239c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863024 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#706844}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I4b09fc6d47e64a972fa63665f7e84b0c61a742f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865166Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#706843}
-
Guido Urdaneta authored
This CL has two main changes: 1. Use persistent media device IDs only if cookies are allowed. If cookies are not allowed, device IDs are unique per document. 2. Make group IDs unique per document, following a change in the spec. This is achieved by moving the former groupId salt from WebContentsImpl to RenderFrameHostImpl and resetting it on every navigation. Prior to this CL, persistent media device IDs were used even if the origin had cookies disabled, and group IDs were unique per web-contents, not per document. Drive-by: remove unused MediaStreamDispatcherHost reference from RenderFrameHostImpl. Bug: 1008124 Change-Id: Iabd0c9cc76e05190779cc210970e185dfc8f5992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863095Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#706842}
-
Friedrich Horschig authored
After some discussion, we decided to add the "above the keyboard" line to the opening announcement, see linked bug for details. Screenshots don't need to be updated since they can't show the string anyway (as it's only heard via talkback). Bug: 1009140 Change-Id: Iddd74a87bf67fc679b341505e0d585dc8dd5dc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865217Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706841}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/00170cc5e6fb..e99b9182214f git log 00170cc5e6fb..e99b9182214f --date=short --no-merges --format='%ad %ae %s' 2019-10-16 kubak@google.com Support constant-folding UConvert and SConvert (#2960) 2019-10-16 rharrison@google.com Add fuzzer for spirv-as call path (#2976) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e99b9182214f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: Ib79f2185785f88083a80c03a677907c0069bd4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706840}
-
Hirokazu Honda authored
This adds Fourcc::IsMultiPlanar(), which returns if the fourcc is multi planar format in terms of V4L2 API. Bug: None Test: image_processor_test on atlas and hana Change-Id: I464e624b3043dbab29331df52e91958537a03b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866369Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706839}
-
Monica Basta authored
On startup,check if two or more profiles has the same default profile name, e.g: "Person 1", for these profiles recompute the local profile name in a way that "Person n" is unique. This can happen because the profile name was a syncable pref so having two profiles with the same local profile name "Person n" was possible. Bug: 1012182 Change-Id: Ic19352c4fdd15717b7d88c53e3e769eb3dfaa8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864781 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#706838}
-
Ioana Pandele authored
Change-Id: Ib0cdf0c62cc391934d37554274a321bd93f4d364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865341 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706837}
-
Thomas Tangl authored
... and wait for the unconsented account to be set. Bug: 995720 Change-Id: I2348b9c57309482040462afb73310b279e280fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865329Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706836}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_triggering_event_info.h file was moved to public/common/navigation. Since the file is no longer in the public/web directory we are also renaming it to triggering_event_info.h (and the enum defined in that file to TriggeringEventInfo). In order to avoid clashes between class and method names the TriggeringEventInfo() method in FrameLoader had to be renamed to GetTriggeringEventInfo(). Bug: 1008303 Change-Id: I0daba0ea71c1ebe879d78db39844d41db727ee0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860417Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#706835}
-
Rakina Zata Amni authored
A devtoools display locking a11y test was marked as failing in MSAN bots and is also flaky when tested locally, this CL updates that test and fixes the cause of the failure (getFullAXTree might be called when style/layout is dirty, which caused failing DCHECKs). Some other display locking a11y tests were not updated correctly, and is updated in this CL as well. Bug: 996625 Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706834}
-
Vadym Doroshenko authored
Bug: 1015234 Change-Id: Ibed37406b06a30f2d158d25c97994d256354c901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865342 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#706833}
-
Tsuyoshi Horo authored
Bug: 969596 Change-Id: I80ce8fe371f3d8d04cfc45146398976aa693f2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866118Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706832}
-
Michael van Ouwerkerk authored
Bug: 1010515 Change-Id: If62345aba1aed10d3e679140ee66aeb2f074115f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841331Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706831}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/68dee89cf39e..9187f322d59f git log 68dee89cf39e..9187f322d59f --date=short --no-merges --format='%ad %ae %s' 2019-10-17 jrosenth@chromium.org lib/retry_util_unittest: Add support for Python 3 2019-10-17 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9187f322d59f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I73e46d409230b06048c91224151992aec503a323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706830}
-
Ricky Liang authored
This CL enables FakeVideoCaptureDevice and FileVideoCaptureDevice to provide fake camera frames backed by GpuMemoryBuffer. Bug: 982201, 1006613 Test: capture_unittests Test: tast.DecodeAccelUsedVP8 Test: Manually with appr.tc and Hangouts Meet Change-Id: I495d1cf11f4f4b9181842c373023b907d7f77f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863055 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#706829}
-
Jan Scheffler authored
This cl adds Ctrl+G and F3 as keyboard shortcuts for windows and linux to find the next occurrence while a search is open (not necessarily focused). The default behaviour of Ctrl+G opening the goto line popup still works as long as the search is not opened. Bug: chromium:887586 Change-Id: I8164786778e0b8cb99f7d6ca9d37a61cc34b622b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817887Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706828}
-
Miyoung Shin authored
This CL converts LearningTaskController{Ptr, Request} in media to the new Mojo type, and usese pending_receiver<LearningTaskController> in media_metrics_provider.mojom. Bug: 955171 Change-Id: I38bd8fc6704d057efd8e37ef18b591b7c5d3d10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862926Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#706827}
-
Alex Clarke authored
In pinpoint jobs I noticed the StartupTabPreloader optimizations are not triggering when they should, see: https://pinpoint-dot-chromeperf.appspot.com/job/10b357bac20000 This appears to be because the Intent's component is org.chromium.chrome.browser.ChromeTabbedActivity but the StartupTabPreloader expects com.google.android.apps.chrome.Main and is ignoring the intent as a result. By using a VIEW intent this optimization should trigger, which will let us correctly evaluate some possible optimizations. Bug: 1013535 Change-Id: Ifdd92faec33f7af2231746110a9ae10135ce8e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864678Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#706826}
-
Jüri Valdmann authored
It makes GCC very upset. Bug: 819294 Change-Id: Icf29f006d40a2d8686e93cb0c0f7db6a19ef6242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862912 Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706825}
-
Pâris MEULEMAN authored
As a work around to bug https://crbug.com/1014098 provide a getAccessTokenWithFacade method on OAuth2TokenService for InvalidationGcmUpstreamSender as it cannot access to the profile before native initialization. Bug: 1014098 Change-Id: Ifa1a8c029764d2d935b7bf5723fa1782f928608c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862909 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706824}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d5153bb05a6b..0df7697235b4 git log d5153bb05a6b..0df7697235b4 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0b9ebe58e380..ed6e230ec65e (10 commits) 2019-10-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9097eeb5359b..6652f0b64287 (11 commits) 2019-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src fbf280c2..e27799ab (477 commits) Created with: gclient setdep -r src/third_party/skia@0df7697235b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I6d707ec761b6d8aa9e2d56a1c0980cfd133355a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706823}
-
Tom Anderson authored
Control Flow Integrity [1] indirect call (cfi-icall) checking can not verify that dynamically resolved function pointers call their intended function. Instead we place the function pointer ProtectedMemory, a wrapper for keeping variables in read-only memory except for when they are initialized. After setting the pointer in protected memory we can use the UnsanitizedCfiCall wrapper to disable cfi-icall checking when calling it since we know it can not be tampered with. [1] https://www.chromium.org/developers/testing/control-flow-integrity BUG=1014902 R=thestig Change-Id: Id55510f4d924bf8d4dd73332b7a8b18a9e6bc04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864377 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706822}
-
Henrique Ferreiro authored
Convert all users of the drivefs::mojom::FakeDriveFsLauncher interface. Bug: 955171 Change-Id: Iad4d70615c78b699ac1cf078b5bdbc658245ce10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859781Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#706821}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I76a5a385a183700931618753ff8985b8260c467c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856158 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#706820}
-