- 21 Jan, 2021 40 commits
-
-
Alice Wang authored
This CL cleans up SigninPromoUtilTest by removing the unused method and annotation. Bug: 1166173 Change-Id: Idb9bceb7dac0c371af3c2e9b2b15eefddbf2722a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640034Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845627}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/477bd92472cc..3b349f3ea9c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5fab1d1ef557e00f7739fa05e9cf0f6454c50ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642738Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845626}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4384.0-1610969724-benchmark-89.0.4389.9-r1 to 89-4384.0-1610969724-benchmark-89.0.4389.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iaa4526a6659275b1fb790848bac52e4278c03032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642802Reviewed-by:
-
Alice Wang authored
This CL adds a render test for SigninFirstRunFragment when no accounts are on device. Bug: 1045473 Change-Id: I058212677f7f4cb0d29888632f12d2fabd75ded0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639895Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4384.0-1610966529-benchmark-89.0.4389.9-r1 to 89-4384.0-1610966529-benchmark-89.0.4389.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I55e58cc45b74c50db2a08a290e6ef6477378210c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642800Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/309863f0a8f1..f9033fa039cd 2021-01-21 chrche@microsoft.com [Loc] Migrate perf_ui to localization V2 2021-01-21 tvanderlippe@chromium.org Migrate MultiMap to map-utilities 2021-01-21 mathias@chromium.org Enable focus styles for network request blocking checkboxes 2021-01-21 szuend@chromium.org Roll deps from Chromium into DevTools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I811a2ab39894bdd07a300b72cfd2ad493541776d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642516Reviewed-by:
-
Richard Knoll authored
The UNNotification API expects us to provide a unique identifier for each notification we show. The previous implementation simply used the notification id as-is which breaks with multiple profiles as their ids may overlap. This CL changes the used id to be "ProfileID|NotificationId" instead to avoid this issue. Also fixes support for the renotify flag. Bug: 1127306 Change-Id: I9f302c3e045d2f6f3358f5d528e80f9a626fca59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637519 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#845621}
-
Ossama Mahmoud authored
This is a reland of ddd08c52 Original change's description: > OOBE: Arc-ToS Improvements > > Migrate ArcToSScreen to multistep behavior. > Get rid of display: none; and display: block; > > Bug: 1156667 > Change-Id: I4c2fc425edd4883c5edfceb0a5a9f67a6227de7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603744 > Commit-Queue: Ossama Mahmoud <osamafathy@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844554} Bug: 1156667 Change-Id: I53e9d533c9e3b7d5b5ba44dcf55997a3d9f6fab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637560Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Cr-Commit-Position: refs/heads/master@{#845620}
-
Jan Wilken Dörrie authored
This change prepapres sys_info_win for the string of base::string16 to std::u16string. Bug: 911896 Change-Id: I53c2cb2127aa576d8c4f83382893c5ffdd095070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642267 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845619}
-
Hans Wennborg authored
Link-time optimization enables greater performance, but leads to significantly longer link times. This change turns off optimization in the link step except for select targets such as the actual browser executable/shared lib. Source files are still compiled with the usual optimization flags, and the ThinLTO mechanism is still used for all links; this only affects whether optimizations are also performed in the link step or not. The motivation is to speed up builds with thin_lto_enable_optimizations so that this can be enabled in official builds on all targets. Currently only ChromeOS and Android use thin_lto_enable_optimizations, and in terms of production builds this is a no-op since the optimization is applied to the shipping binaries as before. However it means that tests and auxiliary binaries won't be optimized during the link step. In terms of build speed, this reduces the link time of v8_context_snapshot_generator in a Linux build with thin_lto_enable_optimizations from 173 to 39 CPU minutes. On Windows, the link time of the same target goes from 2m50 to 1m40 (wall-clock time). Linking unit_tests goes from 8m50 to 5m40. Build timings (best of two) of official "all" builds on my Win workstation: - Without ThinLTO: 25m - With ThinLTO opts: 4h36m - With ThinLTO opts+this patch: 2h39m With the ThinLTO cache enabled (requires fixing crbug.com/871962): - With ThinLTO opts+this patch: 1h52m Hopefully this patch (esp. if we can also fix the thinlto cache bug) would make win-official survive enabling thin_lto_enable_optimizations in official builds. Build timings of official "all" builds on my Linux workstation: (ThinLTO without opts is already enabled in official builds due to CFI, so I didn't measure with it disabled.) - With ThinLTO opts: 4h00m - With ThinLTO + this patch: 1h12m Note that this means test binaries and the shipping browser see different levels of optimization. We think that is the right trade-off: the difference should only matter in case of compiler/linker bugs, and we believe the browser binary gets enough testing (e.g. by perf bots) that such bugs will still be caught. Also to some extent this is already the case: most testing is done on non-official builds, and official builds use different optimizations (notably PGO). We have more ideas for speeding up linking of the non-link-time-optimized targets, but we hope this is enough to enable ThinLTO in official Windows and Linux builds. Bug: 110124, 1057737 Change-Id: I4130c02d0b7fe7012e52c92e51a0b255b576ad2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628955 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#845618}
-
Christian Dullweber authored
Bug: 1146211 Change-Id: Ib9667340b5148cfe56adea91cf1e2089c1f8b3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635152 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#845617}
-
Alex Ilin authored
This reverts commit e2de939b. Reason for revert: causes crash https://crbug.com/1169047 Original change's description: > [profiles] Don't show a profile being created in the picker and menu > > This CL leverages the already existing kIsOmittedFromProfileListKey > preference in ProfileAttributesEntry to mark profiles that shouldn't > be shown to the user. > > kIsOmittedFromProfileListKey was created for profiles in the middle of > being set up as new legacy supervised users. The preference was dead > because it was never set to true. This CL revives it and adds additional > checks to profile_picker_handler.cc and profile_menu_view.cc to not > display omitted profiles. > > Bug: 1126913, 1166809 > Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752 > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845372} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5133c4502f02b68c4e707fa7c86072bdabce4ff2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126913 Bug: 1166809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642328Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845616}
-
Andrey Zaytsev authored
Bug: 1152351 Change-Id: I8afa16d818cfe1da71ec0479d9bc9d314346fd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637833Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#845615}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b0aab7e1. With Chromium commits locally applied on WPT: 898dcda5 "Move CSPEE to the NavigationRequest." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org: external/wpt/touch-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I124f4be3f7d63bc94da9200c1af9eee7b591c847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642184Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845614}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I50474a161c23b5ddab42701df2bed008eaa0e4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640434Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845613}
-
Boris Sazonov authored
This reverts commit 3f534050. Reason for revert: breaks Android builders: https://crbug.com/1169083. Original change's description: > Reland "[TFLite] Enable tflite in build for android and desktop." > > This is a reland of a4df03d0 > > This addresses the revert by removing neon from the TFLite build > for chromeos. > > > Original change's description: > > [TFLite] Enable tflite in build for android and desktop. > > > > Bug: 1165517 > > Binary-Size: Expected increase due to inclusion of TFLite in binary. > > Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845026} > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Bug: 1165517 > Binary-Size: Expected increase due to inclusion of TFLite in binary. > TBR: Andrew Grieve <agrieve@chromium.org> > TBR: Tarun Bansal <tbansal@chromium.org> > Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845478} TBR=agrieve@chromium.org,tbansal@chromium.org,sophiechang@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I7475d86a39c33285c37662fa8a1c7f44f4229e1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1165517 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642619Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#845612}
-
Roman Sorokin authored
Was introduced in https://codereview.chromium.org/2752873002 Fixed: 1165252 Change-Id: Ie3c432d79c5ba216410ad211bbcf46cc6e1d6c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640454Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845611}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc1e578d..099b043d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib07fa2b98e8f6e6dd1d02de54e3b3228fbcd69bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642127Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845610}
-
Richard Knoll authored
This refactors the macOS AlertDispatcher interface to no longer require an instance of NSUserNotificationCenter to be passed in. We expect the caller to query their local NotificationCenter instead and merge the results. This allows us to use the same interface in a future CL for the UNNotification API. Bug: 1127306 Change-Id: I207eaf454ed86a7636725949269de5fee780167b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640119Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/762814bd9229..ef869c2d01d5 2021-01-21 cwallez@chromium.org Use SubresourceStorage to track per-subresource state. 2021-01-21 cwallez@chromium.org EnumMaskIterator: ASSERT when the mask is too big. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I1ebdd3a7101b9e5f77299c653a6cfa4313ffe699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642171Reviewed-by:
-
Jan Wilken Dörrie authored
37dd8f83def8 Fix compilation issue on arm64 with Debian's glibc 2.19 564d5f340f99 [c16lcpy] Use std::char_traits<base::char16> in c16lcpy 2d2e46b2ac34 ios: Fix iOS14 detection of _UIGestureEnvironmentUpdate sinkholes 2a777a4d4fb0 compat: Remove non-Mac dependency on third_party/xnu b858473d9c3d compat: Remove unused deps Bug: 911896 Change-Id: I211044fee163098123619910206c72dad4937edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642264 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#845607}
-
Christian Dullweber authored
Bug: 1146211 Change-Id: Idc792f4e5dc5f89494b8b3a978fb912c3a545bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632962 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Rahul Goyal authored
The trigger scripts persists in case user clicks cancel/dismiss in onboarding dialog. With this patch user has the option to continue with JITT even after cancelling/dismissing the onboarding dialog. Bug: b/174445633 Change-Id: If6d9caf1a39af1668f2b9e796d9fd42326590e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612892 Commit-Queue: Rahul Goyal <goyalrahul@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#845605}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611176356-4b0456d54b0928899e317c11eb73b969caf82aca.profdata to chrome-win64-master-1611219467-221ce2b3efda04c3b102ac62c26b5f5a8e2aaa76.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7555b0acb3bd87fcc81489cc18686e0814d42147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642424Reviewed-by:
-
Simon Zünd authored
These tests print the sidebar menu in the Applicastion panel, thus prohibiting the new Trust Token panel (https://crrev.com/c/2626291) to land. R=sigurds@chromium.org Bug: chromium:1126824 Change-Id: I3f7afb680a1dfa8817fab956bc5a01748b4a41b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642616 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845603}
-
Anders Hartvoll Ruud authored
This CL wraps all calls to Element::StyleForPseudoElement outside the Element hierarchy in a new function Element:: UncachedStyleForPseudoElement. This is done because we need to differentiate between pseudo-element style calculation done as part of the main style recalc (where the StyleRecalcContext is immediately available on the stack), and calculations done on demand from paint/layout code (where we'll need populate a StyleRecalcContext by traversing the ancestor chain). By doing this refactor, we can limit the "StyleRecalcContext re- construction" to take place in Element::UncachedStyleForPseudoElement, rather than at every "external" call-site for StyleForPseudoElement. Note: I was considering adding a PassKey<Element> to StyleForPseudoElement to prevent accidental use of that function outside the Element hierarchy, but it probably won't be needed once a StyleRecalcContext parameter is added. There should be no behavior change in this CL. Bug: 1145970 Change-Id: I4e505deaf1a3158185865e6df231e3b78cb02632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637476 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#845602}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/477bd92472cc..3b349f3ea9c0 2021-01-21 lijiahui.me@gmail.com Update build-instructions.md file reference location in ui/README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I784b8fb6185283a2ebe72c8e11a8ad5a1a277dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642170Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611208290-cf05eaf8e0dadf6ae1b4b2e6d84e2b6985a10d51.profdata to chrome-win32-master-1611219467-390b4abe6a87e7c94cab88849ad56f5359438186.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4e87dc2e52d98c023e3746f273f5e15b99adc8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642164Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5fccb46378a1..309863f0a8f1 2021-01-21 wolfi@chromium.org Port FrameDetailsView to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iad20833c5e7888e537436a6d56fba1c961c169bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641992Reviewed-by:
-
Anastasiia N authored
This reverts commit 660b7591. Reason for revert: https://crbug.com/1169070 Original change's description: > [ntp] Add flag to disable the logo > > Makes the logo Finch-configurable. Flag is enabled by default. > > Bug: 1168361 > Change-Id: Ie9fbeebb5f88fcf6ca2d6a418759f65e61d3231e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639153 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845490} TBR=tiborg@chromium.org,aee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ifa4cd2f58ccf58452a32f0c89bc23fb07cb50a5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1168361, 1169070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642327Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#845598}
-
Jan Wilken Dörrie authored
This change modifies encryption utils used for Password Check to return base::Optional<std::string> instead of std::string. Now these methods return a nullopt instead of an empty string in case there was an error in the used Cipher, forcing callers to explicitly handle error cases. Bug: 1157004 Change-Id: I21bea839020cd89e097fcf2a36efabe2adbed91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642144 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#845597}
-
Viktor Semeniuk authored
This change allows to sync compromised credentials only if appropriate flag is enabled. Bug: 1168546 Change-Id: I8d777778771a344cefa62c418a0e364b695b522e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640094 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#845596}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bb7660008b16..9f4b159b7aa0 2021-01-21 syoussefi@chromium.org Translator: Avoid vector copies with multi-replacement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Id4ea9fb7a04c081b7f776515150b37db3a64522e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641573Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib1bf1c5dbe182909134e04b298147355a3523814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641012Reviewed-by:
-
Dana Fried authored
Currently nothing will cause this tip to be displayed, but this CL provides the mechanism to do so for future experimentation. Change-Id: Id8730bcf9c0a543c825a8842ebb6c4d73a5562aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552035 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#845593}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/026ad9ac2205..a7e34d33fe70 2021-01-21 asapersson@webrtc.org Add resolution_bitrate_limits to EncoderInfo field trial. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7d0ba42352607495a7f2973e101e5c81ba143b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641989Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: b/168080931 Bug: b/147265909 Change-Id: I786453f22e1748a3b1e2da6edb8d3a35563bb57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642084 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#845591}
-
Collin Baker authored
ThumbnailImage::CropPreviewImage relies on the supplied thumbnail having non-null image data. A null thumbnail was passed when ClearData was called. It is not necessary to crop a null thumbnail, so avoid calling it when the thumbnail is null. Fixed: 1168483 Change-Id: I89de21fb69f49069c44db54f4e82f80c3afa7da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641156Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#845590}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/settings. Bug: 1148570 Change-Id: I10bcc9e993a9df44932719297ed1893821ae2525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641476 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#845589}
-
Peter E Conn authored
Change-Id: I8caff95f74faa0ac9509028b357dfcc146980262 Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637498Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
-
