- 18 Aug, 2020 36 commits
-
-
Xianzhu Wang authored
Previously once a layer became not LCD-text capable, it would never use LCD-text again. I think this was to avoid re-raterization during animation. As we don't allow LCD text with will-change:transform and during animation, and we skip re-rasterization on LCD text status change during animation, there is no reason to keep that logic. Bug: 1111195 Change-Id: Ib544be76c114e520572c0ccf5d88dd96bf7db151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344810Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798939}
-
Pete Williamson authored
Headlines, 3packs, and Covid news all don't have a base URL. Allow sending feedback anyway. Bug: 1117268 Change-Id: Iad366bc79b042dc51c1df5938db32c6f5f7cada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360484Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#798938}
-
Yuke Liao authored
The CQ linux-lacros-rel couldn't find certain targets, for example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8871947371480314656/+/steps/analyze/0/stdout This CL fixes the issue by using gn_all instead. Bug: 1116180 Change-Id: I5b9f3a8f595790d8ff2628d132599f6347df7e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360571 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798937}
-
Brandon Wylie authored
Bug: 1116167 Change-Id: I4187c9a7fe3434bd3de5177913a0d5f34291a81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358817Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798936}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8111309b7f06e13a31904997edcc0a1171e03796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798935}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d63bca58a085..693d0e0bb673 2020-08-17 jmadill@chromium.org Vulkan: Minor cleanup to vk_helpers. 2020-08-17 cnorthrop@google.com Capture/Replay: Don't capture unused default uniforms in MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: MEC capture of COD:Mobile Change-Id: I67668785a88f96de2f7e7c0a96820fd6167bfff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360268Reviewed-by:
-
Carlos IL authored
The parameter was accidentally removed when solving merge conflicts in crrev.com/c/2350022 Also adds a test to prevent a similar regression in the future. Change-Id: Ib0646c69fc1881f8a82fc122fc4d2fce23f41a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356935 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798933}
-
Merissa Tan authored
This reverts commit d5524bc1. Reason for revert: Fixed bug that was making arc.Gamepad fail. Manually tested to ensure arc.Gamepad is passing. Original change's description: > Revert "Add gamepad rumble support in Exo and Wayland." > > This reverts commit 047950bb. > > Reason for revert: failing arc.Gamepad > > Original change's description: > > Add gamepad rumble support in Exo and Wayland. > > > > - Add exo::Gamepad interface. > > - Add exo::GamepadObserver interface. > > - Add WaylandGamepadVibratorImpl to handle vibration and cancel > > vibration requests from the client. > > - Refactor WaylandGamingSeatDelegate so that WaylandGamepadDelegate > > handles all gamepad-specific events. > > - Add Wayland protocol to support gamepad rumble. The zcr_gamepad_vibrator_v2 interface is created when the server calls > > the vibrator_added event. The client can then trigger/disable vibration > > events on a gamepad vibrator through the interface. > > > > BUG=b:158686809 > > TEST=Add unit tests in gamepad_unittest. All tests pass in > > exo_unittests. > > > > Change-Id: Ie4b1b3b5f9748f31846c54c97cb4f7c315d09a05 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313976 > > Commit-Queue: Merissa Tan <liyingtan@google.com> > > Auto-Submit: Merissa Tan <liyingtan@google.com> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798253} > > TBR=oshima@chromium.org,xutan@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,liyingtan@google.com > > Change-Id: I39d80057e7bcfda6bbfab5d2ea99d0d94a743aaf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:158686809 > Bug: 1116682 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358690 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798400} Bug=b:158686809 Test=Add unit tests in gamepad_unittest. All tests pass in exo_unittests. Manually tested arc.Gamepad Tast test. Change-Id: I094007035f7eb28e3130e3a1de207e4a85f6845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359580Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Merissa Tan <liyingtan@google.com> Auto-Submit: Merissa Tan <liyingtan@google.com> Cr-Commit-Position: refs/heads/master@{#798932}
-
Miguel Casas authored
The relanded CL was reverted due to crashes when used from ARC++: Video Frames coming from this path are not GpuMemoryBuffers, so there's a DCHECK not verified, and then a crash. This CL addresses that situation, fixing `video_decode_accelerator_tests --use_vd_vda`: see crrev.com/c/2359734/1..3. Bug: b:163920993 Original RELAND description ------------------------------------------- The original CL was reverted due to crashes in betty initialization: betty is a VM which doesn't support VA, so the VideoDecoderPipeline constructed-destructed a VaapiVideoDecoder, hitting an unprotected nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. TBR=andrescj@chromium.org Original CL description ----------------------------------------------- Certain platforms and codecs suffer from horrible artifacts (Intel BYT, H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of error in the tracking of the VASurfaces lifetime in the driver: every time we get a new resource from the pool to decode onto, this is imported into libva as a VASurface: this works fine almost everywhere but doesn't play well in these old platforms (see CreateSurface() body). This CL adds a map that keeps the ref-counted VASurfaces alive and indexed by the unique GpuMemoryBufferId until the VA Context is destroyed. In so doing, we're basically observing the "contract" of va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all contexts using these surfaces have been destroyed". [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 Bug: b:142019786 b:143323596 Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#795026} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#798931}
-
Joe DeBlasio authored
I can't get this test to timeout, so I'm re-enabling it on the offchance that the issue was transient caused by something else. Fixed: 1106402. Change-Id: I5abe1b431772d19f2f6d47488347e938939452f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360756 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#798930}
-
Solomon Kinard authored
Bug: None Change-Id: I1e4624e218e4bd4b63c245586012fc5ea4d7a7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359636Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798929}
-
Christopher Cameron authored
Change the CAMetalLayer that is used to display HDR content to always be extended-linear-sRGB (and it is already always half-float). Add code in the shader to support converting extended-sRGB, PQ, and HLG transfer to linear. This allows us to promote HLG content to overlays again, because we are now no longer passing the kCGColorSpaceITUR_2020_HLG color space directly to the WindowServer (we are interpreting it ourselves). The next patch in this sequence will add tone mapping support for HDR-but-only-slightly-HDR displays. Bug: 1101041, 1079160 Change-Id: Iee02c84d376eacc63fcb4ccd08ef093d2260f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354912 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798928}
-
Thomas Guilbert authored
This CL adds two WebCodecs contributors to owners. Change-Id: I6e6f00dc40bb4b52eb941a656a428cbca1f1440c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357916 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#798927}
-
Mark Schillaci authored
This CL adds support for multiselectable aria-activedescendants For nodes that are multiselectable (e.g. listbox of items with an aria-activedescendant role), we add more descriptive labels. For Android R we use the new stateDescription on AccessibilityNodeInfo object for the given node. To support pre-Android R, we append the labels to the text for the node. For a multiselectable node that has no items selected, we add the text: "multiselectable, none selected." For a multiselectable node with n children selected of k total, we add the text: "multiselectable, n of k selected." multiselectable aria activedescendants AX-Relnotes: Added more descriptive accessibility labels for Change-Id: I9fe04714c5800939b73b11c3339e628ae7760939 Bug: 1101660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341826Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#798926}
-
Nick Burris authored
Create the view that draws the secure payment confirmation dialog. Bug: 1110322 Change-Id: I99e113a24fda093423b9ebb0def776d57446ff4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340320 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798925}
-
Sky Malice authored
Test if flakily crashing in native, see bug for more details. TBR: mahmoudi Bug: 1117264 Change-Id: Ieccd3c7cbabeb529b3f64a7e949d7be793bf516c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358826 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#798924}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5cfa7194d55e..e9d783c4d235 2020-08-17 reed@google.com use pathbuilder 2020-08-17 kjlubick@google.com [infra] Update go to 1.15 2020-08-17 brianosman@google.com SkSL: Disallow swizzles that *only* contain '0' or '1' components 2020-08-17 robertphillips@google.com Remove some (presumably) unneeded calls to textureParamsModified in GrGLGpu 2020-08-17 johnstiles@google.com Update the Gradient documentation. 2020-08-17 ethannicholas@google.com SkSL now detects modifiers used in incorrect contexts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Ieded41e80b71c0da36d2cd13713d70dc6e16bc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359473Reviewed-by:
-
Robert Ma authored
* Load other resources separately * Throw from loadMojoResources when a path is not /gen/.../*.mojom.js Bug: 1116600 Change-Id: I4f9dbc4459583480ce202e65c789397422a282fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358904Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#798922}
-
Melissa Zhang authored
Bug: 1097623 Change-Id: Ib864f2ddef5774f11394c0bcf53792c27333b1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355167Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798921}
-
Sean McAllister authored
This reverts commit f82a08ba. Reason for revert: Causing breakage in linux-chromeos-chrome builder: https://crbug.com/1117021 Original change's description: > Add Remote Apps Mojo service > > This CL adds a Mojo service for Remote Apps. The service is a thin layer > which mainly forwards calls to the RemoteAppsManager. > > Only extensions under the imprivata_in_session_extension behavior feature > have access to the API. > > Bug: 1101208 > Change-Id: Ieaf9f6839ba22d86cb3fba8fa64afe49ade8e6ce > DD: go/remote_apps_mojo > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332615 > Commit-Queue: Jit Yao Yap <jityao@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798551} TBR=xiyuan@chromium.org,antrim@chromium.org,rdevlin.cronin@chromium.org,sammc@chromium.org,ortuno@chromium.org,jityao@google.com Change-Id: Ica8c3ed24d2051e87b1c4c6cbf09a3490e553a6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358605 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798920}
-
Scott Violet authored
BUG=1076463 TEST=covered by tests Change-Id: I03eed9dd1a307d92a2a7b92c59ab045b851e03a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358052 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798919}
-
Khushal Sagar authored
TBR=sunnyps@chromium.org Bug: 1114184 Change-Id: I4f4c328ff19df11d7abe3521934e7523a7871373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360497 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798918}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/699711c7e3cd..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifb714260df5e3e19a5540ecb1441d6fccaf435d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360492Reviewed-by:
-
Dana Fried authored
Without abs(), a drag-left (e.g. to reorder extensions) will be interpreted as trying to open the tabstrip tray in touch mode. Bug: 1117274 Change-Id: I535eeb8284bcc9d9406721efbcd9363b820c9d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360596Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#798916}
-
Fergus Dall authored
This reverts commit e771c29c. Reason for revert: Broke ChromeSessionManagerRlzTest.* tests. See: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7804 Original change's description: > Oobe: enable child specific signin feature > > Bug: 1101318 > Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#798671} TBR=xiyuan@chromium.org,antrim@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I579715924cccd7f9f531f0ce1310e68254c24c44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359874Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42e3f1d3cb76..5664586374b9 2020-08-17 ddoman@chromium.org [resultdb] add ddoman@ to depot_tools/LUCI_OWNERS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib67e87a72e06dc95fc9609a55b66fb9cc39eec8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360436Reviewed-by:
-
Zhongyi Shi authored
When connection migration is enabled, if network is disconnected, migration will wait for a new network to start migration. If there is no new network being connected, instead of close the connection with ERR_NETWORK_CHANGED, throw ERR_INTERNET_DISCONNECTED to reflect the cause of failure correctly. Note if the session encounters a pre-emptive QUIC_PACKET_WRITE_ERROR before receiving OnNetworkDisconnected notification, ERR_NETWORK_CHANGED will be thrown as PACKET_WRITE_ERROR is not necessarily caused by OnNetworkDisconnected. Bug: 1115629 Change-Id: I81fae1249993926d60babb5a097f11c30cf42f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353556 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#798913}
-
Sahir Vellani authored
In order to allow touch interactions to appropriately work with composited scrollbars, the scrollbar needs to be designated as a touch event consumer. This will prevent touch moves on the scrollbar from being filtered. This requires the browser to know whether a hit-testable scrollbar is present on a given platform. This change introduces the mechanism for providing the browser with that information. SetHasTouchEventHandlers is converted to SetHasTouchEventConsumers, with the consumers being JavaScript touch event handlers or scrollbars. The has_handlers boolean is converted to a bitfield containing these two pieces of information. This change does not change the behavior of the browser, and is a prerequisite to allowing touch dragging and interactions on composited scrollbars. Bug: 1082606 Change-Id: I1cf93155ffbccf8dca5196b358f343ee89208abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298346Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798912}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25f6caceffe6..8d6628854c8b 2020-08-17 mjackson@microsoft.com PWA: Update installability failure to account for display_override If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109520 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I995f3ec10246c9397b21e72f5768b7476f924bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360437Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2a9f6661597..1756465158d3 2020-08-17 fmayer@google.com Merge "Roll traceconv and trace_processor." 2020-08-17 fmayer@google.com Merge "Store field names in class." 2020-08-17 fmayer@google.com Calculate SHA after stripping. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic4afa010df3be65a141cf48c64309bca4b2e1d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360552Reviewed-by:
-
Peter Kasting authored
* Declare constants and variables in the narrowest scope possible * Remove unnecessary base:: qualifiers * Use helpers like JoinString() and std::transform() * Use more/better Time:: constants * Simplify * Use const/constexpr more * Don't handle DCHECK failure * Use TimeDelta::InMicrosecondsF() to get a double Bug: none Change-Id: I8ba31377f5f051f903018d7d9066146cf34e9a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358999 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798909}
-
Dan Harrington authored
Bug: 1117076, b/164532972 Change-Id: I6352376426a09ff444680b61537e05442db368d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360235 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#798908}
-
chrome://safe-browsingDaniel Rubery authored
This CL modifies the way the SafeBrowsingUIHandler retrieves the SB cookie so that we can display the correct cookie per-profile. Bug: 1049833 Change-Id: Ifab72742807b808c07ab324b6f0474fc7bfa63b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358592Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#798907}
-
Alan Cutter authored
This CL extends WebAppUiManagerImpl::UninstallAndReplace() to also migrate the following user preferences: - chrome://apps grid position. - standalone/browser tab launch preference. Pre-migration screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=462010&signed_aid=oHAn32fAhc9IyNofMQ7C9Q==&inline=1 Post-migration screenshot before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=462009&signed_aid=LhJc8aoValNlvgCzMUSiUg==&inline=1 Post-migration screenshot after: https://bugs.chromium.org/p/chromium/issues/attachment?aid=462008&signed_aid=cvtBWSuplfvc9sMKp2XvCw==&inline=1 Bug: 1105338 Change-Id: I908d11870c940f27485ac1436570659313ae794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358938Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#798906}
-
Robbie McElrath authored
This CL renames the ShouldPinControlsToContentTop field, which I landed in crrev.com/c/2284138, to OnlyExpandControlsAtPageTop. The term 'pin' had caused some confusion, as had the phrase 'content top', since that could be interpreted as either the viewport top, or the top of the page itself. I had considered OnlyExpandControlsAtTop, but 'controls at top' could be interpreted as 'top controls'. Bug: 1069498 Change-Id: Iaff131ae1379113958cdfb4803e902e08a1949ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336013 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
David Bertoni authored
The BrowserActionOpenPopupOnPopup test requires focus to run properly and was flaky when it lived in browser_tests. The test passed 3000 iterations without a flake when moved to interactive_ui_tests. Bug: 1115237 Change-Id: Ib891eaefb04f72d0ee4e5c1d5d9549fbd52b0e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350240 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798904}
-
- 17 Aug, 2020 4 commits
-
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tERUmejT2tSaTumq5zSy0ws4x3w3pAMkEcpgdkD5WTEC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202008160800_RC00.html Bug: b/161497534, b/159083441, b/162187144, b/161966844 Change-Id: Id9854948dc2f0f28eb3ae7293919c013f2bb91cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359971Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#798903}
-
Nelson Billing authored
- These special-cases were in place due to a bug in dump_syms. - The bug in dump_syms was fixed in commit https://chromium.googlesource.com/breakpad/breakpad/+/f32b83eb08e9ee158d3037b2114357187fd45a05 Change-Id: Ic39b1f8ca3cd7e513817f0ee364d72eb3e65adad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357610Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nelson Billing <nbilling@google.com> Cr-Commit-Position: refs/heads/master@{#798902}
-
Tamir Duberstein authored
Bug: 1099393 Change-Id: Id9076b0c92ac0583ffd8cb845663db3ff236c381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353294Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#798901}
-
Thomas Lukaszewicz authored
Currently MD rounded corners are using layer masking to achieve the desired clip for client views. This CL updates client views to make use of the ui:Layer SetRoundedCornerRadius() fast path that significantly improves performance vs layer masking. Bug: 822075 Change-Id: I113c6b0101145518962b22940f653fb2cc93381f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359027 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#798900}
-
