GitLab

Review URL: http://codereview.chromium.org/100109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14735 0039d316-1c4b-4281-b951-d872f2087c98

machineGetDefaultPrintSettings was returning an empty struct because no printer
is installed. Checking when its empty will allow us to know that a printer is
missing on that system. There is clearly no other way to do this, unless we do
not do all those dchecks on dpi and other struct members.BUG=6835TEST=Tested
only on windows, since linux/mac printing not even implemented. Removed all
printer drivers, opened chromium, and ran a print job, popup dialog appeared
stating no printer installed. Installed my printer drivers again, print dialog
appeared.

Patch contributed by Mohamed Mansour <m0.interactive@gmail.com>

Review: http://codereview.chromium.org/100023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14731 0039d316-1c4b-4281-b951-d872f2087c98

TEST=The new unittest passes.
BUG=10802

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14729 0039d316-1c4b-4281-b951-d872f2087c98

2. V8 debugger message handlers are temporary removed when a new debugger agent is attaching to avoid failing on compile events.
Review URL: http://codereview.chromium.org/100042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14728 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14727 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14726 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14723 0039d316-1c4b-4281-b951-d872f2087c98

throbber more responsive. The issue is that I changed the meaning of LOAD_START
from indicating that the renderer started loading to indicating when the
browser told the renderer to start loading. This means it now looks like we
started loading "about:crash" whereas before it didn't.

I think this change is reasonable and how we could about:crash in this
respect isn't important, so I just removed the failing checks.
Review URL: http://codereview.chromium.org/99118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14720 0039d316-1c4b-4281-b951-d872f2087c98

be more responsive and the loading state won't be out-of-sync with anything
else. This also removes the synchronous update to the throbber when we load a
URL because this happens before the loda actually starts, giving a flash of the
default favicon. The load start call made by RenderViewHost will cover this
case after the load actually starts.

BUG=11051
Review URL: http://codereview.chromium.org/100033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14718 0039d316-1c4b-4281-b951-d872f2087c98

Introducing a class for writing important files, preventing their corruption during writing.

Switched PrefService to use it. Other classes will be switched in future changesets.

TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences.

http://crbug.com/10618

Review URL: http://codereview.chromium.org/83001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glen
Review URL: http://codereview.chromium.org/100097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14713 0039d316-1c4b-4281-b951-d872f2087c98

HSLToSkColor premultiplies its output, should this instead live in the ImageOperations bitmap munging code?
Review URL: http://codereview.chromium.org/79082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14712 0039d316-1c4b-4281-b951-d872f2087c98

Implement tabs.createWindow extension api call. Required: (a) new RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h

BUG=11092:
R=aa,mpComplete,darin,pkasting

Review URL: http://codereview.chromium.org/79070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10529

Review URL: http://codereview.chromium.org/99113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14709 0039d316-1c4b-4281-b951-d872f2087c98

(Replace with memset)


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14708 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14707 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/93147

BUG=9401


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14705 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14703 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14702 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10446,9924

Review URL: http://codereview.chromium.org/99096


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10045

Review URL: http://codereview.chromium.org/99106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14698 0039d316-1c4b-4281-b951-d872f2087c98

Disabling the test again. This time the test doesn't fail at mulitple places. It fails at only one place. investigating...
Review URL: http://codereview.chromium.org/102003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14696 0039d316-1c4b-4281-b951-d872f2087c98

buildbots, except for the valgrind bots which use -O1.  For now,
just disable -Werror on the bots with an override.

Review URL: http://codereview.chromium.org/100087


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14695 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14694 0039d316-1c4b-4281-b951-d872f2087c98

1. the new profile dialog closes the setup.exe process as soon as the dialog is closed. The testcase used to wait for setup.exe to start/end, which would never happen. heence the test failed.
2. Closing of new profile dialog also deletes the reg keys right away. looks like there were some timing issues.Added a sleep of 400 to see if the test passes now. if it passes, then I will look into other options and remove the sleep.
-----

The standalone installer path got changed recently. modified that path also.


Review URL: http://codereview.chromium.org/100086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14693 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14690 0039d316-1c4b-4281-b951-d872f2087c98

Removes the use of Windows-specific types for accessibility roles and states in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation.
Review URL: http://codereview.chromium.org/93085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14689 0039d316-1c4b-4281-b951-d872f2087c98

First stage to make tests/others cross-platform.

BUG=None
TEST=Ran tests successfully (windows)

Review URL: http://codereview.chromium.org/63113
Patch from Mohamed Mansour <m0.interactive@gmail.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14688 0039d316-1c4b-4281-b951-d872f2087c98

When navigating from an interstitial to another page with an interstitial, we should not discard the non committed entries, as this would cause the new navigation pending entry to go away.

BUG=9791
TEST=Visit a page with an SSL error (ex: https://ebay.com). Focus the location bar and press enter (to navigate again to that page). The interstitial should be shown again and the location bar should show the URL. Also ensure that interstitial pages (SSL and safe browsing) still work as expected.
Review URL: http://codereview.chromium.org/100002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14687 0039d316-1c4b-4281-b951-d872f2087c98

it's not ready yet for mac.

TBR=evan

Review URL: http://codereview.chromium.org/100083


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11003
TEST=none

Review URL: http://codereview.chromium.org/100079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14685 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/92106


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14684 0039d316-1c4b-4281-b951-d872f2087c98

reintroduced in a later CL (probably due to SVN merge). This will
fix p13n build.


Review URL: http://codereview.chromium.org/99078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14683 0039d316-1c4b-4281-b951-d872f2087c98

* Reset HWND size when HWNDHtmlView changes size. The two should always be in sync.

* Race: We might already have frames when RenderWidget receives a new background, need to set these to transparent too.

* Race: Toolstrip background not always available by the time ExtensionToolstrip is constucted

* Make images line up correctly for toolstrip buttons.

Review URL: http://codereview.chromium.org/99042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14682 0039d316-1c4b-4281-b951-d872f2087c98

TBR=levin
BUG=10352
TEST=run_webkit_tests

Review URL: http://codereview.chromium.org/99098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14681 0039d316-1c4b-4281-b951-d872f2087c98

change re-enables the ui tests.  Since jam re-enabled some tests,
I had to #ifdef around 4 tests that are not shutting down cleanly
on linux.  It looks like we have renderers that aren't shutting
down properly (pegged at 100% cpu).

Review URL: http://codereview.chromium.org/100061


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14680 0039d316-1c4b-4281-b951-d872f2087c98

Previously, --user-data-dir called PathService::Override which called
AbsolutePath. On POSIX, this calls realpath and fails if the given
path doesn't actually exist.

We need to do this on Windows because we change the current directory
in order to load plugins (at least). However, on POSIX we shouldn't
ever change cwd.

So, on POSIX, don't try to make the user-data-dir absolute.

TEST=On POSIX, start chrome with --user-data-dir=/tmp/xyz (where xyz is a directory which doesn't exist). Once running, check that /tmp/xyz exists and contains the expected files.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14679 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/93135
Review URL: http://codereview.chromium.org/99079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10861,11011
TEST=buildbot run of layout tests
TBR=dglazkov

Review URL: http://codereview.chromium.org/99092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14677 0039d316-1c4b-4281-b951-d872f2087c98