- 07 Dec, 2017 40 commits
-
-
Yuke Liao authored
Fix a bug in the script. The script requires that the target executable specified in the commands to be relative to the root of the source, which doesn't make sense, users should be allowed to use whatever path as long as it points to the right place. Bug: Change-Id: I152797da96d02b9f211dd9e56421ff551e84597c Reviewed-on: https://chromium-review.googlesource.com/814734 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#522478}
-
Carlos IL authored
Removed separate |should_ssl_errors_be_fatal| flag from places that were still passing it, since it is no longer required as |ssl_info| now contains that information. Bug: 783262 Change-Id: I0994458c32dc2cf078108032b6d6c3f9d2c6cfc3 Reviewed-on: https://chromium-review.googlesource.com/811452Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#522477}
-
Boris Sazonov authored
This CL removes AccountManagerFacadeTest.hasAccountForName as the same method in AccountManagerFacade can be invoked from any thread. It was the last usage of org.chromium.components.signin.test.util.SimpleFuture, it is removed as well. Bug: 698258 Change-Id: I62271d79e469ae966ea500dbb058fb54baf36a54 Reviewed-on: https://chromium-review.googlesource.com/814514Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522476}
-
Johann authored
Add jianj@ and marpan@ to libvpx watchlist. Split out libaom watchlist R=tomfinegan@chromium.org Change-Id: I1acca71b8f51ab2e177e9e65a68a988c25cafe76 Reviewed-on: https://chromium-review.googlesource.com/814614 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#522475}
-
Xiaocheng Hu authored
When the DOM tree is very deep, TextDumper may run out of stack space due to the main recursion in its implementation. This patch adds a depth limit to the recursion to avoid that. Bug: 792094 Change-Id: Ica139bbf73f4129d317b7ed5d1e92c0d13566cf6 Reviewed-on: https://chromium-review.googlesource.com/812118Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#522474}
-
Pete Williamson authored
This will allow us to someday remove the finch trial. Bug: 792290 Change-Id: I22fb674f3e3a2a612eedce0ed58a61ea10a08de6 Reviewed-on: https://chromium-review.googlesource.com/810091Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#522473}
-
Mythri Alle authored
AppendExtraBrowserArgs takes only one flag at a time. Fix v8.browsing_desktop-future and v8.browsing_mobile-future to call AppendExtraBrowserArgs twice to pass two flags. Bug: Change-Id: I85bfe7b69be2164a26d77a9bc8bacb7272eff10f Reviewed-on: https://chromium-review.googlesource.com/814437Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#522472}
-
Xiaocheng Hu authored
This patch exposes NGInlineFormattingContextOf() from ng_offset_mapping.cc as a utility function, so that we can easily check if a given position is laid out as layout ng inline, and if so, which context it is in. New unit tests are added for the function. This patch is split off from crrev.com/c/803015: Compute LocalCaretRect in NG Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6ea8c8f77f7389ea7b68a58311900171883a582b Reviewed-on: https://chromium-review.googlesource.com/809767 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522471}
-
arthursonzogni authored
This CL has effect on the code only when the NetworkService or the NavigationMojoResponse features is enabled. During a navigation, after the headers are received, this CL unbinds the browser-side URLLoaderClient implementation. It passes the pair of URLLoaderPtr/URLLoaderClientRequest to the renderer. Then it binds it to the renderer-side URLLoaderClient implementation that will be used to continue the navigation (it will receive OnStartLoadingResponseBody() and OnComplete()). As a side effect, several additionnal things had to be done: 1) When the navigation is intercepted by the download manager, the same kind of thing as above must be done. Instead of the renderer, the download manager should get the URLLoaderPtr/URLLoaderClientRequest pair and continue the loading. 2) When the load is handled by the URLFileLoader, there was a deadlock, the URLLoader and the URLLoaderClient were waiting for each other to closing their datapipe endpoints. This is solved by closing the URLFileLoader's one first when it has written its last byte. 3) Same as in 2), but with the URLFileDirectoryLoader. See the others CLs in this series: [1/3] https://chromium-review.googlesource.com/c/739502 [2/3] https://chromium-review.googlesource.com/c/741237 [3/3] this CL. This is part 3 of the implementation plan. Design doc: https://goo.gl/Rrrc7n Bug: 705744 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I9df447e28afe119dc678adac943a000de6787bf4 Reviewed-on: https://chromium-review.googlesource.com/753738 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Min Qin(OOO 12/7-1/10) <qinmin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#522470}
-
Koji Ishii authored
This patch enables LayoutNGPaintFragments in virtual/layout_ng, and also merges layout_ng and layout_ng_paint. There are additional failures; some are just to be rebaselined. I will analyze and cleanup in following patches. Bug: 792329, 714962 Change-Id: Ie61d9672e3d4f44847ef8771214c16e993245943 Reviewed-on: https://chromium-review.googlesource.com/804803Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#522469}
-
Ned Nguyen authored
This suite is a bit flaky on CQ, so we are moving it to the main waterfall. The fact that this is a dbg build also give us some clue to cause of the flakes. Bug: 791800 Change-Id: I0aa36d80e1de4683a6b6765363654eb7c282b4bc Reviewed-on: https://chromium-review.googlesource.com/812166Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#522468}
-
Alexei Svitkine authored
Includes a unit test. Also fixes some lint warnings. BUG=792553 TBR=khushalsagar@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4d582129d50bc2a7403b0bc0028bbf0ff4fd6b4e Reviewed-on: https://chromium-review.googlesource.com/811627 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522467}
-
Benjamin Pastene authored
Looks like we already have the wheel: https://codesearch.chromium.org/chromium/infra/recipes-py/.vpython?rcl=0f093b369402a86363de15a3fae0c98eab4c8e00&l=5 Bug: 792130 Change-Id: I451bc2abe4d801248101536a998f77bba466e6c4 Reviewed-on: https://chromium-review.googlesource.com/812492Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#522466}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9d78afdd3d87..b5e2acc413ff $ git log 9d78afdd3..b5e2acc41 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 rmistry Skip PostUploadHooks for all auto commit bots 2017-12-07 benjaminwagner Add Nexus7 CPU jobs. 2017-12-07 benjaminwagner Move PixelXL jobs to the Pixel. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I8d1a68a816c258c3d44be00b8652f0dcfea600e4 Reviewed-on: https://chromium-review.googlesource.com/814576Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522465}
-
Abhishek Arya authored
- Use absolute path to make filters work. - Fix description to account for fact that we just want developer to add GN configuration and we build the target for them. - Fix missing target in pdfium command line. - llvm directory can be cleared when target_os change, but cr_coverage_revision stays intact. So, check for coverage tool binaries, otherwise we will crash on file not found. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: Change-Id: I0ce23c09863323af2d03561a232cb9e614493506 Reviewed-on: https://chromium-review.googlesource.com/814495 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522464}
-
Bruce Dawson authored
base_paths_win.cc needs the known folders GUIDs which are defined in KnownFolders.h. It was including shlobj.h which *usually* brings in this header file, but not always. The happy path is: shlobj.h includes shlobj_core.h which includes shlguid.h which includes KnownFolders.h However shlobj_core.h includes shlguid.h like this: #ifndef INITGUID #include <shlguid.h> #endif /* !INITGUID */ That's fine if shlguid.h is the only place that defines INITGUID, but it isn't. It doesn't even define it - it includes another file that does. That's terrible. So, if you include shlobj.h you may or may not get KnownFolders.h. This is sloppy on our part, and on Microsoft's. This was found while experimenting with different jumbo-build settings - FOLDERID_ApplicationShortcuts would not be defined if the wrong .cc files were included first. The investigation was done by compiling with /showIncludes to find out why KnownFolders.h was sometimes included, and then find out why it wasn't always. The bug in shlobj_core.h was reported here: https://developercommunity.visualstudio.com/content/problem/162527/shlguidh-is-incorrectly-included-by-shlobj-coreh.html Change-Id: I57f7894a7016704d15d5b02bbcf518b318263db2 Reviewed-on: https://chromium-review.googlesource.com/813017 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#522463}
-
Koji Ishii authored
This patch supports the CSS 'visibility' property in NGTextFragmentPainter, in the same manner as InlineTextBoxPainter. The logic for line break painting is copied, but to be verified when selection is supported in LayoutNGPaintFragments. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2334fa2af6588257c77cdc26b0f58daf39d48b63 Reviewed-on: https://chromium-review.googlesource.com/810305Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522462}
-
sczs authored
-Fades in the Contract ToolbarButton after the locationBarContainer has expanded. -Fades in the Toolbar Buttons (Back,Fwd,ToolsMenu,etc.) after the locationBarContainer has contracted. -Theres a delay to fade in the buttonsafter contraction/expansion, just like in the Old Animation. -Fades out the Toolbar Buttons (Back,Fwd,ToolsMenu,etc.) when the locationBarContainer expansion starts. Video: https://drive.google.com/open?id=1Re0-jdXUH11v-KccgKs2dEYX_fJ29Uud Bug: 784592 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I473daf54dffb14a4da24ed58983ef7ab8b4981aa Reviewed-on: https://chromium-review.googlesource.com/809706Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#522461}
-
Danyao Wang authored
This is step 3 to removing _lastRegisteredRequestURL from CRWWebController. This CL has no functional change. Bug: 789993,792515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia415197025b4b3461fc807602e17063a753c39c1 Reviewed-on: https://chromium-review.googlesource.com/812446 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#522460}
-
Tao Bai authored
Reproduced the crash locally, but it needs a little bit more work to write a test, this patch has fix only, following up patch will add test. Bug: 792327 Change-Id: I76d8dbc51b84b0aca87f09e162fc97d870881ca9 Reviewed-on: https://chromium-review.googlesource.com/813195Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#522459}
-
Louis Romero authored
Bug: 776593 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I41d610437bbc4dda655b988d95c0491ea930871d Reviewed-on: https://chromium-review.googlesource.com/809707 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#522458}
-
Ross McIlroy authored
BUG=chromium:782089 Change-Id: Ib2062b2aca231aca5d84dc169821b10bf1a24bcb Reviewed-on: https://chromium-review.googlesource.com/803338Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522457}
-
Alex Vallée authored
Change-Id: If511b749a2231c6e3c5f500ed574f2229d02e389 Reviewed-on: https://chromium-review.googlesource.com/812325Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Vallee <avallee@chromium.org> Cr-Commit-Position: refs/heads/master@{#522456}
-
Amirhossein Simjour authored
Vertical touch distance required to start scrolling is increased from 0.165 to 0.185, and horizontal distance is increased from 0.15 to 0.17. BUG=740001 Change-Id: I9ea9c16052e0ea490de7ecf92f164701554475a3 Reviewed-on: https://chromium-review.googlesource.com/811665Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#522455}
-
Hans Wennborg authored
Recent Clang versions started taking into account that enums are signed on Windows when emitting these warnings. NOTRY=true Bug: 792519 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0fe2646985282b759e3e261a09fa0f1380c98e61 Reviewed-on: https://chromium-review.googlesource.com/813182 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522454}
-
Michael Spang authored
../../chromecast/tracing/tracing_service_main.cc:96:28: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TraceCopyTask() {} ^ override ../../chromecast/tracing/tracing_service_main.cc:96:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~TraceCopyTask() {} ^~~~~~~~ ../../chromecast/tracing/tracing_service_main.cc:181:30: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TraceConnection() {} ^ override ../../chromecast/tracing/tracing_service_main.cc:181:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~TraceConnection() {} ^~~~~~~~ ../../chromecast/tracing/tracing_service_main.cc:339:29: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TracingService() {} ^ override ../../chromecast/tracing/tracing_service_main.cc:339:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~TracingService() {} ^~~~~~~~ 6 errors generated. BUG=b/31079742 Change-Id: I8cc22c845599662e9a6088328933e67cd4ebf490 Reviewed-on: https://chromium-review.googlesource.com/814218 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#522453}
-
Gauthier Ambard authored
The toolbar needs to update its UI when a snapshot for the side swipe is taken. Bug: 785756 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If1735fe80b575608ed625dda3525a51b1689ee49 Reviewed-on: https://chromium-review.googlesource.com/809155Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#522452}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/5dcbbfd1533b..d73ba12a934e $ git log 5dcbbfd15..d73ba12a9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ff0401422873a8d550c97bac0a3ce8c37ff7d06 Reviewed-on: https://chromium-review.googlesource.com/814274Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522451}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79bacdd9..744d799d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie4f0d628152e699829771955710ac682c15e9ed9 Reviewed-on: https://chromium-review.googlesource.com/814136Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522450}
-
Aaron Leventhal authored
When a suggested search match in the omnibox popup has an immediate answer, add this to the friendly accessible screen reader label. For example, typing "weath" will produce something like: "Weather Answer 42 degrees" rather than just "Weather". Bug: 787858 Change-Id: I1a8db6d4c0a77c8f769138325c806cc2959df513 Reviewed-on: https://chromium-review.googlesource.com/809784Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#522449}
-
Yeol authored
TouchPoint radius of the ellipse should exactly equal to half the corresponding extent of the rectangle. assuming non-rotated touch geometry. Bug: 731725 Change-Id: Ibf19c867549f13676afbc6cd0d504850fb415159 Reviewed-on: https://chromium-review.googlesource.com/762827Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#522448}
-
Theresa Wellington authored
Show the Google G when the bottom sheet is opened and the url is cleared. This is hidden behind a flag. BUG=792244 Change-Id: I2768dc0aefce94890260e061baae6930d413415b Reviewed-on: https://chromium-review.googlesource.com/811688Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#522447}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4f5e1d4ff3fa..9d78afdd3d87 $ git log 4f5e1d4ff..9d78afdd3 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 borenet Revert "[infra] Move commands from isolates to gen_tasks.go" 2017-12-06 herb Fix buffer off-by-one error. 2017-12-07 borenet [infra] Move commands from isolates to gen_tasks.go 2017-12-07 rmistry Do not skip trybots for uploads by update-docs 2017-12-06 benjaminwagner Specify long build ID in Android dimensions. 2017-12-07 bsalomon Revert "Add define to use customize vulkan header." 2017-12-06 scroggo Update to the latest version of libjpeg-turbo Created with: roll-dep src/third_party/skia BUG=792316 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I6b3738c95a764c9efbaefee9a7895cd739a65211 Reviewed-on: https://chromium-review.googlesource.com/814276Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522446}
-
Henrik Grunell authored
An attempt to reduce flakiness, based on that the AEC dump requires longer time before being closed than the input and output recordings due to IPC and more thread jumps. See also the added comment in the file for more info. Bug: 783790 Change-Id: I1f2cd838a749eb1ec76e6e32e283b26e89ff293e Reviewed-on: https://chromium-review.googlesource.com/813715 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#522445}
-
Mohamed Heikal authored
Calling Tab.loadUrl if mNativeTabAndroid is 0 would crash chrome. There has been a few crashes of the sort. This change would make chrome crash on the Java side rather than the native side so that the java stacktrace is visible in the crash. This is a temporary change and will be removed once we have more information or the bug is closed as WontFix. Bug: 662877 Change-Id: I0ad62c757d57c11bc405f6b22fad59f047aad527 Reviewed-on: https://chromium-review.googlesource.com/811987Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#522444}
-
Danyao Wang authored
This is step 3 to removing _lastRegisteredRequestURL from CRWWebController. Bug: 789993,792515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib3ea5bb686a91e0d28cbb8ec7c1c860518c85090 Reviewed-on: https://chromium-review.googlesource.com/812407 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#522443}
-
Pete Williamson authored
Bug: 792290 Change-Id: I2321ae02cd36e54f372e22edd74db2253dbc6e9a Svelte is a term we use for android devices with <= 512MB memory. We used the OfflinePagesSvelte experiment originally to check if we should do background offlining on Svelte devices at all. We determined that we should, and eventually removed the flag in most places (but not here). This change removes the flag in the final place. There is a similarly named experimental flag for doing 'foreground' offlining on svelte devices - "OfflinePagesSvelteConcurrentLoading". We plan to enable it someday, but first we need to fix chromium so that we don't start an additional process. Chromium promises not to start more than two processes on android svelte devices. Change-Id: I2321ae02cd36e54f372e22edd74db2253dbc6e9a Reviewed-on: https://chromium-review.googlesource.com/813014Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522442}
-
tzik authored
The DCHECK in WebTaskRunner::PostTask used to ensure that a same thread WTF::Function is posted to the original thread. However, after it is merged to base::OnceCallback, it wrongly rejects base::OnceCallback which may be passed through base::SingleThreadTaskRunner::PostTask. This CL removes the DCHECK to prevent the potential failure. The restriction itself is still checked by a callback wrapper made by WTF::Bind. Change-Id: I5b0cf0a6beb3b88a66a1ce89a8df466379cb9c74 Reviewed-on: https://chromium-review.googlesource.com/813574 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522441}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/7b0be4ced5f3..bb6ecbad918e $ git log 7b0be4ced..bb6ecbad9 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 dsinclair Fix nits from previous CL. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If3c609caec836e5571d6b04f5aa14ad2992ee488 Reviewed-on: https://chromium-review.googlesource.com/814275 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522440}
-
Peter Beverloo authored
Bug: 711529 Change-Id: Id64a48214d682f5feba6f6a5f301b394e4a6ce42 Reviewed-on: https://chromium-review.googlesource.com/806274Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#522439}
-