GitLab

TBR=govind@chromium.org

Change-Id: Ib08e9e9d53de98bf9ed11a048cd8a853294b1f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096779Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748721}

This target depends on the DevTools `all_devtools_files` target. We are
in the progress of marking that target as testonly.

`blink_devtools_frontend_resources_files` can be testonly itself, as
`blink_web_tests` (which is the only target that depends on it) is
marked as testonly itself.

Bug: 1011811
Change-Id: Ic128457f5dba06992401e6c6d43550df1fa8c12a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095063
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748720}

https://webrtc.googlesource.com/src.git/+log/c782263e5f19..b2678cfefedd

git log c782263e5f19..b2678cfefedd --date=short --first-parent --format='%ad %ae %s'
2020-03-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5a78076c..29afd4ae (748288:748637)
2020-03-10 srte@webrtc.org Cleanup: Removes unused AimdRateControl field trials.
2020-03-10 ilnik@webrtc.org Reland "Wire up internal libvpx VP9 scaler to statistics proxy"
2020-03-10 phoglund@webrtc.org Hand protos directly to histograms and fix summary.

Created with:
  gclient setdep -r src/third_party/webrtc@b2678cfefedd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I611e65e64cfce1d9db1be6d96fce09e86c0dbe06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096090Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748719}

This adds a new interaction to the framework, which shows a calendar
popup and lets the user set or clear a date from the specified range.

Bug: b/145043394
Change-Id: I739e6b5ccb5821352b1ce63e63d8573bdde74f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093224
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#748718}

This change extends expiry for a number of histograms emitted from
the Cookie and Reporting/NEL databases in //net/extras/sqlite,
and also removes a couple of them.

They are useful as a debugging aid for users reporting problems
loading/saving cookies.

The one that is removed is {Cookie,ReportingAndNEL}.DBSizeInKB.

Fixed: 1053115, 1052954, 1037004
Change-Id: I6eb0229758d7791e97dbff1e9b69195e14e760dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095438Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748717}

This cuts out one of the middle steps as well as the additional clip to
|bounds|. We will be clipping the results of the filter anyway, so
hopefully this extra clip step doesn't matter too much. When the full
'filter' syntax is supported on SVG content we won't be able to use the
filter region clip in this way anyway.

Bug: 109224

Change-Id: I8cf8799c8c0992b763291f57759ad7d83f98d258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096448Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#748716}

browser_policy_connector_ must outlive local_state_ in early shutdown
cases where ownership isn't transferred away to the BrowserProcess.

BUG=948265
R=rkaplow@chromium.org

Change-Id: I1b79131b0668352743e8a4620910dbed3fbdc96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096577
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748715}

Bug: 1056621
Change-Id: I5bf7da8366018d9cff7c581d78ac1e2c8f8e962b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078411Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748714}

Safety check: renamed displayedString to displayString for consistency with the rest of the codebase

Bug: 1015841
Change-Id: I65edf49f7224ab118ba164f9039fa1c717e578b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096696Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#748713}

iOS flag owners were asked to claim ownership and state an expiry in
this announcement email:
https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ

This is one of several CLs that adds iOS flag ownership information into
flag-metadata.json.

The owner of these flags was identified via git blame. A placeholder
expiry milestone of M86 was added. Please either LGTM, or suggest a new
owner and/or expiry.

Bug: 1058614
Change-Id: I87a7166d964b3229661b125e71288e9bf0eec6f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095397Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748712}

When building the 'chrome' target Mojo generates about 680 .cc files
that contain no actual code. Due to the includes that are stamped out
these files collectively take a non-trivial amount of time to compile.
Detecting these files and deleting the #includes saves about ~1,200
to ~2,100 CPU seconds.

The no-code detection doesn't work generically, but it handles the
code which mojo generates.

Bug: 1054626
Change-Id: Icb2feaa0021332e0a6d4c9e5cac314824578cd87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093881Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748711}

Bug:949839

Change-Id: Id84825c9b13a800c80a22ed3bf42b4056bc16343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084718
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748710}

iOS flag owners were asked to claim ownership and state an expiry in
this announcement email:
https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ

This is one of several CLs that adds iOS flag ownership information into
flag-metadata.json.

The owner of these flags was identified via git blame. A placeholder
expiry milestone of M86 was added. Please either LGTM, or suggest a new
owner and/or expiry.

Bug: 1058614
Change-Id: I426f0455d698715bfdc9b256f3de6cb5492f640e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095198Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748709}

Follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/1960465

With change above and with virtual context enabled, it is fairly likely
that when a context is lost, the new context is created before the old
context is destroyed. Since GpuChannelManager keeps using the same
GLShareGroup, the new context will end up in the same share group as the
old context.

Avoid this by creating a new GLShareGroup in LoseAllContexts.

Bug: 1059286,1052485
Change-Id: I1d60578fa6359329406d634fe04c7f242314839a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090137
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748708}

iOS flag owners were asked to claim ownership and state an expiry in
this announcement email:
https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ

For these flags, ownership was claimed, but no expiration milestone was
given.

This CL attempts to act as a forcing function for owners to choose
an expiration milestone. This CL sets M85 as the default expiry milestone
for every flag in this CL. All owners have been responded with an LGTM
or with a comment to change the expiry.

Bug: 1058614
Change-Id: I40b40103f6a74aab185e8c7cebeceeb183476bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094238Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748707}

TBR=olka@chromium.org

Bug: 1060165
Change-Id: I0f96c85b400ea05dd0bfbd9852d99b029cfdec02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096758Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748706}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/391bb28f91a4..e1f6408da19a


Created with:
  gclient setdep -r src-internal@e1f6408da19a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I28d0b7b85a80967148d6411b0a943edd083192b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096086Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748705}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I87da77e5966845dcf4c8e44c6fd54aac6c0f77d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748704}

DownloadManagerCoordinatorTest.CloseInProgressDownload test fails,
because dispatchInstallationNotifierBlock schedules a delayed block
execution and that block expect proper setup of WebThread. The
expectation flakily fails if tests tear down WebThread environment.

The expectation to have WebThread set up is incorrect for delayed block
of code in tests and production, because WebThread can be legitimately
torn down.

This CL removes that DCHECK, but keeps all other DCHECKs that are still
active as long as InstallationNotifier object is alive.

Bug: 1059885
Change-Id: I9b4b257a5b654923d52840bb314d36ff243269e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095349
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748703}

TBR: ssid@chromium.org
Change-Id: I4bc532216b495b9975aded3e3ccf62d71596ff6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096735
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748702}

The SeekBar and RemaininTime need to be marked as clickable for
TalkBack to recognize them properly.

Setting the ImportantForAccessibility flag is not enough.

Bug: 895776, 656015
Change-Id: Ifa923c460c16a88ce1bb2a479c5c623604bb55ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095592
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748701}

Media feeds are announced to the browser
by adding a <link> element in the <head>
of the document. This adds a method to
fetch them from the renderer and store
them in the database.

BUG=1058142

Change-Id: I5efa854e72c8dc9d977efe0245f070b9334758a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085734Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748700}

https://android.googlesource.com/platform/external/perfetto.git/+log/2663ead23f9a..3ddc82494f77

git log 2663ead23f9a..3ddc82494f77 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 treehugger-gerrit@google.com Merge changes I34fe91e2,Ia93e6d60
2020-03-10 treehugger-gerrit@google.com Merge "processor: TrackEvent: Don't log success statuses as errors :)"

Created with:
  gclient setdep -r src/third_party/perfetto@3ddc82494f77

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Iecc4a1d1922ef11e2d4b38fb7bcdd49b62d4f957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096085Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748699}

The length attribute was defined as a long instead of unsigned long.
We also note that channelIndex for getChannelData(),
copyFromChannel(), and copyToChannel() was declared to be a long
instead of unsigned long.  Fix those too.

Bug: 1059305
Change-Id: Ia57fc606e8943de56bb2943b00e19b8beaeb9642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095212Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748698}

Bug: 1059157
Change-Id: Ic6d20bad1f0827e3e3e715a6309ab2932307a7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090981Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748697}

Spec: the sixth item of
https://mikewest.github.io/corpp/#integration-html

Fix stale implementation, and add reporting.

 - Run CORP on redirects.
 - Use the parent COEP instead of the response COEP value.
 - Add reporting plumbing.

Bug: 887967, 1052764
Change-Id: I3723e671fb7d571dcce741f859d8d831ae7c584e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089183
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748696}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aafa9b5c733c..bf9df5292254

git log aafa9b5c733c..bf9df5292254 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 jacktfranklin@chromium.org Move utilities test to being built with Ninja
2020-03-10 jacktfranklin@chromium.org Move StringUtilities test into Ninja/TS land.
2020-03-10 szuend@chromium.org [utilities] Remove Array#remove 🎉
2020-03-10 szuend@chromium.org [cleanup] Use Map + Set instead of Object + Array in CSSModel
2020-03-10 szuend@chromium.org [utilities] Remove Map#remove

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@bf9df5292254

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I22cf8ef2cd65c0059fe1a77eea8c97ee9f199e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748695}

Bug: none
Change-Id: I9691adc8e1a1e652e3f5c9b54746bd358b91ad5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096105
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748694}

This file is not used anymore after migrating its content into
paltform_keys_service.h.

Bug: 1045895
Change-Id: I6e2918f9ccc7a8383651eee82b44b514270cb402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096638Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Michael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/master@{#748693}

|ProfileKey#getLastUsedProfileKey| always returns regular profile key.
Hence, to reduce misconceptions when profiles are used in incognito
sessions, |ProfileKey#getLastUsedProfileKey| function is renamed to
|ProfileKey#getLastUsedRegularProfileKey|.

Bug: 1041781
Change-Id: If945d58c8d8251e965c5c9d5eac7fb2d4744a47e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083486Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748692}

Bug: 1019787
Change-Id: I39ee5bf184349d5511095e1064fe99b38c3136d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095204
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748691}

Change-Id: Iaa8b1a6b66ab3d1d10c8c5544a0df1083a959281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092126
Auto-Submit: Jonathan Freed <freedjm@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748690}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I4df814181ef866f68a2242e3e375ace7a6c4d818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096087Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748689}

This function was just a straight wrapper around the
SigninErrorControllerFactory but is not defined on ChromeOS. This does
not seem very valuable.

Moreover, it was only used from AvatarButtonErrorController.
And since AvatarButtonErrorController will be needed on ChromeOS, there is
no point in keeping this wrapper.

Bug: 1041472
Change-Id: If6f7e84dc9250e3d542206022a20620235eb885a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093597Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748688}

This adds an OWNERS file to this recently-added directory.

Change-Id: I3ffd7971c195b73a713b518aec4756f6c6d9778a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096776Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748687}

This is one of those "we're only in it for the ComputedStyle (and
notifications)" LayoutObject, so inheriting via LayoutSVGHiddenContainer
only adds overhead. Inherit directly from LayoutObject instead. While
doing this also rename to LayoutSVGFilterPrimitive to avoid any
confusion with LayoutObjects for actual resources.

Change-Id: Icfc293d3ece94d56cc2136975f49bd21e7e8d32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094304
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748686}

Fix an issue where TabService attempted to proceed to write the proto
even if there was an error.

Change-Id: I5734921cd77baa026cc47e47d2656b87f672aa94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095012Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748685}

SkTraceMemoryDump provides Skia a way to produce Chrome memory dumps.
The dumpStringValue() function had an empty implementation however.

Bug: 1043676
Change-Id: I915ccbcb21ba4462bbb6ade1e66f64df322427ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064820Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748684}

Refactors the AppUrlLoadingService to get a Browser from its delegate
and not care about TabModel. There should be no functional changes.

Also :
 - Updates TestAppUrlLoadingService to use correct variable naming.

Bug: 1046373
Change-Id: I1da8a1033b0bf26972f07908bbe815c6b9d8f4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094308
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748683}

This change adds a preference to remember the last time a Bulk Check
ran to completion and sets the elapsed_time_since_last_check field
on CompromisedCredentialsInfo appropriately.

Bug: 1047726
Change-Id: I2115cb582c3edbedd3b1d82df8db362353a286d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095100Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748682}