- 22 Jan, 2021 40 commits
-
-
Christoph Schwering authored
This CL registers a TranslationDriver::LanguageDetectionObserver and re-runs Autofill's heuristics when the language has been detected. Forms are extracted from the DOM and sent to Autofill before the page language has been determined. Therefore, without the listener, Autofill will be informed about the page language only after the renderer proactively sends updated forms to the browser, which happens upon certain user actions and certain dynamic changes of the DOM (e.g., when the user focuses a field). By then, it may very well be too late to re-run Autofill's heuristics. This CL fixes this issue: Autofill is now notified about the page language once it is determined by Translate. Autofill then re-runs the heuristics for the specific language. Note that this is about language determination, not about actual translation. Autofill does not need notifications about translations. Once the site is translated and a re-parse happens, Autofill will use the translated language to run the heuristics, but this behaviour is not affected by this CL. This CL has a side-effect on repeated-field type rationalization, which previously was only run when server predictions were received. This appears to have been a bug in one way or another; it will be addressed later. For now, this CL adjusts the test expectations (*.out files) to take into account repeated-field type rationalization. This CL builds on crrev.com/c/2575080. Bug: 1150895, 1168239 Change-Id: Ie018b9281305895f74541245076c0958828e3de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561838 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#845908}
-
Yue Zhang authored
Bug: 1157892 Change-Id: Ibae1711b252cf824ee5da91b7f39ecb12df03002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634132 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845907}
-
Ian Kilpatrick authored
Previously we had two separate issues. 1) We were using border/padding to determine the %-block-size rather than border/scrollbar/padding. 2) For OOF nodes, we weren't subtracting the border/scrollbar/padding at all. This patch fixes both these issues. Bug: 1060904, 1158406 Change-Id: I266d69725c6cecdb0888e29489e46f1a82ffccc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641294 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#845906}
-
Lukasz Anforowicz authored
Bug: 1164416 Change-Id: I3834ffb77ff1ef23f39c8886049b563753ab6cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630625 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#845905}
-
Vladimir Levin authored
This patch ensures that we reset some state that we accumulate and only reset if we actually report a layout shift. The problem is that the accumulated values can later cause us _not_ to early out from ObjectShifted and report a layout shift where we should not have reported one. By resetting the state after every prepaint, we ensure that we reset the accumulated state. R=skobes@chromium.org Change-Id: I2e764d3d847669cbdf06219da183cda02df57684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639862 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#845904}
-
Moe Ahmadi authored
This is the final step to transfer ownership of realbox to omnibox team. Bug: 1159934 Change-Id: I15814c0ffd32e3c5a2a6e3349bf612406071ed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641808 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845903}
-
Eugene But authored
Workaround for null context was necessary on iOS 12 as confirmed by Navigation.IOSNullContextInDidFailProvisionalNavigation histogram. Also stop recording Navigation.IOSNullContextInDidFailProvisionalNavigation as this histogram has expired and served its purpose. Bug: None Change-Id: Id2df18c8e92c134049a820b6a38af403c38bac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638447 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845902}
-
Yaron Friedman authored
From flaky portal these are among top 15 flakiest: org.chromium.chrome.browser.bookmarks.BookmarkTest#testReadingListEmptyView org.chromium.chrome.browser.bookmarks.BookmarkTest#testReadingListFolderShown Sample failure looks to be because bookmarkmodel isn't loaded: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8857470340605361056/+/steps/chrome_public_test_apk_on_Android_device_Pixel_2__with_patch_/0/logs/Flaky_failure:_org.chromium.chrome.browser.bookmarks.BookmarkTest_testReadingListEmptyView__status_FAILURE_SUCCESS_/0 Change-Id: Ie7c050345d31fd03f3bdb4eb41b1f2253c135bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643487Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845901}
-
Xiaocheng Hu authored
This patch introduces a dirty bit to CounterStyle to indicate whether the information is stale. In general, a CounterStyle is dirtied if its underlying @counter-style rule has changed, or if any other @counter-style rule that it can reach via the 'extends' and 'fallback' references have changed. A dirtied CounterStyle will be removed or replaced in the corresponding CounterStyleMap. The overall process is very similar to how FontFallbackList is dirtied when @font-face rules or loading status are changed. This dirty bit allows partial invalidation of style and layout after @counter-style rule changes. A follow-up patch will implement such partial invalidation. Bug: 687225 Change-Id: I950af0b76381bfdb88adcb5a4ce38ca990e6b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641157Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#845900}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611251835-492ad3518ecdcc200059acbff6fa6ac0a2007e2f.profdata to chrome-linux-master-1611272973-8e4032da22e18455d35fc6237c90007c71899d37.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie38c5f91ed587143802917d1f2934000df0abd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845899}
-
Ben Joyce authored
Bug: 1169407 Change-Id: I66080a99bfcd36ce17fce4e5d5bfc8ed09de7e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644062Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Auto-Submit: benjamin joyce <bjoyce@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#845898}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611251835-293c4fab8514e5eb6bd360b905bded2a6927bf71.profdata to chrome-mac-master-1611272973-25501ceb667d7bff805b8f0169ae53268fd6f0a5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie12a54d6e66fc7b846535cd18dc0018cc4aaa08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644282Reviewed-by:
-
Tibor Goldschwendt authored
Makes the logo Finch-configurable. Flag is enabled by default. This is a reland of 660b7591 with a fix for the msan builder. See crbug/1169070 for more details. Original change's info: > Bug: 1168361 > Change-Id: Ie9fbeebb5f88fcf6ca2d6a418759f65e61d3231e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639153 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845490} Bug: 1168361 Fixed: 1169070 Change-Id: I9f038b06cfd7551bf0acb94a7ac08cb8d49d7095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643179 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845896}
-
Mason Freed authored
This code was added in [1] to work around a bug [2] in the layout test system that doesn't seem to still reproduce. The "open" attribute is not a presentation attribute, so it shouldn't be marked as one. This should not change any behavior. [1] https://source.chromium.org/chromium/chromium/src/+/f56b6ef2b68e305e106e0310fd884c620861fb8b [2] https://bugs.webkit.org/show_bug.cgi?id=91058 Change-Id: If03bf98075db8b94e56f27370199a36e508106b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640923 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845895}
-
Andrew Grieve authored
Makes the arg take effect more universally by having it be a flag on proguard.py rather than work by having targets add the correct proguard configs. Also enabled -repackageclasses '' for L8, which means it should produce a smaller .dex file. Bug: 1168672 Change-Id: I9c07d337755efedbdf1fabbe8822a9fdfba49fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641306 Commit-Queue: David Trainor <dtrainor@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#845894}
-
Pete Williamson authored
This histogram is reaching its expiration date, and we realized that we will need it as long as we have a feed. After a quick discussion with the team, we decided to change it to never expire. Bug: 1167830 Change-Id: I4740a4f76c6ebc285792d803af66a4aac7dd68c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643361Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#845893}
-
David Tseng authored
AX-Relnotes: n/a Bug: none R=katie@chromium.org Change-Id: Id29f9a97d0342e8333f8bebff9781460fb05fa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643758Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845892}
-
Takumi Fujimoto authored
UpdateAndMaybeSwitch() is hit even when not mirroring, so we should record the remoting compatibility only when mirroring. Bug: 1163944 Change-Id: I05415bc9b15115526f66cdb6006cb9e946a0d379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638494 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#845891}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..302f83f07614 2021-01-21 fmayer@google.com Merge "style: Remove unnecessary cast." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6445b471adad871a9637d5cefe4e73266bdc5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642832Reviewed-by:
-
Michael Thiessen authored
See bug for context. FLAG_IMMUTABLE should be used as the default for PendingIntents when mutability is not required as it is more secure. A mutability flag should be explicitly set for all PendingIntents as when unspecified Android makes PendingIntents mutable. Bug: 1163529 Change-Id: I28bf2d277c72edaf03a7133a0302326ad2357f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643099Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845889}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I1a35b8c3c33d9744bd6e3ba25b653f4d1ce7c0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642763Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#845888}
-
Stephen Chenney authored
A previous change, https://crrev.com/54668d23a68b82a35be7359cce9e4569e178cf6f, removed rounding of the scale factor for GTK platforms. This resulting in blurry content for some users with desktop environments that give deviceScaleFactors of 1.002 and similar. To address the problem, round the scale to 2 decimal places. Fixed: 1087109 Change-Id: I17364d69facc3745528a8971bb2616ff76eb9b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639816Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#845887}
-
manukh authored
This param determines whether e.g. input 'abc' will autocomplete 'abc[ title] (url.com/abc)' or '[url.com/]abc'. Rich autocompletion prefers autocompleting URLs to titles, and prefixes to non-prefixes. By default, prefix/non-prefix has precedence to URL/title; i.e. when the input matches both the URL non-prefix and the title prefix, the title prefix is autocompleted. With this param enabled, URL/title will have precedence and the non-prefix URL will be autocompleted. Bug: 1062446, 1163356 Change-Id: I96763f2f4c19567ee69d7b39493cefbd6c1d5496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618477 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#845886}
-
Manas Verma authored
This CL introduces a flag for showing an Offer Notification Bubble on Desktop. Bug: 1093057 Change-Id: I9262745a3071dc791624433fa1fa283bdb79cb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641990Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#845885}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 6de4865545da73687dd6d28d153cd345ed5e7918`. Bug: 1169333 Change-Id: Ib5a4366ae57caf5ae89856948d4064f60ece8142 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641005 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#845884}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03fc9a3eb3f8..361ccce1243f 2021-01-22 sokcevic@google.com Revert "Support main branch in bot_update" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iadcd51dd0ce1b83ab9b826cc24c37c867c19d7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644078Reviewed-by:
-
Evan Stade authored
Bug: 1147268 Change-Id: I27126916d8f4f46ee7f4e63b1318e79e1681d8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643516Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845882}
-
Jinsuk Kim authored
Fakebox on Tablet doesn't run animation upon click. This CL re-enables the test and makes the test skip the checks against animation effect. Bug: 1145195 Change-Id: I90687f7ccd56621e2cc3de22cf9499ee332ccd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639350Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845881}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611241154-e1663486a23de2e3bc4e3496ca3a854ed6ee6faf.profdata to chrome-win32-master-1611262248-acebbca4ed738fd78c31627253df071e74108512.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ica68d514e1c9abe27cf998c74519ef65de25f803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643997Reviewed-by:
-
Sushanth Rajasankar authored
This change adds support for an experimental CanvasFormattedText API. This API aims to make it easy for web developers to get correct and fast multiline formatted text rendering functionality in Canvas, while preserving the low-level flexibility for positioning text that is already present in the existing Canvas API More details and use cases for the API can be found here https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Canvas/FormattedText.md With this change an initial subset of the proposal is implemented. fillFormattedText is introduced on the canvas rendering context that allows for rendering multiline text in canvas. Not yet implemented: -The font and color attributes on the canvas text. -Support for writing modes & text direction. -Support for the advanced Advanced usage in the explainer. -StrokeText -Ability to mutate runs once they are appended to CanvasFormattedText. -Tests will be in a follow up change. Perf Characteristics: Comparing with hypothetical javascript multiline implementation, that is a call to measureText + fillText to draw a line. CanvasFormattedText is faster to re-render the same text on both a laptop / desktop class hardware. When it comes to first render, depending on the number of lines the text breaks into performance varies. On the hardware tested it is 10% (laptop i7-7660U) and 16% (desktop i9-9940X) faster when there are 3 lines. When there is just a single line and no line breaking involved CanvasFormatted text is 70% to 50% slower than a call to measuretext + filltext. Sample Code: <SCRIPT> function DrawMultiline() { var context = document.getElementById("target") .getContext("2d"); context.font = "30px Arial"; var text = new CanvasFormattedText(); text.appendRun({ text: " Lorem Ipsum " }); text.appendRun({ text: " is sample text" }); context.fillFormattedText(text, 100, 0, 300); } </SCRIPT> <BODY> <canvas width=500 height=300 id="target"></canvas> <button onclick="DrawMultiline()">Draw</button> </BODY> Change-Id: I31df1a8c538dc799ec1a328e4952d01e78bbc344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570327 Commit-Queue: Sushanth Rajasankar <Sushraja@microsoft.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#845879}
-
Chris Lu authored
This URL will be used to test Discover Feed server changes on a client. Bug: 1169382 Change-Id: I3fa1d7ccdb380ecfd295985d771bc9a44acf793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643094 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#845878}
-
Dale Curtis authored
MimeUtil::IsSupportedImageMimeType() always lowers case before testing for support, however ImageDecoder::CreateByMimeType() leaves the case untouched. This change forces lower case in WebCodecs ImageDecoder and ImageDecoder::CreateByMimeType to ensure consistency. R=pkasting Fixed: 1168980 Change-Id: Ibe4202fb56f7b1a0731553662607c76e207467cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643270 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845877}
-
Ken Rockot authored
These tests use Mojo JS bindings which are universally being migrated to JS modules. In order to load JS moudles, they need to become HTTP tests. Since there are already a bunch of manual webshare tests in external/wpt/web-share, and WPT is the direction things are moving, this moves the tests into wpt_internal/ (instead of, say, http/tests/). No functional changes, just path and filename updates so that they run on HTTPS too. Bug: 1004256 Change-Id: Ice6eadf740f2e01a6dd1253a988225e832ff1ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641315Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#845876}
-
Scott Violet authored
isServedFromBackForwardCache was added in 89. BUG=none TEST=test only change Change-Id: I0a3612fb7086977e2cb2c88e6428255f72f1875c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643937 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#845875}
-
chinsenj authored
Currently, the Move to Desks menu shows in browser and PWA context menus regardless of the number of current desks. This CL makes it so this menu only displays if there is more than one desk. Test: manual Bug: 1166001 Change-Id: I9d3781b74b22a3db734c1622c8ae9f4b1621bf68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637777Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jeremy Chinsen <chinsenj@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#845874}
-
Chris Harrelson authored
Fixed: 1165026 Change-Id: I12b50d9a37411136d380b48d57fe33dce158caeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639872Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#845873}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/203154b52a46..70f493d6e6ab 2021-01-21 cnorthrop@google.com Tests: Add Subway Surfers trace 2021-01-21 timvp@google.com Vulkan: Flush if sync object is pending during SyncVk::getStatus() 2021-01-21 timvp@google.com Capture/Replay: Erase texture from mCachedTextureLevelData 2021-01-21 penghuang@chromium.org Do not make context current during context deletion. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: FenceSyncTest.BasicOperationsTest: Test: angle_perftests --gtest_filter="*subway_surfers*" Change-Id: Ib282601846dd50672cc2723b05b905480b850bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643118Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iab3fc833e24cd9b5901f59e3be5f006b6b319221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640934Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845871}
-
Etienne Bergeron authored
We observed jank related to SiteEngagementService functions. This CL is adding the appropriate trace events to track the slow cases with slow-reports. Bug crbug/1135279 was fixed and reduced the conflicts with the main thread but we still observed some slow cases. R=etiennep@chromium.org Bug: 1135279 Change-Id: I2d3e8b1231f344a6d307d15aa39204455257d92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643436Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#845870}
-
Andrey Kosyakov authored
Disable default HUD for windows hosting DevTools front-end -- a common use case is to tweak a page using DevTools while observing the HUD, so having a HUD from DevTools window is fairly inconvenient. Bug: 1152089 Change-Id: I2e9216a30b977a4482e241e166b9168ada9c3319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633529Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
