GitLab

BUG=646631

Review-Url: https://codereview.chromium.org/2338063004
Cr-Commit-Position: refs/heads/master@{#418961}

It is both clearer this way, and it avoids shadowing by the identically-named
m_frame in FrameView.

TBR=drott

Review-Url: https://codereview.chromium.org/2343553002
Cr-Commit-Position: refs/heads/master@{#418960}

The call sites where the time is used to compute time deltas within the
lifetime of the Chrome browser process are affected.

BUG=646619

Review-Url: https://codereview.chromium.org/2336913003
Cr-Commit-Position: refs/heads/master@{#418959}

If it's an exclusive end offset, we need to know this, so that we map to the
former fragmentainer group, rather than the latter, if the offset is at a
column row boundary.

Review-Url: https://codereview.chromium.org/2345583004
Cr-Commit-Position: refs/heads/master@{#418958}

This CL adds support for BACKGROUND mode in MemoryCache dump provider,
where it just adds the total sizes of resources (given by encodedSize
of each resource).
This CL also fixes the image resources reporting which had a shared
buffer that was not reported in the ImageResource subclass.
It also fixes the SharedBuffer::onMemoryDump to dump when both shared
buffer and segments are used together.

BUG=629925

Review-Url: https://codereview.chromium.org/2337733002
Cr-Commit-Position: refs/heads/master@{#418957}

This fixes an MSan error introduced by
https://codereview.chromium.org/2294373002/

==31610==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0xa7ce15a in WriteBytesCommon base/pickle.cc:478:3
    #1 0xa7ce15a in WriteBytesStatic<4> base/pickle.cc:443:0
    #2 0x98c5407 in WritePOD<int> base/pickle.h:367:5
    #3 0x98c5407 in WriteInt base/pickle.h:229:0
    #4 0x98c5407 in Persist net/cert/signed_certificate_timestamp.cc:43:0
    #5 0x991c383 in Persist net/http/http_response_info.cc:381:18
    #6 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18

  Uninitialized value was stored to memory at
    #0 0x98c57fd in Persist net/cert/signed_certificate_timestamp.cc:43:3
    #1 0x991c383 in Persist net/http/http_response_info.cc:381:18
    #2 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18

  Uninitialized value was created by a heap allocation
    #0 0x8da8c2 in operator new(unsigned long) ??:0
    #1 0xa68c2f8 in GetX509CertSCT net/test/ct_test_util.cc:220:14
    #2 0x2cb7451 in TestBody net/http/http_response_info_unittest.cc:104:3

Review-Url: https://codereview.chromium.org/2337983006
Cr-Commit-Position: refs/heads/master@{#418956}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8a8133bd..48c952ad

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2340393002
Cr-Commit-Position: refs/heads/master@{#418955}

BUG=646146

Review-Url: https://codereview.chromium.org/2337143004
Cr-Commit-Position: refs/heads/master@{#418954}

In one of the test cases, showModal() was called after the dialog had already
been removed from the DOM from tearDown().

BUG=642574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2341493003
Cr-Commit-Position: refs/heads/master@{#418953}

Remove:
* SSLConfig::npn_protos,
* SSLClientSocket::NextProtoStatusToString(),
* enum SSLClientSocket::NextProtoStatus,
* enum SSLClientSocket::SSLNegotiationExtension,
* kDefaultSupportedNPNProtocol,
* SSLClientSocketImpl::npn_status_,
* SSLClientSocketImpl::negotiation_extension_,
* SSLClientSocketImpl::SelectNextProtoCallback,
* SSLClientSocketImpl::SSLContext::SelectNextProtoCallback,
* HttpNetworkSession::GetNpnProtos(),
* NPN unittests.

BUG=526713

Review-Url: https://codereview.chromium.org/2348453002
Cr-Commit-Position: refs/heads/master@{#418952}

R=mmenke@chromium.org
CC=rdsmith@chromium.org

BUG=474859

Review-Url: https://codereview.chromium.org/2338043002
Cr-Commit-Position: refs/heads/master@{#418951}

Revert of Add CastMediaBlocker and BrowserTest (patchset #5 id:80001 of https://codereview.chromium.org/2330243002/ )

Reason for revert:
Test is failing on Cast Linux:
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/31563

Original issue's description:
> Add CastMediaBlocker and BrowserTest
>
> CastMediaBlocker is a class which can prevent media from being played
> on a web page.
>
> BUG=NONE
> TEST=ChromecastShellMediaBlockingBrowserTest
>
> Committed: https://crrev.com/502bcc946bd12e907572f8b22ef4a0abbc8190d0
> Cr-Commit-Position: refs/heads/master@{#418897}

TBR=halliwell@chromium.org,byungchul@chromium.org,derekjchow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review-Url: https://codereview.chromium.org/2345053002
Cr-Commit-Position: refs/heads/master@{#418950}

The crash is caused by using getId() instead of mWebappInfo.id() when registering
WebAPK. WebApkManagedActivity is launched on Jellybean instead of WebApkActivity,
and getId() in WebApkManagedActivity returns the index of the managered activity,
rather than the Webapp id.

BUG=640434

Review-Url: https://codereview.chromium.org/2339623002
Cr-Commit-Position: refs/heads/master@{#418949}

Convert it to a build flag, as it never properly made the move from gyp.

BUG=646660

Review-Url: https://codereview.chromium.org/2337243003
Cr-Commit-Position: refs/heads/master@{#418948}

- Constrain paint start/end to be bounded by actual text size
  and leave space for at least one character.
- Include start() in paintLength for RTL in paintCompositionUnderline().
  It's included in paintEnd, and I believe its absence was a bug.
- Early-out when painting SVG inline text if text length is zero,
  as we do in for non-SVG inline text.
- Add some DCHECKs to reflect my understanding of key preconditions.
- Add basic LTR/RTL composition underline layout tests.
- Add a 'split' test case wherein InlineTextBox has start = 1.

BUG=641261
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2337373002
Cr-Commit-Position: refs/heads/master@{#418947}

This CL implements QuicHttpStream::GetLoadTimingInfo.

|dns_start| and |dns_end| are obtained in
QuicStreamFactory::Job::DoResolveHost and
DoResolveHostComplete. These two values are passed to
QuicChromiumClientSession's constructor.

|connect_start| and |connect_end| are obtained in
QuicChromiumClientSession::CrytoConnect() and when
handshake is confirmed.

|ssl_start| and |ssl_end| are the same as |connect_start|
and |connect_end| because QUIC always does encryption.

If a session is reused, the connect_timing fields should
all be null. This CL also sets
|socket_reused| field of LoadTimingInfo accordingly.

BUG=637051

Committed: https://crrev.com/5608fc1bd4f0a80b6d1996f3f4059f2efa0a0777
Committed: https://crrev.com/83ac2f22700c563fef8a670ad4c5c57d34032e03
Review-Url: https://codereview.chromium.org/2324183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#417969}
Cr-Original-Commit-Position: refs/heads/master@{#418567}
Cr-Commit-Position: refs/heads/master@{#418946}

https://chromium.googlesource.com/angle/angle.git/+log/7ebb97f..09cfac6

BUG=,chromium:644669

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2346913002
Cr-Commit-Position: refs/heads/master@{#418945}

BUG=

Review-Url: https://codereview.chromium.org/2345663002
Cr-Commit-Position: refs/heads/master@{#418944}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3cc40b373729..596285fbd59f

$ git log 3cc40b373..596285fbd --date=short --no-merges --format='%ad %ae %s'
2016-09-15 petrcermak [tracing] Limit scalar span sparkline's negative z-index to the span only

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2343803005
Cr-Commit-Position: refs/heads/master@{#418943}

https://chromium.googlesource.com/skia.git/+log/606add3dfb2f..ab00f4222c9f

$ git log 606add3df..ab00f4222 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 rmistry Update version of SVG asset
2016-09-15 mtklein Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of https://codereview.chromium.org/2340463008/ )
2016-09-15 brianosman Add storage and computation of SkColor4f version of gradient stops.
2016-09-15 mtklein GN: support 32-bit x86 builds
2016-09-15 mtklein Blacklist slsrgb + image decoding.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2345003002
Cr-Commit-Position: refs/heads/master@{#418942}

TBR=dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2343913002
Cr-Commit-Position: refs/heads/master@{#418941}

Currently, if you perform a mouse dragging action on an OOPIF such as
moving a scroll bar or selecting text, and the mouse cursor moves out
of the OOPIF, input events get routed to the parent frame so the
dragging action stops working. This CL cause the browser process to
lock input to a single RenderWidgetHostView while a mouse button is
being held down, correcting that problem.

BUG=529377

Review-Url: https://codereview.chromium.org/2339503002
Cr-Commit-Position: refs/heads/master@{#418940}

With this CL, SequencedWorkerPool::Inner::PostTask (and hence all task
posting APIs associated with SequencedWorkerPool) returns false when
redirection to TaskScheduler is enabled and the posted task definitely
will not run.

BUG=622400

Review-Url: https://codereview.chromium.org/2346823002
Cr-Commit-Position: refs/heads/master@{#418939}

This adds session type to extension features grammar. The session
type refers to the type of user active in the session in which
an extension is running. The parameter will enable making a feature
available depending on type of the session in which the extension/app
is running.

Feature session types are declared as list of individual session types
in which a feature is available (undefined list means no restrictions).
Currently, values supported for session type are as follows:
* 'kiosk' - kiosk app session
* 'regular' -  non-kiosk user session
The list of supported values is expected to be expanded in future.

Depends on https://codereview.chromium.org/2241203003/ for plumbing
of current session type to feature availability checks

BUG=606417

Review-Url: https://codereview.chromium.org/2255613003
Cr-Commit-Position: refs/heads/master@{#418938}

https://codereview.chromium.org/2083423006 removed the creation of begin
frame sources inside of cc proxies.  When vsync was disabled, the
browser would run unthrottled but the renderer would still tick based
on the browser.  This regressed some perf tests.  This patch reverts
that situation and reimplements unthrottled renderer begin frame sources
in a different way.

When the command line parameter is present, the renderer now runs
unthrottled by creating a separate unthrottled begin frame source inside
of RenderThreadImpl instead of an external one.

As some clean up, the property of being throttled is baked into the
BeginFrameSource interface itself.  This allows for the removal of the
throttling scheduler setting (and the already unused use external bfs
setting).  This should allow for future patches to allow toggling this
property.

The browser compositor and display compositor continue to be tied
together and tick at the same rate.  Therefore, with this patch,
--disable-gpu-vsync=gpu only applies to the display/browser.
--disable-gpu-vsync=beginframe only applies to the renderer.
--disable-gpu-vsync on its own will unthrottle both.

R=brianderson@chromium.org,sunnyps@chromium.org
BUG=643722,644926
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2323123002
Cr-Commit-Position: refs/heads/master@{#418937}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2337803003
Cr-Commit-Position: refs/heads/master@{#418936}

BUG=647311
TBR=kenrb@chromium.org

Review-Url: https://codereview.chromium.org/2341683004
Cr-Commit-Position: refs/heads/master@{#418935}

Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium.

BUG=630728

Review-Url: https://codereview.chromium.org/2330173002
Cr-Commit-Position: refs/heads/master@{#418934}

Revert of Track frame context URL using first script heuristic (patchset #7 id:120001 of https://codereview.chromium.org/2296923004/ )

Reason for revert:
broke compile:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/93915
c:\b\c\b\win_layout\src\third_party\webkit\source\core\inspector\inspectorwebperfagenttest.cpp(48) : error C2220: warning treated as error - no 'object' file generated
c:\b\c\b\win_layout\src\third_party\webkit\source\core\inspector\inspectorwebperfagenttest.cpp(48) : warning C4702: unreachable code

Original issue's description:
> Track frame context URL using first script heuristic
>
> BUG=635596
>
> Committed: https://crrev.com/7012b38dafd3fcaaeaee7b7413718b4b6d7493ca
> Cr-Commit-Position: refs/heads/master@{#418931}

TBR=caseq@chromium.org,alph@chromium.org,pfeldman@chromium.org,dgozman@chromium.org,panicker@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635596

Review-Url: https://codereview.chromium.org/2345023002
Cr-Commit-Position: refs/heads/master@{#418933}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

Most of the callsites have been converted, with only
https://codereview.chromium.org/2317123003/ remaining as the last big chunk,
but in the meantime new uses of path() crept in.

BUG=640599
TBR=danakj@chromium.org, petewil@chromium.org, siggi@chromium.org,

Review-Url: https://codereview.chromium.org/2347673002
Cr-Commit-Position: refs/heads/master@{#418932}

BUG=635596

Review-Url: https://codereview.chromium.org/2296923004
Cr-Commit-Position: refs/heads/master@{#418931}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fa07ac00..8a8133bd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2342083002
Cr-Commit-Position: refs/heads/master@{#418930}

Fixes a bug where ALL_OR_NONE writes to data pipes were checking the
total capacity of the pipe, rather than the available capacity. The bug
allowed ALL_OR_NONE writes to succeed (MOJO_RESULT_OK), but in actuality
only a portion of the data was written.

Updated unit test with a case that fails w/o the fix, but passes with
the fix.

Review-Url: https://codereview.chromium.org/2341633005
Cr-Commit-Position: refs/heads/master@{#418929}

This change updates the behavior when switching tool types. The tool
type is always sent with the pointer enter event, and when the type
switches while an exo surface is in focus, we will leave and re-enter
the surface with the new tool type.

BUG=645576

Review-Url: https://codereview.chromium.org/2338133004
Cr-Commit-Position: refs/heads/master@{#418928}

The crash in constructor of ImagePattern may be due to the fact that
image passed in as its constructor argument is nullptr. By tracking
all the call trace backwards, we find the image creation originates
from BaseRenderingContext2D::createPattern, where the SourceImageStatus
indicates what corresponding action to do. But this SourceImageStatus
was wrongly set for OffscreenCanvas, in particular, in the function
OffscreenCanvas::getSourceImageForCanvas. This CL corrects it and makes
sure that if the image is null, BaseRenderingContext2D::createPattern
will return Image::nullImage() instead of nullptr.

BUG=646654

Review-Url: https://codereview.chromium.org/2344573002
Cr-Commit-Position: refs/heads/master@{#418927}

This should fix the build break at this bot:
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20x64%20Builder%20%28dbg%29/builds/9753

R=geofflang@chromium.org
TBR=tbarzic@chromium.org
BUG=None

Review-Url: https://codereview.chromium.org/2338133007
Cr-Commit-Position: refs/heads/master@{#418926}

This CL removes calls to MessageLoop::Post(Delayed)Task from
message_loop_unittest.cc

BUG=616447

Review-Url: https://codereview.chromium.org/2342903002
Cr-Commit-Position: refs/heads/master@{#418925}

https://chromium.googlesource.com/skia.git/+log/e839e78443e4..606add3dfb2f

$ git log e839e7844..606add3df --date=short --no-merges --format='%ad %ae %s'
2016-09-15 bungeman Revert of SkFontData to use smart pointers. (patchset #3 id:40001 of https://codereview.chromium.org/2339273002/ )
2016-09-15 mtklein GN: link executables with -rdynamic on Linux.
2016-09-15 bungeman SkFontData to use smart pointers.
2016-09-15 mtklein simple fix?
2016-09-15 rmistry Add ability to create and upload SVGs from a local dir
2016-09-15 borenet Fix NoGPU bot, which is compiling in GPU support
2016-09-15 brianosman Remove the unused 16-bit gradient cache
2016-09-15 brianosman More NoGPU compile fixes
2016-09-15 mtklein Pass rietveld as the default patch_storage.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2345733002
Cr-Commit-Position: refs/heads/master@{#418924}

BUG=644997

Review-Url: https://codereview.chromium.org/2346643002
Cr-Commit-Position: refs/heads/master@{#418923}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/2630ab098b5e..fe5bd51f9b79

$ git log 2630ab098..fe5bd51f9 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 stichnot Update revision for PNaCl
2016-09-14 stichnot PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
2016-09-14 stichnot PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
2016-09-13 stichnot PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
2016-09-12 brettw Remove GYP files in Native Client.

BUG=none

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2345703002
Cr-Commit-Position: refs/heads/master@{#418922}