GitLab

Couple modifications to errors/warnings in setup pin dialog:
1) Shows min length warning right away
2) On confirming pin step, only show mismatch error when confirm button clicked
3) Min length warning becomes error once user exceeds min length, but goes back under min length threshold.

Bug: 723800
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7fb9dd7f18c8555a3d247b8a2613574abe696b32
Reviewed-on: https://chromium-review.googlesource.com/540744Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481785}

This reverts commit 26834276.

Reason for revert: These tests are still failing on WebKit Android (Nexus4):
  JsToCppTest.BackPointer
  JsToCppTest.BitFlip
  JsToCppTest.Ping
  JsToCppTest.Echo

Example build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/66197


Original change's description:
> Reland of "Moves mojo_js_integration_tests into blink."
> 
> This reverts commit c461e58e.
> 
> Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/
> 
> Original change's description:
> > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"
> >
> > Reason for revert:
> > WebKit Android (Nexus4) are still broken with four failing tests:
> >   JsToCppTest.BackPointer
> >   JsToCppTest.BitFlip
> >   JsToCppTest.Ping
> >   JsToCppTest.Echo
> >
> > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=699569
> >
> > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
> > Reviewed-on: https://chromium-review.googlesource.com/538520
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#480282}
> 
> TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org
> 
> Bug: 699569
> Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506
> Reviewed-on: https://chromium-review.googlesource.com/540664
> Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481712}

TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org

Change-Id: I496aba914c51b914ffb8082d9d6cb4c8cf45f590
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 699569
Reviewed-on: https://chromium-review.googlesource.com/544452Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481784}

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c24

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2950393002
Cr-Commit-Position: refs/heads/master@{#481783}

Previously, the Advanced, Networks, and Proxy fields were shown, which are not related to Tether networks.

BUG=672263,730246
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2949363002
Cr-Commit-Position: refs/heads/master@{#481782}

This CL adds SuperfishBlockingPage and SuperfishErrorUI classes to display the
Superfish interstitial. SSLErrorHandler checks for the Superfish certificate
fingerprint and uses a SuperfishBlockingPage (a subclass of SSLBlockingPage)
when it's present.

The strings displayed by SuperfishErrorUI are stubs for now; those will be
filled in to match the mocks in a follow-up.

SSLBlockingPage is modified a bit to allow a subclass that uses its own subclass
of SSLErrorUI. And SSLErrorUI is modified a bit to allow a subclass that uses
special strings.

The certificate error report format is updated to report when the Superfish
interstitial is shown (similar to how clock and captive portal interstitials are
reported). Certificate reporting for the Superfish interstitial is missing a
test; see https://crbug.com/735803.

This is all gated behind the SuperfishInterstitial Finch feature.

BUG=734590

Review-Url: https://codereview.chromium.org/2949003003
Cr-Commit-Position: refs/heads/master@{#481781}

These tests were broken by https://codereview.chromium.org/2789723003

NOTRY=true
TBR=scottmg@chromium.org
BUG=729849

Review-Url: https://codereview.chromium.org/2958443002
Cr-Commit-Position: refs/heads/master@{#481780}

Up until now, the documentation for the feature engagement tracker has
been focused around developing it itself. However, going forward it will
be more beneficial to have documentation for how it should be used.

This CL adds documentation around the following topics:
* Objectives for the service.
* Overview of how it works.
* How to develop a new In-Product Help feature.
* How to enable UMA tracking for new In-Product Help features.
* How to use demo-mode.
* How to use Chrome Variations to locally test In-Product Help features.
* Thorough description for how to configure though Chrome Variations.

BUG=None

Change-Id: I2358b872b07dcaa56df2ae831f47240dee799287
Reviewed-on: https://chromium-review.googlesource.com/524532
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481779}

This argument controls whether the WebContents needs to be reloaded
when activated. Not reloading the WebContents as soon as it is
activated will allow TabManager to implement more advanced reload
rules (e.g. browser window is active, tab has been active for x ms).

Note: Today, a WebContents is considered "active" if it is in a
selected tab, even if the browser window is not visible.

TBR=bauerb@chromium.org,chrisha@chromium.org,bengr@chromium.org

Bug: 731145
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I87a16df112752b97bcc369e34a1e1f86d18d9b99
Reviewed-on: https://chromium-review.googlesource.com/531065
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481778}

This CL extracts the struct Geoposition out of geolocation.mojom 
into a file on its own. No new code.


Bug: 
Change-Id: I6350537ccd19d1da0b02f3c8489fa39a06740376
Reviewed-on: https://chromium-review.googlesource.com/543577Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481777}

This both simplifies the code and fixes the selection bug. The original
code relied on multiple inherited Polymer behaviors which stomped on each other
causing what seems like a race condition per findings at
https://bugs.chromium.org/p/chromium/issues/detail?id=734789#c2.

Specifically:
 - Simplify logic within cr-profile-avatar-selector-grid, no more inherited
   behaviors.
 - Update both settings/ and md_user_manager/ client code.
 - Stop relying on bubbling 'iron-activate' event in manage_profile.html.
   Instead use a Polymer binding + observer.

Regarding the race condition: The previous code, was seemingly attempting to
highlight the grid with the currently selected avatar icon on creation, but
unsuccessfully because this was intentionally broken within the C++ side at
crbug.com/710660. As a side-effect, the 'profile-info-changed' event
propagating back from C++ after every user-initiated change, was causing the
selection of the user to be immediately discarded.

It would make little sense to re-implement JS functionality that is already not
working. Instead I am removing such tests, since they are meaningless until/if
the C++ side is fixed.

BUG=734789
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2950943002
Cr-Commit-Position: refs/heads/master@{#481776}

Moving ChildProcessService and associated classes to base.

BUG: 702316
Change-Id: If4f47ca958127cc316e42f06428af94bb42cd0aa
Reviewed-on: https://chromium-review.googlesource.com/540140
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481775}

  In order to roll GN 7c9bd5f0..bedb4b20 (r465654:r481731) and pick up
  the following changes:

  a104997e Allow overriding script executable in .gn file
  18697c83 Move if, else, true, false into a keyword category
  d4a5e982 [tracing] Switch to new heap dump format.
  8480d866 tools/gn: Implement Windows SDK version command line switch
  3e0d5228 Use ContainsValue() instead of std::find() in tools/
  e4a28698 Fix GN bootstrap
  11857736 [spelling] existance to existence
  21886543 Fix a bug in `gn analyze` for host-only file mods.
  f8bf5083 Fix gn get_label_info comment
  05f56d41 allocator: remove ENABLE_MEMORY_TASK_PROFILER and use only USE_ALLOCATOR_SHIM
  e329e9ec Fix GN bootstrap
  2928b5dc Add information on the requirements for a new Chromium port.
  73228cd4 allocator: rename use_experimental_allocator_shim to use_allocator_shim
  797723cd Fix GN bootstrap
  84fa8b08 Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only)
  d77555bc GN: Fix single-file compilations in VS2017 projects
  cbbd560a gn: get rid of GetRealPath() function
  cf2a4bf9 gn: convert WrapUnique calls to MakeUnique where possible
  dfb837a9 gn: fix bootstrap on windows
  777e1cd5 Fix gn bootstrap after https://codereview.chromium.org/2872503003
  25e10941 gn: Document gen's --check flag.
  14525201 Add a GUID to base::SharedMemoryHandle.
  b154afcb memory-infra: Move dump level check to observer and rename session state
  9b718c79 Fix GN bootstrap
  643d6bc9 gn: fix bootstrap.py after https://codereview.chromium.org/2846893003
  dd1ae15f gn docs: Add a missing closing paren.
  0088ee50 GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support.
  4a4589fc memory-infra: Start disentangling tracing from memory-infra
  7fd3f671 Add curly brackets to list of characters that gn needs to escape
  ca2ec763 Improvements to uses of base::SmallMap
  ddb3babc Use $root:default as a "default" rule

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2953643004
Cr-Commit-Position: refs/heads/master@{#481774}

BUG=727940
R=pdr@chromium.org

Change-Id: Ie54a42a918f8a5fd2b4845dfce6052242740cdbd
Reviewed-on: https://chromium-review.googlesource.com/527606
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481773}

* Combines duplicate certificate chains that were named with "-ok" vs "-fail" (these predated ability to set expectations in .test files)

* Adds .test files for each chain for ANY_EKU, CLIENT_AUTH and SERVER_AUTH

Review-Url: https://codereview.chromium.org/2931053002
Cr-Commit-Position: refs/heads/master@{#481772}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/326eb241976e..e810453155c3

$ git log 326eb2419..e81045315 --date=short --no-merges --format='%ad %ae %s'
2017-06-22 dtu [pinpoint] Reduce Isolate key hash length from 512 to 256.
2017-06-22 erikchen Fix periodic dumping for memory-infra on Android.
2017-06-22 benjhayden Fix a memory leak in results.html.
2017-06-22 benjhayden Document significance in metrics-results-ui.md.
2017-06-22 eakuefner [Dashboard] Create corresponding rows for histograms
2017-06-22 benjhayden Fix and test histogram-set-table.leafHistograms.
2017-06-22 benjhayden Fix and test sorting by delta statistics.

Created with:
  roll-dep src/third_party/catapult
BUG=735124


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I20f82210195a3eba6600d6da3b14aa52513421d9
Reviewed-on: https://chromium-review.googlesource.com/545166
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481771}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b068de4b..4162e53c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2953893002
Cr-Commit-Position: refs/heads/master@{#481770}

It's failing on Mac 10.9, see https://crbug.com/734762#c11.

TBR=dgozman@chromium.org

Bug: 734762
Change-Id: I73185ad9b21f34c61976b93d02fa3ceb278d8027
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/544365Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481769}

This is temporary while we get Mac-10.12 on Intel GPU working.
During this time it will let us accurately compare 3 configurations;

 * Mac 10.9  with GPU-None  -- Currently broken
 * Mac 10.12 with GPU-None  -- Currently working
 * Mac 10.12 with GPU-Intel -- Currently broken

BUG=524758
TBR=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2957503002
Cr-Commit-Position: refs/heads/master@{#481768}

This CL is part of the Mojo Video Capture work.
Design doc for dev work [1].
Design doc for launch [2].

BUG:584797,721812

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://docs.google.com/document/d/1RLlgEdvqRA_NQfSPMJLn5KR-ygVzZ2MRgIy9yd6CdFA/edit?usp=sharing

Change-Id: I38b83efdf1e8619e3edba95df70a6b5fdae30a3f
Reviewed-on: https://chromium-review.googlesource.com/524298Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481767}

TBR=nednguyen

Bug: 736150
Change-Id: I23937789dfdd4620fa4f7ea3a96ea2fa59349d87
Reviewed-on: https://chromium-review.googlesource.com/545199Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481766}

Bug: 736125
Change-Id: Icb66b30de6a7a9b2da77a2a733c9b889871edf6e
Reviewed-on: https://chromium-review.googlesource.com/544448Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481765}

The approach ends up pretty close to what's already done for Windows.

On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more
often match what native UI does) and requires RenderTextHarfbuzz to do
less work. However, it doesn't guarantee that the returned font can
display every glyph in the provided string.

So still use CTFontCopyDefaultCascadeListForLanguages (which is now a
public API - hooray) to provide a last-resort list of fallback fonts.

This CL causes a font used for Hebrew text in a test to change, which
tickled a pre-existing bug/corner case in the test for some macOS
versions.

BUG=696867, 619684, 735346

Previously landed in r481062, but tickled some OS-specific tests due to
a valid discrepancy between rounding directions.

Review-Url: https://codereview.chromium.org/2927953003
Cr-Commit-Position: refs/heads/master@{#481764}

BUG=735534
TEST=Repeat crashes when not in Incognito mode show the advice to try
Incognito mode. However the same test performed when in Incognito mode
should not offer this advice as one of the bullet points.

Review-Url: https://codereview.chromium.org/2949833005
Cr-Commit-Position: refs/heads/master@{#481763}

This CL was mostly generated mechanically with:
  $ git grep -l -i helper.*webview.*mainframeimpl -- third_party/WebKit/Source \
      | xargs -n 1 sed -i -e \
        's/helper\.WebView()->MainFrameImpl()/helper.LocalMainFrame()/g'
  # same as above, but with "helper_." instead of "helper."
  $ git grep -l -i helper.*webview.*mainframeimpl -- third_party/WebKit/Source \
      | xargs -n 1 sed -i -e \
        's/helper_\.WebView()->MainFrameImpl()/helper_.LocalMainFrame()/g'
  $ git cl format

The only manual change was to change the constness of WebViewHelper's
LocalMainFrame and RemoteMainFrame accessors.

BUG=416660

Review-Url: https://codereview.chromium.org/2945093002
Cr-Commit-Position: refs/heads/master@{#481762}

When showModal is called on a <dialog> element, the rest of the
Document becomes inert which prevents it from receiving events or taking
focus. When the Document contains an out-of-process iframe, however, its
contents are not aware of the modal dialog in a remote ancestor.

This CL caches the current inert state on each LocalFrame, which is
changed when a modal dialog because active or inactive. The bit is
plumbed to remote frame children so that OOPIFs will respect inertness.

Also it prevents having to search up the entire frame tree when an
element checks whether it is inert.

BUG=719788
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2883033003
Cr-Commit-Position: refs/heads/master@{#481761}

URLRequests can't outlast the URLRequestContext that spawned them, so
the current code can cause crashes on NetworkContext destruction.

BUG=735995

Review-Url: https://codereview.chromium.org/2951293002
Cr-Commit-Position: refs/heads/master@{#481760}

This reverts commit 861dba53.

Reason for revert: Broke blink_platform_unittests and webkit_unit_tests on WebKit Win x64 Builder (dbg).
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20(dbg)/110174
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20(dbg)/110175

Original change's description:
> Reland "[SPv2] Rework GeometryMapper transform computation"
> 
> This is a reland of afc31e81
> Fixed Windows x64 build failure. DLL export needs to be specified on
> individual explicit template instantiation:
> https://docs.microsoft.com/en-us/cpp/cpp/general-rules-and-limitations
> 
> Original change's description:
> > [SPv2] Rework GeometryMapper transform computation
> > 
> > When computing the conversion matrix between two spaces, there are two
> > types of conversion that are commonly used, but with slightly different
> > semantics:
> > 
> > m1 = destination_to_screen ^ -1 * source_to_screen
> > m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen)
> > 
> > The former computes the space conversion, which is useful for mapping
> > 3D points from one space to 3D points in another space. The latter
> > computes the "projection through screen", which is useful for mapping
> > 2D points from a plane to a backing that is expected to be drawn onto
> > the screen.
> > 
> > To illustrate the difference, see the following example:
> > <div style="transform:rotateY(45deg)">A</div>
> > <div style="transform:rotateY(-45deg)">B</div>
> > 
> > The space conversion from A to B is equal to rotateY(90deg), but the
> > projection between the two planes is identity.
> > 
> > Prior to this CL, GeometryMapper implemented a mixed semantics. This is
> > okay because all existing code only make queries that are co-planar, in
> > which case, either version returns identical result. This is because we
> > only make intra-compositing-layer queries, and 3D transform makes a
> > compositing boundary.
> > 
> > This CL changed the implementation to strictly return the "projection
> > through screen". The algorithm runs in amortized O(1) by caching the
> > matrix between a node and its nearest coplanar ancestor that has a
> > invertible projection.
> > 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93
> > Reviewed-on: https://chromium-review.googlesource.com/534899
> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> > Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#481049}
> 
> Change-Id: I067a0f40f2e41a9fc282c4014975f144417d7d3b
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/543897
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481688}

TBR=trchen@chromium.org,chrishtr@chromium.org

Change-Id: Iccc3418e798df1de4c9f907ea66868c61a355db8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/544449Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481759}

Important sites could be a performance hit, especially because it might
hit disk w/ content settings querying, enumerating all bookmarks, etc.
This change lets you disable that.

BUG=732907

Review-Url: https://codereview.chromium.org/2953853002
Cr-Commit-Position: refs/heads/master@{#481758}

Also reduce the block cache size used by localstorage.

TBR=primiano@chromium.org

Bug: 730475
Change-Id: I3439508d57a54d09d98df8cd2191448720ab19b8
Reviewed-on: https://chromium-review.googlesource.com/543439
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: siddhartha sivakumar <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481757}

Previously, the notifications stayed around after they were tapped; this made it possible to interact with them later at a time when they may be stale.

BUG=672263,730247

Review-Url: https://codereview.chromium.org/2953973002
Cr-Commit-Position: refs/heads/master@{#481756}

These tests verify that browsing data (cookie, localStorage) does not
leak between incognito and non-incognito web views.

BUG=None

Review-Url: https://codereview.chromium.org/2945563002
Cr-Commit-Position: refs/heads/master@{#481755}

Currently, there are a few keyword fields that also specify field_size.
This is misleading, because the size for keyword fields are
automatically calculated from the number of keywords, so field_size is
ignored.

This patch removes any references to field_size in keyword fields. It
also adds an assert in make_computed_style_base to prevent this from
happening in the future.

This patch does not change generated code.

Bug: 628043
Change-Id: Ie9e6bb17d084d8dc96811b2ab2ab76c0c8849e0e
Reviewed-on: https://chromium-review.googlesource.com/540935
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481754}

[CrOS Tether] Move LocalDeviceDataProvider from //chromeos/components/tether to //components/cryptauth.

This functionality is not logically coupled to the Tether component and will be used in other CryptAuth-related projects.

See a sample usage of this change as part of https://codereview.chromium.org/2953863002.

BUG=672263

Review-Url: https://codereview.chromium.org/2951303002
Cr-Commit-Position: refs/heads/master@{#481753}

On Android, the properties of what to show in the FRE are calculated
the first time it is launched.  If you leave in the middle and Chrome
is killed, we use the same properties to show it again.  For the search
engine promo, you can get your phone in a state where it is no longer
valid to be shown.  In this case, we should ensure the state is still
valid before attempting to enqueue the search engine promo screen.

BUG=736112

Review-Url: https://codereview.chromium.org/2949393002
Cr-Commit-Position: refs/heads/master@{#481752}

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952173002
Cr-Commit-Position: refs/heads/master@{#481751}

This patch makes |VisiblePosition::AfterNode()| to take |const Node&| as
|Position::AfterNode()| for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2950273002
Cr-Commit-Position: refs/heads/master@{#481750}

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946883002
Cr-Commit-Position: refs/heads/master@{#481749}

Revert of Enable ThinLTO for POSIX LTO by default on Linux. (patchset #2 id:20001 of https://codereview.chromium.org/2939373002/ )

Reason for revert:
Breaks chromium.perf builder.

BUG=735651

Original issue's description:
> Enable ThinLTO for POSIX LTO by default on Linux.
>
> This is a reland of the remaining part of
> https://codereview.chromium.org/2831213006 .
>
> The binary size regression has been addressed by disabling ThinLTO
> whole-program optimizations and improving the quality of unoptimized
> code.
>
> BUG=660216
> R=thakis@chromium.org,hans@chromium.org
>
> Review-Url: https://codereview.chromium.org/2939373002
> Cr-Commit-Position: refs/heads/master@{#480144}
> Committed: https://chromium.googlesource.com/chromium/src/+/5cb9983f12f300422c16ba812c2d5cdeb278cb74

TBR=hans@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=660216

Review-Url: https://codereview.chromium.org/2953943002
Cr-Commit-Position: refs/heads/master@{#481748}

Native heap profiling can now be run on official builds by setting a
chrome://flag.

BUG=

Review-Url: https://codereview.chromium.org/2949353004
Cr-Commit-Position: refs/heads/master@{#481747}

When the focused window is chrome browser and
not blocked profile, the URL will be sent along
with the voice interaction tree.

Also the browser's window position is sent. This
hopefully could benefit metalayer detection.

BUG=b:62872370
TEST=manual test with debug tool

Review-Url: https://codereview.chromium.org/2952293002
Cr-Commit-Position: refs/heads/master@{#481746}