- 29 Sep, 2020 40 commits
-
-
Jazz Xu authored
This CL removes the DCHECK for pin state in media controls detailed view since we are not removing media controls from system menu immediately after user pinned media controls. So user can tap the media controls again while the system menu is still open and get back to the detailed view with the media controls pinned to shelf. Change-Id: I60235836686b535c0a06ee0bf99e97141ba9bf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435560Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811539}
-
Prashant Nevase authored
While organizing the virtual tests for dark mode images in grayscale, common configurations were removed. But as earlier code did not have grayscale argument explicitly set, the results were same as default dark mode. This patch corrects the argument needed for grayscale and now expected image results look grayish. Bug: 1116914 Change-Id: Iddf66c043d754ee6ed1607ca5c6f9908afbed1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434191Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#811538}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsTetherConnectionDialog* Change-Id: I1440e55698e5369f8f79e4f3b4c39719b7f64acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436891Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#811537}
-
Jason Lin authored
Bug: b/167491603 Change-Id: I5ab220bda34b40f8dd4664ad7abed25bd89ba7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425550 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#811536}
-
David Vallet authored
BUG=1124062 Change-Id: I8ccceb481300089ad3218455ff691ff1dac2b3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421988Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#811535}
-
Dominic Mazzoni authored
Measures the amount of time spent unserializing changes to the accessibility tree and sending automation events. In order to scale reasonably well across different machines, this time is compared to the amount of time spent in renderer accessibility code, that way the test only fails if the disparity is too large. The test code is deliberately all one test for ease of review. As we add more tests, a lot of the code could be broken up into helpers. Bug: none Change-Id: I44a169a7c80d9ccea5cf70cb7450731a43638c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430304 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811534}
-
Bill Budge authored
- Reworks code that sets V8 flags for SharedArrayBuffer and Wasm Threads to also set the new V8 Atomics flag. - Atomics are now always enabled. - SharedArrayBuffer is enabled on desktop, and on Android only with site isolation. Bug: chromium:923807 Change-Id: If40bcbf66216680f0f52ec1bf02dce475b38b1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343566 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#811533}
-
kylechar authored
SkiaRenderer has launched on Windows so we no longer need an FYI bot to run tests. Remove all tests from Win10 FYI x64 SkiaRenderer GL (NVIDIA). Also removes gl_renderer_screenshot_sync tests from CQ, these were testing the old configuration would produce pixels, but we no longer care about GLRenderer. Bug: 809722, 1132963 Change-Id: I85d7c36d3758d524a9b63ac78923533b538177e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410822 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811532}
-
chrome://device-logReilly Grant authored
This change adds a section to chrome://device-log for the Serial API. Existing error messages are now directed here and the platform-specific enumeration backends have been updated to generate log entries when devices are added and removed, as is done for other device types. Bug: 1107826 Change-Id: I694b42fe82b96c44257c979b8a2ea276b34f3124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436277 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#811531}
-
Dominic Mazzoni authored
Bug: 1132546 Change-Id: Ia66ca06eb4aba9c63548faca66caf94009f81fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433258 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811530}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I79e12433c7174345f6a921eb234efcf8e5ce4eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437694Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811529}
-
Ian Kilpatrick authored
This test doesn't add a lot of value now that we have: ng_layout_result_caching_test.cc ...to test cache hits/misses. There should be no behaviour change. Change-Id: I4d13d6f61cdfce0dd00dd3e85eab6d03a7b12d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256156 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811528}
-
John Delaney authored
Adds overflox-x:scroll to the css for the containers which wrap the tables on the chrome://conversion-internals page. This stops the table from rendering outside the bounds of container on narrow screens. Bug: 1132929 Change-Id: If99697c784516ac9c0c8a004646ef29695b31683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436290 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#811527}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cb9160484da5..184c9b9164b7 2020-09-28 thestig@chromium.org mac: Make the system page size a run-time property If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1102194 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I45f0003e8781906284823c9cfde4648c3d6cb289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811526}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9c65f64..e862368a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5aabb9d10643e0fdaeee5193e7f994ebc68ffeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811525}
-
Stephen Chenney authored
Text Decorations were not contributing to ink_overflow, leading to remnants on the screen when invalidated and causing the mis-sizing of composited layers containing the decorations. This change adds ink overflow calculations for LayoutNG fragment items. Legacy layout is unaffected. Tests added include both the paint layer sizing concern and the invalidation concern. Bug: 896295 Change-Id: I3b8cfd9d9c4f3efafd380e6718fd2eaf22229f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422356Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#811524}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df3ae5e6f975..88c194fccd3b 2020-09-28 treehugger-gerrit@google.com Merge "Fixed data source index assert checking against wrong constant." 2020-09-28 cferris@google.com Merge "Update for libunwindstack change." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib0f3f85458d99813ae3c8fd104b13b059de39fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436893Reviewed-by:
-
Lan Wei authored
MediaNotificationServiceFactory uses a non-existent #define for ChromeOS, defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS). Bug: 1121653 Change-Id: Idd748e7e49c9b2bdc675ae55f1c2b49a6c5ee28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436169Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811522}
-
Mike Wittman authored
This reverts commit 2c8b578a. Reason for reland: originally reverted because the change was broken by https://crrev.com/810801 and that change has since been reverted Original change's description: > [Sampling profiler] Factor out platform config 1/4 > > First in a series factoring the ThreadProfiler platform specific > configuration state from the code that takes action on the > state. Defines an IsSupported function that is true if the profiler > is supported on the chrome branding and channel for the platform. > > The end goal is to reduce the configuration complexity, to support > enabling per-thread on Android. > Bug: 1129939 > Change-Id: Ibbd6f4725804b40ac77e15aaa3bd15ad76a0e7b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425165 > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810835} TBR=etiennep@chromium.org, ssid@chromium.org Bug: 1129939 Change-Id: Ie69c5c695bc286f070e34f70553ffd35562208b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436250Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#811521}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601315959-5577f3dbf01608bf6e215c63714e131a2bd389f7.profdata to chrome-mac-master-1601337561-8feee235133953607f7453082566ed5b7d8ffb34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I703ed5612f027a96a6e39464e9c3b10696a73990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437632Reviewed-by:
-
Lan Wei authored
CheckinRequest uses a non-existent #define for ChromeOS, defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS). Bug: 1121653 Change-Id: Ieae0bdf874c006296bfedc4da3cd2394b4e3a9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434777Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601315959-4ec2d6a153e04750c200a2fe71bb63fd4f2d802c.profdata to chrome-linux-master-1601337561-307983a438d89a0d060ed0a79e008eada61629c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org Change-Id: I4f5536ecc77a4bb7de555059c5ec9269c3c95415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437789Reviewed-by:
-
Peter Kasting authored
I didn't realize this existed when I wrote the initial change. Bug: 772945 Change-Id: Ib4dd142fc06b42f02c38811a7684f5564481471f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433587 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#811517}
-
Rachel Wong authored
There are several AutocompleteMatch fields that provide rich entity information but are currently not used by the launcher. This CL adds rich entity fields to the omnibox results, which will then be forwarded to ash. Any changes which may override existing behaviour are gated behind a feature flag. Bug: 1130372 Change-Id: Ia92aaa88cc1c6af41bd3b820b85b978c7b108e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409685 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/21e6e530cf90..18d69fb4e7b2 2020-09-28 wangxianzhu@chromium.org Let --interval-profiling-period cover legacy page interactions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132070 Tbr: rmhasan@google.com Change-Id: I2d6d25a8dd199772f3412be9899cc4aaea80d930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437409Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I81bdb9ed1de679f6b726c672bbd1519c0fcb2c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436413 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#811514}
-
zhaoyangli authored
Accept Xcode GM license as version from CIPD, instead of throwing a KeyError when 'IDEXcodeVersionForAgreedToGMLicense' key doesn't exist in '/Library/Preferences/com.apple.dt.Xcode.plist'. Bug: 1131413 Change-Id: Ic383174232d02e37a53da20b74680609b2743ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432874Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#811513}
-
Piotr Pawliczek authored
This patch adds support for new error codes defined in CL:2420496 and translates them to chromeos::PrinterSetupResult values. It also unifies error messages attached to chromeos::PrinterSetupResult values. BUG=chromium:1069844,chromium:1123268 TEST=tested on atlas as a part of larger patch Change-Id: I5eab4139a4a0dbdc878ef79de23ed35dca94cdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420497 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Alexander Surkov authored
TreeSelector suggests the wider range of application selection including handy browser selectors like --chromium Bug: 1131921 Change-Id: I658684bdf45efde747f5ae5311dc819c369fe1c6 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432105Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#811511}
-
Lei Zhang authored
Do not re-invent base::DoNothing() poorly. Bug: 537099 Change-Id: I837c8995686d1fa87779b58ab621d0e712803864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430824 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811510}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e41ad708. With Chromium commits locally applied on WPT: 6bdcd688 "[COOP] access reporting: split property.https.html test." 95fddf83 "[css-flex] Fix flex base size for aspect ratio items of column flexboxes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I919b1e8e2a7e44c5fc593f8fa153cbe3e45fb3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436803Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811509}
-
Jeffrey Kardatzke authored
When allocating buffers for the output (capture) queue with the new VD, we should add extra buffers to what the driver says we need to account for delays with the rest of Chrome's rendering pipeline. BUG=b:165647432,b:157703889 TEST=Playback no longer stutters on trogdor Change-Id: I782377dd10e3ac0c63ce12d12b6ac3c49c370b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433591 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#811508}
-
Darren Shen authored
The fields defined on a Mojo lite struct should not be renamed, as they are expected verbatim by the Mojo struct encoder. However, if compiled with property_renaming=ALL_UNQUOTED, the current generated struct fields will be renamed, which breaks the encoder. Use @export to prevent these fields from being renamed. Bug: 1132645 Change-Id: I0f4678c5ebf7d54ddd53c75eb3e7f0a4db94a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432235 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#811507}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/webui/chromeos/crostini_upgrader This CL was uploaded by git cl split. R=joelhockey@chromium.org Change-Id: Ia2ce23323e4f98ea6c9205d707d53866026e6244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434775 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811506}
-
Darren Shen authored
This reverts commit 96c22a25. Reason for revert: Seems to break the tree: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/38070? Original change's description: > [CrOS PhoneHub] Hook up quick actions UI to controllers. > > - Create a base class for quick actions controller. > - Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states. > - Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL. > > BUG=1106937,1126208 > > Change-Id: I3eb511e1843cd4cb6b80316a706a2dcbc61a8e49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419552 > Commit-Queue: Andre Le <leandre@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811478} TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org Change-Id: I36f2df2386549b01b802481f0cf2a65fa27d424c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Bug: 1126208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437538Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#811505}
-
Daniel Classon authored
Renames "Reverse scrolling" to "Enable reverse scrolling" on the settings page for Mouse and Touchpad, as per the bug. Fixed: 1132398 Change-Id: I173fe20f95a21c3909e8fa766cc8bfaac62258b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434211Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29d2aa6ec8cc..306abde46d50 2020-09-28 vidorteg@microsoft.com Locking user agent shadow dom from translation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bbd5e92c6b5a8bd8d830d661030f6de08abf587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437091Reviewed-by:
-
David Bertoni authored
The conditional check for a null pointer value for g_test_clock is unnecessary, since the constructor of net::BackoffEntry will initialize the value to a nullptr anyway. This allowed removing the constructor completely. Change-Id: I02d62a79aba3257f50a0d5aae91d54ec9a612e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430449Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811502}
-
Xiaohan Wang authored
This reverts commit 87c8ae14. Reason for revert: Reland with fix Change-Id: I2778e8a68ba0c804b7795cade0ca9f8ed69838cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435781Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811501}
-
Stefan Zager authored
When calculating the viewport intersection of an iframe, we walk up the LayoutObject hierarchy, mapping the iframe's bounds into the coordinate system of each of its ancestors. When we encounter an ancestor with a clip, we take the axis-aligned enclosing rect of the iframe bounds to calculate the clip, and continue with that. As a result, the final computed intersection rect can be *larger* than the initial rect. This patch clamps the size and location of the viewport intersection to the size of the iframe's contents. Change-Id: Ie78cd824d68509ede748a906cefad4d611642388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427187 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811500}
-
