GitLab

Changes:
- Fixing grdp strings in ui_strings and profiler_strings

Reason:
- Profiler string needed an update to remove 'bytes'
- Two CLs requiring a 'var1, var2' localized string checked in at the same time, so we need to remove one.

Change-Id: I4a32629959453048229784b4efdc445960273385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726952Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#682765}

This reverts commit 053b22e8.

Reason for revert: This appears to have made CacheStorageManagerTest.TestErrorInitializingCache flaky - see https://crbug.com/989313

Original change's description:
> CacheStorage: Write index after simple disk_cache.
> 
> When we load the cache_storage index we try to determine if its fresh
> or stale by comparing its timestamp against the timestamp of the
> various simple disk_cache directories.  Both cache_storage and simple
> disk_cache write their index files out using a delay.  The
> cache_storage delay is 5 seconds and the simple disk_cache delay is 20
> seconds.  This means that the simple disk_cache index is always written
> last and as a result the cache_storage index is almost always
> considered stale.
> 
> This CL fix this by extending the cache_storage delay to match the
> simple disk_cache delay.  It also implements a shorter delay on android
> when in the background like simple disk_cache uses to avoid losing
> data when the app is killed by the operating system.  Finally, the CL
> also now properly flushes the index to disk if there is a pending write
> when the cache_storage subsystem is torn down.
> 
> Over time this should cause ServiceWorkerCache.UsedIndexFileSize to
> show more cases where the index file is used to provide the size.
> 
> Bug: 988001
> Change-Id: Idaa09b956edcfa9e70ac1fdb9b43adcd73ec0508
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721389
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682409}

TBR=dmurph@chromium.org,wanderview@chromium.org

Change-Id: Ic0c766da0b704c6f0c48ed8a46dd97133d09b290
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 988001, 989313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729057Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682764}

vulkan_swiftshader_content_browsertests is a copy of
vulkan_content_browsertests above it, but with --use-vulkan=swiftshader.
Run this test on the Linux Viz fyi bot.

Previously, this test would fail if GPU compositing was blacklisted.
Mark |use_swift_shader| if SwiftShader Vulkan is used to force enable
GPU compositing for tests.

Bug: 969848
Change-Id: Ibcdb3c560bf36fe4ec0e60c035b5f8f71c7027c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692029
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682763}

This reverts commit bfca9d67.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 682731 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmY2E5ZDY3NWM1MjQ4NDNiOGJiNmEwZDAxNGUyOWQ0ZDY4NTkwNTYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-archive-rel/3468

Sample Failed Step: compile

Original change's description:
> Remove references to MessagePump::Type
> 
> It is going away soon, replace with the real thing: MessagePumpType
> 
> Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).
> 
> This is a mechanical change that will be reviewed according to
> https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes
> 
> Bug: 891670
> TBR=gab@chromium.org
> 
> Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058
> Commit-Queue: Carlos Caballero <carlscab@google.com>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682731}


Change-Id: Idf6e0f69a07267d3a322c700882d2b3f65dcf021
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729553
Cr-Commit-Position: refs/heads/master@{#682762}

-SetPlaceholderText, GetInvalid, SetSelectedRange, and GetAccessibleName

Bug: 979037
Change-Id: I0a8430aa85cddc6543345869ca7c0fe47d3cc7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680918Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#682761}

BUG=NONE
R=haraken@chromium.org

Change-Id: I07e5d3c33561fb9075846b9e4be416e195f6f169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729390
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682760}

This reverts commit e9ddea61.

Reason for revert: AppWindowBrowserTest.ShouldShowStaleContentOnEviction is flaky.
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEFwcFdpbmRvd0Jyb3dzZXJUZXN0LlNob3VsZFNob3dTdGFsZUNvbnRlbnRPbkV2aWN0aW9uDA

Original change's description:
> Fix evicted app windows showing as empty in overview
> 
> The Files app, as well as other apps, if they're evicted due to
> being occluded by other windows, will show as empty for a second or
> more in overview until reloaded.
> 
> This CL makes them behave the same way as browser windows, that is
> they show stale contents until reloaded.
> 
> BUG=986085, 866622
> TEST=Manually, follow steps on bug, and note the issue no longer shows.
> 
> Change-Id: If9a2b26b914fe55672d15d4b560cbe6d7e996591
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711843
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682390}

TBR=sky@chromium.org,kenrb@chromium.org,lazyboy@chromium.org,rockot@google.com,afakhry@chromium.org,kylechar@chromium.org

Change-Id: I7772e1ab6134a02d2cd6ad1d312623b424339693
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986085, 866622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729511Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682759}

This change checks for network presence before doing an update check.
This prevents for unnecessary tries and time outs when the device wakes
up in response to a scheduled update check policy and the policy server
is queried incessantly without any network being associated immediately.

BUG=924762
TEST=Unit tests.

Change-Id: I28ce4bd1be306d52e8561238da63421d725b6869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722152
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682758}

This reverts commit 6053bbb2.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> IndexedDB: Refactor AddCursorBinding into CreateCursorBinding
> 
> As part of cleanup from CL https://crrev.com/c/1626660, this CL
> moves creation of CursorImpl into IndexedDBDispatcherHost by
> refactoring AddCursorBinding into CreateCursorBinding.
> 
> As a result, the OpenCursor calling path no longer needs to pass
> the origin and sequenced task runner into the OpenCursorOperation
> task and ownership of CursorImpl and the mojo binding steps is
> made simpler.
> 
> Bug: 988868
> Change-Id: Iab0be1d24d98fc6b0088d01c67c1b778c5c13318
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725318
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Commit-Queue: Chase Phillips <cmp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682428}

TBR=cmp@chromium.org,dmurph@chromium.org

Change-Id: Ibb40173fcc8941794663af59ec4beee48d073cf3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 988868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729552Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682757}

Bug: 988056
Change-Id: Ib35a813214ef429213f2c05cccc6d62a63f7ecbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725256Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#682756}

This CL enhances the chrome://omnibox batch export data to include
variation and path info provided by VersionHandler.  It also cleans up
the use of private |loadTimeData.data_| by using |getValue| with an
explicit selection of relevant fields.

Bug: 964528
Change-Id: I531a001cdf2e4985b82b206fc52fcad28b0e05ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725551
Auto-Submit: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682755}

R=jbudorick, dpranke, tikuta, agable

Change-Id: Ia2a8f2965781fc2d71f14f3142f6e8e155d49dc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728038Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682754}

The GetPageFromScrollView() utility function in TabGridViewController
computes a TabGridPage value (an enum in the range 0..2) by dividing the
scroll view offset by its page width and then lround()ing. This can, it
turns out, produce values outside of the 0..2 range, which is not caught
at runtime.

This causes problems because the currentPageViewController property getter
uses a switch() based on a TabGridPage value. Because the switch is over
an enum, there's no default case. But because this enum is just a typedef
for an int, there's no guarantees that all enum values are valid. When a
TabGridPage value of, say, 3 (or MAXINT, or whatever) is set for
_currentPage, none of the switch cases in currentPageViewController are
hit, so it doesn't set a return value. This means that at runtime the
return value is random memory, which means crashes of various kinds.

This CL is the quick fix: it clamps the value of the page computation to
the defined range of the TabGridPage typedef. This is suitable for merging
into release.

The better fix, which is to change TabGridPage to an enum class and stop
inferring discrete values using just arithmetic, will be in a follow-up
CL, which will probably touch too much code for convenient merging, but
which can land on trunk for future releases.

Bug: 979683
Change-Id: If817d6c6ca0e657d5a49efbc2169601e44b29bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728882Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682753}

Follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1686776/14/base/test/scoped_task_environment.cc#617

R=fdoray@chromium.org

Bug: 946657
Change-Id: I4ecd1d60fff528d059ec21886908ba90e92fd618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693302
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682752}

Show the large cursor accessibility feature only if one of the following
conditions have meet :
-Its not being controlled by any policy
-Its being controlled by a policy and the value of the policy is force on

Bug: 552439
Change-Id: I15cbb7c6efb7261f93a16e84e173e5faf13d355f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718968Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#682751}

This CL renames mojo to mojom and *_struct_traits.* to
*_mojom_traits.* in //chrome/common/media_router.

*_struct_traits.* => *_mojom_traits.*
chrome/common/media_router/mojo => chrome/common/media_router/mojom

Bug: 806965
Change-Id: I26c8131e9a7bd2de4d073dd17471d23304da3d40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726992
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682750}

Split cache: Verify that split cache works with prefetch with kAppendFrameOriginToNetworkIsolationKey

Bug: 951810
Change-Id: Ic849b403f534d72daca6e65d0df2b29ea1777cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726791Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682749}

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: If572e29ad5e6bd87c4d6c9de445e9edea09f8416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729329
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682748}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf1198869aba..80dc3d15d3e3


Created with:
  gclient setdep -r src-internal@80dc3d15d3e3

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ie4be52319402e7ba98d41b77cea717b9b86dda36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729310Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682747}

Using wpt-import in Chromium df2ed4af.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
55d429a7 "CSS: WPT for font-variation-settings parsing"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
guidou@chromium.org, armax@chromium.org:
  external/wpt/mediacapture-streams
mstensho@chromium.org:
  external/wpt/css/css-multicol
rijubrata.bhaumik@intel.com:
  external/wpt/html-media-capture

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I7b0e19d4698af96fcc83d2f2f0ff360110894095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728213Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682746}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=knollr@chromium.org

Bug: 968047
Change-Id: I6c06f32b24ff208b5020f45f70b3c09d08fd9881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728558
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682745}

Bug: None
Change-Id: I19aaad53c0c6aad79b538005882197fa53387cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703587Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682744}

Bug: 969558
Change-Id: I6b6457c4203c3d2b849f10d85e1ec2b3912ae0cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726762Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682743}

The new value for the case when PCR0 is in a wrong state is added. The
implementation of ChromeOS side is done in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1724372

Bug: b:127321828
Test: None
Change-Id: I58f0e7daf24560f56295d369c9e766f7188a0491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729159Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682742}

https://android.googlesource.com/platform/external/perfetto.git/+log/ccb430fd4ebb..e2248cbc238c


git log ccb430fd4ebb..e2248cbc238c --date=short --no-merges --format='%ad %ae %s'
2019-07-31 taylori@google.com Merge "perfetto-ui: Fix sidebar"


Created with:
  gclient setdep -r src/third_party/perfetto@e2248cbc238c

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I7d95d09ff030635a74b5638bcb89b4bd3f0595cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728312Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682741}

In some cases null items could be committed.
For example if two navigations are pending at the same time:
1. Both navigations start
2. Second navigation is hitting "LoadRequest", resetting the pending
   item.
3. First navigation commit, the "pending item" (which is null) is
   committed.

This CL prevents this.

Bug: 979569
Change-Id: I504a0a9d9186cf276a9210167d724de2c7c4bbad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725642Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682740}

The primary goal of this CL is to use IsA<HTMLBaseElement>(element) in
place of IsHTMLBaseElement(element)

Bug: 891908
Change-Id: I7ba795ddbf3a0650a0ca212066d53328559d1e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728537Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#682739}

This fixes a bug with the chevron alignment and also a bug where the last (rather than the first) complete item was preselected in some cases.

Screenshot after change (chevron in payment method is now vertically centered): https://screenshot.googleplex.com/buOn4neaRxZ.png

Bug: b/138643986
Bug: b/138643669
Change-Id: Idf61e667a5290a2314d3d95d62f45cab9e0e0bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729227
Auto-Submit: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682738}

Also disables more affected context menu tests.

Bug: 989550
Change-Id: I9963e6c6dc44f0e255a689c83a878d6db610f342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728539
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682737}

Change-Id: Ie0e5103e4c952ef65110855de248e80a5a54468a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725254Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Xiang Ji <jxiang@google.com>
Cr-Commit-Position: refs/heads/master@{#682736}

In its current implementation, IsSyncEnable() does not cover by default the case where sync is in the "paused" state where it will return true when sync is "paused".

Considering that we don't want demographics to be provided when sync is "paused", we need to add an explicit check for the "paused" state before providing demographics.

Bug: 988825
Change-Id: Ic62a2a6a43468ad3980d7d1fc0e127ba6241579e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724638
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682735}

This avoids setting it when the new entry ownership is not actually transferred
to the caller, hence avoiding double-Closes with perfectly reasonable code like
LegacyCacheStorageCache::QueryCacheContext destructor.

(I am probably going to refactor this issue away next week, but that's not
 for M77).

Bug: 987782, 976206, 982033
Change-Id: I056d238bf8e1a5083f48034318b131fc6acb79e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721109
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682734}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I5d63f8738bf2034ff93c33e446c011938ef61344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729050Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682733}

kMediaStreamSourceTab, kMediaStreamSourceScreen,
kMediaStreamSourceDesktop and kMediaStreamSourceSystem were
declared to be exported from both blink_platform.dll and
blink_common.dll. In some build configurations that
inconsistency caused build errors:

In file included from third_party/blink/renderer/platform/mediastream/media_stream_center.cc:42:
In file included from third_party/blink/renderer/platform/mediastream/media_stream_descriptor.h:37:
In file included from third_party/blink/renderer/platform/mediastream/media_stream_source.h:39:
In file included from third_party/blink/public/platform/modules/mediastream/web_platform_media_stream_source.h:9:
../..\third_party/blink/public/common/mediastream/media_stream_controls.h(17,1): error: 'dllimport' attribute ignored [-Werror,-Wignored-attributes]
BLINK_COMMON_EXPORT extern const char kMediaStreamSourceTab[];

The error is triggered by first seeing the constant with a
declspec(dllexport) (expanded from BLINK_PLATFORM_EXPORT) and
then with a declspec(dllimport) (expanded from
BLINK_COMMON_EXPORT).

Since common can't depend on platform, the constants need to be
in blink_common.dll so this moves them there.

This is only an issue in Windows component builds.

Bug: 704136
Change-Id: I4bcd6c5b29e534ecfc3ffef908a095b2d33f3a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729251Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#682732}

It is going away soon, replace with the real thing: MessagePumpType

Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h).

This is a mechanical change that will be reviewed according to
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes

Bug: 891670
TBR=gab@chromium.org

Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682731}

This was my intention before, but was buggy :(.

Change-Id: I307d13e9a30ee021a5943bc085961281b1d83421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727772
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682730}

https://webrtc.googlesource.com/src.git/+log/6acb069c2c13..97e015fa8e5a


git log 6acb069c2c13..97e015fa8e5a --date=short --no-merges --format='%ad %ae %s'
2019-07-31 titovartem@webrtc.org Update metrics units for better fit in DefaultVideoQualityAnalyzer
2019-07-31 sprang@webrtc.org Fix potential crash if nack is being processed when media gets disabled
2019-07-31 titovartem@webrtc.org Remove dead code from DefaultVideoQualityAnalyzer
2019-07-31 kron@webrtc.org Use total_decode_time_ms in VideoAnalyzer


Created with:
  gclient setdep -r src/third_party/webrtc@97e015fa8e5a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:b/138636698,chromium:980853
Change-Id: Ifee9f86ef83e24164453e3575c16c9104975dd96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729309Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682729}

Change-Id: I0fad75959c29514e06083bffab9d05a0952d3ed3
Bug: 824840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728310
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682728}

Background: The chrome.loginScreenUi extension API can open windows while
in the ChromeOS signin screen. The API uses a views::WebDialogView to
show the window. One of the parameters of the API sets whether the window
can be closed by the user. Currently, setting the parameter to false
prevents the user from closing the window, but the close button is still
interactive (animates when hovered and when pressed).

ash::NonClientFrameViewAsh and DefaultCaptionButtonModel treats the close
button as always visible and always enabled. This CL changes
FrameCaptionButtonContainerView to not show the close button depending on
views::WidgetDelegate::ShouldShowCloseButton().

In addition, this CL also makes the LoginScreenExtensionUi window not
draggable.

BUG=985754

Change-Id: I191cfad13aeb2764fecaa8867cf344a16aeb0e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709586
Commit-Queue: Jit Yao Yap <jityao@google.com>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682727}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=davidben@chromium.org

Bug: 968047
Change-Id: Ibcfcb0491d7c78c55f2c5ea250b94f276293cd4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728881
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682726}