GitLab

With recent fixes of myself, this test now succeeds.

BUG=890071
TEST=none
R=sky@chromium.org

Change-Id: I73e8918771225d9855cbf6299d3c852476adf707
Reviewed-on: https://chromium-review.googlesource.com/c/1305194Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603549}

Matches what we do in SVGIntegerOptionalInteger::CalculateAnimatedValue,
and avoids undefined overflow.

Bug: 899445
Change-Id: I1250a05482713780f707301ed29e015fd81e65f2
Reviewed-on: https://chromium-review.googlesource.com/c/1304483Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#603548}

Make sure to retain a ref to the ContextProvider so that it gets
destroyed on the thread it is bound on.

BUG=898842

Change-Id: Iefcab772acb4cf530ff4a3e7c64e9b66e35b3f4e
Reviewed-on: https://chromium-review.googlesource.com/c/1304068Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603547}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d2036a9f..ca9994a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibf5f71746c2f689b06c51cf23c1d61e378163879
Reviewed-on: https://chromium-review.googlesource.com/c/1304933Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603546}

This reverts commit 0a8ce562.

Reason for revert: crbug/899732

Original change's description:
> Reland "[vr] On-demand install VR dynamic feature module"
> 
> This is a reland of 0275d360 with a fix
> for x86 builders, which have VR disabled.
> 
> Original change's description:
> > [vr] On-demand install VR dynamic feature module
> >
> > With this CL we initate the module install once the user enters VR on a
> > WebXR/VR page. In more detail this CL
> >
> > - Introduces native VrModuleDelegate used to request VR module from
> >   native,
> >
> > - Refactors GvrDevice to request the VR module as part of its
> >   initialization flow,
> >
> > - Adds native side of the VrModuleProvider for Java-native
> >   communication.
> >
> > Bug: 862689
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1241458
> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > Reviewed-by: Bill Orr <billorr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602922}
> 
> TBR=tedchoc@chromium.org,billorr@chromium.org
> 
> Bug: 862689
> Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/c/1301568
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603100}

TBR=tedchoc@chromium.org,billorr@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862689, 899732
Change-Id: I89de56edc6c300955534a701deb92178cf50683e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1305093Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603545}

This is a reland of 01ccf727

Original change's description:
> Enable the pixel by pixel comparison test for Mac OS.
> 
> 1. Tested on Mac and verify everything works as expected.
> 2. Removed the unnecessary call of GetNativeWindow().
> 
> Change-Id: I377e6bfb004548887b9623b0094da91fa36b4d1c
> Reviewed-on: https://chromium-review.googlesource.com/c/1279301
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601879}

Change-Id: Ib6fa1c1d9b3487c88b240ea9262042db8af0c19a
Reviewed-on: https://chromium-review.googlesource.com/c/1296811Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603544}

android_blink_rel has not been migrated to LUCI so we still need to
accept and parse BuildBot URLs in git_cl when fetching try job results.

Bug: 891729
Change-Id: I758feb57cb01ced6cd20644c9508fe77bec0dd3d
Reviewed-on: https://chromium-review.googlesource.com/c/1303758Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603543}

Bug: 821237
Change-Id: I31947ac62a27ccf140630474560a38f883f73bcf
Reviewed-on: https://chromium-review.googlesource.com/c/1300098Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603542}

Sending the experiment is controlled by a Finch experiment.

Bug: b:117847982
Test: Manual
Change-Id: I542a131d931254d610c8acaf5bc0f116b4d19b60
Reviewed-on: https://chromium-review.googlesource.com/c/1291355Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Eyor Alemayehu <eyor@google.com>
Cr-Commit-Position: refs/heads/master@{#603541}

../..\base/bind_internal.h(415,8):  error: redefinition of 'FunctorTraits<R (*)(Args...) __attribute__((stdcall))>'

Bug: 893460
Change-Id: I370eb3d4cebf3171fb143cba9b022696c5a1ebb2
Reviewed-on: https://chromium-review.googlesource.com/c/1298831
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603540}

This patch restricts the number of exposed methods for modifying the
visible state of the omnibox suggestions. Most of this logic is now
driven off of the focused state of the omnibox (via
UrlFocusChangeListener) and whether suggestions are available.

Change-Id: I2dad7eda0331f7e69ad49ebb9c89f71748f4bd6b
Reviewed-on: https://chromium-review.googlesource.com/c/1293991
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603539}

Use local variable to store value of DOM element to avoid modifying DOM, which
may cause potential danger to event-based frontend frameworks.

Bug: 433824
Change-Id: Ie7d3a9d67483738e66730a794ba798c81d515e4e
Reviewed-on: https://chromium-review.googlesource.com/c/1303729Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603538}

This CL re-enables a previously flaky test on Windows. The underlying
cause has been fixed so let's give it a try if it stops flaking.

Bug: 434438
Change-Id: I09a85811db998960711586007005853ca4bb5499
Reviewed-on: https://chromium-review.googlesource.com/c/1304475Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603537}

Consider the following example:

.ripple {
  animation: ripple 1s;
  background: paint(ripple-painter);
}
@keyframes ripple {
  0% {
    --ripple: 0;
  }
  100% {
    --ripple: 1;
  }
}

Assuming --ripple is registered as a number-valued variable, we would like to be able to animate this paint worklet off of the main thread. This change guards against potential jank between the compositor and main thread if other properties depend on the variable.  For example, we want to block compositing in the following case:

.ripple {
  animation: ripple 1s;
  background: paint(ripple-painter);
  opacity: var(--ripple);
}

This patch is conservative in that it does not check which variable is being referenced.  Erring on the side of caution to minimize performance impact. Note that off-thread paint worklets are implemented behind a flag.



Change-Id: Ied3e0f10ba055f9fb830aa886478b5d13de187d5
Reviewed-on: https://chromium-review.googlesource.com/c/1271876
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603536}

The QueueingTimeEstimator had a flag that was, effectively, a
disabled/enabled flag. Instead of naming it for the external state that
causes updates to the flag, name it for what the flag is used for inside
the QueueingTimeEstimator.

Bug: 883487
Change-Id: I73c7f71ff10fcacaf1e85a3f89f5e1a123b78896
Reviewed-on: https://chromium-review.googlesource.com/c/1296822
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603535}

We used to have a comment saying "Older versions of RC don't support the
/nologo flag", but since we've been requiring MSVC 2017 for a long time now,
using `rc /nologo` should be safe by now.

No intended behavior change.

Bug: none
Change-Id: If13d1d3fc4647daada3af5ade526e6f774a9fb7c
Reviewed-on: https://chromium-review.googlesource.com/c/1303882Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603534}

We still need the wrapper to set the env and to filter out ' Assembling: foo',
but less wrapper is probably better.

No intended behavior change.

Bug: none
Change-Id: Id8c165294cc3cf0ba7fc74f86a6a8fb9f8bfa042
Reviewed-on: https://chromium-review.googlesource.com/c/1303883Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603533}

This saves about 100 kiB on 32-bit ARM libchrome.so.

This optimization cannot be applied to libmonochrome.so, unfortunately,
because only Android P and above support these at the system linker
level.

BUG=895194
R=agrieve@chromium.org,torne@chromium.org,pasko@chromium.org,pcc@chromium.org

Change-Id: I5c554dc3dbc1b3ea27edb60579a5cc0dcdc7d759
Reviewed-on: https://chromium-review.googlesource.com/c/1304487
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603532}

- New failures:
  synthetic_gestures/animated-wheel-tiny-delta.html
  compositing/gestures/gesture-tapHighlight-with-filter.html (not spv2-specific)
- New passes:
  Mostly about composited border radiuis.

TBR=pdr@chromium.org

Change-Id: I0ffd5baf139205cd06e6ef5a388efded79ebfb44
Reviewed-on: https://chromium-review.googlesource.com/c/1305214Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603531}

In ScopedCrosSettingsTestHelper, there was one call to
CrosSettings::Get()->Set - this was just used for testing to set
any CrosSetting to a particular value.

If every call to CrosSetting::Get()->Set can be removed, that
means we can delete the entire write path in DeviceSettingsProvider,
which will make code simpler. That means all writes will be using
OwnerSettingsService, which is better because it is profile-aware.

In practise, most tests are using a StubCrosSettingsProvider,
so they don't need to use the write path of DeviceSettingsService,
or the OwnerSettingsService - they can just write it directly
to the StubCrosSettingsProvider.

This test modifies ScopedCrosSettingsTestHelper so it can also
use the StubCrosSettingsProvider when it was initialized by
CrosSettings itself. It also modifies 2 tests that were not
using a StubCrosSettingsProvider, but need to call Set, so that
now they are using a StubCrosSettingsProvider.

For more background, see go/writepath

Bug: 433840
Change-Id: I85a68d6ea116061b13f3c5e5582aa0298af1a386
Reviewed-on: https://chromium-review.googlesource.com/c/1299002Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603530}

Added thumbnail_url, favicon_url, snippet, and attribution. These are not yet
set by any code. We anticipate wanting these fields for experiments on the net
error page, and for integration with Jardin.

Change-Id: I5cd7eb0f20a82e9d6af87f2f03252de80113acbc
Reviewed-on: https://chromium-review.googlesource.com/c/1185914
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603529}

Add support for Previous/NextTrack to MediaController
and the underlying MediaSession. This will be mapped
to the previous and next track media keys on CrOS.

BUG=893296

Change-Id: I582cd70a04c24af69c80ca891a281311b4d05434
Reviewed-on: https://chromium-review.googlesource.com/c/1287268Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603528}

this allows V8 to know when we are using too much memory, which
triggers a GC.

Bug: 897733,842693
Change-Id: I74c7589ab78a753132e54d5eac3c28793580c266
Reviewed-on: https://chromium-review.googlesource.com/c/1297067
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603527}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a47db54fa15..4fea579b6e9b


Created with:
  gclient setdep -r src-internal@4fea579b6e9b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2e203966a621c22efe2ce46ff92e16a070ba73c1
Reviewed-on: https://chromium-review.googlesource.com/c/1304379Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603526}

https://webrtc.googlesource.com/src.git/+log/72864963fe62..12048c71501a


git log 72864963fe62..12048c71501a --date=short --no-merges --format='%ad %ae %s'
2018-10-29 nisse@webrtc.org Fix error handling in hex_decode.
2018-10-29 srte@webrtc.org Adds GetSentPacket to PacketResult.
2018-10-29 srte@webrtc.org Adds unit tests for safe reset trial.


Created with:
  gclient setdep -r src/third_party/webrtc@12048c71501a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I510e1a5040ff75129c0280a63e569f82e8aa5671
Reviewed-on: https://chromium-review.googlesource.com/c/1304913Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603525}

Supporting RELR relocations, as described in [1] has the potential
to drastically reduce the size of native libraries, while speeding
up loading time (see related bug for details).

This CL adds support for RELR relocations to the crazy linker.
Note that this supports both the Android-specific dynamic table
entries, and the default ones supported by lld.

Note that this only modifies the linker. Another CL is required
to enable RELR relocations when building native libraries for
Chrome.

[1] https://reviews.llvm.org/D48247

BUG=895194
R=pasko@chromium.org, agrieve@chromium.org, torne@chromium.org, pcc@chromium.org

Change-Id: Ia074a2228ac7a81418fe706be6e7e57274ae18a0
Reviewed-on: https://chromium-review.googlesource.com/c/1304484
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603524}

This CL changes help context string introduced by
https://crrev.com/c/1299133 for "?" button in "Sync and Google services"
settings page.

Bug: 885333
Change-Id: Ibe24f7f85ad4080dea0eae55efeb7810cb026430
Reviewed-on: https://chromium-review.googlesource.com/c/1304555Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603523}

There are two paths to unminimize/restoring a window:
. Implicitly by calling Show()/Activate(). In this scenario the expectation
  is the Widget returns to it's pre-minimized state.
  DesktopWindowTreeHostMus does *not* cache the pre-minimized state, only
  the server knows it. While waiting for the server to change the show state
  it's important IsMinimized() returns false. To deal with this an observer is
  added to wait for the show state to change.
. By calling Restore(). Restore sets the state to normal, circumventing
  the pre-minimized state in the server. This mirrors what NativeWidgetAura
  does.

BUG=883523
TEST=covered by tests

Change-Id: I79a89a419032f125d905a98a01fe906c7ca82efd
Reviewed-on: https://chromium-review.googlesource.com/c/1299913
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603522}

https://skia.googlesource.com/skia.git/+log/1de48d8040aa..68825776f4b4


git log 1de48d8040aa..68825776f4b4 --date=short --no-merges --format='%ad %ae %s'
2018-10-29 scroggo@google.com Ensure fSrcOffsetUnits is in a valid range


Created with:
  gclient setdep -r src/third_party/skia@68825776f4b4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@chromium.org

Change-Id: I887b448660937455876202987a3259b1d6210613
Reviewed-on: https://chromium-review.googlesource.com/c/1304754Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603521}

Change-Id: Ia488b3c8194eaf39dc46c14745a0eda9bedb66cd
Reviewed-on: https://chromium-review.googlesource.com/c/1303357Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603520}

When typing into the omnibox, accessibility/automation dispatches the following events:
<type 'w'>
event: selection (on the listBoxOption)
<type 'w' again>
event: ariaAttributeChanged (on the listBoxOption)
...
<type down arrow>
event: selection (on the new listBoxOption)

This change:
- introduces a delayed output of 1500ms for the ariaAttributeChanged
- only does this when the target of the change is itself or anancestor, controlledBy some other control
- ensures to clear previous such delayed outputs

Test: manual
Change-Id: I0bdead3d62b949f924f817fc86a7a6c28dce18d0
Reviewed-on: https://chromium-review.googlesource.com/c/1302320Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603519}

|composing_text_| of InputConnectionImpl should be cleared after
CommitText() is called. Otherwise, FinishComposingText() will commit the
same text twice.

Bug: 899736
Test: unit_tests
Change-Id: Idb22d968ffe95d946789fbe62454e8e79cb0b384
Reviewed-on: https://chromium-review.googlesource.com/c/1304773
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603518}

Bug: 791632
Change-Id: I2feff44cf4f875e064bc701fc7f74bf84811e3c8
Reviewed-on: https://chromium-review.googlesource.com/c/1304058Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603517}

Stop inheriting from it and instead use the two classes separately, with
PostMessageServiceConnection abstracted out of PostMessageHandler behind
the PostMessageBackend interface added in change 1299016.

This means we now store a PostMessageServiceConnection in SessionParams
and call to it instead of PostMessageHandler for behaviour relating to
the service connection.

The result of this change is that PostMessageHandler can be used without
a service connection, allowing us to use it directly from CustomTabActivity
in a future CL.

Bug: 898840
Change-Id: Ifd06ee0a803ecd82c350d7b5466bf0a0ee35440b
Reviewed-on: https://chromium-review.googlesource.com/c/1299143
Commit-Queue: David Barker <barkerd@google.com>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603516}

R=mstensho@chromium.org,eae@chromium.org

Change-Id: Ie77e1b604828e853f8432759d1fa726ce180b00b
Reviewed-on: https://chromium-review.googlesource.com/c/1303886Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603515}

in https://chromium-review.googlesource.com/c/chromium/src/+/1302854.

TBR: grunell@chromium.org
Change-Id: Ia08618acf4aadf8111f4acb55f6cbfdd69b0222b
Reviewed-on: https://chromium-review.googlesource.com/c/1304976Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603514}

Before this change, the credentials sent with the RPCs come from chrome
signed in.

With this change, the credentials that are sent are those specified
explicitly in the Intent, regardless of chrome's sign-in state. This
only works on Android.

This change leaves a fallback getting credentials from chrome sign in to
keep the old behavior in case where the Intent doesn't specify anything.

Bug: 806868
Change-Id: Id098c33dd4fa5c10050d3c4784ced7b67ed282cf
Reviewed-on: https://chromium-review.googlesource.com/c/1297974
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603513}

Change the address validation logic according to this doc:
(Solution 6)
go/autofill-validation-dilemma

Bug: 899251
Change-Id: I93435025754106d5c61889097690288d812f5f0c
Reviewed-on: https://chromium-review.googlesource.com/c/1301797
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603512}

We had a few tests that wanted to inspect the ClientDownloadRequest,
but didn't do anything with the TestURLLoaderFactory. This led to the
test waiting for 7 seconds, until the timeout kicks in. This CL adds
calls to PrepareResponse, to mock out the network response, so that
we no longer wait for a timeout. All unit tests under
DownloadProtectionServiceTest now take <1s, with the worst around 200ms.

Bug: 896796
Change-Id: I1c8f24c962fbb5d13e2a86ecfda6f80c1d19d1f4
Reviewed-on: https://chromium-review.googlesource.com/c/1299502Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603511}

Replaces https://crrev.com/c/1280277

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iad5a713243dab998a1a202602a90eb06df0b603d
Reviewed-on: https://chromium-review.googlesource.com/c/1283131Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603510}