- 18 Apr, 2018 40 commits
-
-
Devlin Cronin authored
A crash could occur in ExternalInstallManager if an extension was unacknowledged (and thus in ExternalInstallManager::unacknowledged_ids_), had reached the maximum number of prompts (3), and hadn't had an error shown for it during the session. If this happened, the entry would remain in unacknowledged_ids_ and the extension wouldn't have an entry in shown_ids_, so that if the extension later became loaded (or another external extension was installed), the extension would no longer be present in disabled extensions in the registry. This caused a failed CHECK() in ExternalInstallManager::UpdateExternalExtensionAlert(). Fix this case by properly erasing the entry from unacknowledged_ids_ when the extension reaches the prompt count. Add a unittest to cover the case. Bug: 736292 Change-Id: If7cbf87e3a757e66930c0cfda40ed229a2e37166 Reviewed-on: https://chromium-review.googlesource.com/1012491Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551772}
-
Devlin Cronin authored
Update ExtensionTabsTest to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib718a2169cf42c81f640780884d9a824eca63534 Reviewed-on: https://chromium-review.googlesource.com/1014716Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551771}
-
liberato@chromium.org authored
Bug: 805669 Change-Id: Ibd40c7bde9f913cd3ed75f4c0aa67880716eafbe Reviewed-on: https://chromium-review.googlesource.com/1017309Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551770}
-
https://chromium.googlesource.com/catapult.git/+log/a903f96d720c..a4264f97124c $ git log a903f96d7..a4264f971 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 nednguyen Remove PGO profiler Created with: roll-dep src/third_party/catapult BUG=chromium:713328 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I2865ddcff394972b702a750fc2fc22c54611adbf Reviewed-on: https://chromium-review.googlesource.com/1017223Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551769}
-
Koji Ishii authored
Following the CL:916262 that allowed zero-width layout opportunities, this patch allows negative-width layout opportunities (e.g., 120%-width floats.) Zero-width lines (<br> only) can fit into such opportunities. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I66cf214732a0618500f2422a285282deda4f7eb3 Reviewed-on: https://chromium-review.googlesource.com/870950 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551768}
-
David Tseng authored
Sometimes, we get inline text boxes containing only whitespace in the middle or end of a line. This is typically fine if the whitespace is the only text. However, there are situations where we want this whitespace not to be queued. When there is non-whitespace text in the line: inLineTextBox: "this is a soft-wrap" inLineTextBox.nextOnLine: " " inLineTextBox: "of text" becomes (for the first line): "this is a soft-wrap", "space" inlineTextBox: "this" inLineTextBox.nextOnLine: " " inLineTextBox.nextOnLine.nextOnLine: "is" becomes "this", "space", "is" Test: manual. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If8524c90f4187704bbf1dcfb5580e5697eedeccf Reviewed-on: https://chromium-review.googlesource.com/1015657Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#551767}
-
Benjamin Pastene authored
Bug: 833632 Change-Id: I06da0333072b85b1b00f7954f008d39fe3689306 Reviewed-on: https://chromium-review.googlesource.com/1014639Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#551766}
-
Kevin Bailey authored
Currently we only attempt to convert history provider suggestions to tab switch suggestions. This change moves the code to autocomplete result and calls it from the controller after settling on the best matches. Also moves the unit test. Bug: 780835 Change-Id: Ide8e7998911455766b8157d6dcbf8d65d32fd179 Reviewed-on: https://chromium-review.googlesource.com/1007482 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551765}
-
Mohsen Izadi authored
In OOP-D, there are situations that the GPU (Viz) process is run, but no GL should be initialized (when both hardware acceleration and SwiftShader are disabled). A new "disabled" value is added to --use-gl flag to convey this to the GPU process and prevent unnecessary GL initialization. BUG=799478 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3a42ab0f72b10e9b2a7b231673ace81adef3847b Reviewed-on: https://chromium-review.googlesource.com/1014250 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551764}
-
https://skia.googlesource.com/skia.git/+log/2f54f2c31572..366fc2475261 $ git log 2f54f2c31..366fc2475 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 angle-skia-autoroll Roll third_party/externals/angle2/ c90d4d38c..5804dc8ea (2 commits) 2018-04-18 herb Simplify strike cache Node 2018-04-18 egdaniel Remove persp_shader gms from DDL blacklist Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I797d90b04da211a8686aa03ead9284902f4f9b07 Reviewed-on: https://chromium-review.googlesource.com/1017226Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551763}
-
Peter Boström authored
This adds profile icons to the toolbar avatar button that is available under Material refresh. These icons are a visible badging of the current user. It also enlarges the avatar icon to 20 dips matching the avatar menu. 16 dips was very cramped here for several built-in avatar icons as well as profile pictures. Bug: chromium:822070 Change-Id: I195fc161639cf31479bc20440b37a2eb1c3039e3 Reviewed-on: https://chromium-review.googlesource.com/1015795Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551762}
-
Sergey Poromov authored
This function was extracting domain from username in PolicyData which could be not up-to-date after domain rename. It's better to get rid of as much |username| usages as possible. BUG=780792 TEST=Trybots Change-Id: I6aba952cb63d4450863ac7f3ee30c18a3a9830d1 Reviewed-on: https://chromium-review.googlesource.com/1017122Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551761}
-
Dmitry Skiba authored
MemoryPressureMonitor is supposed to be called only from UI thread (as defined by ThreadUtils), but was called from a binder thread by ChildProcessService$1.onMemoryPressure (see the bug). The issue was introduced because MemoryPressureMonitor.notifyPressure() is an exception from MemoryPressureMonitor "UI thread only" rule, and can be called from any thread. When onMemoryPressure() was initially added, it had just a single notifyPressure() call, so no posting to UI thread was necessary. Later getLastReportedPressure() call was added, but issue with calling it on non-UI thread was overlooked. This CL fixes the original issue, and also removes notifyPressure() special case, avoiding similar threading mistakes in the future. Bug: 834099 Change-Id: Idc5cc478eac217f2c49d642187677e9bf7a5309f Reviewed-on: https://chromium-review.googlesource.com/1016095Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#551760}
-
Hongchan Choi authored
A follow up CL from: https://chromium-review.googlesource.com/c/chromium/src/+/1015201 Bug: 833766 Change-Id: Iaabea9e2801a43257871eeee2013e91fdb0f3d20 Reviewed-on: https://chromium-review.googlesource.com/1017003Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551759}
-
Leonard Grey authored
This is literally a copy and paste job from native_widget_aura. I'd like to push this logic down into NativeWidgetPrivate but DesktopNativeWidgetAura also subclasses it and seems to do its own thing, so I'm open to suggestions on how to best deduplicate. Bug: 1015514 Change-Id: Ib3bb2c6507190802ce540d3bcde9526ec9239bdf Reviewed-on: https://chromium-review.googlesource.com/1015515Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551758}
-
Matt Falkenhagen authored
r550158 introduced a regression when NetworkService/S13nServiceWorker is enabled, because it hops to the IO thread during the start worker sequence in order to support service worker interception. When two clients call `new SharedWorker(url)` at the same time, the expectation is that only one worker thread is started, and the clients share the worker. But there was a race where the first request is on the IO thread when the second request starts, and the second request doesn't know the first request is happening, resulting in the creation of two workers. The fix is to create SharedWorkerHost on the UI thread before hopping to the IO thread, so the second request will notice the host and use it instead of creating a new one. This deflakes http/tests/workers/shared-worker-shared.html when run with the NetworkService flag. Change-Id: Ib4d189c454fc3cdab941af00596b799e2f6dc172 Bug: 830288 Reviewed-on: https://chromium-review.googlesource.com/1013440 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#551757}
-
Robert Ogden authored
See bug. Bug: 831014 Change-Id: I56562109dc185066f7c4c77713f111f910522bdc Reviewed-on: https://chromium-review.googlesource.com/1015961Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#551756}
-
Dirk Pranke authored
This makes mini_installer_tests non-experimental and adds them to the CQ on win10_chromium_x64_rel_ng. R=grt@chromium.org, mmeade@chromium.org, sergeyberezin@chromium.org BUG=827546 Change-Id: I742d7003dd706949ee73e8e4febaa91b52a52bf8 Reviewed-on: https://chromium-review.googlesource.com/1013269Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551755}
-
Elly Fong-Jones authored
Bug: None Change-Id: I7784a086e35d170299d3b38119b050f8eb3615f0 Reviewed-on: https://chromium-review.googlesource.com/1016674Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551754}
-
Matt Menke authored
Previously, they were passed through unaltered, which was rather unexpected. We could error out requests instead, but erroring out after successfully decoding the response body seems likely to lead to more compatibility issues than fix anything. Bug: 833729 Change-Id: I7e0948aa4d3b963f27f4c954d9576b89e963fffb Reviewed-on: https://chromium-review.googlesource.com/1015516Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551753}
-
Marc Treib authored
This changes ScreenlockPrivateApiTest to use the new IdentityManager instead of the old SigninManager. Bug: 825190, 797952 Change-Id: I96aadde12111f4dc3abf5fec9657b72bdd86cede Reviewed-on: https://chromium-review.googlesource.com/1016302Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551752}
-
https://webrtc.googlesource.com/src.git/+log/31ef5f0d1bea..8619e8a3d785 $ git log 31ef5f0d1..8619e8a3d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2fa976d1d54ba47d180a81296ae3741b846c77ad Reviewed-on: https://chromium-review.googlesource.com/1017017Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551751}
-
Ned Nguyen authored
Bug: 832367 Change-Id: Ibf6b3a7291f137e64e47ec382fcf0cfa7230243f Reviewed-on: https://chromium-review.googlesource.com/1015161Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#551750}
-
Devlin Cronin authored
Update ExtensionManagementApiTest to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I0448ee64cbde9ed8431c30090d1f109e6d655fce Reviewed-on: https://chromium-review.googlesource.com/1014711Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551749}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/84ba9179592f..4e29b62239da $ git log 84ba91795..4e29b6223 --date=short --no-merges --format='%ad %ae %s' 2018-02-05 yhong cros_sdk: Resolve the tarball URL only if --download is specified. Created with: roll-dep src/third_party/chromite BUG=chromium:795449 of sorts The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id1c7addda62e3e83c01222aa4d29ac679fffa851 Reviewed-on: https://chromium-review.googlesource.com/1017222Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551748}
-
Nico Weber authored
Bug: 820422 Change-Id: I9d621e09536828a40b09cb369380ac57f4e6f023 Reviewed-on: https://chromium-review.googlesource.com/1016667Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551747}
-
Mythri Alle authored
CodeCacheAfterExecute feature was added to setup a finch trial for the new v8 code caching mechanism. Now, the feature is enabled by default and hence removing this feature. Bug: 783124 Change-Id: I3e59c9a17b72a4201d8b74dc230988dfc7cbf96d Reviewed-on: https://chromium-review.googlesource.com/1012115Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#551746}
-
Daniel Park authored
Bug: 831404 Change-Id: I1b0813135c39cfd912e34e229fe98a97d8b89df4 Reviewed-on: https://chromium-review.googlesource.com/1010417Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551745}
-
khmel@google.com authored
This removes non-md resources due MD is forced now. Test: Manually Bug: 834002 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2af89f20efc69f971c6b5d34ffe9759d4818f90 Reviewed-on: https://chromium-review.googlesource.com/1015659Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#551744}
-
John Z Wu authored
//ios/web_view needs this API for showing a list of cards and updating and deleting cards. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I429e9f6dd544ea80cb1b443891de6b8f8d777ed0 Reviewed-on: https://chromium-review.googlesource.com/1013300 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#551743}
-
Eugene But authored
This histogram is logged when Download is complete with true if Install Drive promo was presented. Bug=832329 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I82e8cfe84c2cc1b10cd2a522d1dc0a02a7c852b9 Reviewed-on: https://chromium-review.googlesource.com/1011415Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#551742}
-
Jun Choi authored
|is_success| parameter in FidoHidDevice::MessageReceived() can be represented by nullptr |message| parameter. Bug: 828088 Change-Id: Ia13439acc98f43af1741308063ac7c2ab1b62af9 Reviewed-on: https://chromium-review.googlesource.com/1014655Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551741}
-
chaopeng authored
Before this patch some calls from compositor may not realize the PLSA disposed. In this patch, we clear the pointer of scrollable area in paint layer and graphics layer and check it before calls. Bug: 813520 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia2df7d114abd1a344d24d534055fca051ad965fd Reviewed-on: https://chromium-review.googlesource.com/1000932 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551740}
-
danakj authored
R=enne@chromium.org Bug: 832726 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3e21bd4a54b82fcf7f9f07ae36cdfdb65034fe39 Reviewed-on: https://chromium-review.googlesource.com/1015820Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#551739}
-
Marek Haranczyk authored
ContentVerifierTest was setting up override but never reseting it causing other tests that loaded extension to access invalid memory of stack allocated registry override. This is regression after crrev.com/c/957645 that causes crash or timeout in extensions_unittests. Bug: 809088, 832801 Change-Id: I45d8ee2e4e450e8d5f619e502e7a6e96c8879ef0 Reviewed-on: https://chromium-review.googlesource.com/1013982 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#551738}
-
btolsch authored
This change attempts to address some Mac CWInterface crashes. Although CWInterface's interfaceWithName was deprecated in 10.10, these crashes don't appear to be a result of that (especially since there is one other use of the API in Chromium that isn't experiencing any crashes). This change adds a check on the interface name before calling interfaceWithName to ensure it is only called on Wifi interfaces. Bug: 827944 Change-Id: I2775bc7c3b26a015c1893b3ba56a13f66f3d5ead Reviewed-on: https://chromium-review.googlesource.com/1016068Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#551737}
-
Brian White authored
This is placed in big letters at the top of the file to have a chance of being noticed by someone when their editor opens before moving down to find the entry they want to change. Change-Id: I204d14138dc508a640ced8c17008c8ae95c1bdb7 Reviewed-on: https://chromium-review.googlesource.com/1015787Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#551736}
-
Marc Treib authored
IdentityManager is the new API that replaces the (semi-)deprecated SigninManager. Bug: 825190, 798412 Change-Id: I4bb24b0ebdf0d1d964ce4ad16aa986cc56af2fa4 Reviewed-on: https://chromium-review.googlesource.com/1016760Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551735}
-
Marc Treib authored
Mostly removing unsued includes. Also deleting the unused sync_db_util.h/cc. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idebea0d8ed82c1ddfb4707ed5517ea6e9125576f Reviewed-on: https://chromium-review.googlesource.com/1014132Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551734}
-
Greg Thompson authored
BUG=722573 R=scottmg@chromium.org Change-Id: I55d17ae0e4de6ccd5a7a674a52a9948bdafc915b Reviewed-on: https://chromium-review.googlesource.com/1016283Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#551733}
-