- 06 Nov, 2020 40 commits
-
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/7LsYDFYkkFrBUZ9 Bug: 889763 Change-Id: I918cae68beb3614f1c32374028320424897c597d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517189 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824758}
-
Alex Danilo authored
Bug: 1002410 Tests: browser_tests --gtest_filter="*saveFileDialogDefaultFilterKeyNavigation" Change-Id: I040f3cda4d4f211cafbab10d46a4506f2b7a10f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521974 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#824757}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d30f01144708..3dfaeeb00271 2020-11-06 syoussefi@chromium.org Vulkan: Don't flush deferred clears on READ framebuffer sync 2020-11-06 jmadill@chromium.org Fix trigger.py using deprecated parameters. 2020-11-06 jdarpinian@chromium.org Allow choosing EAGL or CGL at runtime 2020-11-06 jmadill@chromium.org GL: Add support for GL_OES/EXT_texture_buffer 2020-11-06 syoussefi@chromium.org Vulkan: Store image updates per level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I8dd0dfe603210079f98e9097b00375d90519e6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824756}
-
Drew Davenport authored
This could be called in mesa on some SoCs to set the affinity of the gallium thread from the main thread. BUG=b:170305550 TEST=gpu process does not crash Change-Id: I51aec065750ccbbe71c086ddd2492bc25933d3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514066Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#824755}
-
Leo Lai authored
BUG=b:158955123 TEST=unit_tests. TEST=gn check. Change-Id: I6f1d854228897fb586b7da5c508d72127d82943a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519542 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#824754}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/073820cb20af..67117aa5b601 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1133499 Tbr: peria@google.com Change-Id: Ibf643d6ab42146b5f91662983309de65ff1a13e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522680Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824753}
-
Yuki Shiino authored
Removes migration_adapter.idl because the new IDL interface's implementation landed. Bug: 839389 Change-Id: I4d5096428459fbb902bbe97b70328194356b3fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521971Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824752}
-
Dominic Mazzoni authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: Ibf1d3dd111d1a1c239aa79141905d36752805db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520076Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
-
Joel Hockey authored
I just noticed another flake in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42616. 1/ The in-progress map is changed to store a globally unique identifier so that multiple deletes across volumes cannot collide. 2/ The in-progress map was being cleared after the *.trashinfo files was written, but before the file is moved. This is now changed so that we only clear the map once the file is moved. Bug: 953310 Change-Id: I49c9c75878288f2f1a0be4447c1885a07c873bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521981 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824750}
-
David Bienvenu authored
This reverts commit 00952e6e. Reason for revert: <crbug.com/1141059> Original change's description: > Stop removing WS_THICKFRAME style on full screen. > > Also, change IsFullScreenWindowMode to not require the absence of > WS_THICKFRAME when deciding if a window is full screen. > > This issue this fixes involves the glass_browser_frame_view when > maximizing after going full screen - an extra 8 pixel bar gets drawn > above a maximized window, and if there's another monitor > above the one with chrome maximized, the bar gets drawn on > the other monitor. > > Windows doc > https://docs.microsoft.com/en-us/windows/win32/winmsg/window-styles > claims that some styles can't be changed after the window is > created, but also says that if you change frame styles, you > need to call SetWindowPos with SWP_FRAMECHANGED, which we are doing. > > Not removing the WS_THICKFRAME style doesn't seem to have any visible > effect on full screen windows. > > Bug: 1014720 > Change-Id: Ibfbd480c603fd7c3aca74081201e99e59fbbbecc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972258 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791237} TBR=pkasting@chromium.org,thakis@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014720 Change-Id: I4a35fccff45ba0994157939fe5fa95107ecb0334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522875Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824749}
-
Leo Lai authored
After using attestation client, we don't really need cryptohome and its async caller, but they are still passed to the constructor. BUG=b:158955123 TEST=unit_tests, browser_tests, chromeos_unittests. Change-Id: I984694d0ec985da3c9d21273bba9555f0aa89633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519639 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Adam Rice authored
In 2017 the HTML standard changed to no longer check the bad port list synchronously in the WebSocket constructor, instead relying on the lower-level check in Fetch to cause an asynchronous failure. Safari is now implementing this (https://github.com/web-platform-tests/wpt/pull/26392#issuecomment-722593477), so update our implementation to match. BUG=705534 Change-Id: I29c35fa2307a1215d5f382f86ca97bbfd17aba2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521874Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#824747}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604588329-6f5ba33f1a6962e1b0406a8222a4664471a1f39d.profdata to chrome-win32-master-1604609790-b9d65003227996f3e38071970a83664b74f65abb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2ef00d93f088ceca9b10eb87d28c4a42a3155653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522591Reviewed-by:
-
Nicholas Hollingum authored
Tasks are deleted on completion (even before crrev.com/c/2507234), this caused a UAF when a member-object of the AwaitBorealisStartup task was transitively deleted but its callee. The chosen solution is to post completion as a separate task rather than call it from the current completing BorealisTask, we do this is a mutually-exclusive way so that the deletion of the task is exclusively-after its completion. Bug: b/172605172 Change-Id: Iaf23e9ead37196988b24753cef451da318c48436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521876Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#824745}
-
Daniel Cheng authored
Change-Id: I4a0d6a554cbce5eecb25f6720f22d41919588a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521355Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824744}
-
Meredith Lane authored
This patch has no functional difference, it is just a refactor. It introduces a new AXNodeDataPropertyClient that is responsible for unserializing AOM properties stored on AccessibleNode into an AXNodeData object. This will eventually replace the existing AOMPropertyClient once all sparse attribute setters are migrated over to the new functional map. AX-Relnotes: N/A Bug: 1068668 Change-Id: I518b7cbdd61d09a71005c5739a18b3cd98445115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467044 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Auto-Submit: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824743}
-
James Darpinian authored
readBuffer should return INVALID_OPERATION instead of INVALID_ENUM when passed a COLOR_ATTACHMENT that is greater than MAX_COLOR_ATTACHMENTS. Bug: angleproject:4766 Change-Id: Ibfda4a433da1c21676c63e3173fa28e318f7d840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253278 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#824742}
-
Anders Hartvoll Ruud authored
Currently each CSSAnimation that references a @scroll-timeline gets its own CSSScrollTimeline instance (even in cases where the same animation-timeline name is used). This is a bit excessive, so this CL adds a mechanism for reusing matching instances. Bug: 1074052 Change-Id: I564e370b7ff9464e86ecca742fc693d13a4890bc Fixed: 1123864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518052Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#824741}
-
Yuri Wiitala authored
Fixes a bug where local audio unmutes briefly for a second when the Mirroring Service switches between mirroring and remoting. This is accomplished by holding a "Muter" sentinel throughout the whole session to ensure no accidental audio leakage happens while loopback capture is closed/re-started. In my quest to fix the bug, it became clear that the content::AudioLoopbackStreamCreator does not provide the granularity-of-control needed for the muting bugfix. Thus, this change has CastMirroringServiceHost invoke the Audio Service mojo APIs directly. Bug: 1111026 Change-Id: I9b3e60814306be2179d46a5daeb4c7e8ccee1bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504636Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824740}
-
Andrew Grieve authored
javac prevents missing symbols via compiler errors, but they can still occur by including prebuilts with incomplete deps, or by using jar_excluded_patterns to remove a class that is actually used. Bug: 1142530 Change-Id: Idebb28c9e1133d9021d899c570e35a5ff16d5f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510236 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824739}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic216c9df51dd890013d31d64c28cd254636e3ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522225Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5689d6741bc4..e3fee63a19d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I61f6f080e197bfbf86462a878d2219c90c04cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522510Reviewed-by:
-
Brandon Wylie authored
There's additional checks that AGSA needs to do before progressing, which need to be checked before continuing with voice search. There's an external content provider which exposes this information to Chrome. Bug: 1140765 Change-Id: I46fa2590484c3c4bc89427ef1cabf99ac69bd26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468308 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#824736}
-
Vikas Soni authored
Update expiry of media histograms Media.CodecImage.CodecBufferWaitCoordinator.* from M86 to M95. Bug: 1104950 Change-Id: I6a332f937563206b8a46d88b2ae21218a670ff3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517485 Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824735}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604599166-f98e71683e0c124b3da263294d166e72d717216d.profdata to chrome-mac-master-1604620781-6e005798045dacc8d1de821cf745cddceb8035b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0ee2b5d9da19986603c650dafc9968fbdf6b460f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522224Reviewed-by:
-
Yicheng Li authored
These strings have been approved in UI concept review. Bug: b:156258540, b:144861739 Change-Id: I24ae19f39d686a79f0646f2bd6fa38ee3f1a6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521166Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit c498f582. Reason for revert: This revert seems to cause compile failures. Original change's description: > Revert "Remove ButtonListener in favor of callbacks. Other cleanup." > > This reverts commit 86ef81d7. > > Reason for revert: I suspect this causes test failures on CrOS. > > Original change's description: > > Remove ButtonListener in favor of callbacks. Other cleanup. > > > > Add metadata - remove manually overridden GetClassName. > > > > Add view builders and update view tree construction to use the builder. > > > > TBR=katie@chromium.org > > > > Bug: 772945, 938501, 1130078 > > Change-Id: Id105b26afb15138ee6e70e7ade5e43be11671a47 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505880 > > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > > Auto-Submit: Allen Bauer <kylixrd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824581} > > TBR=pkasting@chromium.org,pbos@chromium.org,kylixrd@chromium.org,tetsui@chromium.org,katie@chromium.org > > Change-Id: I5502a73a1f1f5870937efbbb2588f676748bbad1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 772945 > Bug: 938501 > Bug: 1130078 > Bug: 1146255 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521980 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824702} TBR=pkasting@chromium.org,peria@chromium.org,pbos@chromium.org,kylixrd@chromium.org,tetsui@chromium.org,katie@chromium.org # Not skipping CQ checks because this is a reland. Bug: 772945 Bug: 938501 Bug: 1130078 Bug: 1146255 Change-Id: I608f8cb868f6d974e726014c736bf0fb1ed5704d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521984Reviewed-by:
-
Gavin Williams authored
Import specific functions from scanning_app_test_utils Import the appropriate Scanning subpage for each test. Bug: 1059779 Change-Id: I9d0470a8955a892fa3820e55544097576e9c2118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522111 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#824731}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec0c770ad8b1..91bb7506bd20 2020-11-06 ehmaldonado@google.com [depot_tools][owners] Add owners client to depot_tools. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I81232205075f633a8cf705bc0717e24b311834e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522614Reviewed-by:
-
tby authored
files still appear in the launcher. Tested: manually. Request format is valid, itemsuggest returns 200, and Bug: 1146254 Change-Id: I8f28e813af1c8453a54d8e8373ccf787420ad699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521978Reviewed-by:Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#824729}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aafe840ca245..073820cb20af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com,xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: peria@google.com,xialinyan@google.com Change-Id: I51000f9eaa2a4cf211e1780da477901c7b50f645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522220Reviewed-by:
-
David Bienvenu authored
This reverts commit 3de603ce. Reason for revert: <a user reported this affects win 1909> Original change's description: > remove WS_THICKFRAME for full screen in pre 1903 Windows > > Not doing so caused issues with playing videos in full screen mode on > older versions of Windows, when we stopped removing WS_THICKFRAME in > crrev.com/c/1972258. > > Bug: 1014720,1141059 > Change-Id: I57b01051c457b35b37c465ce3b38d60bf896c32e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510354 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824543} TBR=sadrul@chromium.org,robliao@chromium.org,davidbienvenu@chromium.org Change-Id: I30477800e3c32351ff6ab12cb0717a94c47e7a53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014720 Bug: 1141059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522573Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824727}
-
Changwan Ryu authored
When the input is not focused but if you swipe horizontally on the input element, we still try to show the magnifier. This gesture seems to be silently ignored and it does not actually focus and move the cursor, but we still trigger the magnifier. This can be suppressed by checking the actual selection rect. Bug: 1134492 Change-Id: I47214d6d1c9610258dba5b7c162781a9c60f4258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522571Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824726}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604588329-37596c07bf301a8ab7d867a3b0140d934526b155.profdata to chrome-win64-master-1604609790-bc5437f446ee5ad42df312047e176901e766dccd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib3bdb9fa07756c4e3a571a74e0e5e8000bfab509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521686Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604599166-2d84463f431e41489c0f9ff841daf3c0f07e3415.profdata to chrome-linux-master-1604620781-8baad16a8ee2321f3de713350b41c3a35b5f14db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib20532629446db024e6807d74950988b4ff124d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522597Reviewed-by:
-
Chong Gu authored
Since there's no minidumps in Fuchsia browser, we detect crashes through checking for system info. Filter one failing pixel test on Fuchsia Bug: 1080853 Change-Id: I6ef8b33b64b6e6292ec4adfe8fa9538dde496d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522115 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#824723}
-
Michael Thiessen authored
Long overdue cleanup of functions that should never have been in ChromeActivityTestRule. Change-Id: I0a88b9c8f322fe9ee70d6d0c637ec4b0fb0b0388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521362Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#824722}
-
Mason Freed authored
The WebUI pages should only require HTML Imports at this point, and not Shadow DOM v0 or Custom Elements v0. Limit to just that. Bug: 1111843, 937746 Change-Id: Ib61e38475957e045fb5ecd38dc761f156f55aa53 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512381Reviewed-by:
-
Sven Zheng authored
For local development, test owner don't need to actually upload anything. Bug: 1145334 Change-Id: I2b7f2808d6bc10c7e6dbcfb99805ea52d2b3f152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522611Reviewed-by:
-
Aleks Totic authored
TablesNG code did not get moved over automatically. Bug: 958381 Change-Id: Ib18854483effb0c1ed547e3f531db0926977cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522503Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#824719}
-
