- 09 Dec, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/016711efbb5d..d19d663924f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: Ie15928a4ca5aca3e07f4c24ff8de03ea175f668c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581414Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835179}
-
Guido Urdaneta authored
When the promise of a getUserMedia() call is settled, it can result in the detachment of the execution context. The idenfiability metrics for getUserMedia() require a valid execution context and therefore should run before the getUserMedia() call ends. Bug: 1156510 Change-Id: I29975c9d779858b1574506f5d60ecfe4ae6a1690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580070 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#835178}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607493425-af0aa6c36468b9d0e6f03a33932dae6d4017f80e.profdata to chrome-mac-master-1607515179-092361bc7a185424dad74bccdfea645817af1d61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4a1f73e54f5a5c7eae2dfc0912ead8004840a97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835177}
-
Omar Morsi authored
Bug: 1148294 Change-Id: I24ab19370a6453b464d453284d216fd062da2006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550798 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#835176}
-
Nektarios Paisios authored
We should not be returning a text marker range with NULL AXPositions whenever there is nothing selected on the webpage. Instead, like with all other text marker related attributes, we should return nil. Returning an AXRange with NULL AXPosition objects, makes VoiceOver hold onto and try to utilize NULL AXPositions in later API calls. Such API calls inevitably fail due to the fact that they are correctly considered invalid by our AXTextMarker deserialization logic. AX-Relnotes: n/a. R=abigailbklein@google.com, dmazzoni@chromium.org Change-Id: Iafa561e21f44a44deca4b5fa1e1d83ced02f1cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581298 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835175}
-
Antonio Sartori authored
A Web Platform Test was failing because it was missing the 'sub' suffix in the file name, so template substitution was not performed by the web platform http server. This change fixes that. Bug: 1021462,1149272 Change-Id: Ic665aab61912002edf6a1cbfded4ff1ca3340c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577778 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835174}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607493425-c73fec691091cf0b277c9f5003730e7d0a079735.profdata to chrome-linux-master-1607515179-f1c33f017a68d1555043f7e4b5e6f959b5d2d5d2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I95dc91cbc47250e0a8eb1c6f9e0bdd6f04e96340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581412Reviewed-by:
-
Bill Budge authored
- Adds a new feature that turns off SharedArrayBuffer and WebAssemblyThreads features, so developers can more easily test sites with SABs and COOP+COEP site isolation restrictions. Bug: chromium:923807 Change-Id: I76984b13e1994c297a6d3811abe0fefa6f1b6530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579721Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#835172}
-
Alex Ilin authored
Some assistive technologies don't handle correctly the case of one button nested inside of another one. This is the case for the profile-card-menu button that is nested inside of the profile-card button. This CL puts those buttons next to each other in DOM as siblings which fixes the problem. Bug: 1156067 Change-Id: I9342f0608231a7cf3f1a6d6329eb213118c82084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580800 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#835171}
-
Anastasiia N authored
Add kInlineLoginWelcomePageSkipped pref and don't show welcome page if the pref is set to true. Test: browser_tests --gtest_filter="*InlineLoginBrowserTest*" Test: browser_tests --gtest_filter="*InlineLoginWelcomePageBrowserTest*" Bug: 1144114 Change-Id: I4c153a1d7410390e708ed81d0b6e62dc9729db24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549226 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#835170}
-
Victor Vianna authored
This reverts commit c547b0cd. Reason for revert: We wish to merge a fix for this logic back to M88. Let's fix the logic and only then fork the method. Original change's description: > Fork SyncController.isSyncingUrlsWithKeystorePassphrase() in PSS > > SyncController will soon disappear, so we start moving this method to > ProfileSyncService. The SyncController method is still exposed for the > moment because it's called in downstream code. > > There should be no behavior change in the only call site: > SyncController.get() is null iff ProfileSyncService.get() is null. > > Bug: 1156620 > Change-Id: Ida792cb92702f932aad3023d05e048be8aee94e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577227 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Victor Vianna <victorvianna@google.com> > Cr-Commit-Position: refs/heads/master@{#834745} TBR=treib@chromium.org,victorvianna@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ied87d4f89b58db0dc286eab80c345711654c67d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581483Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#835169}
-
Artem Vazhinskiy authored
This CL returns change from https://codereview.chromium.org/214603010 which was reverted at https://codereview.chromium.org/426713002. Without this change user input to omnibox is not recognized as a "user-gesture-triggered" event in terms of handling of external protocol URLs. So, HistoryURLProvider will not provide URL_WHAT_YOU_TYPED result for URLs with external protocol until the user performs some action on the page. Although the omnibox input should also be considered as a user action. Bug: 1143632 Change-Id: I0b70fe641e3a28dc4c9570b037487ca68de2d19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479166 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835168}
-
Tim van der Lippe authored
These are replaced by Karma tests in https://crrev.com/c/2577572 R=aerotwist@chromium.org Bug: 1024752 Change-Id: I6faf792691cdfc0bd9aa657c3be0e6b159f254f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577473 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#835167}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d57b1168772..b1f0d11f4233 2020-12-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I473b159c22da0de6a999f288614f60692128dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581408Reviewed-by:
-
Juanmi Huertas authored
This CL tries to optimize the Offscreencanvas usage in WebGL. It will try to create a new CanvasResource that will receive mailbox, sync_token and the destruction callback for a resource. The idea is to try and let the compositor access the ExternalCanvasResource that will contain all the relevant data to render the frame, and then send it back to the WebGL part. Even though I plan to move it to smaller CLs, currently, this CL adds a new RGBX format to be processed inside CanvasColorParams. Once this CL works and it makes sense I will submit this other CL first https://chromium-review.googlesource.com/c/chromium/src/+/2567978 Bug: 998951 Change-Id: Ib2d178cf489007357b7861f9ed27af1fc2a22da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535012 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#835165}
-
Yoav Weiss authored
This CL adds a test that verifies that empty iframes correctly create a Resource Timing entry. Bug: 933858 Change-Id: I1d5ae7d8c0fe5fb60ebcf92ebd8f4a51e5fd1d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580069Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/516d20deb974..016711efbb5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: I269a07109d188b2fb4eab3add271e34625527d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580553Reviewed-by:
-
Philipp Hancke authored
Deactivate the rtp-payloadtype WPT to allow the fix to roll in. Reactivate the rtp-demuxing WPT. BUG=None Change-Id: I776cbc388596a242f376de03747f4cf216d2ca93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580806Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#835162}
-
Anastasiia N authored
Bug: 1148246 Change-Id: Ic08ea92381fb8a5c60945380ca508b649af461ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563299 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835161}
-
Sigurdur Asgeirsson authored
Tbr: sky@chromium.org Bug: 1145565 Change-Id: I7c49818461f66214f9cbcc082c74490da8beba74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577705Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835160}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b219431a16..b5c844554e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I168e856786a66b29d41bd59ed4dbdd8973520635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581444Reviewed-by:
-
chrome://managementdpapad authored
This is part of an effort to clean up chrome/browser/ui/webui folder, such that most (if not all) files are under a subfolder dedicated to to the WebUI page that uses them, along with appropriate OWNERS files. Bug: None Change-Id: I4b7c815c44de1068d2bd3618675e2fc4e5807e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577839Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes the PasswordCheck base::Feature flag. The feature was completely launched in M86. TBR=harrisonsean Bug: 1047726, 1075494, 1092444 Change-Id: I9d1840830cf6ab70a190a4b30740a3cda22e2a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577207 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#835157}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1edfa2693a5b..9d57b1168772 2020-12-09 pfaffe@chromium.org [wasm debug] Scope view: Show optimized-out values as undefined 2020-12-09 tvanderlippe@chromium.org Fix Remote Devices view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156981 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I04bebc09c2937a01ec5ee6967718c75590d1c469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581443Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607460951-8dc40a3fea0b80cf0b8a704b92ca55c4b39739b6.profdata to chrome-win64-master-1607471901-d1b17db4d547397f57796df9fcd9057f4117af9e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I520d403574f9fcabe882c886036bda3a746cf2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581320Reviewed-by:
-
Antonio Sartori authored
The Content-Security-Policy source expression 'strict-dynamic' should only apply to scripts: https://w3c.github.io/webappsec-csp/#allow-all-inline Previously, we where applying it to all kind of sources. This fixes it. Bug: 694525, 651742 Change-Id: Ie92f45665b6b78902f6b511441a5096b9d93d135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203197 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#835154}
-
Victor Hugo Vianna Silva authored
This class has been unused for a while and was only kept so far because it was believed to be necessary for Chrome's integration with auto-sync. This belief was fueled by a regression following an attempt to remove the class: one auto-sync toggle disappeared (crbug.com/1021873). Turns out the actual root cause for the regression is that there were ContentResolver.setIsSyncable() calls in the class at the time [1]. Now that the class has no logic at all, it can be safely removed, provided Chrome still has the rights to read/write auto-sync settings [2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1912120/2/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapter.java#33 [2] https://source.chromium.org/chromium/chromium/src/+/9ce87784ce6277b46fa2ee769e1b0d9d3ac4310f:chrome/android/java/AndroidManifest.xml;l=58 Bug: 1107904 Change-Id: I33056dbb70aca4d3f9a3c3adc1026b7e21d8b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580342Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#835153}
-
Maksim Moskvitin authored
This CL applies modern style guides and does minor clean-ups in //components/invalidation/impl folder. Bug: 1105388 Change-Id: I2274918306acfc6bf9ae5bc358309ea6a97f3533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577363Reviewed-by:
-
Thanh Nguyen authored
This CL point os settings search to the new sandboxed LSS. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I2e1d33564737062b0f257718efc1a96b8184d432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573257 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
-
Thiemo Nagel authored
This reverts commit 022f0128. Reason for revert: It looks like this is breaking TabStripTabListTest.All in https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 First occurrence: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93505 Original change's description: > [Tab Groups] Only create a tab group if it is the second link. > > This is merely a heuristic for whether or not to create a tab group > based on the opener of the tab next to the current one. > > Bug: 1128703 > Change-Id: Iae0ae8db78be0bbe9be2fdacd143c70e1a0d49bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567818 > Commit-Queue: Charlene Yan <cyan@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834915} TBR=ellyjones@chromium.org,cyan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,connily@chromium.org Change-Id: Ib7fae0f0d2bfce4eddd9966923b50b3690e0fe24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580530Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835150}
-
Alessio Bazzica authored
Bug: chromium:873650 Change-Id: I7db44c72a6be5045525db6047f0c950baa3f8c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580525Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#835149}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36f74334e16b..f0f79e083662 2020-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a3984b7e to 3fc522ff (498 revisions) 2020-12-09 syoussefi@chromium.org Don't output matrix qualifiers in I/O blocks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I11b038d135b28900dd7e26f9f8a7399b7b53437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581400Reviewed-by:
-
Anders Hartvoll Ruud authored
The rule can be parsed, but can otherwise not be used for anything yet. As temporary behavior, @container rules accepts anything accepted by @media. Eventually we need to restrict what is accepted, and/or implement a separate parser. Bug: 1146095 Change-Id: I018008d291f2e353b20ad6624b1310f9da552e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575028Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#835147}
-
Thiemo Nagel authored
This reverts commit dc4eea24. Reason for revert: It looks like this is causing test failures --> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/21664/ Original change's description: > [Nearby] Update subpage visibility text and fix dialog a11y. > > Update device visibility button text in Nearby settings subpage. > Fix 'try again' link a11y in Nearby settings subpage dialog so > that the entire message is read out by ChromeVox when the link > is focused, rather than just the text of the link. > > Fixed: 1154718, 1156777 > Change-Id: I6594bcef97263e1f529112d1d9d5779fa66436a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575885 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Gordon Seto <gordonseto@google.com> > Cr-Commit-Position: refs/heads/master@{#834958} TBR=khorimoto@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,vecore@google.com,cclem@google.com,gordonseto@google.com Change-Id: Iee79682f082d42878209035b1a2802bbbe12a1ac No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581482Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b219431a16..b5c844554e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If68e5d26195bff27bbc952b363a1a0c77140a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581442Reviewed-by:
-
Koji Ishii authored
This patch turns some DCHECKs in |NGOffsetMapping| to CHECKs when it could lead to out-of-bounds access. |NGOffsetMapping| uses |std::prev| or |std::next| after checking the pointer by DCHECKs. If these DCHECKs fail, |std::prev| or |std::next| will read out-of-bounds. Turning them to CHECKs will turn such cases into crashes. Bug: 1156988 Change-Id: I574ffd38636861c7d7aa9985d4a43852aabcbbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579933Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#835144}
-
rbpotter authored
R=dpapad@chromium.org Bug: None Change-Id: I6e20db96c8c8a831ff6c624765a6a078a06e22fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578704 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#835143}
-
Mihai Sardarescu authored
The usage of PrimaryAccountManager::SignOut() was removed in CL https://chromium-review.googlesource.com/c/chromium/src/+/2573082, so it is now obsolete. Bug: 1155505 Change-Id: Ic6a67ab7a37f00d64c5a22f322a0ee1d08c7f9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574859Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of Blacklist with Blocklist in components/password_manager/core/browser/android_affiliation and components/password_manager/core/browser/sync. Bug: 1147799 Change-Id: I3f186a860288b3e25607b65bdfde40d1b5ce15f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579792Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835141}
-
Ilya Nikolaevskiy authored
Bug: chromium:1155063 Change-Id: Ib9180912321b8f5e0d49f8e1cfbda53c47ee0222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577219 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#835140}
-
