Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 10 Sep, 2020 26 commits
  3. 09 Sep, 2020 14 commits
    • Gang Wu's avatar
      use app:chromeDrawableTint to tint TextViewWithCompoundDrawables · aacbc378
      Gang Wu authored 
      We should use app:chromeDrawableTint to tint
TextViewWithCompoundDrawables instead of android:drawableTint.

android:drawableTint works on API level 23 and above. But somehow
not work for PNG drawables in API 23, and TextViewWithCompoundDrawables
provide app:chromeDrawableTint to tint, so we can use it to handle the
issue.

Bug: 1126035
Change-Id: Iebc9b0d0ccf9ca8510bd03d8285d19b2ba705cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402102Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805559}
      aacbc378
    • Kent Tamura's avatar
      Enable "gn check" for //third_party/blink/renderer/modules/webcodecs · 89a6b640
      Kent Tamura authored 
      webcodecs:unit_tests had a circular dependency with
controller:blink_unittests_sources. This CL moves out
controller:blink_bindings_test_sources from
controller:blink_unittests_sources and adds
controller:blink_bindings_test_sources dependency to
webcodecs:unit_tests to remove the circular dependency.

This CL has no behavior changes.

Bug: 800764
Change-Id: Ie578dfe442f2ee111f19abb7496e41a27ff66b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400644
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805558}
      89a6b640
    • Miguel Casas's avatar
      media/gpu/vaapi: batch submitting VABufferIDs for MJPEG decoding · 405ed4ac
      Miguel Casas authored 
      This CL follows crrev.com/c/2393629 by batching up SubmitBuffer
calls in the JPEG decode accelerator, used e.g. for MJPEG camera
stream decoding.

This was verified via chrome:tracing while capturing HD on kohaku
and reks (Braswell) in the link [1]. Similarly to what is seen in
the previous CL, the combination of SubmitBuffer() calls on ToT
is ~10% slower than the batched SubmitBuffers(). A key difference
is that since JPEG is way simpler than e.g. VP9, the submitting
time is comparable to the ExecuteBuffers_Locked(), so this CL
has some minor overall decode-time savings. But still the target
here is to reduce contention on the lock and libva for video
conferencing cases with multiple remote participants a la Meet.

[1] webrtc.github.io/samples/src/content/getusermedia/resolution/

Cq-Depend: chromium:2393629
Bug: b/166646505
Change-Id: I183cc151de24d8fdbdc62e0172be296dacbf26f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393525
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: default avatarJ Kardatzke <jkardatzke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805557}
      405ed4ac
    • Miguel Casas's avatar
      media/gpu/vaapi: batch submitting VABufferIDs for VP8 decoding · b512bba7
      Miguel Casas authored 
      This CL follows crrev.com/c/2393629 by batching up SubmitBuffer
calls in the VP8 decode accelerator.

This is verified via chrome:tracing and codepen.io/full/qzYXba that
plays 4 1280x572 VP8 videos at the same time. Tracing is captured for
a few seconds, basically the SubmitBuffers() call takes ~0.312ms/call
versus the individual SubmitBuffer() calls ~0.072ms -- which gives
an aggregate of 0.360ms, or savings of about ~20%. Since decoding
itself takes about the same as SubmitBuffers on my BSW device (reks),
batching gives ~10% reduction in decode time.

Bug: b/166646505
Change-Id: I11c5570bea1c049fe0e9af75239bd60ac906a843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401512
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: default avatarJ Kardatzke <jkardatzke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805556}
      b512bba7
    • David Tseng's avatar
      Add Learn Mode descriptions for some gestures · 3cddc841
      David Tseng authored 
      See go/chromevox-touch_gestures

Some gestures, e.g. swipe two fingers left, do not have an explicit command. Others, like three finger swipe up/down, have commands which are not also keyboard commands.

In Learn Mode, these gestures are not fullyd escribed beyond just the physical gesture description.

Add these descriptions now in this change.

R=akihiroota@chromium.org

Bug: 1124454
Test: browser_tests --gtest_filter=ChromeVoxLearnMode*.Gesture*
AX-Relnotes: ChromeVox Learn Mode now describes all new gestures and what they do.
Change-Id: I19fd3b39aa15f9df0daa864c4f99f69173d4baa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386377
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: default avatarAkihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805555}
      3cddc841
    • Adithya Srinivasan's avatar
      Portals: Log console error when cross-origin postMessage fails · 6d9b2302
      Adithya Srinivasan authored 
      Follow up to https://crrev.com/c/2382064.

Bug: 1108793
Change-Id: Iba5aaedcf026907760bc9300846a5d45c0dfe6c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398998Reviewed-by: default avatarLucas Gadani <lfg@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805554}
      6d9b2302
    • Rakib M. Hasan's avatar
      android: Chromium side changes to add new waterfall that will run WPT · 47dda8d7
      Rakib M. Hasan authored 
      Follow up to crrev.com/c/2369641. This builder will be in the
chromium.android console. It will run WPT on Weblayer for now. More
browsers will be tested in this builder.

Bug: 1050760
Change-Id: Ia1166f707e4b49dfa654ff199bb9539bb0a8d558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386600Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Reviewed-by: default avatarHaiyang Pan <hypan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#805553}
      47dda8d7
    • Evan Stade's avatar
      Remove some bits of ApiCompatibilityUtils that are no longer needed · 761be790
      Evan Stade authored 
      Since KitKat support is deprecated, >= L checks can be removed and < L
code can be removed.

Bug: none
Change-Id: I123e3c1d5d33d7cf031d7c248d12a8002c2209da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393156
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805552}
      761be790
    • David Van Cleve's avatar
      Revert "Update Crashpad to fc97e5cbb21d for macOS 11 and mac-arm64 support" · 31db08c8
      David Van Cleve authored 
      This reverts commit d4fb5657.

Reason for revert: MacOSVersionNumber seems broken on 10.12:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests

Original change's description:
> Update Crashpad to fc97e5cbb21d for macOS 11 and mac-arm64 support
> 
> Update Crashpad to fc97e5cbb21dc7f4d4679b86792dd2717818bd80
> 
> 7547d0aa874f android: Remove orderfile configs from handler trampoline
> b4724081350e fuchsia: Remove run_tests.py functionality
> ebab28f30d33 Remove a variable-length array* to enable compiling with
>              -Wvla
> 1509aadd6364 Remove a variable-length array to enable compiling with
>              -Wvla
> 45ca490687af Build with -Wvla, forbidding stack-allocated variable-
>              length arrays
> 59e8120e7ada [Wconversion] Suppress warnings on Fuchsia
> 71695216f9bb ios: Fix Xcode project buildgen
> dc9f3a58aabb fuchsia: Fix Wconversion on Mac/iOS builds
> 364fdd65a01e fuchsia: Fix Wconversion on Mac/iOS builds (take two)
> bdf94713241b mac: Switch from <AvailabilityMacros.h> to <Availability.h>
> 56937e1df569 mac: 11.0 SDK support
> b3d84e0d0571 mac: System libraries are no longer found on disk on macOS
>              11
> df3bc64246ab mac: Be more positive
> c4acae9f961a fuchsia: fix configs clobbering in GN template
> 3965bc7d7894 Refactor OS_LINUX usage for coming LaCrOs update
> 5412beb63386 mac: Replace MacOSXMinorVersion with MacOSVersionNumber
> e0d8a0aa01ac mac-arm64: Cope with signal handling quirks
> abfc89bb9b70 mac-arm64: Set expectations for tests that crash via
>              __builtin_trap
> ca83774eea9c mac-arm64: Make MacModelAndBoard use target-type instead of
>              board-id
> f8563cb8626a mac-arm64: Omit the cl_kernels workaround on this platform
> 0bc3826129d5 mac-arm64: Allow target_cpu = "mac_universal" to create
>              universal builds
> df12d57e97b4 mac: Don’t build 32-bit ProcessReaderMac support where it’s
>              unusable
> ca88ff1edb8e mac-arm64: Don’t attempt to determine the CPU frequency
> fc97e5cbb21d mac: Work around broken {CTL_KERN, KERN_PROCARGS2} sysctl
>              in 11.0db6
> 
> Bug: crashpad:345,crashpad:347,crashpad:352,crashpad:355,chromium:1103944
> Change-Id: I3c1f59d3c5bd2886916ea80228be765aafb4f63d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399518
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Auto-Submit: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805417}

TBR=rsesek@chromium.org,mark@chromium.org

Change-Id: I69ec022aaebff58e4225114fb1c2f164990b6f48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:345
Bug: crashpad:347
Bug: crashpad:352
Bug: crashpad:355
Bug: chromium:1103944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401271Reviewed-by: default avatarDavid Van Cleve <davidvc@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805551}
      31db08c8
    • Jimmy Gong's avatar
      Provide reasons for ConnectionAttempt() failures logs · c66c4f0b
      Jimmy Gong authored 
      Bug: 1106937
Change-Id: Ica9e835c591950ed66312f82b55fab3e79d6b5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401704Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805550}
      c66c4f0b
    • Lukasz Anforowicz's avatar
      Introduce NonNetworkURLLoaderFactoryBase class. · d6b0a81f
      Lukasz Anforowicz authored 
      This CL deduplicates code that used to be repeated in
FileURLLoaderFactory and ContentURLLoaderFactory: the overridden Clone,
private OnDisconnect method and |receivers_| field.

In the future, other aspects of URLLoaderFactory implementation (e.g.
handling of CORS and/or helpers for responding with file contents) may
hopefully also be moved into NonNetworkURLLoaderFactoryBase.

Bug: 1106995, 1105256
Change-Id: I7b8783bc4020d914fb7bdd9f56e2e9698fd9a615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357559
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805549}
      d6b0a81f
    • Sunny Sachanandani's avatar
      Revert "Reland "media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation"" · d6b09b47
      Sunny Sachanandani authored 
      This reverts commit 1364e616.

Reason for revert: Increased crash rate - see crbug.com/1125954

Original change's description:
> Reland "media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation"
> 
> This is a reland of b71115a3
> 
> Relanding after triaging Gold failures on gpu.fyi bots in previous
> attempt.
> 
> Original change's description:
> > media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation
> >
> > Avoid a CPU side copy to account for mismatched strides between the
> > decoded video frame and GPU texture created for uploading the frame.
> > GL_UNPACK_ROW_LENGTH allows specifying the stride for glTexSubImage2D,
> > and is part of the GL_EXT_unpack_subimage extension implemented by the
> > command buffer on the client side.
> >
> > Also includes a pixel test with a VP8 video with a GL incompatible
> > stride that doesn't match the video's coded size (992 vs 962).
> >
> > Bug: 1077211
> > Change-Id: I62753234bde3b92e64089c92a59e65ae2bc1c84c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386671
> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#803696}
> 
> TBR=dalecurtis@chromium.org,zmo@chromium.org
> 
> Bug: 1077211, 1124215
> Change-Id: I43a97e72cdd0ba633d4b374a2319fbc7dc7252f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390958
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803960}

TBR=dalecurtis@chromium.org,zmo@chromium.org,sunnyps@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1077211, 1125954
Change-Id: I9c77f5e7694385ccdbbadcddf738135a18ca6412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402124Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805548}
      d6b09b47
    • Lukasz Anforowicz's avatar
      Make ContentURLLoaderFactory always owned by its |receivers_|. · 14bb39a7
      Lukasz Anforowicz authored 
      This CL introduces ContentURLLoaderFactory::Create static method that
allows creating a ContentURLLoaderFactory that is owned by its
|receivers_| and will self-delete when the last receiver disconnects.

This CL removes the ability to directly construct and own a
std::unique_ptr<ContentURLLoaderFactory>, because this ability means
that the factory can be destructed while receivers bound via the Clone
method are still alive (see the associated bug).  In particular, this CL
stops exposing ContentURLLoaderFactory constructor as a public member,
which forces construction to go via the new Create static method.

This CL mostly just follows the pattern established earlier by
https://crrev.com/c/2337411.

Bug: 1106995
Change-Id: Ia2c41c798b242e2547f22b0e7079ee444b15cbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337577
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805547}
      14bb39a7
    • Carlos IL's avatar
      Add testing config for mixed image autoupgrade · 54b63c07
      Carlos IL authored 
      This also removes the stale 'DirectCompositionGpuVSync' experiment from
testing config since a size presubmit was failing. This was the only
stale experiment found in the json file (found using cleanup.py from
crbug.com/1053702).

Bug: 1042877
Change-Id: I632e19f837c7566849cc3d4477732084765ffa12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399133
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805546}
      54b63c07