- 04 Mar, 2020 40 commits
-
-
Mark Brand authored
This adds code that generates libprotobuf-mutator based structure-aware fuzzers as part of the mojom compilation process. (changes in //mojo). It also adds a fuzzer for CodeCacheHost using this framework to demonstrate how it will be used, and documentation explaining that fuzzer and how to use this generator to write new fuzzers. (changes in //content/test). It finally includes a few changes to typemap and traits files that were necessary to smooth over some inconsistencies in existing code using mojo. Bug: 941849 Change-Id: I660a57bd90c0963bd9a0b8608c746cdb767edc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978739 Commit-Queue: Mark Brand <markbrand@google.com> Auto-Submit: Mark Brand <markbrand@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#746827}
-
henrika authored
Makes some final adjustments in the previous change landed in https://chromium-review.googlesource.com/c/chromium/src/+/2062428 to ensure that all output streams adds a unique ID and that the logging style identical for all platforms. Bug: 1017219 Change-Id: I7d7caa45307e3a7a8270528feea3c3205b5b784c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087674Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#746826}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ia136d653d5d1bf8f4dbeaaf589a646e44c49240a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087223 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746825}
-
Anna Malova authored
Bug: 1007815 Change-Id: Idae1c817d49e4e69c9d1b4145d55ccb1f27bdb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087916Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1861849..ad298fa3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34a889a76b3a04211acab89e31c90fa0a370cbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087113Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746823}
-
Maciek Slusarczyk authored
ChromeOS.SAML.APILogin tracks usage of Gaia vs SAML sign-in. Extending its validity by 6 months to collect additional data. Bug: 1053279 Change-Id: Ieb95c17a590fc25b454bbb4c1e369dbebefe6502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087615 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746822}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/181bb9733f83..8e76ccdb37b0 git log 181bb9733f83..8e76ccdb37b0 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 shaochuan@chromium.org Fix string/bytes confusion in CommandVMTest 2020-03-04 vapier@chromium.org Revert "cbuildbot: switch to python3 only" 2020-03-04 saklein@chromium.org run_tests: Fix test interleaving. 2020-03-04 bpastene@chromium.org cros_chrome_sdk: Add a "--no-shell" arg that will skip the sub-shell. 2020-03-03 cjmcdonald@chromium.org Update proto bindings to current master 2020-03-03 vapier@chromium.org results_lib_unittest: delete unused code 2020-03-03 vapier@chromium.org cbuildbot: switch to python3 only 2020-03-03 cjmcdonald@chromium.org Chroot snapshot endpoints 2020-03-03 achuith@chromium.org vm: Get rid of Device.run Created with: gclient setdep -r src/third_party/chromite@8e76ccdb37b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I2a3e80e811059b5d4a76850d62182da5161a6ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746821}
-
Omer Katz authored
Vector::Trace used to check that all unused slots are zeroed out. This is a hidden assumption that the Vector cannot be changed while it is traced. This assumption will no longer once Vectors are traced concurrently. Bug: 986235 Change-Id: I05e1270f92f0542595e2c87c776cbf58a785e8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015245Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746820}
-
Erik Johnson authored
Include session ID in crash reports if the crash occurred during a Stadia session Bug: b/137860124 Test: currently in production, working as intended. Change-Id: I60e2a47cbeaa0f01cc8db1c89d2c9bd3111079c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083741 Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#746819}
-
Alice Wang authored
This CL replaces ChromeSigninController in PickerAdapter by IdentityManager. Bug: 1049548 Change-Id: If3523863144cb37b807406b87abb5db2ace89fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084556Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746818}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/07fd18460d09..8800de8931b3 git log 07fd18460d09..8800de8931b3 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 tvanderlippe@chromium.org Remove support for devtools startup tests 2020-03-04 jacktfranklin@chromium.org Create `NumberUtilities` and move `constrain` in 2020-03-04 tvanderlippe@chromium.org Copy lit-html build files to gen folder 2020-03-04 aerotwist@chromium.org [global] Remaps self.Common.console 2020-03-04 tvanderlippe@chromium.org Add skipped test for breakpoints with inline scripts 2020-03-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-04 tvanderlippe@chromium.org Generate ARIAProperties.js on presubmit 2020-03-04 tvanderlippe@chromium.org Add e2etest for shadow root styles 2020-03-04 mathias@chromium.org [deps] Roll deps Created with: gclient setdep -r src/third_party/devtools-frontend/src@8800de8931b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003497,chromium:1003700,chromium:1044632,chromium:1046596,chromium:1050549,chromium:1056614,chromium:1058320 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I180cd2f749519b685f7be7f4f4b502d4d9949ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087839Reviewed-by:
-
Ian Clelland authored
This imports the tests from https://github.com/httpwg/structured-header-tests/blob/master/param-dict.json into the structured headers unit tests. Bug: 1011101 Change-Id: If9b34906c00cb6e63b91a3c313be28510a4c1a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087992 Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#746816}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ac359c9ea04..74e0991a6bbc Created with: gclient setdep -r src-internal@74e0991a6bbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia398239f611426e9f625efb8d2efb3d7e39e20e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087840Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746815}
-
jonross authored
With samans@ no longer working on chromium, I'm adding myself to surface related OWNERS files which we missed when I became an owner. This will make sure we don't have no owner for Surface Sync related changes. Change-Id: I3ece816d933fbc00bfa940af35d7984be13e8967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087998Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#746814}
-
Yann Dago authored
Profile::GetCreationTime relied on the directory's creation time, which is not supported by all the file systems. For example, in POSIX we use the st_ctim property, which is the last file status change timestamp. Using the prefs will ensure that the creation time never changes if the profile directory is copied or if the file creation time is not supported by the file system. This also ensures that Profile::GetCreationTime works properly across enterprise snapshots. Bug: 958893 Change-Id: I4e6189642939bb52524c412a9146087d597320dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079163 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#746813}
-
Anna Malova authored
Bug: 1007815 Change-Id: I18ef44afac822d4d98787cdf4297611d211c343d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083487Reviewed-by:
-
Jérôme Lebel authored
|self.addAccountSigninCoordinator| needs to be interrupted when UserSigninCoordinator interrupted. Once |self.addAccountSigninCoordinator| is done, the sign-in flow can be interrupted (with dismissing the view controller if needed). Related to: crrev.com/c/2062410 Bug: 971989 Change-Id: I4825d822737e11ce5af83ef5f94d26c95bfda673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087752 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746811}
-
Alexander Timin authored
Add a non-waking task queue to blink scheduler. It should be used for metrics which should be recorded when the main thread is non-idle. R=haraken@chromium.org,tasak@chromium.org,bartekn@chromium.org,shaseley@chromium.org Change-Id: I63c18e1736d74c962745c1c7be63990932603e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056948Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
-
Annie Sullivan authored
The UKM were removed in crrev.com/c/1988594, and I think the intention was also to remove the UMA, because LargestContentfulPaint is the metric we are exposing to users. Change-Id: Ief74c8760dfc254892d251b5a4a07160e0eeb7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080815 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746809}
-
Justin Cohen authored
Change-Id: Id5ee6a44dff07e10295f997a68e982c6fefa471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085291 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746808}
-
Anna Malova authored
SetRequestHeadersCallback expects RequestHeadersCallback which is RepeatingCallback. Bug: 1007815 Change-Id: Ib0061cbff30193c1533989bc51142666cd8c073f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087221 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Samuel Huang authored
Running an ASan build of Clank requires a one-time device set up instructions. However, the 1-line instruction in asan.md is improperly wrapped to 2 separate lines. This CL remedies the above. Bug: 978698 Change-Id: Ie0f5b403cb20a3f4e7bcbe18d56ec339f15f9059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082327Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746806}
-
Rafael Cintron authored
GetNumericHelper and DoGetFramebufferAttachmentParameter were previously allocating a std::vector of bufsize size and using it as scratch space before copying the result to the output parameter. With this change, GetNumericHelper and DoGetFramebufferAttachmentParameter are modified to write directly into the output parameter. Bug: 1057747 Change-Id: If19d353a9f7d0bc9aa513deede15afad5c05b67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084111Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746805}
-
Alice Wang authored
This CL removes the boolean FirstRunActivity.SHOW_WELCOME_PAGE since after removing the Android EDU support it is always true. Bug: 1056132 Change-Id: I8e7891d22d537364899a8a22f423cd4363e22982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074479Reviewed-by:
-
Stepan Khapugin authored
Breaks startUpBrowserForegroundInitialization into three methods: * Code to run before any scene is created * Code to run to build up a scene/window * Code to run after at least one scene/window is created Currently these are broken down simply by the order in which they appeared in the original method. A follow-up CL will reshuffle code between these as necessary. Bug: 1045658 Change-Id: I0c40be3a88d082018a47f13bf3a0876de8cac179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087751 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746803}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4518a20e14ec..420ad1af1ef1 git log 4518a20e14ec..420ad1af1ef1 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 eshr@google.com Fix video_loopback crash when selecting all streams Created with: gclient setdep -r src/third_party/webrtc@420ad1af1ef1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I515a58750ce9138c9cb7f101a12e98d0accf2616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087837Reviewed-by:
-
Danil Chapovalov authored
Bug: None Change-Id: Iecf24e69967e57307ec1aa8bd475c9f410dc6611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087340Reviewed-by:
-
Fergal Daly authored
Also link to debugging_with_crash_keys.md from crash_key.h. Bug: 1056426 Change-Id: I8652eae061868e0ec220a89071e738fc2fef7ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086388Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#746800}
-
arthursonzogni authored
(mechanical change) Plumb the full COEP struct to several content/browser components: - EmbeddedWorkerInstance - ServiceWorkerDatabase - ServiceWorkerNewScriptLoader - ServiceWorkerUpdateChecker - ServiceWorkerVersion This is helping implementing the COEP reporting API. It fixes one TODO from: https://crbug.com/1056122. Maybe it is fixing the issue completely? I am personnally interested, because the CacheStorage is currently taking the full COEP struct, but without this patch, I only have access to the COEP.value. I need this patch to make progress on: https://crbug.com/1031542 Bug: 1056122, 1031542 Change-Id: I98e6e5e2034d6f83df7939681b661ee2fe5c1362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084996 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#746799}
-
arthursonzogni authored
Test CacheStorage responses entering in a COEP ServiceWorker are enforced against CORP/CORS. Bug: 1031542 Change-Id: Iadae43549cfca5e2b7e47676fc447b5b6104e43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084811 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Andy Paicu authored
...request. Bug: 1057981 Change-Id: I08617ef32dd46d68773e84ac5484abe10bb1b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087717 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#746797}
-
Roman Sorokin authored
* Do not wipe anchors from the uToS as it's already an embedded version * Put links from the additional tos in a plain text. Fixed: 1057957 Change-Id: Id7ae1c3a1f738017057c404f6986fadcb2158679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084552 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#746796}
-
Alice Wang authored
This CL fixes the ConfirmManagedSyncDataDialogIntegrationTest by replacing the bundle null check by listener check during the recreation, since the bundle can have null value when activity gets recreated on oreo phones, this made the test flaky. Bug: 1054855 Change-Id: Id3e2d265be0c78c8415b9ed891f4d4fea8d63b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083186 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Nazerke authored
This CL modernizes the SelectorCoordinator to use |browser| in the initializer. Bug: 1029346, 1048675 Change-Id: Id337cb6313adf9ba58cbb7080a45f3cb23458e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087217Reviewed-by:
-
Greg Thompson authored
This CL adds installed_browser_version to BrowserReport and includes the pending browser version when an update is awaiting a browser restart. BUG=1043624 R=zmin@chromium.org Change-Id: I6e86c5e5641a6bda7a7eb36267d527afd347aa44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087715 Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746793}
-
Fredrik Söderquist authored
Currently there are three different methods - SubtreeChildWasAdded, SubtreeChildWillBeRemoved and SubtreeTextDidChange - that are almost identical. Most callsites call them by first getting a LayoutSVGText from LocateLayoutSVGTextAncestor and then calling the method if an appropriate ancestor is found. Instead add a static LayoutSVGText::NotifySubtreeStructureChanged which find an ancestor and calls a new merged version of the above methods, SubtreeStructureChanged. Also fold InvalidatePositioningValues() into the new method since it is it's only caller. Change-Id: I797d350acf76f6a3372d0833566313d304d16fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087400Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746792}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ie2f1535a6dd84e6fae4a106d2868ee465fe5c9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085255 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Jose Lopes authored
This is a repeating callback because it's run from a loop: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=fd1f7cd492a3db415e007ab24b6ff266fddb43d8&l=773 However, most likely this parameter is not used at all: * https://crbug.com/1057572 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007805 Change-Id: I5b5d4818ebdfbcad7356f801e2e656b3116494f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083014 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746790}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ifee769d9f78a813e0540ffe007329a2246274e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085212Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: I0cbc5c04efb6e11e734c0528f330c10157fee083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083150 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746788}
-
