GitLab

GOOGLE_CHROME_BUILD is more a branding thing. Since
COM_INIT_CHECK_HOOK_ENABLED is also gated on OFFICIAL_BUILD
(which is more an optimization thing), this doesn't have an effect on
production Chrome.

Branded builds without official build optimizations will get
the com init check hook after this CL, but likely very few people
build in that configuration, and it shouldn't matter much for them.

Bug: 961769
Change-Id: Ib7dd98843c33c6571b53cd0007d260af422e0976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864718
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706702}

https://quiche.googlesource.com/quiche.git/+log/abb67699b6e2..780eaa6043f2

$ git log abb67699b..780eaa604 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 fkastenholz Change "&SomeQuicStringPiece[1]" to "SomeQuicStringPiece.data()+1"
2019-10-16 rch gfe-relnote: Use QPACK Dynamic Table in the toy client and server, but not in the test client and server. Protected by disabled --v99 flag.
2019-10-16 fayang gfe-relnote: n/a (flag counts)
2019-10-15 nharper Add newlines to quic_client_interop_test output
2019-10-15 dschinazi Fix auto-setting IETF stream flow control limits
2019-10-15 renjietang Change max_push_id related version guard to VersionUsesHttp3.
2019-10-15 rch Change QuicSpdySession::SendMaxPushId() to use max_allowed_push_id_ instead of requiring the caller to pass it in explicitly.
2019-10-15 rch Make the toy QUIC server send responses of arbitrary length based a number specified in the path.
2019-10-15 bnc Signal error if Insert Count Increment causes overflow.
2019-10-15 dschinazi Add rebinding support to quic_client_interop

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I67ee10f329b012d9d2e4c08d1420dac7baaad90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865349
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706701}

Enables the AR tests on Nougat, as AR support was recently added to N in
crrev.com/c/1854802.

Bug: 1012972
Change-Id: Ie9c309a34fc78e930e6317a268cc1906ea90f3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863954Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706700}

Switches uses of PrintResult in the WebRTC browser perf tests to
PerfResultReporter and whitelists browser_tests for conversion to
histograms before uploading to the perf dashboard.

Bug: 923564
Change-Id: I7ff090bcdeaf3906491b85993456f07313cd4a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856825Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706699}

Decouple icons pixel data from WebApplicationInfo metadata.

The Update and Sync-Initiated installs will use it to override icon pixel
data. See next CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1858025

Bug: 860583
Change-Id: Ief987de76bfd1389835c1318e57fb7d79ac4728d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861443
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706698}

This CL updates the web app sync behaviour to ignore sync changes to
web app manifest fields.

This is in preparation for automatic local manifest updating which
may set device specific values so we must not sync these changes
to avoid creating sync wars. See:
https://chromium-review.googlesource.com/c/chromium/src/+/1811402

The existing implementation (check name & description) is from the
initial implementation of bookmark app sync:
https://chromium.googlesource.com/chromium/src/+/d93fcd51386a104ce54d9577ae0df8957d310c89
The fact that it doesn't sync for any of the other fields is likely
an oversight when those fields were added.

In the near future these synced fields will be used as fallback values
for the first sync install on a device, see:
https://chromium-review.googlesource.com/c/chromium/src/+/1858025
After the initial sync install these fields are no longer useful to us
as we will attempt to match the live site manifest rather than other
devices.

Bug: 926083
Change-Id: I146b3f4f1ddcd58b4766f69a12c3c0a61e6f495f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737818Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706697}

Change-Id: I42bf3c7b46578b2694a15af9e3aafc9a0c232484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864379Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706696}

This CL is based on
https://chromium-review.googlesource.com/c/chromium/src/+/1824126/4

It is the fifth patch of splitting the bigger one
https://chromium-review.googlesource.com/c/chromium/src/+/1797069

It also splits out FakeboxDelegate for future refactors.

Screenshots:
https://drive.google.com/file/d/1RuLYCqP-PDR_czA-Q-csK0c9yd-tGJNZ/view?usp=sharing
https://drive.google.com/file/d/1oN3JWCRKE1UH2rypQYvQwTFPgJY1JdE5/view?usp=sharing

Bug: 982018, 1013693
Change-Id: I3cee0015c72c0b3fdbaf8db91dcf1da549ee89cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825165
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706695}

This is an implementation of the Service Manager's Connector mojom
interface which can be used in isolation without any dependency on an
actual Service Manager instance. It serves as a transitional helper for
code to migrate away from Service Manager APIs incrementally.

Bug: 977637
Change-Id: I98e7edabfe36f98f0d9e817e3b8d8c4de23cb67c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854210Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#706694}

Bug: 918220
Change-Id: I59de7158479d82f4775638b3e31645f18b818759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865656
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706693}

This CL changes the GMC dismiss button to show whenever the media
notification is hovered or focused instead of whenever the media is
paused. This means that users can dismiss while media is playing, which
will stop playback.

Bug: 1008907
Change-Id: I5342a4e1e7238a16203687e57dfe6608b2ab35be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859584Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706692}

This behavior was unintentionally broken by https://crrev.com/91216c0f

Bug: 1014220
Change-Id: Ibf2e961c4d98987fc24b6e028b81f8ac89b4fe94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860477Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#706691}

The file and class don't follow current convention. Remove the class
and it's use case from codebase.

Bug: 1002989

Change-Id: I0896cb1a010d19e24d5157cc5275f10e167c7a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865428Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706690}

Using wpt-import in Chromium e096591e.
With Chromium commits locally applied on WPT:
6386d9d8 "Update service_worker_unregister_and_register()"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I2df8cbb5beeb4841b3f0e3f2aa529d9f4bf199da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864243Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706689}

When a screen reader user is tabbing through the registered
service workers, the screen reader fails to announce the origins
from which the service workers are registered. By default, the
reader just announces "Update", as the Update button is the first
focusable element within each individual Service Worker view.

This change adds a new API to ReportView.Section. Because Section
is a generic control which may not always follow this paradigm,
the new API seems to be the best choice for how to implement. The
API is opt-in by call sites as demonstrated by this use of it.
The API sets the role="group" on the containing element, and
applies a label to the containing element. Upon focus entering the
containing element, the full title is read aloud.

"After" screencap: https://imgur.com/a/XfMg2SA

Bug: 963183
Change-Id: I5ef631d24d9f2df9f610a21c84fd5a9d6ae26b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864721Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706688}

https://chromium.googlesource.com/angle/angle.git/+log/9a334fdadf3f..16944ed21bc2

git log 9a334fdadf3f..16944ed21bc2 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 jmadill@chromium.org Vulkan: Fix ASSERT that could be triggered on some swaps.
2019-10-16 mihu@microsoft.com Disabling multisampled_render_to_texture extension if renderer is ADRENO.

Created with:
  gclient setdep -r src/third_party/angle@16944ed21bc2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@google.com

Bug: None
Change-Id: I9bfbaeaeb645c50787d7c325f03716eeb043202d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865697Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706687}

We never understood why this histogram was reading results different
than what we expected, so its use is very limited. Spec-compliant
treatment of '#' characters in Data URIs has been shipped in Chrome for
a long time and will not be changing.

Bug: 931396
Change-Id: I6d8ec2b230e78c93d4d8a36c4a5d8a48f761927a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856265Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706686}

Add BreadcrumbManager to locally store and discard breadcrumb events.

Bug: 1003922
Change-Id: I20ac153f22b5350129107f5efd0ac622edb07a62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804803
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706685}

The page switcher button size in app list folder should be 20 dip, and
there should be no additional horizontal margin between the buttons.

BUG=1014922

Change-Id: I5710a148cb0bca47948260589ccb392a0ec3de6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864357Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706684}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15bcceb9eaa2..b060ba608175


Created with:
  gclient setdep -r src-internal@b060ba608175

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:b/140584925,chromium:None,chromium:None
Change-Id: I05ad8a0db6888989d73a2eec71c5816b9d4b2d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864420Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706683}

Supporting preflight is tricky because preflight requests are made in
the network service, and they don't have request IDs. We are adding
a new message, OnLoaderForCorsPreflightCreated, to
TrustedURLLoaderHeaderClient to address that.

We are using TrustedURLLoaderHeaderClient, which means this mechanism
works only when "extraHeaders" is specified. Unlike for usual requests,
WebRequestProxyingUrlLoaderFactory::InProgressRequest dispatches
 - onBeforeRequest when OnLoaderForCorsPreflightCreated is called,
 - onBeforeSendHeaders and onSendHeaders when OnBeforeSendHeaders
   is called, and
 - onHeadersReceived, onResponseStarted, and onCompleted when
   OnHeadersReceived is called.

This CL implements the logic in
WebRequestProxyUrlLoaderFactory::InProgressRequest, and attaches
kURLLoadOptionAsCorsPreflight and kURLLoadOptionUseHeaderClient to
the loader for CORS preflight.

The preceding change is: https://crrev.com/c/1833395

Bug: 1002884
Change-Id: Id48f27bedf20bad29723f3af9b48ebaa8b2345b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837561
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706682}

There seems to be an issue with starting up the "timed out" UI when a
notifications prompt is visible or needs to be dismissed.  This modifies
the behavior of SetFramesThrottled to only stop/start the timeouts if a
webxr frame has not yet been submitted.  This is essentially the logic
that existed for these timeouts prior to the implementation of the
throttled logic.

Bug: 1014764
Change-Id: Ia9646799b8d54efc1f39e8800bf82acc5cf861a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865810
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706681}

This reverts commit d680737d.

Reason for revert: Causes a different crash in return for fixing one.

Original change's description:
> Fix message center crash
>
> Modify check for message center gaining activation to not
> dereference the message center widget. There's a crash
> caused by focus switching between the message center
> and quick setting bubbles before the message center bubble's
> constructor has exited.
>
> Change-Id: Ia15acb47dc3806466a2f40a73e843333655e7953
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860692
> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
> Reviewed-by: Tim Song <tengs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705749}

TBR=tengs@chromium.org,amehfooz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie38a91a9c3ef177425b461ec6b42822d0c0c5bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865657Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706680}

Generate constant names have recently changed to CONSTANT_CAISING. This
CL fixes usage of the old names.

Bug: 1014233
Change-Id: Ib7c7c50bcb34150c86bbeec08c7aaac87718de1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862886Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706679}

cros side change:
https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1861131

Bug: 1014218
Test: None
Change-Id: I0caf2f9ae4f4fb0d84a9c09642bcab78294bce0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861138Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706678}

Bug: 1014950
Change-Id: I1e09d061df53b106b1e1ad33923b71122d698882
Tbr: alph@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865813Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706677}

Bug: 969139
Change-Id: Iae7fd1ef3ae269cfac1db6fea41016864328e0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845964Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706676}

As of https://chromium-review.googlesource.com/c/chromium/src/+/1657387,
the VariationsHeaderHelper no longer needs code to support URLRequest.

Bug: 773295
Change-Id: Ide7d426f5b27701f1ac3063d2ee674a4879016ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853105
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706675}

We want to keep this around for a couple more milestones
because it will be a way to test/opt out of the new referrer
policy default (crbug.com/1014207).

Bug: 1014207
Change-Id: I67fe1b41ecf2c1ca76b744f4c1dcd1c7da2b8f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865557
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706674}

This turns on the flag to compute the aspect ratio for <img> elements
from the width/height attributes, if any, while the image is loading.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/GePU9T8UpEc/bET6Mi60CgAJ

https://chromestatus.com/feature/5695266130755584

Bug: 979891
Change-Id: Ib7aa7c8766807613af2bf01eea21a64925095763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865546
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706673}

crrrev.com/c/1846313 added noise to the network threshold for heavy ads. This
change did not override the noise provider in
AdsPageLoadMetricsObserverTest.HeavyAdWithUserGesture_NotConsideredHeavy, This
does not break the test because we never consider the ad to be heavy. However, if
there was a regression that caused an ad with a user gesture to be considered heavy,
this test becomes non-determinstic as the noise may cause us to not label it as
heavy.

This CL mocks the noise provider to 0 to ensure we are testing the user gesture logic
correctly. This similar behavior was seen in two other tests which are also updated.

Change-Id: I7f085800b6ae189a5082c207460defd68b371638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849130
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706672}

This CL handles:
1 - Sets the height of ThinWebView correctly without using custom full ratio
2 - Recalculates and sets the height correctly on an orientation change

Bug: 1014225
Change-Id: Ie3c129cce6755603abea032f71d21e1c50537177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860599Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706671}

This CL modify the spacing to taking 1/3 of the available space if we
have a small screen or in portrait mode, 1/5 if we have large screen.

Bug: 1011641
Change-Id: I97020a650f416c9976eb5a9ab32b038a9338ba53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865553Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706670}

Bug: 1011908
Change-Id: I95190f8f0ecbad7a5ae556145e92e9b5094041f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864419Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706669}

This change modifies the plumbing for autofill state to include
autocomplete as well. Though these two concepts are similar, they
are different, and we would like to keep them separate inside blink.
Screen readers can then choose how they want to expose these
pieces of information to the user.

This change also modifies where autofill/autocomplete state is stored.
It was previously being stored on each AXLayoutObject, many of which
never needed this information. Now, autofill/autocomplete state is
stored in AXObjectCache so we only store this information for
objects that use it.

Bug: 994904
Change-Id: Ie9c924a033fad949efee27d466c79215689a87c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766701
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706668}

Also cleaned up:
- duplicate 'printing' section in WebLocalFrame
- superfluous IsLoading() override in WebLocalFrame

Bug: 416660
Change-Id: I2a9d1ed89d1f8d4d7c3d297fe9066a42fa77f2f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864617Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706667}

- Fetch ThreadState from page header instead of TLS.
- Avoid virtual call when checking for large object pages.
- Directly go through object_start_bitmap() instead of using
  FromInnerAddress, as we know that the address is neither null, nor in
  the linear allocation area or pointing to free space.
- Fold TryMark and Mark at the expense of an Unmark() for the rare
  case where an object is in construction.

Output on Z840 (down from ~21.8x):
[ RUN      ] WriteBarrierPerfTest.MemberWritePerformance
*RESULT WriteBarrierPerfTest writes during GC: = 28129.39521800281 writes/ms
*RESULT WriteBarrierPerfTest writes outside GC: = 480769.2307692308 writes/ms
*RESULT WriteBarrierPerfTest relative speed difference: = 17.091346153846157 times
[       OK ] WriteBarrierPerfTest.MemberWritePerformance (32 ms)

Bug: 1014414
Change-Id: I9319a312a94a4fbafd4d87145414e7b2f4acd583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865163
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706666}

l10n_util::GetApplicationLocale() returns empty string on Android since
we don't pack any .pak file into our apk, which makes the notification
client always fallback to en-US. This CL fixes this by calling
base::android::GetDefaultLocaleString() on Android to get back the
default locale.

Bug: 1001291
Change-Id: I0d8499d00dcd8a1343109377b3bee6f708c43e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864362
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706665}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/341f30345fd1..4283206673b9

git log 341f30345fd1..4283206673b9 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 khegde@chromium.org diagnostics: Add healthd_ec to cros_ec-access

Created with:
  gclient setdep -r src/third_party/chromite@4283206673b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I2caa5eda4bfd750f0673b0c2fb0b3a1d19d3e833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865584Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706664}

This operation doesn't make sense on remote frames.

Bug: 416660
Change-Id: I24ab6dfbfa1e582a920f7502076e88e24eccaa47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865610Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706663}