- 04 Oct, 2019 40 commits
-
-
Sky Malice authored
Bug: 995480, 995482, 995488, 995489, 995497, 995499, 995500, 995505, 995512, 995516, 995519 Change-Id: I7dc1aaab76b498c35a57cbfdcad35f87f98dd098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829648Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702870}
-
Ben Wagner authored
This makes it much easier to roll expat. It automates calling rolldep, updating the README.chromium, updating the expat_config.h configuration header, and adds the OWNERS to the review. Bug: chromium:1004341 Change-Id: I9e19e0016cedc12b1f2079cd54b95bd7e3d3f25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829677Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702869}
-
danakj authored
The post task in RenderWidget was in order to keep IPC receipt of destruction of a frame-based RenderWidget (ie a RenderView in the past) from happening while the RenderWidget was already closing due to the renderer-side detaching, but running a nested message loop. The RenderView destruction now already does a PostTask hop in RenderThreadImpl before starting destruction of the RenderViewImpl and its frame tree and RenderWidgets. A RenderWidget for a frame closes when the frame detaches, and that is built to be consistent even if it occurs inside of unload. The RenderWidget does not need to be kept around after the blink frame and RenderFrame and WebWidget associated with it are all gone. Popups and pepper RenderWidgets can close during a frame unload without a consistency problem. R=dcheng@chromium.org Bug: 419087 Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#702868}
-
Mikhail Khokhlov authored
Telemetry marks stories as failed when there is a problem with metrics computation. This CL reproduces the same behavior in Results Processor. Bug: 1010041 Change-Id: Idb0b86fc30c2cc4a9e8fd18feb56737501f34487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840654Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#702867}
-
Johann authored
libyuv is referenced in vpxenc.c but was never built or used anywhere in chromium. Make this explicit. BUG=1011071 Change-Id: If3fd27ccc728cbe50023297b47744596634978da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838164 Commit-Queue: Johann Koenig <johannkoenig@google.com> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#702866}
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/449, this CL makes use of ={} syntax in IDL files. Bug: 877147 Change-Id: Icc2fd12b7cf7800456398f6e1a5021e159a3f8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837791 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#702865}
-
John Delaney authored
These histograms are still being used to evaluate the AsyncStackAdTagging experiment. Bug: 995527 Change-Id: I8959e046d1ad6559ff7ef369b97ceba2649d15dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832401Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702864}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the viz::mojom::CompositorFrameSink and viz::mojom::CompositorFrameSinkClient interfaces, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ic01dd94b8e070794df82668d01e0c45b058737f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835507Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#702863}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the browser and renderer processes for the resource_coordinator::mojom::blink::DocumentCoordinationUnit and the resource_coordinator::mojom::blink::ProcessCoordinationUnit interfaces to the new mojo types. Bug: 955171, 978694 Change-Id: I7fd19d7aa32882347bf059a00f17269aecabc1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837613 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702862}
-
Torne (Richard Coles) authored
The framework attempts to call {manifest_package}.R.onResourcesLoaded() when an APK that is built as a library (typically WebView) is run as a standalone app, which is intended to fix the R class references to point to the correct package ID. We usually already generate the required class/method, but we weren't keeping it during proguard. Fixing this by adding the missing keep rule and ensuring that we always generate a class with the right package means that code running in the context of the WebView APK should now be able to refer to resources normally via the R class without needing to use getIdentifier. Bug: 1009982 Change-Id: Ib33d59ca2696ba949536be34c997690a310c2370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834042 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702861}
-
Paul Lewis authored
Bug: 1009443 Change-Id: If5cc243605332b6264aead0ba2a869a751e57bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834143Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#702860}
-
Andrew Grieve authored
I noticed that md5_check.py was taking up to 200ms for javac actions. Turns out it was due to it hashing really big .jar files. The utility of md5_check is that it tracks the md5s of often-changing source files (e.g. .java files). It's not worth spending >100ms to check if rt.jar has changed over and over again. This now uses mtime for files greater than 1mb, and the md5_check overhead for javac.py is down below 10ms on my machine. Bug: 906803 Change-Id: I4956419e12b69ad025f12a79d82cf044fc9db34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839238Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702859}
-
Armando Miraglia authored
On CrOS when the default device is unplugged, the capturing is automatically switched to the next default device. This is not the case for other platforms. For this reason, we should not surface the onended when the default device is unplugged. BUG=b:141964689 Change-Id: Ia804a25147a213d2db6827670c586e89370eb06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840513 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#702858}
-
Abhijeet Kandalkar authored
This CL converts usage of |TracingSessionHostRequest| to mojo::PendingReceiver<mojom::TracingSessionHost> Bug: 955171, 978694 Change-Id: I79f31015757c0a92179c60fb5fea69adcd24ae59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831930Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#702857}
-
Daniel McArdle authored
This CL attempts to improve the fuzzer coverage of the various Create() functions that are invoked by RecordParsed::CreateFrom(), e.g. ARecordRdata::Create(). See [1] for fuzzer coverage prior to this CL. [1]: https://chromium-coverage.appspot.com/reports/699620_fuzzers_only/linux/chromium/src/net/dns/record_rdata.cc.html Change-Id: Icad9ca987464f76099daf649d9f46f41c1c9ab9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829939 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#702856}
-
Yasmin authored
Bug: 1005288 Change-Id: I336f17fa43b7d0db0b4d16657fd3d14a925deedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837771Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702855}
-
Andrew Grieve authored
I think this was an unintended side-effect of turning on multidex-by-default for apks. When building all transitive dex for chrome_java: 23.6 s weighted time to generate 225 .main_dex_list files (167.1 s CPU time) When building just chrome_java: 2.3 weighted s to build gen/chrome/android/chrome_java.dex.jar.main_dex_list (2.3 s CPU time) Bug: 937874, 906803 Change-Id: I46d4e8f610fd50d0ad645b9656c677595ac9dd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837217Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#702854}
-
Laís Minchillo authored
If ConnectivityManager.getDefaultProxy() returns a ProxyInfo with host "localhost" and port -1 (which is invalid), extract ProxyConfig from the original Intent in the PROXY_CHANGE_ACTION broadcast. Bug: 993538 Change-Id: Ic61b5f5527a921596b71e7b0582436827b1739e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765848 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702853}
-
Matthias Körber authored
To avoid flakiness of |SaveImportedProfileSetModificationDate| the timeout was doubled to 2s. Bug: 1010684 Change-Id: I54c4e063cc224e0552e02c767075da51bb0d3434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840651 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#702852}
-
kylechar authored
The draw() call should only fail if the SkSurface and SkDDL are incompatible. This indicates a bug and should never happen. Bug: 1009452 Change-Id: I4b3c5199439f5380310c58526576c8542178ae14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837658Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702851}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9d32f659. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 9d32f659 "[Contacts] Update implementation to match spec changes." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ifa5b4bd0ee3f086710defbd174521fdf02831b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840671Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702850}
-
François Beaufort authored
https://dawn.googlesource.com/dawn.git/+log/3fd022ef6041..21dfc919547f $ git log 3fd022ef6..21dfc9195 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 bryan.bernhart Resource Management 7: Device memory sub-allocation using buddy allocator. 2019-10-03 beaufort.francois Add missing optional label member to descriptors Created with: roll-dep src/third_party/dawn Change-Id: I1011570dcc920cd005ad5bba2a5022f63b595fb5 Bug: 877147 Bug: dawn:22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839691Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#702849}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I717d5456ab9c0a00ac254f83727c0a6f46b3d0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826894 Auto-Submit: Mythri Alle <mythria@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#702848}
-
Marina Ciocea authored
The name of the shared tab is calculated based on the URL of the shared tab, and it's used in TabSharingInfoBarDelegate to create different infobar layouts for shared tab vs other tabs. In some cases the tab name can be empty, if the URL doesn't have a host like about:blank for example. Use the tab title instead when the tab name is empty. Bug: 1010995 Change-Id: I4ca333f13b53f66b6f7d251d9c53a020e3f52a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840652Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#702847}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 1011255 Change-Id: I8bd7cf00b7bedae650f28ae343e77fb8970db2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840636Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#702846}
-
Nick Diego Yamane authored
DiceSigninUiUtilTest inherits from BrowserWithTestWindowTest so runs UI code (e.g: WindowTreeHost, etc), which makes tests to crash, hitting DCHECKs, when MessageLoopCurrentForUI is used, for example. So, change its constructor to use default BrowserWithTestWindowTest traits, which implies in MainThreadType::UI being used. Bug: None Change-Id: Ie27fb19e83881168fa79a837a5fef49353086098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839071Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#702845}
-
Nico Weber authored
These files are already listed in extra_js_files in //chrome/test/data/webui:unit_tests_js, so this doesn't change behavior. On the win/cross build, the js2gtest() is a no-op and it throws isolate errors since these files don't exist. See also https://chromium-review.googlesource.com/c/chromium/src/+/1837411 TBR=dbeam Bug: 995737,912946,1010561 Change-Id: I87a413f820fa9dc5294657a3bef07330da3feb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840812Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702844}
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/268593669. The chrome_os_user_report_request and chrome_os_user_report_response IDs are changed in https://critique.corp.google.com/#review/270056000. Change-Id: Ib8035ac50dd5cbdbb0d67be9e4be1c0c6f816605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824272Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#702843}
-
Mike Jackson authored
This change updates DevTools a11y performance tests to help facilitate the upcoming axe-core roll to V3.3.2. axe-core v3.3.2 will now return an error if the element passed in to axe.run are not attached to the document. This change is to ensure that we show the performance panels, thus ensuring its attached to the document. Bug: 984817 Change-Id: I772f37670d59f72c5638188a7b4a7c4d99461f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837277Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702842}
-
Charlie Harrison authored
This reverts commit 255e53df. Reason for revert: Test is not the root cause of this failure. See https://bugs.chromium.org/p/chromium/issues/detail?id=1011275 Original change's description: > Disable flaky MetricsWebContentsObserverTest.TimingOrderError > > TBR=csharrison@chromium.org > > Bug: 1011203 > Change-Id: Ie9807b09fb16726f117c02507a3a200d22acfe0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839311 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Auto-Submit: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702698} TBR=yoichio@chromium.org,csharrison@chromium.org Change-Id: Ie3c883479388584376bd84816ae7e379f4e09ea6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841111Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#702841}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56b86259997a..ddbd321fd7d7 git log 56b86259997a..ddbd321fd7d7 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 perezju@chromium.org [Telemetry] Refactor story_runner_unittest.RunBenchmarkTest Created with: gclient setdep -r src/third_party/catapult@ddbd321fd7d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1008852 Change-Id: I9f1b850dd5c4a6dc8abc28932933c858bcf99a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840711Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702840}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/31be647e..485edf28 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib52654548944ed67514c337694b5e6a7963ec129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839879Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702839}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/78c82a40409d..f83d0ef0859c git log 78c82a40409d..f83d0ef0859c --date=short --no-merges --format='%ad %ae %s' 2019-10-04 phoglund@webrtc.org Revert "Remove an old hack from test_main_lib.cc." 2019-10-04 srte@webrtc.org Replacing /target:target with /target in BUILD autofix. 2019-10-04 sprang@webrtc.org Adds support for passing a vector of packets to the paced sender. 2019-10-04 srte@webrtc.org Cleanup of simple TODO(srte) comments. 2019-10-04 phoglund@webrtc.org Remove an old hack from test_main_lib.cc. 2019-10-03 srte@webrtc.org Base overhead calculation for audio priority rate on available data. Created with: gclient setdep -r src/third_party/webrtc@f83d0ef0859c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I88909bbe12a74caf5c36ba268bff34ff9ace2cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702838}
-
Rune Lillesveen authored
The FIXME comment does not make sense with the current state of the code. Change-Id: Ia13d8de2d2b09b4bfaf5ae353c8fb439cb8e40cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840831 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#702837}
-
Tanmoy Mollik authored
The sign-in code uses the apisid Gaia cookie as a way to detect changes to Google accounts on the web. sapisid is the secure version of apisid. Bug: 889632 Change-Id: I8bf7790c5a1c85da6ae7d890dc7ce3d8a3f38928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827399 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#702836}
-
Ioana Pandele authored
This is a reland of 74640a89 TBR=vasilii@chromium.org Original change's description: > [iOS] Make the leak detection backend available on iOS > > Bug: 986317 > > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702059} Bug: 986317 Change-Id: I490b8d96074e1786b74905a083f0554fe914b4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840771Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#702835}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84f61e2273d6..0ce0e2c0a426 Created with: gclient setdep -r src-internal@0ce0e2c0a426 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I30e40d20156720ef1a8dff58a7d6415e7322be5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840591Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702834}
-
Anna Malova authored
Set CACHE_DIR to WV-specific directory (WebView). Folders under app_webview are moved into app_webview/Default. HTTP Cache under cache/org.chromium.android_webview is moved into cache/WebView/Default/HTTP Cache. Bug: 963875 Change-Id: Ifa150fe0a40a775bc1705e1ac4ea355e67dbee0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793087 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#702833}
-
Kazuhiro Inaba authored
This reverts commit 5142981c. Reason for revert: Causing crashes on Octopus (kernel 4.14) media plays b/141202973 Bug: b/141202973 Original change's description: > Relax NV12 format rejection for exo > > Applies the same restriction in other scenarios (web page/apps). > > * Reject iff > - the buffer is cropped hirozontally, and > - the cropped bounds' horizontal coordinates (x and width) doesn't > fall into even pixel boundary > > Bug: 997821 > Test: manually tested with netflix web/arc apps on eve. > Change-Id: I10ea54da345427eb33fbee25c8d872363d08b0a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775190 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692771} TBR=oshima@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997821 Change-Id: I4633f6aac96505fbc1c173a65bc1b4d7a79b9726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838896Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#702832}
-
Sebastien authored
- Made the GamesService extend KeyedService. - Added a new games directory under chrome/browser - Implemented a simple keyed service factory for the GamesService. Bug: 1006874 Change-Id: I0e71845b6a8f87e3fffad4c20deba93d00f1e79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838331Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#702831}
-