- 03 Apr, 2020 15 commits
-
-
Daniel Rubery authored
We want to fail open, but we don't want to tell the user "Scan complete" if the scan didn't actually complete. Change-Id: I174a9cec446ade9282438d1b1dd240cbbe3153be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132782 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#756089}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I3d893bdb737ec96f5f0cd3f998eb147388b0753d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132351Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756088}
-
Lily Chen authored
This reverts commit 2507555f. Reason for revert: Expected full rollout delayed Original change's description: > Enable SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure > > TBR=jschuh@chromium.org > > Bug: 953306 > Change-Id: I5bde61d8ff66261ade4e68caadafda73c522df00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122809 > Reviewed-by: Lily Chen <chlily@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753807} TBR=jschuh@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 953306 Change-Id: Ic7da4e9938184e2833895ff263325c01948be6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135046Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#756087}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Icf74f98bc7d2472c1475b38558aec93bd13640e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132079Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756086}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Id7281021934fb65c18236ab7d2c28ccefe7342d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132350Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756085}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I36d9b145b303908274be19d9f8374dc181e9af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132021Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756084}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iac720bf6eed6f24e55fc017ce97eb7e2e4e52f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132078Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756083}
-
Majid Valipour authored
Implement basic element-based IDL and processing. - Change existing start and end offset to accept a dictionary at the moment it only has target and threshold but no edge or rootMargin. - Add ScrollTimelineOffset that can handle both the existing string or the new dictionary based offset. - Update ScrollTimeline to use new the offset class. - Implement basic validation logic for new element-based offset. - Add test verify correct parsing and validation on construction. This is the first patch in a series. Follow up patch [1] would use this new offset input to produce the resolved offset. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2100887 Test: wpt/scroll-animations/constructor.html Bug: 1023375 Change-Id: Ie14fb2127d089a39379c498b4b15c86e6b2dd272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070673 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#756082}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I5e86464399de6553de95300992a7582ecf63eaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132076Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756081}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4400d32f044c..f954babacc6c git log 4400d32f044c..f954babacc6c --date=short --first-parent --format='%ad %ae %s' 2020-04-02 btolsch@chromium.org Fix bot name in try bucket Created with: gclient setdep -r src/third_party/openscreen/src@f954babacc6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I280e61d4cf9104f8b8fd41afa34612f362695acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756080}
-
K. Moon authored
tools/autotest.py currently uses `"win" in sys.platform` to detect if the current platform is Windows. macOS uses "darwin" as the platform, so this check erroneously detects macOS as Windows. According to the documentation for sys.platform, the platform value should be matched against sys.platform as a prefix: https://docs.python.org/3/library/sys.html#sys.platform This change tightens the check to only detect platforms starting with "win32" as Windows. R=mthiesse Change-Id: Ic46cbc3b28c250d6557a58f583d5a9ba03df5b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134964 Auto-Submit: K Moon <kmoon@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#756079}
-
Xiaoqian Dai authored
Bug: 1061144 Change-Id: I1977fceb66746a6d56913b3cbb2b7c0551760681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135012Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#756078}
-
Jimmy Gong authored
- Hooks up the Mojo handler interface to the Print Management app. - Generates js-lite bindings from printing_manager.mojom. Bug: 1053704 Change-Id: If5df4fe8313e510de0548a72b50277bda585535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117163Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#756077}
-
John Budorick authored
Bug: 1011494 Change-Id: I8618af474f354fd6b4e50d43d3d1a3e995f2ef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135148Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756076}
-
Jinsuk Kim authored
ChromeTabUtils.fullyLoadUrlInNewTab sometimes takes long to finish on Tablet. Replaced it with ActivityTestRule.loadUrl. What they do is different but doesn't matter for the goal of the tests as long as they load a given URL. Swiping left and immediately swiping right on rendered pages sometimes fails. This CL gives a bit of delay before the second swiping starts for the gesture navigation to be ready. The tests for left swipe were removed, since those testing right swipe also include left swipe. Tested locally on Nexus 7. Bug: 1041233, 1051221 Change-Id: I4bf866f2521c02b3c4500d47776ba80fdea91ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125914 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756075}
-
- 02 Apr, 2020 25 commits
-
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: I591340da66ae1e581d87e644ed143d90ef092e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117140Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#756074}
-
Anders Hartvoll Ruud authored
Change-Id: Id8b9b3ede1a3589ee8ce19afa0ca84db303a7c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132196Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#756073}
-
Gyuyoung Kim authored
This CL moves radiobutton-min-size.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Bug: 1063749 Change-Id: Id38ac0e7fab2bae3e60de87b9dfbab9817985545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132658Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756072}
-
James Cook authored
This logic was duplicated in 3 places, so consolidate in a new helper function. Bug: 1059085 Test: browser_tests, unit_tests Change-Id: I5101d19f195f7ee9c1157330fa634a5f14b47cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132332 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756071}
-
David Grogan authored
Old code wasn't taking advantage of both cache slots. This was not just a regression relative to a previous FlexNG version, but was also significantly worse than legacy flex. Bug: 845235, 1064411 Change-Id: I03955e4dffd4fae6829f60b8d5e105b1a058da7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121738Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756070}
-
Livvie Lin authored
This metric is similar to Security.SecurityLevel.FormSubmission, but more specific so that mixed content pages and subframe submissions are not included. Bug: 1067005 Change-Id: I355c325c7e9b7cece6fb26becd994fccb08ee983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132682Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756069}
-
Regan Hsu authored
* Created SearchHandler wrapper. * Copied an ethernet svg from Polymer's iron-icons into os_icons.html. * Copied a settings svg from Polymer's iron-icons into os_icons.html for general use. * Add icons support for the 3 available mojo result icon types. * Add arrow forward icon on the RHS. * CSS alignments. Screenshots: https://screenshot.googleplex.com/7dMbgYnp6vA (real results) https://screenshot.googleplex.com/aQH3hpPVXqj (fake) https://screenshot.googleplex.com/Bu8xZnk7bN6 (focus on entire row) https://screenshot.googleplex.com/sQzcVgZLHqd (narrow mode) Bug: 1056909 Change-Id: I1bdeba2685ae80684b4aae6ddb347071f303e2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131013 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756068}
-
Ian Kilpatrick authored
This adds additional logic to CanUseCachedIntrinsicInlineSizes to use the cache logic more. This logic is covered by the "new" css/css-sizing/intrinsic-percent-replaced-dynamic-* Change-Id: Ic0cdf68978ba1fb84fa0a586c48da035239fb7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116531 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#756067}
-
Ben Mason authored
Bring chrome://terms in line with https://www.google.com/chrome/terms/ Bug: 1060545 Change-Id: I5987f94338734523c5896e651f938c3758fdab12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134767 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#756066}
-
Danan S authored
The OK button in this case shows the string "Ask a Parent" Bug: 1067061 Change-Id: I1d65bd1fd6bbede0f7544ea1c4101553b421ebd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132541Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756065}
-
Danan S authored
This patch whitelists the Chrome Webstore in the SupervisedUserUrlFilter, but only if it hasn't been specifically blocked by the parent. Bug: 1065544 Change-Id: I7d4755e9225a83b899f73a1f0de7f1c839744097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133557 Auto-Submit: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756064}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ecdd22b0b60..19d4809e1126 git log 4ecdd22b0b60..19d4809e1126 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 brucedawson@chromium.org Use "call" in gclient.bat to restore title Created with: gclient setdep -r src/third_party/depot_tools@19d4809e1126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib29099db5f311d1b7c6b8095db3c87fccc025d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134713Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756063}
-
Anders Hartvoll Ruud authored
Running without the CSSCascade flag doesn't work anymore, since we hit a DCHECK. We're not supposed to calculate the animation update more than once, and with CSSCascade disabled it can potentially already have happened once we reach ApplyAnimatedStandardProperties. This CL re- introduces an if-check that was removed in [1] to fix the issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2064248 Change-Id: I340f31543f63ed05a6a033ece0779ffaa8d57e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132400Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#756062}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/094f8e6f0c43..daabea6ba6c0 git log 094f8e6f0c43..daabea6ba6c0 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 thestig@chromium.org Use FX_AllocUninit() in FxAllocAllocator. 2020-04-02 thestig@chromium.org Mass rename "nameTree" variables. 2020-04-01 thestig@chromium.org Fix insertions into empty name trees. 2020-04-01 thestig@chromium.org Parse pdfium_tests's feature string in TestRunner. 2020-04-01 asweintraub@google.com Change for loops to use const refs where possible. Created with: gclient setdep -r src/third_party/pdfium@daabea6ba6c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie789a46175358410baad7265b6f6c48f8af3f2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756061}
-
Trent Begin authored
NetworkHealth now gathers a subeset the underlying network device's properties. Bug: chromium:1057739 Test: unit_tests --gtest_filter=NetworkHealthTest.* Change-Id: I69a9be3226ce515a049708357978e9d313e84c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133162 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756060}
-
Tom Anderson authored
BUG=1002674 Change-Id: Idf223f1193cbe1dde07901f5e28f1422b464cf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098159 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756059}
-
Jonah Chin authored
This change introduces the TextureBacking interface that will be used on PaintImage. This CL simply introduces the cc interface. Follow up changes will introduce the blink-side implementation. This is being done as part of the OOPR-Canvas2D project. For more info about the project see the tracking bug here: crbug.com/1018894 Bug: 1031050 Change-Id: I844c441bea308507a541fd3e131159f7c1d16b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131216Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756058}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/33cc65df59f1..cafccfd0e563 git log 33cc65df59f1..cafccfd0e563 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 michael.liao@microsoft.com [Elements - Styles Pane]: Adding SR announcement when adding a class successfully using '.cls' button Created with: gclient setdep -r src/third_party/devtools-frontend/src@cafccfd0e563 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066163 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2f7984d68c034fba4004ccd84b089231a9cdfa9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756057}
-
Istiaque Ahmed authored
This CL also makes its member to be stack allocated base::Value instead of dynamic allocated one. Bug: None Test: Minor cleanup, no behavior changes expected. Change-Id: I6b97497c43e7c37b6dd5481049834c3b54b9b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133207 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756056}
-
Paul Moy authored
Instead of having every unit test duplicate the code for creating its own RemoteCommandJob, move this code inside the test fixture so the logic is only needed a single time. This also lets the fixture's methods access the job without specifically being passed the job as an argument. Bug: chromium:1066251 Change-Id: I2d31ba0b77246d16ee41cad6e4b0e154c716d1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131326Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756055}
-
evliu authored
This CL contains the renderer-side changes for the Live Caption feature. The design document can be found at: go/chrome-live-caption. Bug: 1065563 Change-Id: I8a50e2afe4b13cc88b122a18e23c2275ace527d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127419Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#756054}
-
Hesen Zhang authored
This reverts commit 0a948617. Reason for revert: Issue 1067443: Step "snapshot_unittests" failing on 1 builder(s) Original change's description: > Add EDU login flow: CSS fixes > > Address comments to UI implementation - update margins and logo size. > New screenshots: > http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI > > Bug: 1054798 > Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756012} TBR=xiyuan@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Change-Id: I81184b3bf1adf68915934cd353f9617b58268265 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135023Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756053}
-
Alex Danilo authored
Bug: 960277 Tests: browser_tests --gtest_filter="*openQuickViewMhtml*" Change-Id: I8be8483e6b5dd6e3e99701bfc14551262c782090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131822Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756052}
-
Timothy Loh authored
This CL wires up the toggle in settings for controlling printer access from Plugin VM to a new pref plugin_vm.printers_allowed. When this or the PrintingEnabled policy is set to false, the CUPS proxy will return a 401 forbidden error to every request. Bug: 950431 Change-Id: I14c395b53ea11bcb9c438266e36aa21e6fcd85b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120110 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#756051}
-
Meredith Lane authored
This reverts commit 402af855. Reason for revert: Causes blink_web_tests to deterministically fail on Linux, first failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87941 Original change's description: > Remove more passing WPT tests > > Remove more tests that are passing consistently. > > BUG=626703 > > Change-Id: I65d54aebe19c4ee6aa5177eb63318ed3810d428c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127514 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755829} TBR=dtapuska@chromium.org,robertma@chromium.org Change-Id: I06631b9d4e4a4f21eb7d27600398343a661078e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 626703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134747Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756050}
-