GitLab

This was detected by ASan's new container-overflow feature.

BUG=409051
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/516283004

Cr-Commit-Position: refs/heads/master@{#292674}

BUG=404813,405622

Review URL: https://codereview.chromium.org/502333002

Cr-Commit-Position: refs/heads/master@{#292673}

For the actual changes, check:
vp8 fix: deallocate denoiser->yv12_last_source
https://codereview.chromium.org/506203004
Disable LTO for one target.
https://codereview.chromium.org/471653004

BUG=408997

Review URL: https://codereview.chromium.org/522573003

Cr-Commit-Position: refs/heads/master@{#292672}

Sort the list of input resource files for the jarjar resource step so
that the contents of generated makefiles in WebView have a stable
ordering.

BUG=

Review URL: https://codereview.chromium.org/516293003

Cr-Commit-Position: refs/heads/master@{#292671}

And add a long explanatory comment about how things are shut down.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/517373002

Cr-Commit-Position: refs/heads/master@{#292670}

- Fixes gcc_version issues on gTrusty.
- Fixes accidental duplicate in input_events build file.
- Fixes spammy warnings in libxml.

BUG=none
TEST=builds

Review URL: https://codereview.chromium.org/518543004

Cr-Commit-Position: refs/heads/master@{#292669}

This makes it behave the same as the Close function.

Destroying RenderWidgetCompositor during RenderWidget::DoDeferredClose
can cause problems for nested message loops.  The bug is that
InputHandlerProxy creates a SwapPromiseMonitor which adds itself to the
LayerTreeHost.  In that stack, a nested message loop is run which runs
the RenderWidget::DoDeferredClose function which previously destroyed
the LayerTreeHost.  This explodes, because LayerTreeHost expects all
SwapPromiseMonitors to be removed before it is destroyed.

Making DoDeferredClose non-nestable avoids this problem, as the nested
message loop can't run the task, the SwapPromiseMonitor safely gets
removed, and then the LayerTreeHost can be cleanly deleted.

This patch depends on https://codereview.chromium.org/512533002

R=jamesr@chromium.org,danakj@chromium.org
BUG=403500

Review URL: https://codereview.chromium.org/513433002

Cr-Commit-Position: refs/heads/master@{#292668}

BUG=309681
NOTRY=True

Review URL: https://codereview.chromium.org/523703002

Cr-Commit-Position: refs/heads/master@{#292667}

ef9d63ec to a502c749.

Contains refactors of shader objects, errors and validation.

Review URL: https://codereview.chromium.org/518873002

Cr-Commit-Position: refs/heads/master@{#292666}

This fixes a class of test flakes that impacts all Windows tests that
use registry_util::RegistryOverrideManager.

BUG=none
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/519773002

Cr-Commit-Position: refs/heads/master@{#292665}

BUG=110610

Review URL: https://codereview.chromium.org/518743002

Cr-Commit-Position: refs/heads/master@{#292664}

BUG=110610

Review URL: https://codereview.chromium.org/514143002

Cr-Commit-Position: refs/heads/master@{#292663}

https://chromium.googlesource.com/chromium/blink/+log/55f9f55cb598e92a166451f4848ce9b80aab3a8d..3c4c83c54cc17327ea22f7c628e790a8895dde0d
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/522693004

Cr-Commit-Position: refs/heads/master@{#292662}

I also propose to rename this function to just RunTest, because its purpose is to do everything necessary to obtain a build and run a test to get results, and it's a relatively important and high-level function.

"Flat is better than nested."
  -- The Zen of Python, PEP 20.

BUG=

Review URL: https://codereview.chromium.org/484583002

Cr-Commit-Position: refs/heads/master@{#292661}

BUG=392215

Review URL: https://codereview.chromium.org/508263003

Cr-Commit-Position: refs/heads/master@{#292660}

Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store.

TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest*
TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore*

BUG=397545

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289996

Review URL: https://codereview.chromium.org/381073002

Cr-Commit-Position: refs/heads/master@{#292659}

Unifies the existing desc, refs, and check commands to take an output directory rather than creating a build in out/Default. This matches the other commands.

Separates out the label pattern matching code from the visibility component into a separate object so it can be used in commands to match more than one label. Adds support for toolchains in these patterns (this wasn't so necessary for visibility, but is more useful for these other commands). The old pattern code is now used only for the sources filter. This patch moves the documentation for that directly on the sources assignment filter help.

Enhances "gn check" to take a label or label pattern of targets to check. This is especially necessary now with so many errors, one can focus on one small part of the codebase.

Enhances "gn refs" to work like "gn desc deps" but in reverse. It can print reverse dependency trees, or find all targets that depend on a given target or targets. For example, "find everything that depends on anything in //mojo". It lost the ability to find configs or unresolved dependencies. We could potentially add these back, but they're complicated to implement and less useful.

Adds a "gn ls" command to list targets.

BUG=343726

Review URL: https://codereview.chromium.org/500423003

Cr-Commit-Position: refs/heads/master@{#292658}

Revert of ui: Move ui_unittests.gyp into ui/base. (patchset #5 id:80001 of https://codereview.chromium.org/506483002/)

Reason for revert:
it breaks clobber build of ios_dbg_simulator.

Original issue's description:
> ui: Move ui_unittests.gyp into ui/base.
>
> ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
> ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
> ui_unittests.isolate -> ui_base_tests.isolate
>
> Add a TODO assigned to me to rename ui_unittests target to
> ui_base_unittests when buildbot is updated.
>
> BUG=331829,373148,299841,103304
> TEST=ui_unittests
> R=sky@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/60f6892f7223f9d6db92314edb5df9b63d25720f

TBR=sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331829,373148,299841,103304

Review URL: https://codereview.chromium.org/522843002

Cr-Commit-Position: refs/heads/master@{#292657}

The num_bytes header for an array must contain the real size of the
array, not the 8 bytes aligned one.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/519673002

Cr-Commit-Position: refs/heads/master@{#292656}

BUG=345874
NOTRY=true

Review URL: https://codereview.chromium.org/517383003

Cr-Commit-Position: refs/heads/master@{#292655}

On Linux the distutil returns only the name of the python library.
Passing only the library name is not good for a compiler (in this case
it was a simple 'python2.7'), the script should return the correct
compiler option (which should be the '-lpython2.7')

BUG=408979
TEST=ninja -C out/Release libmojo_python_system.so

Review URL: https://codereview.chromium.org/521653002

Cr-Commit-Position: refs/heads/master@{#292654}

BUG=345874
NOTRY=true

Review URL: https://codereview.chromium.org/519823002

Cr-Commit-Position: refs/heads/master@{#292653}

This is the message validation / receiver end side.

BUG=324170

Review URL: https://codereview.chromium.org/514293002

Cr-Commit-Position: refs/heads/master@{#292652}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/523673002

Cr-Commit-Position: refs/heads/master@{#292651}

BUG=388084

Review URL: https://codereview.chromium.org/493363006

Cr-Commit-Position: refs/heads/master@{#292650}

This fixes some TODOs in ui/BUILD.gn and add GN build file for
third_party/mozilla.

BUG=None
TEST=None
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/521553002

Cr-Commit-Position: refs/heads/master@{#292649}

No longer show page actions in the location bar iff the
extension action redesign switch is enabled. In addition,
make all extensions tests* pass with the switch on! Woot!

*This is based on running these tests locally.  Once
https://codereview.chromium.org/489183005/ goes through,
I can push a run through the trybots with the switch on
by default for kicks and grins.

BUG=397259
BUG=408261

Review URL: https://codereview.chromium.org/516633002

Cr-Commit-Position: refs/heads/master@{#292648}

This pulls in the following Native Client changes:

r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain
r13668: (noelallen) Force rebuild on cmd change.
r13669: (dbrazdil) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13670: (mseaborn) Fix munmap() with length > 0xffff0000 to behave consistently on 32/64-bit
r13671: (mseaborn) Add comment about updating the trybot list in the Commit Queue's code
r13672: (dschuff) Expose LLC's -force-align-stack flag to pnacl-translate
r13673: (dschuff) PNaCl: Update libc++ revision in pnacl/COMPONENT_REVISIONS
r13674: (mseaborn) Use uint32_t for untrusted pointer args: sysconf() and other syscalls
r13675: (mseaborn) Revert r13667: "Re-enable use of Goma on Windows, except when using the PNaCl toolchain"

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/516123002

Cr-Commit-Position: refs/heads/master@{#292647}

It isn't specific to chrome, it has a broader usage.

BUG=None
TEST=./tools/check_grd_for_unused_strings.py
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/523523002

Cr-Commit-Position: refs/heads/master@{#292646}

This reverts commit 662e9508.

Original commit: https://codereview.chromium.org/136853003

BUG=333205

Review URL: https://codereview.chromium.org/473003003

Cr-Commit-Position: refs/heads/master@{#292645}

https://chromium.googlesource.com/chromium/blink/+log/b8b43dd815f11fafd074bea301aa25cc3957be7c..55f9f55cb598e92a166451f4848ce9b80aab3a8d
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/517203003

Cr-Commit-Position: refs/heads/master@{#292644}

Add a ShellAudioController class that activates audio
devices for input and output and requests max volume.

Also move chromeos::NetworkHandler initialization into
ShellBrowserMainParts so that ShellNetworkController can get
tests at some point.

BUG=405968

Review URL: https://codereview.chromium.org/515573003

Cr-Commit-Position: refs/heads/master@{#292643}

BUG=

Review URL: https://codereview.chromium.org/466513002

Cr-Commit-Position: refs/heads/master@{#292642}

And add tests.

BUG=408896
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/524503002

Cr-Commit-Position: refs/heads/master@{#292641}

BUG=352293

Review URL: https://codereview.chromium.org/494853004

Cr-Commit-Position: refs/heads/master@{#292640}

BUG=370977

Review URL: https://codereview.chromium.org/520683002

Cr-Commit-Position: refs/heads/master@{#292639}

TBR=rnk@chromium.org
NOTRY=true
BUG=345874

Review URL: https://codereview.chromium.org/519783002

Cr-Commit-Position: refs/heads/master@{#292638}

BUG=408936

Review URL: https://codereview.chromium.org/522633002

Cr-Commit-Position: refs/heads/master@{#292637}

If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.

This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.

TBR=DaleCurtis@chromium.org

BUG=404884
TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html

Review URL: https://codereview.chromium.org/510073002

Cr-Commit-Position: refs/heads/master@{#292636}

BUG=341408
TBR=TBR=bauerb@chromium.org, benwells@chromium.org, gene@chromium.org, asvitkine@chromium.org, noms@chromium.org, tim@chromium.org, sky@chromium.org, fgorski@chromium.org

Review URL: https://codereview.chromium.org/502343002

Cr-Commit-Position: refs/heads/master@{#292635}