GitLab

- Update spec links to the implementation checkpoint
- Use #section-name instead of #rfc.section.numbers as numbers may change.

Bug: 803774
Change-Id: I6f8a72bd89b7deacb33f9da237caa640b86333bd
Reviewed-on: https://chromium-review.googlesource.com/981813Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546045}

Frees up 256KB of pooled memory used for Oipan's GC.

Bug: chromium:757440
Change-Id: Ie54cda0dc87f616e0e8bb0900184c876ec9a1548
Reviewed-on: https://chromium-review.googlesource.com/980877Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546044}

API bindings are created lazily on first-access. Because of this, the
active context may not be the context to which the API belongs. For
instance, a child frame may instantiate an API on its parent frame, so
that the owning context is the parent frame, but the current context (at
binding instantiation time) is the child frame.

This is problematic if we create objects during the binding
instantiation (such as the APIBindingBridge), because methods called on
these objects will be executed in the context that was active when they
were created. This means that the APIBindingBridge object, for instance,
could belong to a different context than the Chrome API for which it
was instantiated.

In addition to being strange, this can cause a crash in the case that
the child context was not fully registered with the extension system. If
the context is not registered, the C++ code cannot safely run JS code in
that context, which is necessary for API instantiation with JS custom
hooks.  Additionally, the calling context, though not fully registered,
will not be marked as invalid because it isn't scheduled for release.

Contexts can be active, but not registered with the extension system, in
the case when the registration was deferred by the ExtensionFrameHelper
because of a pending browser navigation.

This can eventually lead to a crash when we try to execute JS through
the extension JSRunner for the uninitialized context.

To fix this, force API binding construction to happen with the owning
context as the active context. In this case, the context should always
have been initialized (because otherwise we would not have set up the
hooks for API instantiation).

Bug: 819968

Change-Id: I09890560ca92743ebc855561c9119e625e61e410
Reviewed-on: https://chromium-review.googlesource.com/978791
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546043}

I moved some unittests in [1] but I did it wrongly.

The original tests added N pending connections and measured the delay for
the Nth connection. The new tests add N pending connections and measured
the delay which will be used for a new connection (i.e., the N+1th
connection).

This CL fixes the issue.

1: https://crrev.com/8e55d7a3718dba9fe5d451cf899bef669ba02473

Bug: 721400
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iee4c31414a217496df104c5194452e874be63c5a
Reviewed-on: https://chromium-review.googlesource.com/981960
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546042}

Tbr: boliu@chromium.org
Change-Id: I8fb1063286de9e2955ece5a4d605720ef6f0d94c
Reviewed-on: https://chromium-review.googlesource.com/980274
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546041}

VS 15.7 (VS 2017 Update 7) warns on a conversion from size_t to uint32_t
class BreakList. This was probably avoided in previous compiler versions
because of how VS handled templates, which they are now fixing.

Adding an explicit cast avoids the warning.

Change-Id: Ib9dadbe079b57bfe0a37324858a912f8f9c1cb94
Reviewed-on: https://chromium-review.googlesource.com/978956Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546040}

Under certain circumstances, we may try to render quads with missing
resources in GLRenderer. Currently, this leads to a crash.

This change causes us to handle this more gracefully (skip drawing
these quads) rather than crashing. This is a temporary fix until we
figure out why these resources are missing in the first place.

Bug: 811858
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie01891f7816f7797178a63989b301ad276984671
Reviewed-on: https://chromium-review.googlesource.com/920145Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546039}

These tests currently pass by luck as they are missing EnablePixelOutput() call
that is necessary to get proper pixel values out of <video>, that is necessary
for detecting events.

This CL adds a test class instance to setup these tests properly.

Bug: 825996
Change-Id: I2b629d3d5fa8a3b038c101aa3aeed419cb5e04ff
Reviewed-on: https://chromium-review.googlesource.com/981401
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546038}

ash::Shell's UserActivityForwarder notifies UserActivityDetector in Mus.
Observing PlatformEventSource directly is redundant and causes problems.

Reprocessing native events with adjusted locations breaks double clicks.
This patch prevents UserActivityDetector from reprocessing those events.

Bug: 825695
Change-Id: Iefe4af55eedf8efc7515664b2f0cc46abe273866
Reviewed-on: https://chromium-review.googlesource.com/981492
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546037}

This CL creates the chrome/browser/chromeos/apps directory, which will
contain code to facilitate the different apps platforms on Chrome OS
interoperating with each other and the Chrome OS system.

Much of the initial work will be to take existing integrations for
ARC++, and make them sufficiently generic so that other app platforms
can use them. We first focus on the ARC++ intent helper, which allows
users to open an app from the omnibox.

This CL moves construction of the ArcNavigationThrottle, which controls
the appearance of the intent helper, from ChromeContentBrowserClient
into a new AppsNavigationThrottle. Follow-up CLs will begin to split
ArcNavigationThrottle so that the throttle-specific code is moved to
AppsNavigationThrottle. The change in this CL means that the follow-up
refactoring will not need to change ChromeContentBrowserClient again.

BUG=824598

Change-Id: I4062a198b631215709deeab80fe669e0aea53857
Reviewed-on: https://chromium-review.googlesource.com/974761Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546036}

We are failing a DCHECK where we assumed that reset nodes cannot have
non-reset nodes as their next sibling (i.e. a reset node cannot be
followed by a non-reset node on the same level). We were using this
assumption when we wanted to reparent all non-reset nodes and we stopped
at the first reset node.

However, this assumption seems to be wrong as we are hitting this DCHECK
on ClusterFuzz. This patch speculatively fixes this issue by not
stopping at the first reset node.

This is a speculative fix.

Bug: 822217
Change-Id: I83679c51d82d28c7bd1ace92b27cc7910b9c9db4
Reviewed-on: https://chromium-review.googlesource.com/981334
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546035}

Because wchar_t is the same as char16 on Windows, and by extension
std::wstring is the same as string16, instantiating templates using both
of these types leads to duplicate instantiations. This error is only
reported when building with -fno-delayed-template-parsing, but it is
always dodgy/wrong.

Microsoft is working towards supporting correct template parsing which
means that we can also (because they are fixing their headers).

The (simplified) error messages were:
error: duplicate explicit instantiation of 'PrepareForUTF8Output<wchar_t>'
ignored as a Microsoft extension
error: duplicate explicit instantiation of 'PrepareForUTF16Or32Output<>
ignored as a Microsoft extension

Bug: 825352
Change-Id: I5360b14f48277d56c3800238cc77077f13ef9acf
Reviewed-on: https://chromium-review.googlesource.com/981083
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546034}

Bug: 809293
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I301fa871eb33ccbae30c219f4ff3b12c7916f6dd
Reviewed-on: https://chromium-review.googlesource.com/976942
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546033}

Add a new histogram Net.QuicSession.NetworkProbingResult which records network probing results according to different migration causes.

This is a temporary change in order to understand the success/failure
rate of network probings when attempting connection migration.

Change-Id: I3c4c64cec67322a23e39c22269bc3f44790a650b
Reviewed-on: https://chromium-review.googlesource.com/973912
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546032}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4732b3b1c4bf..ee04b9a2f489

$ git log 4732b3b1c..ee04b9a2f --date=short --no-merges --format='%ad %ae %s'
2018-03-26 ehmaldonado bot_update: Make gclient experiment a property instead of an argument.
2018-03-26 ehmaldonado bot_update: Add a flag to move applying the patch to gclient.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:643346,chromium:643346


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I01dfb181687e4f1e325d13aed34ebbb3cf0c96e6
Reviewed-on: https://chromium-review.googlesource.com/981783
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546031}

Change-Id: Iaccfcc4c221052ee123df4c52973ed3878a39bb7
Reviewed-on: https://chromium-review.googlesource.com/967075Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#546030}

Test was disabled in issue 804413 due to the linux-chromeos-release bot
flakiness. Re-enable to determine if the test flakes on the CQ.

Tbr: fukino-san
Bug: 804413
Change-Id: I14b1f3dfcb78123a3deadd227960cdb3db91a874
Reviewed-on: https://chromium-review.googlesource.com/981812Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546029}

Avoids calling methods on null object in ContentViewCoreImpl.
onRotationChanged by adding null checks.

Bug: 824156
Change-Id: I5af9eda71b61e06dc0e55f5eb211504d6dd04bd1
Reviewed-on: https://chromium-review.googlesource.com/981333Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546028}

https://skia.googlesource.com/skia.git/+log/e579f1e70fd8..2ef4525daf15

$ git log e579f1e70..2ef4525da --date=short --no-merges --format='%ad %ae %s'
2018-03-23 herb Remove SkAutoGlyphCache
2018-03-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ a571f28d4..84fdc62c6 (6 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: Id16ab42fe990eab550809344b460d138d996710f
Reviewed-on: https://chromium-review.googlesource.com/981784
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546027}

Change-Id: I0fb1cf2f0a8a12ccd17f07bc764adf9654f8ff1f
Bug: 824802
Reviewed-on: https://chromium-review.googlesource.com/974441
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546026}

This reverts commit aeecb4f3.

Reason for revert: Causing lots of failures on webkit bots, e.g.:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/42143

Original change's description:
> Don't adjust the NavigationTimings on redirects
> 
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
> 
> R=​ksakamoto,arthursonzogni
> 
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}

TBR=kinuko@chromium.org,ksakamoto@chromium.org,arthursonzogni@chromium.org

Change-Id: I467ed888084ea0eda06faa903d1797fabffc47da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813889
Reviewed-on: https://chromium-review.googlesource.com/981912Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546025}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6aab402bbddc..44e40f3f3671

$ git log 6aab402bb..44e40f3f3 --date=short --no-merges --format='%ad %ae %s'
2018-03-26 bhthompson Move -arcnext Android PFQ builders to PI
2018-03-26 bhthompson Add pi Android PFQ configuration for pi-arc-dev Android branch
2018-03-26 xhwang chrome-sdk: Bundle Widevine CDM iff "is_chrome_branded" is true

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:349182


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I71c477e1fa1dba7fe2a53cd73980614938b881c4
Reviewed-on: https://chromium-review.googlesource.com/981785
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546024}

Make the --disable_rendering behave as it should, that is, disable
rendering altogether. With this patch, vdatest can run without any GL
support.

This has the advantage of reducing the subset of code tested, and to
remove false positives due to graphics regressions. It is also useful
during platform bringup where graphics are not always available and
working.

The thumbnails tests do require a renderer to create the thumbnails ;
therefore they are disabled when this option is set.

BUG=819542
TEST=Verified that vdatest was passing on kevin and hana, with both
rendering enabled and disabled and at various fps.

Change-Id: I119165e59cff24913918559d79a5c457e973cea4
Reviewed-on: https://chromium-review.googlesource.com/954770Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546023}

Change-Id: I14e783b5adb905cf27731c55e224f7b0311e2b8e
Reviewed-on: https://chromium-review.googlesource.com/936010Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546022}

Add 2 new UMAs for the files app:
- FileBrowser.SelectSearch, recorded when the user selects the 'Search' button
- FileBrowser.ToggleFileListType, recorded when the user switches between the
  'grid view' and 'list view' options of the files app

mouse), and change the grid view type, then check chrome://histograms.

Test: Select the search box (with keyboard shortcuts, or with tab, or with the
Bug: 397213
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icf073dfae57717a91a6f6dbedc3c3d99dcecbdb3
Reviewed-on: https://chromium-review.googlesource.com/957566
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546021}

This reverts commit 0a869fb4.

Reason for revert: New checker is causing errors on bot 
e.g. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26753

from the failure: The following view violates DoesViewHaveAccessibilityErrors():
browser/ui/views/frame/BrowserRootView > ui/views/window/NonClientView > BrowserView > TopContainerView > ToolbarView > View > MenuButton (id 1008)
- Focusable View has no accessible name or placeholder, and the name attribute does not use kAttributeExplicitlyEmpty.

Original change's description:
> Test any widget activated in a browser test for accessibility violations
> 
> Use ChromeViewsDelegate/WidgetObserver combination to ensure that all
> widgets are tested for accessibility as they become hidden or visible
> in a browsertest.
> 
> The test goes through the View entire subtree and ensure any focusable
> View has an accessible name.
> 
> Bug: 819350
> Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0
> Reviewed-on: https://chromium-review.googlesource.com/951933
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545904}

TBR=sky@chromium.org,tapted@chromium.org,aleventhal@chromium.org

Change-Id: I4acc057b19df35a9350ae04efa06e5f6b69b2e88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819350
Reviewed-on: https://chromium-review.googlesource.com/981634Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546020}

If we're going to recover from corrupt rows by removing everything in the
eTLD + 1, we probably ought to know how frequent they are.

Bug: 787679
Change-Id: I4b01e9442121e747cf24292e01ac640bed5dec07
Reviewed-on: https://chromium-review.googlesource.com/980699
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546019}

This implements the LayoutFragment.inlineOffset and
LayoutFragment.blockOffset attributes.

The tests added simply re-create the reference by setting these two
attributes in different text directions and writing modes.

Change-Id: I1865403ca12e3b174738ee93320eae5ba16ac292
Bug: 726125
Reviewed-on: https://chromium-review.googlesource.com/971832
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546018}

Bug: 234933
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4a42336006cf553bf52d30be4656f953d8341323
Reviewed-on: https://chromium-review.googlesource.com/974447Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546017}

Generate optimized code that will help ARMv8 chips (between 2
to 10% perf gain on ARMv8 little/big cores) at the expense of
a small perf regression on older chips (i.e. ARMv7).

Bug: 772870
Change-Id: Ifc47870724da9790c944f76fedcc225d0a896caf
Reviewed-on: https://chromium-review.googlesource.com/976521
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546016}

Use base::RefCountedBytes::TakeVector() or base::RefCountedStaticMemory
instead.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6bf4cdc2b0dff5f8c75e3a8dacda0da92213a9fb
Reviewed-on: https://chromium-review.googlesource.com/979398Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546015}

LocalCaretRectTest has parameterization for LayoutNG. However, test
case |AfterLineBreak| uses contenteditable unnecessarily, which forces
legacy layout and invalidates the parameterization. This patch fixes
it.

This patch also adds two similar test cases for line breaks in
'white-space: pre' style, verifying that NG LocalCaretRect impl
handles consecutive line breaks at block end correctly.

Bug: 812535
Change-Id: Iaba4bcc616078f35f73fca23565b6628f04f7271
Reviewed-on: https://chromium-review.googlesource.com/974909
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546014}

This only really reports object counts (including for
the wait-till-load queues), but proper thing is kinda
expensive to compute, and this might be enough for diagnosing
the potential leak case.

Bug: 809199

Change-Id: I8afd6902693784da3ecdb9d4066d7d23ed94de82
Reviewed-on: https://chromium-review.googlesource.com/978034
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546013}

This CL upgrades cr-lazy-render for compatibility with Polymer 2. It
does this by using a slot for a <template> from the light DOM which
gets templatized since the cr-lazy-render element itself can no longer
be a <template>.

This means that all clients need to wrap their light DOM in <template>
tags.

Bug: 818279
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieaed7cb2f9422557aed0c3a388939b17b5825245
Reviewed-on: https://chromium-review.googlesource.com/977203
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546012}

This CL has no functional change.

Bug: 228355
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I12f9222642ea1679ff714651f256067b03d88d1e
Reviewed-on: https://chromium-review.googlesource.com/980735
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546011}

This reverts commit 7a1b3bb0.

Reason for revert: Seems to have caused memory failures. Sample failure:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8760
with this in the stack
views::WidgetDelegate::GetAccessibleWindowTitle

Original change's description:
> [Extensions] Remove manifest v1 support for accessible resources
> 
> In manifest version 1, all extension resources were considered
> accessible by the web (i.e., could be embedded within or
> requested by a web page). In manifest v2, only resources
> explicitly specified in the web_accessible_resources key are
> accessible. Remove support for manifest v1, and always check
> the web accessible resources.
> 
> Update unit tests to migrate relevant tests and remove tests for
> manifest v1-specific behavior.
> 
> Bug: 816677, 816679
> Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146
> Reviewed-on: https://chromium-review.googlesource.com/953177
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545898}

TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org

Change-Id: Ifae57fc0f5cb2b738d48527af5e20c19eac5b0a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816677, 816679
Reviewed-on: https://chromium-review.googlesource.com/981336Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546010}

Bug: webrtc:8996
Change-Id: I430b7eeb00088706ff29adf74d46c997e2a66b37
Reviewed-on: https://chromium-review.googlesource.com/974470Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546009}

Remove BrowserThread and WebContents references

Bug: 803135
Change-Id: I791bbeb0bd3d52c497c7bad7d035aaac7440f588
Reviewed-on: https://chromium-review.googlesource.com/981328
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546008}

We have to regenerate ideal bounds when it's updated even when
it's animating.

Bug: 587688
Change-Id: I238808c6242734e1c3749a6dd7bd624f6a8a3bac
Test: TabStripBrowserTest.ActiveTabWidthWhenTabsAreTiny
Reviewed-on: https://chromium-review.googlesource.com/958382
Commit-Queue: SangWoo Ko <sangwoo108@gmail.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546007}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ibabee0c19403e3a2b1273f9b98eb6ca7f1d114a3
Reviewed-on: https://chromium-review.googlesource.com/980095Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546006}