- 07 Apr, 2020 40 commits
-
-
Charles William Dick authored
It is not possible to directly reclaim memory from ARCVM based Android apps, so don't kill them. In ARCVM, the virtio balloon is sized to balance available memory between host and guest, so if there is critical memory pressure in Chrome, there will also be limited memory in the Android guest. ARCVM relies on the Android Low Memory Killer running in the guest to kill apps, increasing the memory available to the guest, which will be returned to the host with the virtio balloon. BUG=b:147336074 TEST=launch ARCVM, run 'grep 'WARNING debugd' /var/log/messages'. verify there's no warning from debugd. tast run <DUT> arc.MemoryChromeOSPerf.vm, also see no warnings in /var/log/messages. (this will force critical memory pressure) Change-Id: I7d610ea44eaf45494f6b4143b053779f6f3df6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135094Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Charles Dueck <cwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756962}
-
Joel Hockey authored
TBR=lxj@google.com Change-Id: Iba61e0db0a9643277afb16d9a118c86854c8dca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138912Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#756961}
-
Kent Tamura authored
Converts max_option_width to LayoutUnit instead of casting to int. The LayoutUnit constructor uses base::saturated_cast<> internally. Bug: 1068338 Change-Id: Id13f98c440eaad1ba2fad8ad0ae84129121c734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138672 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756960}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Idf295365ed27f4299f717bf3995a45afae252c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137106Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756959}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76f4fff613b5..5846ff3c7ae0 git log 76f4fff613b5..5846ff3c7ae0 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 csmartdalton@google.com Make glDraw*BaseInstance non-optional when extension(s) are present Created with: gclient setdep -r src/third_party/skia@5846ff3c7ae0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ia25cbb01846168e27d5a3036c8d3f187bd1449ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756958}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3549e2d6063c..e89877724aba Created with: gclient setdep -r src-internal@e89877724aba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094,chromium:1055749 Tbr: zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com Change-Id: Icb102e444f03d30e5ab18b8b61ea44130dfb491f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756957}
-
Kuo Jen Wei authored
Bug: b:147986763 Test: Pass 'tast run <DUT> camera.CCAUIResolutions' with crrev.com/c/2128208 on treeya Change-Id: Ia3181cbfd0438b36f403ace4f4771b0fdfd40955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127995Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#756956}
-
Jarryd authored
Bug: 997262 Change-Id: I597c51641d6cdab16558cc3611c8187739be6e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137858Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756955}
-
David Munro authored
Test: Manual with ChromeVox Bug: chromium:1061778 Change-Id: Iec82ac9c785dafea14e4a4484178b2b5c0fca007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135104 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756954}
-
Mei Liang authored
This CL modifies the list tab card item to show the domain of the tab's URL, and falls back to show the full URL if no domain associated with the URL of the tab. Change-Id: Idd508f46e62a53ae47a8ce90ec4e2ef424a58664 Bug: 1042890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133428Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756953}
-
Bruce Dawson authored
This improves the assert message when user32.lib cannot be found during gn gen on Windows. This is an ongoing source of problems for external contributors and this change may help with diagnostics. Change-Id: I1649fb4d9cac4a735377df14149f554b434d63cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136889Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#756952}
-
Ionel Popescu authored
Prior to this CL, the outline-offset was *ignored when drawing the default focus ring (see AdjustedFocusRingOffset): - for FormControlsRefresh, GetDefaultOffsetForFocusRing was used instead - on Windows the value was completely ignored - on Mac the value was used This CL updated the behavior so that the default focus ring respects the value of outline-offset. Because of this, GetDefaultOffsetForFocusRing is not needed anymore since now we can directly update the outline-offset to correctly reflect what we are painting. Another difference in behavior is that the offset is not going to be zoom independent anymore. This fix is just for FormControlsRefresh (the feature is enabled on all platforms except Android) to minimize regression risks. The fix is validated by: focus-ring-outline-offset.html Bug: 945181 Change-Id: I2cff82556571d9f541b95f8cece9b7c3be1191c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138156 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#756951}
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: Ica0b2b1410ee8940e8210cd2fd1d8966d8b7c377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117790 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756950}
-
Nnamdi Theodore Johnson-Kanu authored
https://chromium-review.googlesource.com/c/chromium/src/+/2126332 Changes the routes to printing pages in settings. os_printing_page has a route that was missed. This CL updates the route in os_printing_page.html to match the new route, from /printing to osPrinting. Fix: 1068322 Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#756949}
-
Curtis McMullan authored
This commit enables resize for the virtual keyboard by default. BUG=1019990 Change-Id: I5e71d411b9997c31b8e2f3414f8913df68641e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138679Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#756948}
-
ssid authored
When unique db is missing and migration state says it should, the database could have been deleted by other means. In this case just return an empty shared db instead of error. Change-Id: I5b15955662405b306583ed1942d8591703ebf942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130685Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#756947}
-
Tal Pressman authored
The experiment had positive results, so it is being enabled going forward. Change-Id: I68caf49902b0f24770c27f76541beba450c1321e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132022 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756946}
-
Kent Tamura authored
This CL has no user-visible behavior changes. Note that LayoutNG ratio computed by these counters is 83.1% on nytiimes.com. Bug: 1067527 Change-Id: I0f2628d3eb5c4d7da7a4d5b3cc44cc918137a17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138653Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#756945}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84323449dfaf..461f9ab12106 git log 84323449dfaf..461f9ab12106 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 cnorthrop@google.com Capture/Replay: Implement more GLES entry points Created with: gclient setdep -r src/third_party/angle@461f9ab12106 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Id7064414d9044a3d282f396ed2e596c5ed3cb768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756944}
-
Gyuyoung Kim authored
The original WPT migration of flexitem-stretch-image.html has caused a test failure on Firefox. The test will be updated to work on Firefox. So, the migrated WPT test needs to be kept in order to make Firefox have the test. Instead, the original test is restored in the css3/flexbox to avoid regressions from the existing behavior. Additionally, this CL adds the test as flex-item-stretch-image.html to avoid the same naming confusion with the WPT test. Bug: 1063749 Change-Id: I2633293f05c3a584e73b6594d12a7c85abe39103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135659Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756943}
-
Hajime Hoshi authored
When we are restoring the page from bfcache, preserving its state, corresponding PageLoadTracker should be preserved too. BUG=1001087 BUG=1014174 Change-Id: Ic207ebfeb09d867e531a94d411efc520e30b5e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007095Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#756942}
-
Melissa Zhang authored
This reverts commit 50fbc87a. Reason for revert: Breaking https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 and https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 Original change's description: > Parameterize existing accessibility hit-testing tests > > https://crrev.com/c/2117330 added tests for cross-platform > accessibility hit testing code using parameterized combinations of > simulated device scale factor and use-zoom-for-dsf on or off. This CL > expands the parameterization to other existing hit-testing tests. > > To fix issues running these tests on cast_shell_linux I also made two > changes to the tests themselves: > - Reduce the scale factor from 2 to 1.25 > - Relocate one test point to be within the screen size > > Bug: 1007488 > Change-Id: I715270064365458ac9ec69f3c3ac81a674d2718c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135017 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756884} TBR=dmazzoni@chromium.org,kbabbitt@microsoft.com Change-Id: I5082d843dcdef6454933fc3cb6008b24744af606 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139051Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756941}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dfe9760a8e2d..c048306eaf01 git log dfe9760a8e2d..c048306eaf01 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 dberris@chromium.org Dashboard: Update maximum processing rate 2020-04-07 dberris@chromium.org Pinpoint: Fix TBR parsing to be more forgiving Created with: gclient setdep -r src/third_party/catapult@c048306eaf01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054073,chromium:1067531 Tbr: nuskos@google.com Change-Id: I398991f661f61383b5a1ccf59222568fbd300fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756940}
-
Lingqi Chi authored
FailingHttpNetworkTransaction was test-only code but called by NetworkContext::SetFailingHttpTransactionForTesting, so it was linked in the production code. Since it was only called by a test to force a network error, this patch removed SetFailingHttpTransactionForTesting method and used an alternative way to do that. Bug: 1012116 Change-Id: I918e04a3c143b80292f66d3c0e47651b84d6580e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129791Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756939}
-
John Z Wu authored
Also explicitly whitelist DEVICE_INFO for clarity. Bug: 1056421 Change-Id: I724e5bae984c2b70f28d3f31861c18c0acbfdb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137590 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#756938}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f44ca7b..50b248c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I456c584e3c76c22fb6abff1ffc285c4c77a3827a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138222Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756937}
-
Hitoshi Yoshida authored
The current IDL compiler generates two sets of files foo/bar.{cc,h} and bindings/{components}/v8/v8_bar.{cc,h} for foo/bar.idl that defines a dictionary, and makes v8_bar.h include bar.h. On the other hand, our new code generator which is enabled behind a flag will generate only v8_bar.{cc,h} and foo/bar.{cc,h} won't be necessary. This CL replaces inclusions of foo/bar.h to v8/v8_bar.h to make them work with both code generators, and has no behavior changes. Bug: 839389 Change-Id: I3b9915bd7861170871d671b02330e6643b2cd932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138852Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#756936}
-
Hiroki Sato authored
NOTIFICATION_STATE_CHANGED event is dispatched not only when the toast is displayed but also when the notification state is changed. In the first case, we can dispatch accessibility announcement, and in the second case, we shouldn't. This distinguishment was done in ARC Android side. This CL migrates the logic to Chrome side. See also http://ag/10917984. Bug: b/152374820 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Change-Id: Id59902e980ff9b24d6207a4ac001ba2162937b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132023 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#756935}
-
Mike Reed authored
Change-Id: Ibfccaaa9030b8698bfe5c2652e500b6375abcf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137821Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#756934}
-
Alex Danilo authored
Removes the 'Cancel selection' text from the selection bar cancel button. Changes the icon for selection bar to match the file list selection icon. Positions the icon and number of files selected message to align with the icons and file names in the file list. Removes the resize listener on the toolbar controller which was used in the old layout to size the 'Cancel selection' button to match the position of the splitter bar between the tree and file list views. The listener function itself remains, with a comment added so that it can be removed after files-ng work is complete. Bug: 1068079, 1065837 Change-Id: I857f037995a5bc0ba631fa41f62af8d72ff99dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137185 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#756933}
-
My Nguyen authored
Screenshot view when there is confirmed_text: https://screenshot.googleplex.com/Q0sjaEKi2Qa. There is still a need to take care of cursor position of the window, it should always be at the start of the confirmed_text. Bug: 1068044 Change-Id: I12ca6553f6cf57eac82127433340046aaff804f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137181 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756932}
-
Noel Gordon authored
Update the file manager unittest harness: add SVG files to the list of allowable file types that it can serve. Bug: 1061388 Change-Id: I6ee69e26946a368da77373c2cd8c643cc856c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138931Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756931}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org Change-Id: I577d88c5cee4f7716e07db8b335b83cc35d8e93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134866Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#756930}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib41d35e993e312a61b9d5b3c91f845291a9530a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138772Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756929}
-
Johann authored
BUG=webm:1679 Change-Id: Ia2d3c1a81af2542dbe6c790405cc6d0492391005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136987Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#756928}
-
My Nguyen authored
This is the first change in Personal Info Suggestion Window. When "show_tab" is true, the suggestion window created remains the same with the screenshot view: http://screen/MO1QeHfRwi4 When "show_tab" is set to false, the suggestion window created is in this screenshot view: https://screen/moLGCKOrvwr Bug: 1068044 Change-Id: I5397d6a1175fcfca86cb7dc3321d231560b10e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136008 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756927}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ia1031c5480e0b3aaf02371befc796db1166a6d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136012 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756926}
-
Michael Sun authored
Some Bluetooth audio peripheral devices negotiate with the Chrome OS Bluetooth stack (BlueZ) for a larger Advanced Audio Distribution Profile (A2DP) stream packet size, a.k.a. AVDTP MTU. In a noisy RF environment, the Bluetooth device may fail to consume such large packet and result in packet fragmentation, which caused audio to stutter. BluetoothFixA2dpPacketSize feature flag tells Chrome OS audio server (CRAS) to override the packet size with a prefixed smaller value. Bug=b:142499564 Test=Manual enable BluetoothFixA2dpPacketSize in chrome://flags and verified audio packet BlueZ send to the reconnected Bluetooth headset, using btmon, became smaller. Change-Id: Id68a05be87c858cce416af284f1321770028402f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134500 Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756925}
-
Matt Falkenhagen authored
* ServiceWorker.FetchEvent.Subresource.Status * ServiceWorker.FetchEvent.MainResource.Status Bug: 1059800, 1059801 Change-Id: Ibd6ade3eae1b8cc7b3c1a1c07e5b72f210fdb21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137163Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756924}
-
Sinan Sahin authored
Bug: 1066257 Change-Id: I6212cc2c8364307a17aa0e53e3276eae7143d494 Binary-Size: Re-added material lib component. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134769 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756923}
-