- 12 Dec, 2018 40 commits
-
-
agrieve authored
Bug: 898261 Change-Id: Idc5d040a535be7b03b326ed30a902166b63d9b48 Reviewed-on: https://chromium-review.googlesource.com/c/1374138 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#616009}
-
David Bertoni authored
Chrome style forbids binding a pointer to a temporary, so this change allows temporaries to be used in these calls. Change-Id: I83904fca01f13323bc28d36b33a00b5c300490b3 Reviewed-on: https://chromium-review.googlesource.com/c/1368788Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#616008}
-
Joshua Pawlicki authored
It is only sent if valid, and isn't valid on machines with no Omaha (e.g. official builders). Bug: 914443 Change-Id: I9d8746557290bc80ede5b3eba8330cce1405e4fd Reviewed-on: https://chromium-review.googlesource.com/c/1374450Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#616007}
-
manuk authored
Inline text has a 1px border. Previously, we used a white 1px border on the fill text in order to help align them vertically add also add a 1px horizontal gap between them. After other styling changes, the invisible border was no longer necessary for vertical alignment. Additionally, it was causing the horizontal positioning to be slightly off. This CL removes the invisible border, instead using a right-margin for horizontal positioning. Bug: 891303 Change-Id: Ib5fdfc876ada51f129ac2b34c1c59b3d1bd1994e Reviewed-on: https://chromium-review.googlesource.com/c/1374204Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#616006}
-
Michael Spang authored
The message pump is responsible for creating a toplevel span for each time slice triggered from I/O polling. This type of work is not run in the context of a a TaskAnnotator, and is completely invisible to tracing without help from the message pump. Bug: 914201 Test: run_content_shell --remote-debugging-port=9222 ssh root@fuchsia -N -L 9222:localhost:9222 add localhost to chrome://inspect?tracing & connect Change-Id: Ib9d248303c1c11d6fd7f616c31e0a76949c14d63 Reviewed-on: https://chromium-review.googlesource.com/c/1373132Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#616005}
-
Mike Dougherty authored
Remove extraneous |removeAllWebFrames| call to ensure a WebFrame exists for the main frame when navigating back then forward on a same page (ex:example.com#link) link. Additionally, add tests to validate the returned WebFrame object. Bug: 913825 Change-Id: I5abe3a50769564c1c95157eb713ee435093cbab4 Reviewed-on: https://chromium-review.googlesource.com/c/1368768Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#616004}
-
Clark DuVall authored
This was causing a crash if the throttle was destroyed before the callback was called. Bug: 914436 Change-Id: Id52e41c2f42fe29116a2b877311cc1d9405b5116 Reviewed-on: https://chromium-review.googlesource.com/c/1374159Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#616003}
-
Nicolas Ouellet-payeur authored
Bug: 896225 Change-Id: I35a7355a3d3b5fb9ad8d5425e2855985ab36e63a Reviewed-on: https://chromium-review.googlesource.com/c/1370824 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616002}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patches from this series is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: Ic1bf8f93ac2d697571272870e03d6d96b0534ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1370183 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#616001}
-
Jeffrey Cohen authored
The device ID and Name are not wanted for the send tab workflow Bug: 910390 Change-Id: I27a4808366a38cd91283c76a0b361d61216b3fde Reviewed-on: https://chromium-review.googlesource.com/c/1372537Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616000}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I65fc934319453de8ec8d8db38672d02e5c0e7ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1374046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615999}
-
Manu Cornet authored
Bug: 901991 Change-Id: If106647e4c5ac6948a86f3d8f367406cfef8da59 Reviewed-on: https://chromium-review.googlesource.com/c/1374197Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#615998}
-
Kurt Horimoto authored
On iOS 12, resetting the WKScrollView.contentInset at the start of the navigation pushes the content to {0, -contentInset.top}. On iOS 11, this does not occur. This CL updates FullscreenWebStateObserver to push the content below the toolbar the firs time a NavigationItem is loaded with the shouldUseViewContentInset property set to YES. This CL also updates MoveContentHelowHeader() to use the current top toolbar inset rather than progress * extended toolbar height. The previous value was only working correctly because the function was only called with a progress value of 1.0. This CL re-enables FullscreenTestCase.testLongPDFInitialState, as the behavior being tested is now fixed. Bug: 904694, 903247 Change-Id: I134461e16054846a211a5476dd5a6694bd709002 Reviewed-on: https://chromium-review.googlesource.com/c/1371082 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615997}
-
Nektarios Paisios authored
The views/controls/table_view widget is implemented in different ways on different platforms. On Windows it should be exposed as a list view control. On Mac as a table view. Since this widget behaves similar to the existing ARIA tree grid widget but without the functionality of expanding / collapsing columns, we decided to call it a list grid. Note that even though it is similar the widget doesn't have the same keyboard shortcuts and accessibility tree hierarchy as an ARIA grid. Please look at the MSAA hierarchy of the list view control in Windows File Explorer or the table view in Finder on the Mac for examples. R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org TBR=dominickn@chromium.org Change-Id: I8225ff1424a65c3b7ff77bfba17094e69226ada2 Bug: 811277 Reviewed-on: https://chromium-review.googlesource.com/c/1371930 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615996}
-
John Abd-El-Malek authored
Bug: 837753 Change-Id: I479666949f8c552e964ab86420ef080db9010d06 Reviewed-on: https://chromium-review.googlesource.com/c/1367088 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615995}
-
Victor Costan authored
SQLite 3.16 added support for PRAGMA functions [1]. This CL adds tests verifying that PRAGMA functions aren't exposed to WebSQL. The CL uses the busy_timeout PRAGMA [2] because it is available unless PRAGMA support is completely disabled [3]. By comparison, most PRAGMAs belong to groups that can be disabled individually. For example, PRAGMA page_size [4] can be disabled via the SQLITE_OMIT_PAGER_PRAGMAS build flag [5]. [1] https://www.sqlite.org/pragma.html#pragfunc [2] https://www.sqlite.org/pragma.html#pragma_busy_timeout [3] https://cs.chromium.org/chromium/src/third_party/sqlite/src/src/pragma.h?type=cs&q=%5C"busy_timeout%5C"+case:yes [4] https://www.sqlite.org/pragma.html#pragma_page_size [5] https://www.sqlite.org/compile.html#SQLITE_OMIT_PAGER_PRAGMAS Change-Id: Ia7f709da318ba78851368de75dad4400707df624 Reviewed-on: https://chromium-review.googlesource.com/c/1368946Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615994}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5def5f3..3338f216 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idcc8ad89a5cf8b73dbd4073ddddd4e89be3f2ad0 Reviewed-on: https://chromium-review.googlesource.com/c/1374201Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615993}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b0ac1d1ccfa..d110245bb7f7 git log 2b0ac1d1ccfa..d110245bb7f7 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ee5557693416..e9b211dd665b (1 commits) 2018-12-12 mtklein@google.com add -Tidy bot 2018-12-12 ethannicholas@google.com fix for GrVkGpu not always unreffing all command pools 2018-12-12 mtklein@google.com add clang-tools-extra to clang_linux 2018-12-12 mtklein@google.com add google-build-namespaces to clang-tidy checks 2018-12-12 brianosman@google.com Update win_toolchain, and refactor how it's built 2018-12-12 kjlubick@google.com [canvaskit] Correctly translate between shadow radius and sigma 2018-12-12 kjlubick@google.com [canvaskit] Allow users to load their own fonts 2018-12-12 egdaniel@google.com Fix path to vulkan header. 2018-12-12 mtklein@google.com run clang-tidy on headers too 2018-12-12 herb@google.com Use SkFont for bitmap device rendering 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9fbaf697cd86..50dd2ce4e2e3 (5 commits) 2018-12-12 mtklein@google.com restrict -Werror to runs of clang-tidy.sh 2018-12-12 egdaniel@google.com Move vulkan headers from third_party to include/third_party. Created with: gclient setdep -r src/third_party/skia@d110245bb7f7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: If1fd223ccc66139ebba14497ee6eba08fc487863 Reviewed-on: https://chromium-review.googlesource.com/c/1374042Reviewed-by:
-
Takuto Ikuta authored
This is necessary to make second build no-op. Without this, following command runs the script always. $ ninja -C out/android_arm64_dbg_recipe/ gen/tools/perf/contrib/vr_benchmarks/vr_assets_profile Bug: 914264 Change-Id: I35ff097c6a34318813957b71c690386fc1a7a1e3 Reviewed-on: https://chromium-review.googlesource.com/c/1373734Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615991}
-
chrome://extensionsNicolas Ouellet-payeur authored
Adds a message for managed users at the top of the chrome://extensions page. Enterprise users will now see a message that says "Your browser is managed by your organization", with a link they can click to view a help center article. The new UI is hidden behind a flag so that most users don't see this WIP feature just yet. Bug: 893628 Change-Id: Ib8aac65759880b3cd3509b2f57990affb3aafc4f Reviewed-on: https://chromium-review.googlesource.com/c/1352496Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#615990}
-
Chase Phillips authored
Bug: 717812 Change-Id: I4d69b9b5093df319f7c47df3c93794108a0bb451 Reviewed-on: https://chromium-review.googlesource.com/c/1364301Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615989}
-
Henrique Nakashima authored
Use COMPONENT_EXPORT instead. Change-Id: I8cebed14c3f4df0596fbc94edd9afd1840cf5603 Reviewed-on: https://chromium-review.googlesource.com/c/1370574Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Orin Jaworski authored
The default search engine (DSE) list is being refreshed from recently collected data. This CL is focusing first on countries for which a DSE list is already in place. Existing engine registrations will be kept intact, and only new engines are being added. The list of engine references for each country is being completely replaced based on new usage statistics, and unreferenced engine registrations are removed. Bug: 783890 Change-Id: Ie13eaa91d4a62eb581375f6dc00c556c7c536885 Reviewed-on: https://chromium-review.googlesource.com/c/1345542Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615987}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I443fe09079186ef8a2e2680efd6346b5f509b61c Reviewed-on: https://chromium-review.googlesource.com/c/1352780Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#615986}
-
Mrunal Kapade authored
Added checks for feature policy attribute. This fixes all feature policy related tests. BUG=862460,257511 Change-Id: I6258c41dcca164f7c6584ba4a387860237ca3ba3 Reviewed-on: https://chromium-review.googlesource.com/c/1343193Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Cr-Commit-Position: refs/heads/master@{#615985}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88faa6967431..64f62f4a179f git log 88faa6967431..64f62f4a179f --date=short --no-merges --format='%ad %ae %s' 2018-12-12 ynovikov@chromium.org Skip external texture ImageTest tests on Ozone Created with: gclient setdep -r src/third_party/angle@64f62f4a179f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:914146 TBR=jmadill@chromium.org Change-Id: I3cc29d028fe0efe458958a23e047d05268e30097 Reviewed-on: https://chromium-review.googlesource.com/c/1374039Reviewed-by:
-
Jun Mukai authored
This CL made a short-term fix for crostini app icons when SingleProcessMash is enabled. The observed problems are: - the terminal app icon has the spinner (rotating cycle) on launch, but the spinner doesn't disappear when the terminal is ready - other app icons (like gedit) create two app icons, one is the expected one and the other is the blank icon The terminal app is a chrome app (hosted by browser), however CrostiniAppWindowShelfController observes aura::Env in ash::Shell, thus it will fail to obtain Browser object. It needs to aura::Env in the browser. The blank icon is created by ash::ShelfWindowWatcher; to prevent this, kShelfItemTypeKey property needs to be set as ArcAppWindowLauncherController does. This is kinda hacky and does not work with multi-process Mash. We will eventually need a major refactoring around the shelf and the launcher. Bug: 905802 Test: manually Change-Id: If941bcc100160d3b5ff6e590032153000efc674a Reviewed-on: https://chromium-review.googlesource.com/c/1371144 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615983}
-
Manu Cornet authored
Bug: 882991 Change-Id: I952c5e9ed4d2153b50fb7cfb2bc15b4f7557b9fb Reviewed-on: https://chromium-review.googlesource.com/c/1373809Reviewed-by:
-
Kim Paulhamus authored
Bug: 913881 Change-Id: I291167a9f707afe19709aabf212e01aed8d4e201 Reviewed-on: https://chromium-review.googlesource.com/c/1372911Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#615981}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/407a081da693..88f396963bc7 git log 407a081da693..88f396963bc7 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 tsepez@chromium.org De-duplicate rows in element-attributes table. Created with: gclient setdep -r src/third_party/pdfium@88f396963bc7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1082ed761f9d8c34ea74894384b62f39aae5afaf Reviewed-on: https://chromium-review.googlesource.com/c/1374137Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I8f6b7e62166de2d025f05cf4239686fed7a1d3ec Reviewed-on: https://chromium-review.googlesource.com/c/1353884Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#615979}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/149e7c6373d2..277cdb9bcc3e git log 149e7c6373d2..277cdb9bcc3e --date=short --no-merges --format='%ad %ae %s' 2018-12-12 yuzhao.zhang@intel.com Tab_Switching results calculation includes unwanted data Created with: gclient setdep -r src/third_party/catapult@277cdb9bcc3e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899174 TBR=sullivan@chromium.org Change-Id: I679895819692b4a5e2575a90527918dd4525c3f9 Reviewed-on: https://chromium-review.googlesource.com/c/1374040Reviewed-by:
-
Yi Su authored
After migrated to ChromeTableView, PasswordsTableViewController (use to be SavePasswordsCollectionViewController) displays less items in one screen, and testSearchPasswords has to scroll down to find all items which will hide the search bar. Then it will fail when trying to tap on search bar. This CL makes it scroll to top first and then tap the search bar. Change-Id: I08327f99043b26b426a0f41fdb32e578e93c3b74 Reviewed-on: https://chromium-review.googlesource.com/c/1373827Reviewed-by:
-
Morten Stenshorne authored
At some point [1] it ceased to be a printing test, so it didn't really test anything useful. Make sure that we enter print mode, and turn it into a PNG test. Reduce the number of lines and use the Ahem font, to keep the PNG file sizes low. Mark the test as failing with LayoutNGBlockFragmentation. It used to pass because there was no block fragmentation involved in the test. [1] df18d7ad Change-Id: I5a17d76b53515975c90020bd37639f0af4563130 Reviewed-on: https://chromium-review.googlesource.com/c/1371868Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#615976}
-
Tom Anderson authored
Adds a fix for components/crash/content/tools/generate_breakpad_symbols.py which saw significant slowdown causing telemetry_unittests and telemetry_perf_unittests to timeout on the Linux Debug bot. On my machine, the time for this script to run is reduced from ~4m30s to ~6s. > Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so: > > $ ldd libfontconfig.so | grep freetype_harfbuzz > libfreetype_harfbuzz.so => not found > $ ls libfreetype_harfbuzz.so > libfreetype_harfbuzz.so TBR=dpranke R=thestig CC=mmoroz BUG=913070,911836,912366 CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_dbg_ng Change-Id: I94faed54a4ea9d50b8db38ca8c41b65d26e2bd5f Reviewed-on: https://chromium-review.googlesource.com/c/1371080Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615975}
-
Max Moroz authored
TBR=bpastene@chromium.org, inferno@chromium.org Bug: 701825, 911856 Change-Id: I205073ad7f85d770556fd570fa558ae52404f0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1374153Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615974}
-
Dominic Mazzoni authored
Bug: 911945 Change-Id: I64af0f02733e46bf1cd6df73d4ed0735d662c1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1364159 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#615973}
-
Jacob Dufault authored
Eliminates a dependency on test bases Bug: 912704 Change-Id: I30807d081cb790ff0f5c4c0873d75d9267c24b47 Reviewed-on: https://chromium-review.googlesource.com/c/1370908Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#615972}
-
Zinovy Nis authored
Minor fixes. Bug: None Change-Id: I2270516c27757bceb0e6b3e838ce2004f1d137eb Reviewed-on: https://chromium-review.googlesource.com/c/1356985Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615971}
-
jdoerrie authored
This change implements a navigation throttle for the Google Password Manager. Users that try but fail to access the Google Password Manager will be redirected to the local Chrome Password Settings page instead. Since this Google Password Manager integration is still experimental, this navigation throttle is guarded by the kGooglePasswordManager feature flag as well. Bug: 904821 Change-Id: If24d9ca04145d0e969bb34cb945a5a0607ec20c8 Reviewed-on: https://chromium-review.googlesource.com/c/1366442 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#615970}
-
