- 04 Jul, 2018 40 commits
-
-
Michael van Ouwerkerk authored
* Add setBottomBarHeight to IActivityHost * Hide the bottom bar shadow for dynamic modules Bug: 859819 Change-Id: Iab6e0d61326a76d32b4cd913061f85797197d7cc Reviewed-on: https://chromium-review.googlesource.com/1123837Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#572518}
-
Yutaka Hirano authored
CreateLoaderAndStart used in TryCreateDuplicateRequestIds created network::mojom::URLLoaderPtr and network::TestURLLoaderClient in it and hence the request got aborted. That will lead to flakiness because on a slow system the first request got aborted before the second request arrives. This CL fixes that. Bug: 799516 Change-Id: I4767d7f98185e633f229315074a9361b14e47e3b Reviewed-on: https://chromium-review.googlesource.com/1125581Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572517}
-
Luciano Pacheco authored
Putting this CL through to help because orodley@ can't TBR on the following CL. https://chromium-review.googlesource.com/c/chromium/src/+/1125704 TBR=dcheng@chromium.org Bug: 860168 Change-Id: I3673161fbfcd6940bbb508c149fa68c63c546822 Reviewed-on: https://chromium-review.googlesource.com/1125706Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572516}
-
Vaclav Brozek authored
A space between two sentences was missing in a comment, so this CL adds it. Bug: 795462 Change-Id: Iaa1e92b411f919e34cd8a3737dcd289f85fecdf6 Reviewed-on: https://chromium-review.googlesource.com/1125660 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#572515}
-
Mohamed Amir Yosef authored
This CL extracts the logics for handling remote updates and committing local updates into BookmarkRemoteUpdatesHandler and BookmarkLocalChangesBuilder respectively. This is to simplfy the BookmarkModelTypeProcessor. Before this CL: processor scheduled metadata save only if there is a change in the metadata without change in the model, because the model would trigger the save in such cases. After this CL: processor schedules metadata save every time remote updates are processed regardless from they entailed a change in the model or not. This simplifies the code, and the bookmark storage should squash subsequent save requests, so consecutive save requests from the model and the processor should result in only one actually save on disk. Bug: 516866 Change-Id: I7918086b31b11f7a72804b152f23af2b059cca3d Reviewed-on: https://chromium-review.googlesource.com/1124854 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572514}
-
Ian Kilpatrick authored
This is amazing. Essentially if an element has "default" quirky start margins, and it is an empty block, the end margin (regardless of if it is quirky or not), becomes quirky. This doesn't propagate to other elements however, see: https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=6016 A bigger fix might be to change the default stylesheet to make all of these elements with quirky margins to have quirky margins on each side, then change the logic for the bottom quirkyness. But this is a pretty scary change. (This may however match other browsers better eventually). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5895a148211a5a1291e9b0a935fea08e094d4ec0 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1124071Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#572513}
-
Nicholas Verne authored
Prior to this change, the lower illustration would change position when label strings changed size or the progress bar became visible. This is prevented by creating two container views, the lower of which is "bottom aligned", and in which the illustration is the only child view. Bug: 848118 Change-Id: I17ff9309152482ea718ed1eb13bf65d823a79bcf Reviewed-on: https://chromium-review.googlesource.com/1125597 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572512}
-
Matt Falkenhagen authored
We expect the precreated AppCacheHost to exist in AppCacheNavigationHandleCore once navigation starts on the IO thread. But we know it doesn't exist at some point. This CL add more logging to try to narrow down possibilities of where the host was lost, if it was ever created. Bug: 857005 Change-Id: I0804b6dd972daf6e28e6ee5bf403e30b94df0b1a Reviewed-on: https://chromium-review.googlesource.com/1125649Reviewed-by:
-
Makoto Shimazu authored
TBR=luoe@chromium.org NOTRY=true Bug: 859064 Change-Id: I2c8478e61a3680d2a170afa70bd5e689e7e2e97e Reviewed-on: https://chromium-review.googlesource.com/1125657Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572510}
-
tzik authored
This CL replaces most MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I949bc78c5e103baa610a8a2d1197901ceb090c50 Reviewed-on: https://chromium-review.googlesource.com/1105812 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#572509}
-
yiyix authored
BeginMainFrameIntervalCritical assume that the browser is at 60 fps, but browser has a slower fps rate comparing to Renderer. So spikes in this metrics doesn't mean regression in system. Bug: 656849 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12b6e7d7fe9aa080ea5267445826ac54b3fb3938 Reviewed-on: https://chromium-review.googlesource.com/1124761 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#572508}
-
Luciano Pacheco authored
Add My Files parent on navigation tree, navigation_list_model.js creates the "My Files" entry as a EntryList and EntryListItem on directory_tree.js is the UI element to display it. This is a continuation of: * crrev.com/c/1086680 * crrev.com/c/1116400 * crrev.com/c/1116517 Some changes required to display EntryList: * isDescendantEntry: Inspect on each of EntryList's children. * FileManager.initializeUI: Fetch asynchronously the flag to be able to use before displaying the navigation tree. * extract the switch (modelItem.type) to its own function, to be able to reuse it. Design doc: https://docs.google.com/document/d/1X5XSLKJd0yerL-qFhpb2z9ibUVb_W3gG_tfIV7T_Qt0 Bug: 846587, 846592, 846591, 846590, 846589, 846588, 846586 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id8f27f09763d4478b93d52dd32e4ed851c7e448d Reviewed-on: https://chromium-review.googlesource.com/1113258 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572507}
-
Noel Gordon authored
Shave about 500ms off per test by only loading the file(s) the tests require. Remove getExpectedFileEntryRows helper as a side-effect: it is now unused so git-mv it to /dev/null. Bug: 859008 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id49678e63d2160cbf7ce4daee45d36edaa124b97 Reviewed-on: https://chromium-review.googlesource.com/1125639Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572506}
-
Jochen Eisinger authored
Replaces the two distinct implementations of CryptAuthAccessTokenFetcher with having CryptAuthClientImpl directly construct a PAATF. Those two implementations are each identical in functionality to using a PAATF in kImmediate mode: the first simply wraps PAATF used in kImmediate mode, while the second just makes an immediate request on ProfileOAuth2TokenService. Also eliminates a //chromeos implementation of CryptAuthClientFactory, as that implementation is now identical with the //components/cryptauth implementation, which is used instead in the //chromeos context. BUG=809433 R=blundell@chromium.org,khorimoto@chromium.org Change-Id: I93ee9e736395bc71a1e741fc45d027ff32787536 Reviewed-on: https://chromium-review.googlesource.com/1107715 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#572505}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6784ffa78e70..233c65202e69 git log 6784ffa78e70..233c65202e69 --date=short --no-merges --format='%ad %ae %s' 2018-07-04 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@233c65202e69 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I7944b5466e69d1c3eb7667ed506622f8cc1a5c0e Reviewed-on: https://chromium-review.googlesource.com/1125619Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572504}
-
Luciano Pacheco authored
This is a continuation of crrev.com/c/1086680 and crrev.com/c/1116400. isFakeEntry changed the logic to not use operator "in" since Closure compiler was failing for FilesAppEntry types: "ERROR - Cannot use the IN operator with structs". Bug: 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I34914893d01bba43fdbcfc9e4b197031e50c662a Reviewed-on: https://chromium-review.googlesource.com/1116517 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
TBR=reveman@chromium.org Bug: 856145 Change-Id: I8280cf4c382282237d24bd6c4f432104c5f023aa Reviewed-on: https://chromium-review.googlesource.com/1125645Reviewed-by:
-
Nicholas Verne authored
Crostini Terminal icon now has a Shut Down Linux item, which is enabled if and only if the default vm is running for this user. CrostiniManager now tracks |running_vms_| and updates this multimap when vms start and stop. Bug: 848116 Change-Id: I1130f0ff2e122828c81c286fa3a4362e3cb3138d Reviewed-on: https://chromium-review.googlesource.com/1124065Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#572501}
-
Trent Apted authored
Although it doesn't flake in Release, the presense of DCHECKs makes this test fail. Waiting just for the gallery element could read the button state in the static gallery.html DOM, so wait for the first image to be fully loaded. Bug: 857021 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4e07384b105489410a73894b4a9e0a58bdae287d Reviewed-on: https://chromium-review.googlesource.com/1125589Reviewed-by:
-
Luciano Pacheco authored
This is a preparation for crrev.com/c/1113258 which uses this deps. Bug: 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9fc23fa6a137df4256420464384ac3366d260b3c Reviewed-on: https://chromium-review.googlesource.com/1116400 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I147efd9556ff6dad0a5afb08f29f791dd6ef0547 Reviewed-on: https://chromium-review.googlesource.com/1125533Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22bb66f2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20740 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=markdittmer No-Export: true Change-Id: Idc755344530ed753097aea477e632b001b51d615 Reviewed-on: https://chromium-review.googlesource.com/1125530 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572497}
-
Luciano Pacheco authored
Add interface FilesAppEntry which is the base interface that moving forward the app UI will converge as base type that can be displayed on different UI components such as: navigation tree, file list and breadcrumbs, eventually superseding Entry type. Add VolumeEntry which implements interface FilesAppEntry to represent a Volume, this will allow to display Volumes on file list/Right Hand Side (RHS). Add EntryList which implements interface FilesAppEntry to represent a list of entries. This will be used to implement "My Files" which will contain a list of VolumeEntry for the volumes: Downloads, Linux Files (Crostini) and Play Files (ARC++). Design doc: https://docs.google.com/document/d/1X5XSLKJd0yerL-qFhpb2z9ibUVb_W3gG_tfIV7T_Qt0 Bug: 846587, 835203 Test: Unit-test for the new types. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia2fce233338f8b8e0969b77daf4c77139852c441 Reviewed-on: https://chromium-review.googlesource.com/1086680 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Tarun Bansal authored
This separates out the code for parsing accept-ch and accept-cl-lifetime header. This makes it easier to parse http-equiv accept-cl-lifetime header which will be added in the next CL. Previously, when only accept-ch header was present, it was handled using a different code path then when both accept-ch and accept-cl-lifetime headers are present. This CL changes it to handle the two headers separately. That also makes it possible to unify the two code paths. Change-Id: I1013419a55360249718855677678356f8446ec11 Bug: 852484 Reviewed-on: https://chromium-review.googlesource.com/1125083 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Kyle Milka authored
Bug: 859381 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibd5a7f08e9aa20682ca2a43baf491bcfa43f2ca7 Reviewed-on: https://chromium-review.googlesource.com/1123034Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572494}
-
Adam Rice authored
Once the context in which a fetch is executing has been destroyed the fetch cannot be aborted. blink::BodyStreamBuffer was attempting to abort the fetch anyway, leading to a crash. Check that the context hasn't been destroyed before attempting the abort. BUG=860063 Change-Id: I593dcbfe2f2dacd7be9df456399cd0328da7af39 Reviewed-on: https://chromium-review.googlesource.com/1125543Reviewed-by:
-
Zhuoyu Qian authored
As the comment in frame_selection.h by yoichio@, rename SelectLineBreak to SelectSoftLineBreak. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iadba94c4212ff7384f8bd0e460a89bb25c6fbe77 Reviewed-on: https://chromium-review.googlesource.com/1124207Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#572492}
-
Ramin Halavati authored
When network traffic annotation tests are run on Windows without filtering for relevant files (to test heuristics), there might be compile errors that can be ignored. Bug: 844014 Change-Id: Ib1e843971ea8892430142ccb6a5f7ac71714e0ff TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1125069Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#572491}
-
Makoto Shimazu authored
This reverts commit 87135a31. Reason for revert: ChromeNetworkServiceBrowserTest.EncryptedCookies keeps failing on Mac10.11 bot. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/27835 Original change's description: > Network Service: Enable encrypted cookies > > Cookies will now be stored encrypted by default in the network service. > Tested that crbug.com/848361 is fixed with this change. > > Bug: 789632, 848361, 789644 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8 > Reviewed-on: https://chromium-review.googlesource.com/1104791 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572444} TBR=dcheng@chromium.org,jam@chromium.org,mmenke@chromium.org,cfroussios@chromium.org,morlovich@chromium.org,cduvall@chromium.org Change-Id: I192a10c6d28a102dcf5ae247cdbda4c602872eb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789632, 848361, 789644 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1125460Reviewed-by:
-
rbpotter authored
Ensure user can tab to destination list items in the destinations dialog. Bug: 859846 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I137fc8cc73ee6bfef197607ed7a75d711002a6f8 Reviewed-on: https://chromium-review.googlesource.com/1125279 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#572489}
-
Julie Jeongeun Kim authored
Each Ozone platform creates its own NativeDisplayDelegate to get display information. Otherwise, 'display::FakeDisplayDelegate' is used for NativeDisplayDelegate. Per bug, ozone headless is crashing because it uses FakeDisplayDelegate and it doesn't invoke OnConfigurationChanged before initialization completes so ScreenBase can't add the display. Once NativeDisplayDelegate is initialized, DesktopScreenOzone requires DisplayMode from DisplaySnapshot but FakeDisplayDelegate has FakeDisplaySnapshot and it doesn't have DisplayMode. This CL creates HeadlessNativeDisplayDelegate which owns DisplaySnapshot and DisplayMode for ozone/headless. DesktopScreenOzone keeps it in delegate_ and communicates with it. To try this, compile with the following gn args use_ozone = true ozone_platform_headless = true TEST=./out/Debug/chrome --ozone-platform=headless Bug: 851375 Change-Id: I2c097bf54fafb2d9311919647801e401c59ba929 Reviewed-on: https://chromium-review.googlesource.com/1120447 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#572488}
-
Christopher Cameron authored
Add missing patchset from crrev.com/572420 Bug: 826265 Change-Id: I2506916da8a489c83f3c93ff3a143070505c3bba Reviewed-on: https://chromium-review.googlesource.com/1125528Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 852056 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7c8bde3aa2b5fc77daf1b022f85cbecffa5915ce Reviewed-on: https://chromium-review.googlesource.com/1123403 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 9f1eb0ba. Reason for revert: speculative revert due to cc_unittests failures https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/51119 Original change's description: > Switching all ui/gl dependent tests to SwiftShader > > This cl's switches cc_unittests and viz_unittests from OSMesa > to SwiftShader and fixes other issues related to that change. > > Bug chromium:848035 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ib1b58e02d4df4a687ef7be57284c06097bdeca94 > Reviewed-on: https://chromium-review.googlesource.com/1070490 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572442} TBR=danakj@chromium.org,sugoi@chromium.org,dcastagna@chromium.org,piman@chromium.org,ericrk@chromium.org Change-Id: I5957fd458b172fd58d4d1fe866e4b07be600c6cb No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1125599Reviewed-by:
-
Junichi Uekawa authored
Also add some blurb about Chrome OS specific things. BUG=None. TEST=read it. Change-Id: Ia9755c354aee0872f7225695c17a5ebdf08cea54 Reviewed-on: https://chromium-review.googlesource.com/1111747 Commit-Queue: Junichi Uekawa <uekawa@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#572484}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c8e16a9e9d6..c79c3e591230 git log 7c8e16a9e9d6..c79c3e591230 --date=short --no-merges --format='%ad %ae %s' 2018-07-04 zhuohao@chromium.org kukui: add new paladin Created with: gclient setdep -r src/third_party/chromite@c79c3e591230 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I42499f2fd1d41a50de88dde0987fe5d1fceb56db Reviewed-on: https://chromium-review.googlesource.com/1125422Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572483}
-
Sam McNally authored
Returning transient errors when the refresh token isn't loaded yet was better than persistent errors, but it could result in quite a few errors being returned before a success, sometimes causing DriveFS to give up anyway. Avoid this by waiting for the account to be ready before servicing any access token requests. Bug: 855002 Change-Id: I1578f8f9116592e1ee2864a804269a4a49ba8c92 Reviewed-on: https://chromium-review.googlesource.com/1125551Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572482}
-
Yutaka Hirano authored
This CL adds DocumentThreadableLoader::module_id_ to see which module is to blame for the CHECK failure. I'll revert this change once the cause is found. Bug: 837511 Change-Id: I76a724d1d8277d5e70afed85bb5576df99d997ca Reviewed-on: https://chromium-review.googlesource.com/1125546Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
This CL does two things: * It decreases height of feature pod hover when the pod doesn't have sub-label. (https://crbug.com/858942) * It increases width of the hover when it doesn't have enough space to show detailed view arrow. Previously, it hid the arrow in such case. In order to do that, it increased the width of feature pod button by 28px because we symmetrically increase the hover width. The arrow and the spacing takes 14px in total. Screenshot(before): http://screen/5bzdLf3rGQn Screenshot(after): http://screen/48Jr2f39Kp7 TEST=manual BUG=858942,858913 Change-Id: If1db17c0fa932188b36b02979374253f5cde084d Reviewed-on: https://chromium-review.googlesource.com/1124199 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572480}
-
Darren Shen authored
It currently returns a mutable reference, which is discouraged by the style guide. TBR=blundell@chromium.org Change-Id: Ie7537feffeeeacf317deb02cc5fa9e90a186db70 Reviewed-on: https://chromium-review.googlesource.com/1123963 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#572479}
-
