- 11 Sep, 2018 40 commits
-
-
Jdragon authored
This patch means rearrange module file name in alphabetical order. Change-Id: Ia2697a2d2dfeb3576677b0732d64f7b7bc21cce3 Reviewed-on: https://chromium-review.googlesource.com/1215153Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#590235}
-
Vadym Doroshenko authored
When flag #new-password-form-parsing is on, PasswordFormManager is used for saving and NewPasswordFormManager for filling. Now they have separate metric recorders. Metric PasswordManager.ActionsTakenV3 (and others) is inconsistent because filling and saving parts of this metric written with different recorders. This CL implements usage of the same metric recorder for PasswordFormManager and NewPasswordFormManager that corresponds for the same form. Bug: 882432, 831123 Change-Id: I84b480c86ec8172fb9d055cd8189529c5e4f42fb Reviewed-on: https://chromium-review.googlesource.com/1215965 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#590234}
-
Max Morin authored
This reverts commit 5fddb84e. Reason for revert: Speculative revert for failing WebRTC browser tests. Original change's description: > Enable sandboxing for audio service field trial testing on Windows and Mac. > > Bug: 832666 > Change-Id: Ic64a983498156bba73c458f2abc872db337d1999 > Reviewed-on: https://chromium-review.googlesource.com/1216142 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589911} TBR=rkaplow@chromium.org,marinaciocea@chromium.org Change-Id: Ib0a488a759dea9176b6096bdfafd710f6c3aa8bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832666, 882780 Reviewed-on: https://chromium-review.googlesource.com/1218942Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590233}
-
Alex Lau authored
Add missing assertions after callRemoteTestUtil invocations. LOG(FATAL) instead of assertion when trying to add entries to a non-existant Android Files test volume. Also remove unnecessary AndroidFilesTestVolume.Initialize() call. Bug: 877371 Change-Id: I925ad37a056e411eb3a5bd833cad59a5ce11fae3 Reviewed-on: https://chromium-review.googlesource.com/1218664Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#590232}
-
momohatt authored
This method resumes a cache writer which is paused by enabling pause_when_not_identical option. With this option enabled, a cache writer pauses right after it finds any differences with the cached body and the body from network, and calling Resume() to such paused cache writers makes them resume its internal state machine and complete the remaining read and write to the storage. This method takes a callback, but it is triggered only when the remaining read and write finishes asynchronously. Bug: 648295 Change-Id: I1c01804151bff20fc69ba7d0993447f676e98548 Reviewed-on: https://chromium-review.googlesource.com/1214975 Commit-Queue: Momoko Hattori <momohatt@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590231}
-
Manu Cornet authored
Enable shelf background blur only when the launcher's background blur is enabled. This allows for a more consistent user experience, and may also help with performance on some devices. Bug: 879962,881134 Change-Id: I40015199f3312b62ef7b175167b65d5a9a6e352a Reviewed-on: https://chromium-review.googlesource.com/1217584 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#590230}
-
Rune Lillesveen authored
We used to push SelectorFilter for AttachLayoutTree when we did style resolution there. The test in question used to fail DCHECKs. No longer necessary for this test. Change-Id: Icf7d7020d03c15dc446d18469971302915abbe89 Reviewed-on: https://chromium-review.googlesource.com/1218724Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#590229}
-
Dominic Battre authored
Disabled testToolbarSwipeNextThenPrevTab and testToolbarSwipeNextThenPrevTabIncognito for flakiness. See bug for details. TBR=mdjones@chromium.org Bug: 882003 Change-Id: Ic78f41566c1abce0feb4010196fcf1270fba11a6 Reviewed-on: https://chromium-review.googlesource.com/1218722Reviewed-by:
-
Ulan Degenbaev authored
Bug: 880432 Change-Id: Ice70a3804321e89f21579436e2de05a76cdeb8fd Reviewed-on: https://chromium-review.googlesource.com/1216283 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#590227}
-
Yutaka Hirano authored
This reverts commit 90e9d5ae. Reason for revert: The test is still flaky. Original change's description: > Tentatively re-enable SitePerProcessHitTestBrowserTest.TouchActionAckTimeout > > A number of changes have landed recently that may eliminate the > flakieness seen in this test. This CL re-enables the test, but feel > free to revert this if the flakes continue. > > Bug: 871062 > Change-Id: Iad353f9aecbf2eb59c4831ef70658f08c13a47a9 > Reviewed-on: https://chromium-review.googlesource.com/1217087 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590047} TBR=kenrb@chromium.org,wjmaclean@chromium.org Change-Id: I7467a05dc55da2a98e0e5476bb4088e64ffb7d01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871062 Reviewed-on: https://chromium-review.googlesource.com/1218306Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590226}
-
Hiroshige Hayashizaki authored
To make mixed content check more spec-conformant, this CL makes mixed content check in Workers/Worklets take into account whether the parent contexts are HTTPS or not, in addition to their SecurityOrigin, by - Implementing HTTPS state spec concept in ExecutionContext, i.e. Document https://html.spec.whatwg.org/#concept-document-https-state WorkerGlobalScope https://html.spec.whatwg.org/#concept-workerglobalscope-https-state WorkletGlobalScope https://drafts.css-houdini.org/worklets/#set-up-a-worklet-environment-settings-object - Plumbing outside Settings's HTTP state to Worker/WorkletGlobalScope via GlobalScopeCreationParams, and - Plumbing HTTP state from Worker/WorkletGlobalScope to WorkerFetchContext via FetchClientSettingsObjectImpl, and https://html.spec.whatwg.org/#https-state - Using it for mixed content check instead of SecurityOrigin. https://w3c.github.io/webappsec-mixed-content/#categorize-settings-object While this is still not completely spec-conformant, mixed content check becomes stricter: for top-level worklet scripts and subresource requests from data: URL workers created from HTTPS Documents, HTTP requests will be blocked after this CL. Bug: 880986, 880023, 880015 Change-Id: I4a43e2ee424177e93b0d7da40c2c1b8891cdced3 Reviewed-on: https://chromium-review.googlesource.com/1208390Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#590225}
-
Rune Lillesveen authored
And that we do not re-enter RebuildLayoutTree. Bug: 868810 Change-Id: Icb70557747c26ccd107775919034ec91b054d070 Reviewed-on: https://chromium-review.googlesource.com/1217743Reviewed-by:
-
Rune Lillesveen authored
We will need it outside of node.cc for layout tree rebuild root. Bug: 868810 Change-Id: If428d5c1f954686c70c35631718c5fa270c8971b Reviewed-on: https://chromium-review.googlesource.com/1217422Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/727453b25672..56e273293a3c git log 727453b25672..56e273293a3c --date=short --no-merges --format='%ad %ae %s' 2018-09-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@56e273293a3c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I10281a13235851fac2d0ed17962022eb17baae85 Reviewed-on: https://chromium-review.googlesource.com/1217817Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590222}
-
Yutaka Hirano authored
- Mark cancel-invoked.html as Timeout. - Mark basic.html as Timeout on ASAN. - Remove SLOW expectations for both of them. Bug: 882756, 867982 Change-Id: Ie5d332d02ca8543cb6a4342101b2897ea7af27f3 Tbr: rmcilroy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1218642Reviewed-by:
-
Camillo Bruni authored
Bug: 878390 Change-Id: Idbf6ea53989688e675718c76babe259caf51c9db Reviewed-on: https://chromium-review.googlesource.com/1215946 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Mike West authored
This is a re-land of [1] after MSAN failures caused a rollback in [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/966442 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/1213152 Bug: 787905 Change-Id: Ie4632a3a482c77202e7e4d3b5c360f021e628389 Reviewed-on: https://chromium-review.googlesource.com/1216684Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#590219}
-
Yutaka Hirano authored
This reverts commit d2bade56. Reason for revert: Speculative revert for test failure. https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Original change's description: > Scheduler: WebURLLoader should notify Blink with the initial priority. > > The loading stack only notifies Blink with any increase in the > request priority. Add support to notify the scheduler with the > initial priority as well. > > Bug: 870349 > Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b > Reviewed-on: https://chromium-review.googlesource.com/1185593 > Commit-Queue: Farah Charab <farahcharab@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586752} TBR=kinuko@chromium.org,altimin@chromium.org,farahcharab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870349, 882200 Change-Id: Id010e1ce5f2c4374f3f89208567fe4e344399051 Reviewed-on: https://chromium-review.googlesource.com/1218263 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Ramin Halavati authored
ChromeOS specific preferences are removed from the persistent storage list for incognito mode. As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: I9b5c18427cf9875b20d44dd99b65cab2900a5998 Reviewed-on: https://chromium-review.googlesource.com/1185598Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#590217}
-
Tetsui Ohkubo authored
We have to set insets to ARC++ notification mask so that visible rect should have appropriate rounded corners during scroll. Ideally this can be fixed by changing layer ordering of NativeViewHost, but it's not going to happen soon. TEST=manual BUG=866777 Change-Id: Ic4a2dc3c7f56051937dd02ae34fa0ab3bb290c08 Reviewed-on: https://chromium-review.googlesource.com/1215507Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590216}
-
Luciano Pacheco authored
In case of failure, debug/report the folder name in the log. Test: browser_tests --gtest_filter="CreateNewFolder/FilesApp*" Bug: 876267 Change-Id: I1341c3f746506521a172829fdcf121cbe2030920 Reviewed-on: https://chromium-review.googlesource.com/1207787 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5518e65d90d7..82bf31003c66 git log 5518e65d90d7..82bf31003c66 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader cf47cfdd7c44..6dafcf32ec41 (1 commits) Created with: gclient setdep -r src/third_party/skia@82bf31003c66 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ia71a82159dfe05a8daa28cfccd4e266118b5af88 Reviewed-on: https://chromium-review.googlesource.com/1218543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590214}
-
Mythri Alle authored
This is a reland of f17b2cd3 Original change's description: > Update ResourceLoader to also fetch cached code for inline scripts > > V8 also stores code caches for inline scripts in the html resources. > This cl updates ResourceLoader to fetch cached code for inline scripts > in MainResources. > > Bug: chromium:880212, chromium:812168 > Change-Id: I822453b52897aac292444df20e50937d8198064d > Reviewed-on: https://chromium-review.googlesource.com/1208391 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589137} Bug: chromium:880212, chromium:812168 Change-Id: I5d0d38bf89de68d6fe88324a42742b2dfac3be96 Reviewed-on: https://chromium-review.googlesource.com/1215326Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#590213}
-
Tarun Bansal authored
When the holdback experiment is enabled, the NetInfo network quality related Web APIs (https://wicg.github.io/netinfo/) would report network quality corresponding to the experiment params. This CL only affects the NetInfo JavaScript APIs. A subsequent CL will use the framework in this CL to also override the values of network quality reported in network quality related client hints headers. Change-Id: Iab9d4ecfe7c14eb5d3cee26dbf209fd943156333 Bug: 880545 Reviewed-on: https://chromium-review.googlesource.com/1201343 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590212}
-
Joel Hockey authored
New JS class Crostini to manage crostini shared paths. Record paths that are shared, and do not show 'Share with Linux' option for paths that are already shared. Update Crostini UI test: * Verify that 'Share with Linux' is not shown for files (only dirs). * Fixed drive_welcome.css path. Bug: 878324 Change-Id: I6b8445d0a127043f9d24126384267284af5ed7ab Reviewed-on: https://chromium-review.googlesource.com/1215154Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#590211}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f68077fb. With Chromium commits locally applied on WPT: d7762551 "Consistently use single quotes in Background Fetch WPTs." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24520 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I08929dba303e26a5d927e92ff5c3077a27c19903 Reviewed-on: https://chromium-review.googlesource.com/1217521 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590210}
-
Joanmarie Diggs authored
Originally landed: crrev.com/c/1163724 Reverted: crrev.com/c/1217069 The revert was due to the two new tests failing on Ubuntu 16.04, which has a newer version of ATK and thus different expectations. In order to run the same tests in both environments, prune states which are not essential to what is being tested from the state set of the expectations. This modification also eliminates the need to hand-edit new expectations which are generated on more recent systems. Original changes preserved in this re-land: * Add an event notifier in AXPlatformNodeAuraLinux for browser chrome. * Check to see if focus should follow selection. If it should, also emit state-changed:focused events. * Ensure that the correct states (focusable and selectable) wind up in the state set of elements where focus should follow selection. * Forward events from Blink content to AXPlatformNodeAuraLinux. * Create an event listener so that DumpAccessibilityEventsTest tests can be run. Add expectations for tests for which events are now emitted. At the present time, that is only focus and selected. R=dmazzoni@google.com Bug: 866340 Change-Id: I371ad0a1516aceb6c6924d0142a6f3268dfdd3ac Reviewed-on: https://chromium-review.googlesource.com/1217744Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#590209}
-
Mike Frysinger authored
Use the proper names for both of these in docs meant for public consumption. Change-Id: Ia5f56ac791e5a743a3b59c5ccef2dea6a868c2b7 Reviewed-on: https://chromium-review.googlesource.com/1217546Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#590208}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1215426. Now the test is passing and we don't need -expected.txt files. I forgot to remove these files under flag-specific/. Bug: 882477 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7e5a3bb7bb3393bfbbf0e9827daf5c8983cff41a Reviewed-on: https://chromium-review.googlesource.com/1218044Reviewed-by:
-
Ricky Liang authored
This CL decodes the still capture frame to YUV, rotates it according to screen rotation and encodes it back. This is to fix takePhoto() result having wrong orientation on HALv1 devices. Bug: 878865 Test: Tested on reef with CCA 5.1.0 that the captured photos are correct for both front and back cameras. Change-Id: Ib3758e0736b0dbb9b145acd3716b58cf6e08ccd3 Reviewed-on: https://chromium-review.googlesource.com/1208392 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#590206}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/63aa0e5b7001..0d0fb43f34ee git log 63aa0e5b7001..0d0fb43f34ee --date=short --no-merges --format='%ad %ae %s' 2018-09-11 jmadill@chromium.org Pass unpack buffer as explicit parameter to texSubImage. Created with: gclient setdep -r src/third_party/angle@0d0fb43f34ee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880906 TBR=ynovikov@chromium.org Change-Id: I83ce6ccf2c62c770845912f19ef043d6cd3c374e Reviewed-on: https://chromium-review.googlesource.com/1217815Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590205}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/867aebe10898..1bfa8980a363 git log 867aebe10898..1bfa8980a363 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@1bfa8980a363 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie61820f65ea25741a4b3084ccc917bacae0409f6 Reviewed-on: https://chromium-review.googlesource.com/1218422Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590204}
-
Alexey Baskakov authored
This is a cleanup code-health change. Bug: 774918 Change-Id: I9b73ad49874fa48210aba031d646173f1544678d Reviewed-on: https://chromium-review.googlesource.com/1209133Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#590203}
-
Lei Zhang authored
template_url_parser_fuzzer eventually calls down into code that interacts with base::CommandLine. BUG=882155 Change-Id: Id37803e2f3e67a6acc2e5686b136661d3bb0e1ea Reviewed-on: https://chromium-review.googlesource.com/1218163Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590202}
-
Daniel Cheng authored
Rather than requiring subclasses of blink::Frame to remember to call blink::frame::Detach() at the end of their overridden implementation, move the subclass logic into a separate method that is pure virtual on blink::Frame. This allows lifecycle management to be consolidated into blink::Frame::Detach(), rather than having asserts scattered throughout and hoping the subclasses managed it correctly. Bug: 838348 Change-Id: If2e26d7117af7dd890e2fa04052979438ec87cae Reviewed-on: https://chromium-review.googlesource.com/1217510Reviewed-by:
-
Sergei Datsenko authored
There is a bug in the caching code which triggers PLOG. Suppress it to avoid log noise. BUG=chromium:882738 Change-Id: Id7effca5c24268a9862b4cad2761051b02add5c6 Reviewed-on: https://chromium-review.googlesource.com/1218482Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#590200}
-
Yoichi Osato authored
This patch fix ComputeInlineBoxPosition for the position that points after line break and no LayoutObject after that by fallback to previous position. The fallback examples: - "<br>|" to "|<br>" - "<pre>foo\n|</pre>" to "<pre>foo|\n</pre>" This change aligns legacy LocalCaretRect to NG. Bug: 789870, 812535 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icb6cd9b8bc58b56a04d01eb22bdd58bd16ad5a01 Reviewed-on: https://chromium-review.googlesource.com/1215506 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590199}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2353705f52ff..656c1c9c270c Created with: gclient setdep -r src-internal@656c1c9c270c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882510 TBR=mmoss@chromium.org Change-Id: I30b703b7204c1cf4b5cec2d9d5fdcc0194a42e68 Reviewed-on: https://chromium-review.googlesource.com/1217818Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590198}
-
Mike Dougherty authored
Bug: 881816 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I695dac7e9aa0b2c6e08d5e661d56afda12d140b8 Reviewed-on: https://chromium-review.googlesource.com/1215042 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590197}
-
Timothy Loh authored
Due to either syncing or using multi-profile, we can get into a state where synced pin state lists Crostini apps although we shouldn't be displaying them. This results in weirdness like blank-space icons for the Terminal, or penguin icons for apps with icons, when these pinned items are supposed to be hidden. Clicking the shelf icons does nothing due to https://crrev.com/c/1212373. This CL prevents these broken pinned apps from appearing. Bug: 869266 Change-Id: I13ca91b8055cf43003bf1d467ca28161eb289e29 Reviewed-on: https://chromium-review.googlesource.com/1215532Reviewed-by:
-
