- 26 Oct, 2020 40 commits
-
-
Patrick Noland authored
Bug: 1142544 Change-Id: I9533d4f1350a5d539055f85a9bb1b48b21808b71 TBR: bashi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498655Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#820914}
-
Nicolas Ouellet-Payeur authored
The DestroyProfileOnBrowserClose didn't clean up data on disk when the profile got deleted, so the flag did nothing for ephemeral profiles, until now. With this patch, DestroyProfileOnBrowserClose applies to ephemeral profiles. When the last browser window in a profile closes, the Profile object is destroyed. Then, the profile directory is nuked from disk. This way, sensitive data gets deleted much earlier than it previously did. Bug: 88586 Change-Id: Ic74f8ceec0344f2759a88ab4a007f36316517037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485639Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#820913}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ief1d72ccf5f31a05639445068a4288cbbfa9cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498833Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#820912}
-
Reilly Grant authored
This change refactors the use counters for the Shape Detection family of APIs so that usage of the detect() methods on BarcodeDetector, FaceDetector and TextDetector interfaces is recorded separately. These new use counters are then enabled for UKM. This removes the use counters for the constructors, which are less useful than recording usage of the detect() methods as constructing an instance of the detector does not indicate real usage and could overtrigger for feature detection. Bug: 1001217 Change-Id: Iec763bb8f0f175e098943228492ca6b27440a167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498825 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#820911}
-
Scott Violet authored
Specifically if the NewTabCallback deletes then tab, then we shouldn't try to load a url. BUG=1142090 TEST=testOpenPopupFromInfoBarAndNewTabCallbackDestroysTab Change-Id: Ib31e7cb52d7dec6d1724c1e3471b7c5ace72c858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496160Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820910}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603713364-255d86fa5592c315dc7718e8b4c93f0ba1279e07.profdata to chrome-linux-master-1603735176-b32fad2c4d9cbe478f3c31f23cbc72f28c88ba53.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I10216ea86e7d5e1539e9754fdec24aa8b801fd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820909}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2663acda4ce..546b189d859d 2020-10-26 jalyn@microsoft.com Settings: Prepare shortcut editor for reset button If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I963de7d818ac55cae7b807cd4db08006738ab3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820908}
-
Sebastien Lalancette authored
This value will be mainly used when facing parsing failures when converting responses from the text-fragments-polyfill JavaScript library used on iOS. Bug: 1136043 Change-Id: I2af25b336944a5ac4f7258de75aeec8f73b46ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499084Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#820907}
-
Peter Kasting authored
These are selected so as to unblock removing (and remove) the majority of the remaining ButtonListener-receiving APIs. Bug: 772945 Change-Id: If33924bb5b21a843c2b90717916e54ac281ce235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495834 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820906}
-
Alexis Hetu authored
Using an RGBA8 image for an RG8 texture was causing confusion in the underlying driver where copyTexSubImage could be disallowed because of unequal formats between the framebuffer and texture (RG8 vs RGBA8) while the application was seeing 2 RGBA8 textures. Removing the workaround is now possible and fixes the issue. Bug: 985458 Change-Id: I6a1ac80f05adb67917ddda34835c9be7f0d5d1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499264Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820905}
-
Andre Le authored
- Add PhoneHubNotificationView to customize Phone Hub Notification. - After sending a reply, take the UI back to action buttons and briefly disable the reply button. BUG=1106937,1126208 Change-Id: Ie022f2a4955b6dd0ebd4b0120bfffae805038a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488364Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#820904}
-
Ilia Samsonov authored
Currently our builders run python in x86 architecture. This cl introduces the same routine as in depot tools to detect whether we are running on arm. https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2287751 Bug: 1130741 Change-Id: I139c1d6be042a43e73c80ae6aac789cdba9e352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462484Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#820903}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7874beb5c5a1..306f03788f83 2020-10-26 johnchen@chromium.org [Telemetry] Speculative fix for missing win32gui If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1141914 Tbr: zhanliang@google.com Change-Id: Idbf758dd9a58341279d73cabf19efc5ea9a8dca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820902}
-
Daniel Rubery authored
SafeBrowsingNetworkContexts is ready to roll out to Beta (see cl/337414650), so add a field trial for it. A few tests fail with the feature enabled, so we add a little code to fix those tests as well. Change-Id: I5254a0b632f5319f50d29756a996e69dcd3acc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477252Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#820901}
-
Victor Hugo Vianna Silva authored
Bug: 1099615 Change-Id: If712d3e7158ead902a6f93ccf85bcb45372a682c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498591 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820900}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2a3a5b3b4c3..aaea0d98fb64 2020-10-26 johnstiles@google.com Update `nameVariable` to return the variable name directly. 2020-10-26 brianosman@google.com Slight tweak to SkTHashMap natvis support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I210d3a21b9a2f09684a3b8741adea931130dd3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820899}
-
Jeroen Dhollander authored
This code path was previously not tested. The binary data for this test is committed in crrev.com/i/3324203. Bug: N/A Change-Id: I27c89cce52effc11accf3b4a03822ad2198c6ec9 Tests: browser_tests --gtest_filter=AssistantBrowserTest.* Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461249 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820898}
-
Philipp Hancke authored
following the pattern from https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/streams/transferable/worker.html Also moves the audio/worker test to the worker file BUG=chromium:1058021 Change-Id: I0a49166208aa5cd68a2660abed1ec5e0c52b9b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499521Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#820897}
-
Daniel Rubery authored
On Windows, when downloading the second or later part of a multipart archive, unrar will attempt to open another file. Due to the modifications we place on unrar to work within the sandbox, we don't open the file, but instead use File::hOpenFile as the handle. This is uninitialized memory, which is passed to GetFileType, causing a crash. This CL initializes hOpenFile to fix this problem and adds a test that would have caught the issue. Fixed: 1135503 Change-Id: I6cc83a5a2b5925900cde7b8b2dc8be64f0620d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490334 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#820896}
-
Rainhard Findling authored
* Workaround for crbug.com/1139806. * Writes the CCT scan completion time into a Chrome pref in case Chrome is open when the scan completes. * Uses this timestamp alongside the one from the registry in the Chrome cleaner child of safety check. Bug: 1087263,1139806 Change-Id: Ia3fda6e87058ba76089ce22e8367f41d8e0b8512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484700Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#820895}
-
Dan Harrington authored
There were two problems with these regexes: 1. it didn't support the syntax without curly braces: -checkdiscard @com.Foo class * 2. it ate newlines, which could break rules Change-Id: I667ec65f2e9c8a06c812d62578e700792cf172a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498828 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#820894}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603713364-eb28cdd9672687229cd838b6373ed78fbaa1ba2f.profdata to chrome-mac-master-1603735176-39200681b7df83b17975b9debf912df318fc5920.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0e8059d7223b60f02ced18b1632c15ac8797d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820893}
-
Eugene Zemtsov authored
Change-Id: I6ff42f27427b4ba171b7cb345523f4b1b550a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495795Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#820892}
-
Victor Hugo Vianna Silva authored
Let's attempt to re-enable the test. Bug: 1111533 Change-Id: If091b686e3ba64395587ec029dbd82df61559466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498691 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820891}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/902077f931b9..84938ab95122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: slightlyoff@google.com,avi@google.com Change-Id: I25b1cc8a18a150007184cf87604183510a2934eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820890}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I22a823fbe7d247fd5723bebddf4de3bb7ee69c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494765Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#820889}
-
Olivier Li authored
This helps track whether the HangWatcher is able to periodically wake up fast enough to watch for hangs. Bug: 1135528 Change-Id: I85d3c4896de35351dc2d68482e48f79b0c55d1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495275Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#820888}
-
Etienne Bergeron authored
This reverts commit b642822f. This CL is causing a shutdown crash. https://bugs.chromium.org/p/chromium/issues/detail?id=1142247 It will be merged back into next canary with the fix. Original change's description: > Move ISpVoice instance to a worker thread > > This CL is moving the speech synthesizer code to a worker thread. > > The TtsPlatformImpl is using an ISpVoice COM interface to perform > text-to-speech actions. The instance was living on the UI Main > Thread which was using STA Apartment. > > This CL is splitting the logic in two parts. The first part is the > control logic which stay on the UI Thread. The second part is the > synthesizer logic which is running on a worker thread. > > Bug: 869399, 1133813 > Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820340} TBR=dmazzoni@chromium.org,fdoray@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869399 Bug: 1133813 Change-Id: I6249ad2d5d7938e8aa960bbd8d0798f7396513ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499602Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@google.com> Cr-Commit-Position: refs/heads/master@{#820887}
-
dpapad authored
The latest version makes it possible to import chai.js with a JS module "import" statement. Also: - Fixing a few occurrences where the latest version would throw errors, as it seems stricter into what can be passed into the assert methods. For example passing a string to chai.assert.isAbove() now throws an error. - Making a small local modification depicted in chromium.patch, necessary to run chai.js in d8, which does not gave a window or global object. Bug: 1133198 Change-Id: I1a1503b3503b0f0dc54d537107714421f1865f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498054Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820886}
-
Toni Barzic authored
Last (only?) usage was removed in CL:2482042 BUG=1137452 Change-Id: I66c9a940c4fd182a99a322fa47eb3a17b0342a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496187Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820885}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I1fa0fc8f17e983730dc0c7caa68acd7289e1765e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498873Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#820884}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4f621af798e237210e7ca9c7a1eb787e475a83ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820883}
-
Bruce Dawson authored
This change fixes bisect-builds.py so that it runs under Python 3 (while still supporting Python 2). The changes are: - Don't import httplib (unsupported but also unused) - Import urllib.request as urllib on Python 3 - Don't use 16L syntax for 16 - Use input instead of raw_input on Python 3 - Convert integer division results to integer - Use is_alive instead of IsAlive - Use except Exception _as_ e instead of a comma The new code needs to use two conditionals with the rest of the fixes still working fine in Python 2. Bug: 941669 Change-Id: I34cd995225233f3f97008c7e07e0537b4683c48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498954 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#820882}
-
Dominique Fauteux-Chapleau authored
This is a reland of crrev.com/c/2414550 This should not change deep scanning behaviour with Connectors since OnSecurityEventEnterpriseConnector replaces this policy. Removing this policy completely is safe since it was marked as future and it has only been delivered as a cloud policy. Bug: 1103390 Change-Id: I884f8bc059844918e8ef19b9b1ac37c4313d4363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462391Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#820881}
-
Ella Ge authored
Bug: 1098946 Change-Id: I6bc30df96b54c19b4aa3b0e4572e3501af3be750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497991Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#820880}
-
Alexander Alekseev authored
This CL adds a graph of the scanout time per seconds reported in the PresentationFeedback. Screenshot: https://screenshot.googleplex.com/7wZhCV78vtPskdu.png Bug: 1075612 Change-Id: I16a5320532f35bdc3be4baa6e2bb59bd3db632b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463872 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#820879}
-
Alex Gough authored
Input file here does not need to be written. Bug: 1130762 Change-Id: I4f7d3bc0b583ec3c9afe3105ef3a98eb11551e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488703Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#820878}
-
Arthur Eubanks authored
Change-Id: I733621250e2a873a6e8e68bb332355160e7b082d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490544Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#820877}
-
Joe Downing authored
I've added 'internal_only' and 'platform_only' features to our policies in this CL. This will fix a problem the admin console team is hitting where our policies are showing up in the console but aren't configurable via cloud policy (or aren't applicable outside of Google). While I was making changes, I also fixed some references to other policy names which were missing the '<ph...' tags. Change-Id: Iac11f832b6e17cee0005eb74989a4818ce3f9b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495709Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#820876}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic949342158fc0428cb133c16a793e9460756050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820875}
-