- 11 Nov, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie2d67e934daf7648642d6f598937865a1d59476f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826191}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605041937-1449424af661a723772729965b60b3f566868499.profdata to chrome-win64-master-1605052680-a273e99b05826791587df478a7f9bb5649ddafe2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2131e9b3e64893600d1db29cc739328667d9d050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531557Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes base::STLIncludes and replaces existing usages with the equivalent base::ranges::includes. Furthermore it adds DCHECKs to base::ranges::includes to assert that the preconditions are met. TBR=dcheng Bug: None Change-Id: I5e282897fa5321da68a905804ee30cf491baaf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529116 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826189}
-
Maksim Sisov authored
This CL adds Ozone/Linux CI Test configuration. Initially, it will run the same gtests as CQ Test configuration to be sure the config is correct. Later, when the testers are up and running on CI, chromium_linux_gtests will be used instead. R=dpranke CC=msisov Bug: 1142753 Change-Id: If1173c93f12774569c257dd8ad04abab2f99a434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529098 Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#826188}
-
Chris Blume authored
A number of CC files were not passing the include-what-you-use presubmit test. This CL includes missing files that are being used. R=khushalsagar@chromium.org Change-Id: I75a2ca716d7f802ce4720a564838c0d6b46470af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521201Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#826187}
-
Ben Reich authored
Had the params.task_output_dir as the source of the v8 coverage files, this is incorrect it should be the tests folder in the --javascript-coverage-dir flag path. Bug: 1113941 Change-Id: I8491ce86f6c615be20e7660becedc3c7887cfd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526805Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#826186}
-
sandromaggi authored
This moves the timer from |WaitForDocumentAction| into the |ScriptExecutor| as part of the |WaitForDocumentOperation| (similar to |WaitForDomOperation|). This CL also replaces the old |WaitForDocumentToBecomeInteractive| to use the new code. Bug: b/172542134 Change-Id: I1587d7d64a2f1a73a8a6187153a06e0d86c6dac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527137 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826185}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605052680-4bcc95392c674b4241fea3539716bd9698469487.profdata to chrome-mac-master-1605074376-4a1ac92ae1c3d96ed8ec2e639c66896bbbb0571f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I840685239275491efadf0e814812ae993fec85ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531560Reviewed-by:
-
Luciano Pacheco authored
JS Modules for the following files: //ui/file_manger/base/js/filtered_volume_manager.js //ui/file_manger/file_manager/background/js/test_util_base.js //ui/file_manger/audio_player/js: background.js error_util.js test_util.js Add the main_background.m.js to act as the entry point for the background page. Bug: 1133186 Change-Id: If679c77d9e5226fc7931f4cbe042b50c17abb549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531596Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#826183}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604987499-d58c7c50ae14a2e4ca32a9270333a79aabab2447.profdata to chrome-win32-master-1605041937-c87b025ab4b9cd2fe14d3e7cb6f1c951afd90e7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If8e83237f92df285f403d67d389ce3dbc3be6eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530626Reviewed-by:
-
Harvey Yang authored
Following the mechanism that ARC chooses sensors: https://source.corp.google.com/master-arc-dev/vendor/google_arc/libs/sensor_hub/sensors.cpp;rcl=3907f008bf945792e9b58ef57dd919f0d6153a1f;l=597 Choose the richer set (lid or base) of accelerometer, gyrometer, and magnetometer; prefer the ambient light sensor on the lid than the one on the base. BUG=b:172414302 TEST=unit tests and run on octopus Change-Id: I4c716c927fcb10b93eaa33735bba0ed3933867a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494523 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826181}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81e9301838fc..6835e1ab1918 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4a2d19ef40ed4fdf7b4d5322c07bb528b95cc4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531361Reviewed-by:
-
John Abd-El-Malek authored
Change-Id: Idb466ed2e66d1b291c4bee2c5504084acdca30ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483623 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826179}
-
rajendrant authored
This moves the common API used in subresource redirect web contents observer to a separate utility file. These common function will be used in the upcoming robots rules fetching and checking logic. No change in behavior is expected. Bug: 1147565 Change-Id: I46c13ab38a8290f24a8e7142f7a7354f08a8ba93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530391 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#826178}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9c99b7964fab..0bfdbc37e9ec 2020-11-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cf726518..56e88353 (825867:825974) 2020-11-10 alessiob@webrtc.org Revert "RNN VAD: pitch search optimizations (part 1)" 2020-11-10 alessiob@webrtc.org Revert "RNN VAD: pitch search optimizations (part 2)" 2020-11-10 kwiberg@webrtc.org CallbackList: Improve documentation 2020-11-10 alessiob@webrtc.org Revert "RNN VAD: pitch search optimizations (part 3)" 2020-11-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 73d177ae..cf726518 (825746:825867) 2020-11-10 mbonadei@webrtc.org Undo enforcing of PEP-8 pylint changes for method and function names. 2020-11-10 hta@webrtc.org Eliminate sigslot from RtpTransmissionManager 2020-11-10 hta@webrtc.org Remove has_slots from a class that does not need it 2020-11-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3f3e178f..73d177ae (824219:825746) 2020-11-10 alessiob@webrtc.org RNN VAD: pitch search optimizations (part 3) 2020-11-10 alessiob@webrtc.org RNN VAD: pitch search optimizations (part 2) 2020-11-09 jakobi@webrtc.org Remove check for WebRTC-SendSideBwe-WithOverhead in bitrate controller. 2020-11-09 hta@webrtc.org Remove one use of sigslot from webrtc_session_description_factory 2020-11-09 alessiob@webrtc.org RNN VAD: pitch search optimizations (part 1) 2020-11-09 kwiberg@webrtc.org Introduce RTC_CHECK_NOTREACHED(), an always-checking RTC_NOTREACHED() 2020-11-09 perkj@webrtc.org Replace field trials with WebRtcKeyValueConfig in SendSideBandwidthEstimate If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I54f316ffb0bd805b80a2981ebe2fee77790cd75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531242Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 6e85e7a4. Reason for revert: crbug.com/1147678 Original change's description: > Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > This is a reland of ba7d8814. Two changes were made: > 1) A null pointer check is added to AutofillSaveCardInfoBar.java, and > 2) In AutofillUpstreamTest.java, startMainActivityWithURL() is replaced with loadUrl(). > > Original change's description: > > [AF] Add account indication footer to AutofillSaveCardInfoBar > > > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > > > Screenshot with feature enabled in light mode: > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > > > Screenshot with feature enabled in dark mode: > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > > > Bug: 1135847, 1146186 > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > > Commit-Queue: Anne Lim <annelim@google.com> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Cr-Commit-Position: refs/heads/master@{#823710} > > Bug: 1135847 > Change-Id: Ifd9d514234a3af82330686373578f54ffd3427c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522219 > Commit-Queue: Anne Lim <annelim@google.com> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825853} TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com Change-Id: I09677d00d3c73763eb0c95ba56fee01bedbb149a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135847, 1147678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531084Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826176}
-
Josh Nohle authored
Records if the user has the Nearby Share feature enabled, and if not, records why the feature is not enabled. For example, the feature is not allowed by policy, or the user onboarded but later disabled the feature. Emitted when the Nearby Share service starts. This happens at login for the primary profile if the feature flag is on. Manually tested all scenarios except disallowed by policy. Bug: 1105579 Change-Id: I7674b70017069f5ee1a4f4afd5c0fe6c2cb7445c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523310 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826175}
-
Noel Gordon authored
After chrome.metricsPrivate fakes landed, CL:2500642 does not need use these window.metrics fakes. Remove them. Bug: 1113981 Change-Id: Iefcd5881a31a147e9387a9a175723a571412e5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531597 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#826174}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82f6a0e5..c6f52c21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I854c1e174f62b38ad72d23b4ac7fcf8ea781c5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530526Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826173}
-
Tarun Bansal authored
This CL moves the logic to disable lite videos on seek behind experiment parameter, and also disables that by default. The param can be enabled again once we are reasonably confident that it's not too aggressive and we can run an experiment to verify that. Bug: 1145646 Change-Id: Iedeb82abc1124568986f8d87cf92ef2f48c5eb2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524925 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#826172}
-
Austin Tankiang authored
Bug: 1129778 Fixed: 1145079 Change-Id: Ibb1b1aceff989163377d33a746a812268864e322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520481 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Harvey Yang authored
This commit adds PlatformSensor(Provider)ChromeOS in generic sensor for chromebooks. They get data by registering a Sensor Hal Client to Sensor Hal Dispatcher, and waits for a mojo connection to IIO Service. BUG=chromium:1116940 TEST=unit tests and run on octopus Change-Id: I63af90d8b617acb275e35422e2c667904c10b450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400398 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
-
Ted Meyer authored
adding Husain to reviewer just so it won't get submitted without him giving +1 for the survey contents. link to survey: https://docs.google.com/forms/d/e/1FAIpQLSe5X3Al_esm00XL3jUMG78xD9_CSy9bdMl6XZWVfdUJP5wSqg/viewform R=dalecurtis,hbengali@google.com Change-Id: I0318d41fe444bad968711a0b1f1276b55e7a9494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522882Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826169}
-
Sergey Ulanov authored
Previously audio and video decryptor creation logic was not consistent: audio stream decryptor was created in FuchsiaClearStreamDecryptor::Create(), while video stream decryptor is allocated in FuchsiaCdm. This CL removes Create() from FuchsiaClearStreamDecryptor and adds FuchsiaCdm: :CreateAudioDecryptor(). Change-Id: I17b4ad0d9e8b0949de9951ec2534c15f678d2e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531053 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826168}
-
David Bertoni authored
These tests were disabled for flakiness, but they exhibited no flakes in 3000 iterations on the bots. Bug: 658050, 660366, 875908 Change-Id: Id07368376216fdbe01a9b43351f5ec94925eccc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503311Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826167}
-
Andreas Haas authored
This CL removes uses of: DOMArrayBufferBase::DeprecatedByteLengthAsUnsigned DOMArrayBufferView::deprecatedByteLengthAsUnsigned Because TypeConverters cannot signal failure, another layer of maximum size checking under penalty of DOMExceptions needed to be added in credentials_container.cc. Bug: 1030717 Change-Id: I91598413d0762ffc5fa09d1cd19d79e2a5ce72de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213526 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826166}
-
Moe Ahmadi authored
Fixed: 1147136 Change-Id: Ic6ce9384eda8f59d4fbb223cbf2decb2e0ea668b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527857 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#826165}
-
Eric Lawrence [MSFT] authored
Correct a RFC reference and other tweaks to improve clarity. Change-Id: I547b4f1c12cbae91fe3f58eed73428344e87dc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531071Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#826164}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Id409a4633f9ff666636e4e2fc47ed549c829c861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494283 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#826163}
-
Noel Gordon authored
Add actual storage to the SWA chrome.storage fake, to allow removal of of more "if (window.isSWA) {...}" code from CL:2500642. Implementation code derived from ui/file_manager/file_manager/test/js/chrome_api_test_impl.js Bug: 1113981 Tbr: Bo Change-Id: I5dafeb94616ef9e051f8a3fb829f1204f039c69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529270 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7006e15df59d..480d950d3c3a 2020-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4ed9d3498dcf to 019feda602ec (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I1ec9104ff4d80b43f5391fb627c94ef99ee7470a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531072Reviewed-by:
-
Alexander Alekseev authored
Bug: 1147192,1147526 Test: Resolves reproducible crash on a test device Change-Id: Ie9dadf1b1165e32c45fa2878ca7cd11be823b384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527845Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Shu Chen <shuchen@chromium.org> Auto-Submit: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#826160}
-
Brian Liu Xu authored
This is a reland of commit 933ec987, using GetProcAddress to locate ::GetCurrentInputMessageSource and skip loading it if the function is not supported by the Windows client (i.e. Win7). Original change's description: > Ignore rogue window management mouse move events > > Do not process window management mouse messages (WMMMs) when the pen is active over the client area. > > Windows sends window management mouse messages at the mouse position when windows open or close (e.g. Aura tooltips and Status Bubbles), including WM_MOUSEMOVE, WM_NCMOUSEMOVE, and WM_SETCURSOR. This is a longstanding Windows behavior designed to ensure that mouse cursor visuals and hover states update when the foreground window changes. However, this behavior does not extend to pen input, so WMMMs always come with the mouse coordinates instead of with the pen coordinates even if there is an active pen. > > In Chromium, WM_POINTER processing in the window non-client area are "promoted" to mouse messages in order to allow for interaction with the native window frame (e.g. resize handles, title bar, and window caption buttons). However, WM_POINTER messages in the window client area are handled as Chromium events without any mouse promotion; in this latter case, mouse position and pen position are not guaranteed to be in sync. > > Since Aura tooltips and Status Bubbles appear as custom windows on pen hover, opening/closing them causes Windows to send WMMMs. Consequently, users might see visual flickering as hover states flip back and forth between pen and mouse positions. In order to ensure that these WMMMs do not interfere with hover states, we must ignore such messages until the pen is no longer active. > > This change affects only Windows 8 and newer clients, which use the WM_POINTER API. > > Bug: 1147222 > Change-Id: I44335348f933f48edcfe665b396f133388169957 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525220 > Commit-Queue: Brian Liu Xu <brx@microsoft.com> > Auto-Submit: Brian Liu Xu <brx@microsoft.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825665} Bug: 1147222 Change-Id: I651ee271826a60ff33556cc472bbb86f5190a650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531066Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Auto-Submit: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#826159}
-
Kai Ninomiya authored
Bug: None Change-Id: Icc993fb862f71b41b22e45e8c560332c53d8f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531175Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#826158}
-
Hitoshi Yoshida authored
On backward/forward navigations, backward/forward cache changes some behavior around the navigation. This CL updates a test navigation/back-to-get-after-post to work with backward/forward cache. Bug: 1132180 Change-Id: I86a99eddffbe8c25dc932258035214a60314b34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520557Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#826157}
-
Findit authored
This reverts commit 5f1112ab. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 826153 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVmMTExMmFiMDE4MDgzYmI3ZmQ4NzA0NDc3MGIyYWYwMmFjYzgwMDIM Sample Failed Build: https://ci.chromium.org/b/8863951380802392720 Sample Failed Step: compile Original change's description: > [BreakoutBox] Add MediaStreamTrackProcessor > > This CL introduces MediaStreamTrackProcessor, an object that allows > exposing a MediaStreamTrack's media frames as a readable stream, > enabling applications to perform custom processing. > This basically allows the creation of a custom sink, in terms of the > model proposed by the Media Capture and Streams spec [1]. > A MediaStreamTrackProcessor can be combined with a TransformStream and a > MediaStreamTrackGenerator to effectively insert a processing step inside > an existing track. > > [1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings > > Bug: 1142955 > Change-Id: I2a119f0c2ea9ce50432509286bd0f43758d8a272 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524322 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826153} Change-Id: I39765bc5c0ae5ef193a9e6f805b2ba798a7e901c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530595 Cr-Commit-Position: refs/heads/master@{#826156}
-
Michael Bai authored
AutofillProvider uses WebContents's container getLocationOnScreen() to transform the field's bund to screen coordinates before notify the AutofillService focus change. WebLayer intentionally leaves the space to it's top control, but can't set the margin to ContentView which hosts the WebContents. This patch adds RenderCoordinates.getContentOffsetYPixInt() API for AutofillProvider to get the top margin. Test: the autofill pop is in correct location, and I didn't see side effect. Bug: 1085294, 1135076 Change-Id: I163f67375e0177a5f75717a3069124ec2ff53894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523525 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826155}
-
Yunke Zhou authored
Bug: 1145539 Change-Id: I27926823cbda91fcbec67ccd9828dd440c4d43d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517529 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#826154}
-
Guido Urdaneta authored
This CL introduces MediaStreamTrackProcessor, an object that allows exposing a MediaStreamTrack's media frames as a readable stream, enabling applications to perform custom processing. This basically allows the creation of a custom sink, in terms of the model proposed by the Media Capture and Streams spec [1]. A MediaStreamTrackProcessor can be combined with a TransformStream and a MediaStreamTrackGenerator to effectively insert a processing step inside an existing track. [1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings Bug: 1142955 Change-Id: I2a119f0c2ea9ce50432509286bd0f43758d8a272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524322 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#826153}
-
Thomas Lukaszewicz authored
Currently the TabStripRegionView controls are flush with the window's caption buttons on Windows, Linux and ChromeOS and sitting flush with the browser window itself on Mac. This CL introduces an 8pt padding to the TabStripRegionView when tab strip controls are present in keeping with UX guidance. Presently the only applicable control is the TabSearchBubtton. This introduces the desired spacing between window caption buttons and right aligned controls. It also correctly aligns the rightmost control over the 3 dot menu in the toolbar on Mac. Bug: 1145277 Change-Id: Ic199b7f21f158723559d82dc37046ff463ae6c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522167Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
