- 19 Oct, 2018 40 commits
-
-
Takuto Ikuta authored
The flag suppressed user defined warning from libc++ https://github.com/llvm-project/llvm-project-20170507/blob/a2e822e3ac432da65d730dca1f2cbeee49f6e235/libcxx/include/__tree#L1848 I think this will be useful to prevent forgotten const. Bug: 683349 Change-Id: I24199ae9bf065ee6560b6caa397cd5fd8c042e83 Reviewed-on: https://chromium-review.googlesource.com/c/1286103 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601055}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=xdai@chromium.org Bug: 681136 Change-Id: I2dff39578c1c05a5ddef7758b74a84f7b54b00af Reviewed-on: https://chromium-review.googlesource.com/c/1288491Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601054}
-
Jonathan Metzman authored
Comment it so that people uninterested in fuzzing can understand why something is a fuzzable_proto_library and what that means. Also, fix copyright/license headers in LPM GN files. Change-Id: I898816a69f574175b27a970a0e5a289b74b133b6 Reviewed-on: https://chromium-review.googlesource.com/c/1288895 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#601053}
-
Toni Barzic authored
This code is currently shared between file_manager app and webstore_widget app. The latter is not longer used and will be removed. Given that file manager will becaume the only user of the widget currently under components/chrome_apps/webstore_widget/cws_widget, move this to ui/file_manager. (This breaks webstore widget app, but as stated before, the app is no longer used) BUG=839992 TEST=Verify that installing new file system service in file manager works. Change-Id: Ibe0778b2bb8ef075765ce864835751414baa8841 Reviewed-on: https://chromium-review.googlesource.com/c/1288076Reviewed-by:Stuart Langley <slangley@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#601052}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I18a4a800b822a7c998b983c83501035589477721 Reviewed-on: https://chromium-review.googlesource.com/c/1290205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601051}
-
Fumitoshi Ukai authored
Bug: 835732 Change-Id: I57a009a667ff59e7b5c232df31faa03df830e979 Reviewed-on: https://chromium-review.googlesource.com/c/1282423Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#601050}
-
Xianzhu Wang authored
This allows logging before creating the port. Bug: 896799 Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 Reviewed-on: https://chromium-review.googlesource.com/c/1289305 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#601049}
-
Sam McNally authored
Treat Drive as disabled for all profiles if sync is disabled by the command line. Some tests set this flag outside guest mode, breaking the assumption that any profile where drive is enabled can obtain a corresponding DriveNotificationManager. Bug: 870004 Change-Id: Ibeb7ad8b5f0e4c757afdb4cafebbf21166ada265 Reviewed-on: https://chromium-review.googlesource.com/c/1286015 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#601048}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b29e4cca18a4..e82e0c2cae50 Created with: gclient setdep -r src-internal@e82e0c2cae50 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ec18f6707f6d8f193e082bbbcb43a4cfdd1fc58 Reviewed-on: https://chromium-review.googlesource.com/c/1290101Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601047}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ic0b5eb0c9c9a615ab0a322d8d69dee9a33bffaca Reviewed-on: https://chromium-review.googlesource.com/c/1288503Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#601046}
-
Sam McNally authored
Bug: 870004 Change-Id: I2ea092c31e1d16e6610910b5951bba24a2b4c59f Reviewed-on: https://chromium-review.googlesource.com/c/1282511Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I30ead5224e4a6c694b6dfbfe17f7c74e0130f5f3 Reviewed-on: https://chromium-review.googlesource.com/c/1288499Reviewed-by:
-
Darren Shen authored
This is a reland of b03ffb6b Ran arc.Boot locally and it passes. TBR=jamescook@chromium.org Original change's description: > [VK] Clarify KeyboardUI interface. > > Currently, KeyboardUI has a weird interface where |GetKeyboardWindow| > will start loading the keyboard web page if it is called the first time. > So this resulted in a lot of places where we were calling > GetKeyboardWindow and didn't know whether it would cause a load or not. > > We change the KeyboardUI interface a bit to explicitly state when we > are creating / loading a keyboard window, vs just getting an already > loaded one. > > This removes ChromeKeyboardUIWebContent's dependency on > KeyboardController as well. > > We tried to keep the same behaviour for existing KeyboardUI subclasses. > > Bug: 845780 > Change-Id: I3178c81c382f2c3cd8217eda5a0c9b9d489df5be > Reviewed-on: https://chromium-review.googlesource.com/c/1264336 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599772} Bug: 845780 Change-Id: I77587e5bb62592df6d7cc9497e370600126c9418 Reviewed-on: https://chromium-review.googlesource.com/c/1288175Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#601043}
-
Takuto Ikuta authored
This is for more than 30 mins compile steps like below builds. 2271s https://ci.chromium.org/b/8932325985231306384 2260s https://ci.chromium.org/b/8932340428007432480 2223s https://ci.chromium.org/b/8932325334603827024 2196s https://ci.chromium.org/b/8932322970788940720 Also this is to provide more faster CQ cycle time by improving slowest builder. Bug: 804251 Change-Id: I08e7ba064934bd3273fab5db241f557ffbce3c7b Reviewed-on: https://chromium-review.googlesource.com/c/1290570Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601042}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4c64c3dc862..bc6f52f36d5f git log e4c64c3dc862..bc6f52f36d5f --date=short --no-merges --format='%ad %ae %s' 2018-10-19 jmadill@chromium.org Make BindingPointer::set non-virtual. 2018-10-19 jmadill@chromium.org Introduce SubjectBindingPointer. 2018-10-19 jmadill@chromium.org Make gl::Buffer an angle::Subject. 2018-10-19 jmadill@chromium.org Use dispatch table to optimize buffer binding. Created with: gclient setdep -r src/third_party/angle@bc6f52f36d5f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I16074d6eecca46b34ebce67603abe01c654beb0f Reviewed-on: https://chromium-review.googlesource.com/c/1290531Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/91031585f0fd..95c5c15bdec9 git log 91031585f0fd..95c5c15bdec9 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 dhanyaganesh@chromium.org Add Common Metric Fields for all metrics Created with: gclient setdep -r src/third_party/chromite@95c5c15bdec9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic055c3d6a3f1d22814cd18dbb2650b4127c2a786 Reviewed-on: https://chromium-review.googlesource.com/c/1290113Reviewed-by:
-
Sergei Datsenko authored
This message reappears every time drive sync is retried. There is no point to show a new notification for that, only show one at most. BUG=chromium:893444 Change-Id: If755faac98be822a777df1cec15bd00f8c04d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/1288334 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#601039}
-
Sebastien Marchand authored
Having this feature will make it easier to measure the various impact of changing this value. Bug: 896687 Change-Id: I4f976a41dc402c1b1b49625c4105cee3814a12fe Reviewed-on: https://chromium-review.googlesource.com/c/1288892Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#601038}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6e5a3a3bf0383894ebab6dcfdfdb471e862fba3b Reviewed-on: https://chromium-review.googlesource.com/c/1290629Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601037}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf9c8d4c233a..b29e4cca18a4 Created with: gclient setdep -r src-internal@b29e4cca18a4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I328506ce8ff14c2cdd58b9a730beb35b7570beb8 Reviewed-on: https://chromium-review.googlesource.com/c/1290530Reviewed-by:
-
Stuart Langley authored
This ensures that the correctly localized name is displayed in settings for the drive/Computers path. Bug: 884020 Change-Id: Iaa68242aba57d0ac2228d6b90a6c627f5757875e Reviewed-on: https://chromium-review.googlesource.com/c/1290489Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cedb2de8832d..237fb2a03b4b git log cedb2de8832d..237fb2a03b4b --date=short --no-merges --format='%ad %ae %s' 2018-10-19 benjhayden@chromium.org Allow es6 default, rest, and spread in style guide. Created with: gclient setdep -r src/third_party/catapult@237fb2a03b4b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic2f6148e0cb2f90f7aab0dc996ec5bfe0b788c93 Reviewed-on: https://chromium-review.googlesource.com/c/1290391Reviewed-by:
-
Fabrice de Gans-Riberi authored
The 'http_lib' target was erroneously configured as a component rather than a source set, which broke the component build. Bug: 874155 Change-Id: I968b2418891d5a702f408791cd88b3077090f47d Reviewed-on: https://chromium-review.googlesource.com/c/1290512 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601033}
-
Jered Gray authored
Previously, page visits were recorded in RecordTopHostMetrics() for several transition types that were filtered out when retrieving TopHosts, such as reloads. This has been changed so that the same filters are used for both, which should make the UMA histogram more accurate. HistoryServiceTests have been updated to test the top hosts histogram and an additional test has been added to verify that the page transitions recorded as visits by RecordTopHostMetrics() and those retrieved from the db when TopHosts() is called remain in sync. Additionally, PAGE_TRANSITION_KEYWORD_GENERATED is no longer culled from those incrementing the visit count. Lastly, histograms.xml has been updated to reflect the current state of History.TopHostVisitsByRank. This histogram hasn't been in active use since September of 2017, although it'll soon become active again. Bug: 846459 Change-Id: I3fb153fab5c4e8db06a980d60ba869a2b25af903 Reviewed-on: https://chromium-review.googlesource.com/c/1270183Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#601032}
-
Samuel Huang authored
When llvm-nm finds no symbols in an object file (.o file or embedded in in .a file) it prints 'no symbols' to stderr. This produces a lot of noise when running 'supersize archive' from command line. This CL makes SuperSize capture stderr for calls to llvm-nm (and nm, although it seems to be more quiet). The number of stderr lines (all 'no symbols' as far as we see), if non-0, is returned by nm.RunNmOnIntermediates(), and printed by obj_analyzer._RunNm() as a warning. Change-Id: I2090f8762614d5fc3102f0ec94ef7e83fc305bfd Reviewed-on: https://chromium-review.googlesource.com/c/1289989Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601031}
-
Achuith Bhandarkar authored
testVariationArgs and testTelemetryUsesChromeClockDomain should be handled by https://chromium-review.googlesource.com/c/1284756 Bug: 895977 Test: chromeos-amd64-generic-rel Change-Id: I2627df526bfa56d5ae6e32d4954cb08c8f8c8378 Reviewed-on: https://chromium-review.googlesource.com/c/1289949Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#601030}
-
Nate Chapin authored
Bug: 879306 Change-Id: I7f425130467b120cfc8822c7ec6e77126a1c018c Reviewed-on: https://chromium-review.googlesource.com/c/1289703 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601029}
-
Satoshi Niwa authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5a432f7b9d71..299607e8f0fa $ git log 5a432f7b9..299607e8f --date=short --no-merges --format='%ad %ae %s' 2018-10-16 niwa Pass arc_file_picker feature flag to ARC container as an Android property 2018-10-16 isandrk cryptohome: Remove deprecated TpmGetVersion call 2018-10-10 matthewmwang shill: Add HTTPS URL to system_api and percolate it down to ConnectivityTrial Created with: roll-dep src/third_party/cros_system_api Bug: 117814025 Test: Built succeeded Change-Id: Icf6ae5aec850283404f97f61fa3a582b52f384b9 Reviewed-on: https://chromium-review.googlesource.com/c/1288516Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#601028}
-
Erik Luo authored
Screenshot: https://imgur.com/a/YlClsZ0 Bug: none Change-Id: Ic6732ba029cb0c03a166db77b32daf31f3b79cfa Reviewed-on: https://chromium-review.googlesource.com/c/1290199Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#601027}
-
Erik Luo authored
TextPrompts have contenteditable="plaintext-only", which keep their text selection after losing focus. This CL hides their text select highlight when not focused. Also, live expressions no longer keep their highlight when losing focus. Bug: 820007 Change-Id: I19f1e498c3e3c03ad38f022e3c2e9ebbf0f96d94 Reviewed-on: https://chromium-review.googlesource.com/c/1069334Reviewed-by:
-
Tetsui Ohkubo authored
This CL removes MarkAllPopupsAsShown from MessagePopupCollection. MarkAllPopupsAsShown was the root cause of multiple heap-use-after-free e.g. https://crbug.com/869716 and https://crbug.com/869593 . The method marks active popups as shown and closes them, but ideally it's better to do that in MesageCenterImpl (model) rather than in MessagePopupCollection (view). TEST=MessagePopupCollectionTest BUG=none Change-Id: Iec1dac95ab68ca0a29b3b70d7284392bc826904e Reviewed-on: https://chromium-review.googlesource.com/c/1280562Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#601025}
-
Tom Finegan authored
BUG=896519 Change-Id: Ic6572e30daf960501f14ecac4a932f1091be5957 Reviewed-on: https://chromium-review.googlesource.com/c/1290132 Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601024}
-
Tetsui Ohkubo authored
VPN feature pod button didn't update when VPN connection state changed during UnifiedSystemTray is open. It was because it didn't observe the network state change. TEST=manual BUG=896411 Change-Id: I1b9333b277dbcfc86265837b74a5864279b4b3ca Reviewed-on: https://chromium-review.googlesource.com/c/1288333 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
Previously, RemoteFrame navigations did not perform any renderer-side checks and relied solely on the browser-side logic to block disallowed navigations via mechanisms like FilterURL. This means that blocked remote frame navigations were silently navigated to about:blank without any console error message. This CL adds a CanDisplay check to the remote navigation path to match an equivalent check done for local frame navigations. This way, the renderer can consistently block disallowed navigations in both cases and output an error message. Bug: 894399 Change-Id: I172f68f77c1676f6ca0172d2a6c78f7edc0e3b7a Reviewed-on: https://chromium-review.googlesource.com/c/1282390Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601022}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1ee77bd42da6..1f120c74ea2e git log 1ee77bd42da6..1f120c74ea2e --date=short --no-merges --format='%ad %ae %s' 2018-10-18 tsepez@chromium.org Fully populate JS platform callbacks in pdfium_test 2018-10-18 thestig@chromium.org One more round of IWYU in fxjs/. 2018-10-18 tsepez@chromium.org Try assigning more kinds of values to doc props Created with: gclient setdep -r src/third_party/pdfium@1f120c74ea2e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I93634c658f5a2697ffd0a495575e3ce948c65cff Reviewed-on: https://chromium-review.googlesource.com/c/1290390Reviewed-by:
-
Yoshifumi Inoue authored
This patch renames |ContainsOnlyLatin1()| to |ContainsOnlyLatin1OrEmpty()| as consistency with the patch[1] for improving readability. Note: All renaming is done by global replace tool. This patch similar to the patch[2] which renames |ContainsOnlyASCII()|. [1] http://crrev.com/c/1288157 Rename ContainsOnlyWhitespace() to ContainsOnlyWhitespaceOrEmpty() [2] http://crrev.com/c/1288502 Rename ContainsOnlyASCII() to ContainsOnlyASCIIOrEmpty() Change-Id: I6dbe6230ebf859b366c978c89973c508a6c0c090 Reviewed-on: https://chromium-review.googlesource.com/c/1288501Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 896884 Change-Id: I8071de9ccebf71bcb112990d2e35ca55eb4d7df6 Reviewed-on: https://chromium-review.googlesource.com/c/1289708 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c1e6594df580..93277a7fc8ef git log c1e6594df580..93277a7fc8ef --date=short --no-merges --format='%ad %ae %s' 2018-10-18 ehmaldonado@chromium.org git-cl: Don't report metrics for not-known repos. Created with: gclient setdep -r src/third_party/depot_tools@93277a7fc8ef The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:896868 TBR=agable@chromium.org Change-Id: I6fc12fb825faf3aaac42ce49bca253c0b07cd855 Reviewed-on: https://chromium-review.googlesource.com/c/1289656Reviewed-by:
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idf883678744f87a7d431154608242d0ed0ec7e91 Reviewed-on: https://chromium-review.googlesource.com/c/1288309Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601017}
-
Vikas Soni authored
Initial implementation of an AHardwareBuffer backed sharableImage and corresponding unittests. Bug: 891060 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I785a8666c210a21463514b79f8cc253c6b9544d3 Reviewed-on: https://chromium-review.googlesource.com/c/1282442 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601016}
-
