- 23 Oct, 2020 40 commits
-
-
Ahmed Fakhry authored
- Both AudioEncoders and WebmMuxer were using ThreadCheckers to assert operations being called on a valid thread. However, there's no need to enforce all operations happening on the exact same thread. What we care about is the sequence of operations, therefore a SequenceChecker is good enough. - Add mechanisms to flush any buffered frames in the encoders or muxer to avoid dropping frames, and also enable manual flushing rather than having to destroy the object to have it flush its buffers. BUG=1126586 TEST=Modified a test in media_unittests --gtest_filter=*AudioEncodersTest* Change-Id: Ife44c440c48408553dacdd92fd8800cdc5c7a233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490884Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#820432}
-
rbpotter authored
This reverts commit 7c245642. translation.py script parses all checked-in grd/grdp files. This means that the dummy test expectation file was causing failures, because the grdps it includes don't actually exist (the lines are just there to validate that the generate_grd.py script can correctly generate grdp lines). P3 (see PS1->PS3 diff) fixes the issue by putting the test expectations in a string instead of in a checked-in expected grd file. TBR=dpapad@chromium.org Original change's description: > Revert "WebUI: Add support for producing/consuming grdp files in generate_grd.py" > > This reverts commit 448e1b37. > > Reason for revert: Breaks translation, crbug.com/1141934 > > Original change's description: > > WebUI: Add support for producing/consuming grdp files in generate_grd.py > > > > This will be leveraged in follow up CLs, to auto-generate parts of > > webui_resources.grd. > > > > Bug: 1132403 > > Change-Id: I5bd5f8a411c2cbc1f023220a779d74be209e902c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489920 > > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > > Commit-Queue: dpapad <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820148} > > TBR=dpapad@chromium.org,rbpotter@chromium.org > > Change-Id: Ie0e71ef0d9a7dd8bbe5c0da452692b3e9c3f96db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1132403 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495518 > Reviewed-by: Krishna Govind <govind@chromium.org> > Commit-Queue: Krishna Govind <govind@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820344} TBR=dpapad@chromium.org,govind@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1132403 Change-Id: Ic2f5d9aecd4843113fae189351a6748a675e7ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495292 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#820431}
-
Yue Li authored
Deprecate and clean up Quick Answers simple UI. Bug: 1084284 Test: Run existing tests Change-Id: I03d93b36e2945a5b45ff50eafd8dc5907340b6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374505 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820430}
-
minch authored
Bug: 1136130 Change-Id: I973f58d57415fc83c9638fc36e639963633983af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469365 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#820429}
-
Ryan Sturm authored
When there is a match above the search prefetch match, it should not be prefetched in this arm. Bug: 1138649 Change-Id: I2854284607718659b73323c9994cf19af13ff272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493432 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#820428}
-
Kehuang Li authored
Even though they are enum class instead of enum, we'd give them default value in the struct, so as to avoid them be initialized to random value. Bug: NONE. Test: CQ. Change-Id: If0bd613b2eb6afa10bbc0bb8d5904c9e92c3ba00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490856 Auto-Submit: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#820427}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1b1d2a590744..9ab6e8b9eb0e 2020-10-23 dneto@google.com spirv-reader: treat function parameters as const declarations 2020-10-23 dneto@google.com ast::Variable dumping now indicates is_const 2020-10-23 dneto@google.com Don't leak the array-type memo table. 2020-10-23 dj2@everburning.com Set target defines PUBLIC. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I753e92ea28fd04ef2cca6540434c27b89d47d5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820426}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/24e636926107..8901df8ffe29 2020-10-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e6fda61ef0c4 to 9ab6e8b9eb0e (1 revision) 2020-10-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 79d271580e21 to e6fda61ef0c4 (1 revision) 2020-10-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1b1d2a590744 to 79d271580e21 (2 revisions) 2020-10-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 88d705dc85ff to 1b1d2a590744 (1 revision) 2020-10-23 yunchao.he@intel.com Minor changes in TextureValidationTests 2020-10-23 dj2@everburning.com CMake updates. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: If54c7fd77e51f0cee78fcf0c5fad91985af364fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820425}
-
Jeffrey Kardatzke authored
This reverts commit 8a1b573d. Reason for revert: Incorrect condition on return value from CreateContext in ApplyResolutionChange. Original change's description: > media/gpu/vaapiWrapper: Add WARN_UNUSED_RESULT to critical functions > > This adds WARN_UNUSED_RESULT to VaapiWrapper functions whose > result should have the critical impact enough to regard its > failure as video processing fatal. > VaapiVideoDecoder actually doesn't handle the failure of > VaapiWrapper::CreateContext. This CL also fixes it. > > Bug: b:171536540 > Test: Build media_unittest and vaapi_unittest > Change-Id: Iba6924849bfe8627fd328c3541c7a2c5cb0f0371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493742 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820164} TBR=hiroh@chromium.org,andrescj@chromium.org Change-Id: If3f3255475735f81786f64d686524947ec042a65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:171536540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495980Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#820424}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603454266-512aeaba1be85f32943004abfaab59393bece0f1.profdata to chrome-linux-master-1603475912-957f608884ccda47cbd83f12321a7d7559e0effc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5077ad0df7ac213b9d16e76d5f0ea01674dac6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820423}
-
Scott Violet authored
On kevin. BUG=1141944 TEST=test only change TBR=sidereal@google.com Change-Id: I3e05a2dfe7c5e6483b6de1155e405ef2c07527ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495880Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820422}
-
Regan Hsu authored
Notifies observers when an AttemptConnection() is called, a scan for tether network is requested, but no tether network was found. Bug: 1106938 Change-Id: I6645d5ae89f8774f992001e61242246a4c2101ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491993 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#820421}
-
Xing Liu authored
This CL obsoletes the following metric: Android.DownloadManager.ServiceStopped.DownloadNotification. This metric seems to be used during the foreground service migration for download notification. Now the migration is done, this is no longer used. Bug: 1130635 Change-Id: I96c65a960f0abad6629454c1e99abe3a36fc9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485873Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820420}
-
Prabir Pradhan authored
ClientControlledShellSurface::SetWidgetBounds() expects that the widget is already attached to a window. Therefore the widget bounds should not be updated until the widget is added to the root window. This means UpdateWidgetBounds() should not be called when the scale factor changes, since this can happen before the window attachment. BUG=crbug.com/1137927 TEST=exo_unittests Change-Id: I5f5b193b56ba708aa33df084673fcd1636010550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490924Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#820419}
-
Thomas Lukaszewicz authored
Bug: 1140658 Change-Id: I77f676d076050fb49376166b376ba501244a3166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495502Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#820418}
-
Fabrice de Gans-Riberi authored
This fixes an issue where visibilitychange events were not properly fired when the View was detached. A regression test has been added. Bug: 1141093, 1058247 Change-Id: I4c35ff59182d42083647a7c2cc28aca7533ad936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490234 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#820417}
-
Vikas Soni authored
Some video frames could time out and would not be able to produce/render the decoded data to an AImage. Hence no AHB would be available for those frames. If there is no AHB, then we should not treat it as error in empty mailbox. SharedImageStub: :CreateSharedImageWithAHB. Instead just return with the Bug: 1141004 Change-Id: I07e3e966bf070787a230ef3f7a09a5182907f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495600 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#820416}
-
Sebastien Lalancette authored
Adding myself. Change-Id: Icf1d531b025188f8a512bcb97e12c965801c8d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495054 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820415}
-
Shakti Sahu authored
This CL adds 1 - Support unknown features sent from server at the client 2 - UI improvement for video length Change-Id: I1666e23aae6a3772e2b8478d7a7d37a99e8f104d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494422Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820414}
-
Michael Crouse authored
Update flatbuffers to enable pending tflite addition to third_party. WIP of tflite integration: https://chromium-review.googlesource.com/c/chromium/src/+/2486389 https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/136d75fa6580..6df40a247173 $ git log 136d75fa6..6df40a247 --date=short --no-merges --format='%ad %ae %s' 2020-03-12 aardappel pre-tag version bump for 1.12 2020-03-12 mustii Removes the inner loop in the endtable check written tables (#5803) 2020-03-13 mockbutler Escape characters in jsonschema descriptions (#5644) 2020-03-13 31897320+vglavnyy Remove `noexcept` qualifier copy-ctor of `union` type (#5800) (#5802) 2020-03-13 31897320+vglavnyy Replace 'assert' by 'FLATBUFFERS_ASSERT' inside idl_parser.cpp (#5799) 2020-03-12 jakub Add non-nullable modifier to return type of functions never returning null (#5797) 2020-03-12 qqlddg [C++] Generate code for vector force_align attribute. (#5796) 2020-03-09 25088801+jean-airoldie rust: pub export the VectorIter type (#5736) 2020-03-09 aardappel Fix Python min alignment 2020-03-08 lee.mracek [Rust] Add gen-name-strings for Rust (#5757) 2020-03-05 aardappel Removed assert that wasn't backwards compatible. 2020-03-05 aardappel [C#] add ObjectAPI Serialization Utility (#5785) 2020-03-02 aardappel Fixed docs on how to obtain parser error. 2020-03-02 dbaileychess Added --filename-suffix and --filename-ext to flatc (#5778) 2020-02-27 derekbailey Fixed refractoring issue in reflection/generate_code.sh. Also, mv deletes the original file, so I don't need to clean it up manually in that case. (#5777) 2020-02-24 derekbailey Skip writing reflection_generated.h if not changed (#5776) 2020-02-24 mustii [Swift] Adds GRPC to Swift (#5758) 2020-02-21 paulovictor.pinheiro [Java][FlexBuffers] Abstract buffer access from ByteBuffer (#5743) 2020-02-21 mustii Adds cocoapods and a readme of how to get the package (#5771) 2020-02-13 om26er [snap] Fix versioning (#5727) 2020-02-12 joseph [Python] Fixed potential allignment issue (#5768) 2020-02-12 afonso.tfaria21 Fix memory leak on cpp object api (#5761) 2020-02-11 joseph [Python] Fixed issue #5499 (#5764) 2020-02-10 dpacbach [C++] Use strong enum type for vectors when scoped-enums is on. (#5750) 2020-02-11 51015092+mugisoba [C#] support Json Serialization (#5752) 2020-02-06 aardappel FlexBuffers: C++: scalar-only typed vectors were not aligned. 2020-01-30 rw Bump Rust port to 0.6.1 (#5747) 2020-01-31 51015092+mugisoba [C#] support Object API (#5710) 2020-01-27 mustii Adds min and max, comments, and all of swift's keywords + fix docs (#5737) 2020-01-27 dnfield Use VS 2017 and 2019 on CI, fix cast issue in dart_idl (#5740) 2020-01-25 mustii Creates a flatbuffers validation function + small fix (#5725) 2020-01-24 anders.sjoblom Added the code to embed the binary schema to the source (--bfbs-gen-embed). (#5701) 2020-01-24 paulovictor.pinheiro [Java][FlexBuffers] Deprecate typed vector strings due to design flaw (#5722) 2020-01-24 mustii [Go] Implements a SharedStrings function (#5733) 2020-01-25 vkill.net [Swift] Fix padding function overflow when bufSize is 0 (#5721) 2020-01-24 20694052+PhoebeHui Add vcpkg installation instructions (#5732) 2020-01-23 dnfield [Dart] Fix deprecated field support, inf/nan (#5724) 2020-01-20 max [typescript] Size-prefixed root accessors not taking into account size prefix (#5717) 2020-01-19 max [rust] Add use declarations to Rust-generated bindings for imported FB definitions (#5645) 2020-01-16 somombo [Go] Replace references to hardcoded ”Monster" etc with idiomatic go wherever possible (#5716) 2020-01-17 31897320+vglavnyy [C++] Fix for printing of enum in case output_enum_identifiers=1. (#5706) 2020-01-17 vkill.net [Swift] Support create long string (#5709) 2020-01-13 mustii Added create function for swift (#5707) 2020-01-09 mustii [Swift] Swift implementation
🎉 🎉 (#5603) 2020-01-09 aardappel Changed direct calls to strtod to use StringToNumber 2020-01-09 emkornfield Document JSON compatibility guarantees. (#5704) 2020-01-07 31897320+vglavnyy Add CMake 'generated_code' target to simplify resolution of build dependencies (#5697) 2020-01-06 beardsworth (Optionally) add an additional suffix namespace to generated fbs files. (#5698) 2020-01-07 dreifachstein [Java] Replace Table.UTF8_CHARSET with StandardCharsets.UTF_8 (#5696) 2020-01-02 rw Rust: Temporarily disable 2 endianness unit tests (#5695) 2020-01-02 dpacbach [C++17] Add Traits class for Tables and Factory function within it. (#5678) 2020-01-02 aardappel Removed code_generators.cpp from library targets 2019-12-31 max [rust] Make enum names public (#5690) 2019-12-30 beardsworth Correct inverted logic around include prefixes. (#5689) 2019-12-26 47436172+lu-wang-g Optimize Pack method using numpy (#5662) 2019-12-26 AustinSchuh [C++] Add Builder and Table typedefs (#5685) 2019-12-26 aardappel Minor doc updates: FlexBuffers C#, Discord, CppUsage. 2019-12-26 AustinSchuh Upgrade rules_go (#5684) 2019-12-26 AustinSchuh Fix --incompatible_load_cc_rules_from_bzl (#5683) 2019-12-26 AustinSchuh Add support for absl::string_view when available (#5682) 2019-12-26 AustinSchuh [Bazel] Add support for compatible_with and restricted_to (#5681) 2019-12-24 rw CI: New Docker tests for Python with numpy (#5677) 2019-12-23 aardappel Fixed struct initialization error on older versions of C# 2019-12-23 aardappel Fixed warnings in FlexBuffers.java 2019-12-23 aardappel Fixed out of date licenses on gRPC Python files. 2019-12-23 aardappel Removed test proto output. 2019-12-24 31897320+vglavnyy Add flatc '--cpp_std' switch (#5656) 2019-12-23 aardappel Fix for FlexBuffers FBT_VECTOR_STRING size bit-width. 2019-12-23 32997632+stefan301 Added Check to VerifyAlignment (#5675) 2019-12-23 michael.beardsworth Improve import handling for proto conversion (#5673) 2019-12-19 lxrite [Dart] Fix prepare space for writeListInt64 and writeListUint64 (#5654) 2019-12-17 mbrubeck Make Rust constants public (#5659) 2019-12-17 stein Add namespace qualification to union types (#5666) 2019-12-15 max Bugfix for Rust generation of union fields named with language keywords (#5592) 2019-12-14 i wrap multiple statements in do {} while(!IsConstTrue(true)) (#5655) 2019-12-09 gautham.bangalore [gRPC] Uncomment MessageBuilder (#5658) 2019-12-09 bjornharrtell Supress unsigned-integer-overflow for PaddingBytes (#5647) 2019-12-06 stein Add --force-empty-vectors option (#5653) 2019-12-05 aardappel Fixed enum min/max values not properly escaped. 2019-12-02 bttk Split Bazel targets into multiple packages (#5640) 2019-12-02 security-tps Remove a static_assert (#5643) 2019-12-02 47436172+lu-wang-g Flatbuffers Python Object API (#5616) 2019-12-03 chronoxor [Clang 10]: definition of implicit copy constructor for 'TableKeyComparatoris deprecated #5649 (#5650) 2019-12-02 nilsocket [docs]: add missing semicolon (#5648) 2019-11-26 3629062+tigrato [GO] Fix support for enums with underscores and Unions with imported members (#5600) 2019-11-26 31897320+vglavnyy Fix ambiguity of a type deduction in TEST_EQ macro if arguments have `enum class` type. (#5630) 2019-11-26 31897320+vglavnyy Simplify declarations of x-macro FLATBUFFERS_TD (#5638) 2019-11-26 i read vtable size through ReadScalar() (#5636) Created with: roll-dep src/third_party/flatbuffers/src Bug: 1141211 Change-Id: Ife27c510b6457dc8b1c95bfc0b56372a4de687c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490851 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:Dominic Battré <battre@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820413}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/37c5f8fa5ffc..867ef5f63787 $ git log 37c5f8fa5..867ef5f63 --date=short --no-merges --format='%ad %ae %s' 2020-10-22 renjietang Replace client side TLS 0-RTT flag with protocol flag FLAG_quic_disable_tls_zero_rtt. 2020-10-22 fayang Downgrade QUIC_BUG to DLOG(WARNING) when idle network deadline has passed during liveness testing. 2020-10-22 ianswett Delay the first Initial ACK sent by the server so it can be bundled with the server's first Initial packet. 2020-10-22 nharper Always enable session tickets in IETF QUIC 2020-10-22 fayang Shorten PTO when a HANDSHAKE or 1-RTT packet is received prior to the INITIAL. Client only. 2020-10-22 quiche-dev Rename SpdyHeaderBlock to Http2HeaderBlock. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I5fcc90640f95e2f59448feddd472fbd80637a266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493252 Commit-Queue: Bence Béky <bnc@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820412}
-
Josh Simmons authored
Fixing by removing the AssistContent dependency from tests. Only TranslateAssistContentTest.java has been modified from the original CL. AssistContent and onProvideAssistContent are only present in M+ SDKs, which was causing some bots to fail to enumerate tests due to a NoClassDefFoundError. Rather than calling onProvideAssistContent, call getTranslateDataForTab directly in tests. This is a reland of commit 243dbcb1, which was reverted by commit fa5127d2. The original CL description: > Include translate information in onProvideAssistContent. > > Assistant will use this information to determine whether or not to show a translate prompt when Assistant is opened over Chrome. > > This is controlled by the "TranslateAssistContent" Feature and is off by default. > > Design doc here: https://docs.google.com/document/d/1xZR09XTTGgY0F00_lFOEX7nUc0oqgSrCs5lZFU9INA0/edit Bug: 1110943, 1135658, 1136112 Change-Id: I9a769f6670fc7278bcdc08b995965241610034d9 Tbr: isherman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459106 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#820411}
-
Collin Baker authored
Previously these two IPH directly created a FeaturePromoBubbleView. One of them would potentially display at the same time as other IPH since it isn't registered with the IPH backend. This specific promo is important to show to users immediately, hence why it is treated differently. To support this use case a notion of a "critical promo" is added to FeaturePromoControllerViews. These promos will preempt any normal IPH promo. This is reserved for very important promos that must be shown immediately. With this support, both promos are invoked through FeaturePromoControllerViews. Bug: 1133016 Change-Id: Ifb3b2273c108bc342698faa61adb4b54d5f7072d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487874 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#820410}
-
Ryan Sturm authored
This is called when the AC matches change. The result will be used in the future to check top result, all results gone (i.e., we can cancel ongoing prefetches). Bug: 1138631 Change-Id: I7b6bad212888eac36756f41f2f534233df596b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493461 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#820409}
-
Sorin Jianu authored
Bug: 1141936 Change-Id: I9c1d9c61d55f3c862e791dc071011a215e68c945 Fixed: 1141936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495519Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820408}
-
Nina Satragno authored
Move the internal chromium large blob tests to web platform tests. The tests are designed to be able to run without testdriver support (i.e using a real authenticator) if support is not available. Bug: 1114875 Change-Id: Ie87053bd97b8b25b80f8613c366778ea287b909c Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490278 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#820407}
-
Patrick Monette authored
Bug: 1077217 Change-Id: I57457b30f2f4592c91d92799b7c2be2bc9f11c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490784 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#820406}
-
Peter Boström authored
Removes CalculatePreferredSize() use for a chunk of remaining dialogs that specify a fixed preferred width. Bug: 1128500 Change-Id: Ib8c072f758a1ae7e3532c5472181be8229e1f53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493666 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820405}
-
Jesse McKenna authored
This CL creates the auto-nav tool, which navigates between a given list of URLs a specified number of times. This can be used to automate local benchmarking for navigations. The tool expects to be run with `vpython`, and requires both `chrome` and `chromedriver` to be present in the provided out directory. Example usage: the following command navigates 5 times through 2 URLs (10 total navigations): `vpython tools/auto-nav.py out/Default 5 https://chromium.org https://crbug.com` Bug: 894253 Change-Id: I4492ef3eb30652a8bc1278ff584b7c2ecbe7f7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320136Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#820404}
-
danakj authored
Instead of binding a mojo reply callback into a lambda, we can post a Closure to RenderViewImpl::Destroy() and chain the mojo reply after it by using Then(). R=dtapuska@chromium.org Change-Id: I20189699e9699a56276f1cc1d8b576fa2f7d3341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495269 Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#820403}
-
Joel Hockey authored
DragDropController::Drop() can be reentrant since exo::DataDevice creates a nested RunLoop (crbug.com/1141745), and referencing |drag_data_| after it has been moved causes a crash. This is fixed by checking |!!drag_data_| in IsDragDropInProgress(). Bug: 1141745 Change-Id: Ide2b376d2b6d8dff3ba820c308e1cc1faffbe7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494189Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#820402}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6657788. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I19918b89ed4f89c4a21e7d1799405f53a092b66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494381Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820401}
-
Scott Violet authored
BUG=1128033 TEST=test only change TBR=ryansturm@chromium.org Change-Id: I271de37305ee5714f2a46e29f71b4ebbd5d9fb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495641 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820400}
-
Lei Zhang authored
The v8 binding target has generated sources like gen/third_party/blink/renderer/bindings/modules/v8/v8_media_recorder.cc that then includes third_party/blink/renderer/modules/mediarecorder headers. These headers use buildflags.h and all buildflags.h files are generated. Thus for v8_media_recorder.cc to build, it needs to depend on //third_party/blink/renderer/modules/mediarecorder:buildflags, but that dependency is missing. To fix this, add a dependency from //third_party/blink/renderer/core:prerequisites, which is responsible for generating all necessary C++ source code to //third_party/blink/renderer/modules/mediarecorder:buildflags. Bug: 1139543 Change-Id: If48a33cf4b5deb5bc66a8c21612eff924da774f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482030 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9d69cbeabf5d..3d2593512740 2020-10-23 mbonadei@webrtc.org Rename RoboCaller to CallbackList. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I16167a90241ce2f76c89f729e91a58915a4a49ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820398}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0ce7bcc8e296..5f4e51f38e3e 2020-10-23 yich@google.com cros_flash: add clear-tpm-owner to flash options 2020-10-23 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-22 ahassani@chromium.org cros_flash: Handle App ID mismatch between device and payload 2020-10-22 bhthompson@google.com Make bvt-installer suite asynchronous on release builders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ibeeb390c40e63e2607abb49309f50092522b1d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820397}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4280.20-1603104419-benchmark-88.0.4296.6-r1 to 88-4280.20-1603104419-benchmark-88.0.4300.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If8fbdaf9574d237e95cca676dfa7561dbe2df820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820396}
-
Robin Lewis authored
This allows us to link with protobuf protos and not have the component builds fail during tests. Refactored registry related flags and operations from mdm_utils to reg_utils. Modified fakes usage for cloud policies since in component builds they need to be installed differently. Bug: 1134817 Change-Id: Icfa40921d82e64d1a905273693cf569d108ff31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493725 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#820395}
-
Ana Salazar authored
Update the title for launcher's window when the launcher changes states. This will give Chomevox the information needed to read the title of the window when the user is navigating through the launcher and presses search + a, w. For a partially shown launcher (peeking), the title will be "Launcher, partial view". For the fullscreen launcher, the title will be "Launcher, all apps". If the searchbox or the assistant is displaying results, the title will be "Launcher" Bug: 1111165 Change-Id: I6715ea095b568f72466182ed20a33b7fffde8538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476618 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820394}
-
Joshua Pawlicki authored
Unfortunately, deferring uninstallation until after the RPC server starts up means the test must pay the 10s between task handling and server shutdown (& uninstall). This CL also adds some basic functionality to print the updater log in the case of a failed test, and speeds up Windows integration tests by moving the sleep to only happen for --uninstall launches. Bug: 1141659 Fixed: 1141659 Change-Id: Iba90261c402966fe1ddb814d01b5521c94da0a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493043 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820393}
-