GitLab

Revert of Allow new zoom bubble to override current one. (patchset #6 id:100001 of https://codereview.chromium.org/849693006/)

Reason for revert:
The changes in this CL are causing a crash: crbug.com/453564

Original issue's description:
> Allow new zoom bubble to override current one.
>
> At present, if a user changes zoom on OSX while the zoom bubble is
> already being shown, the new zoom bubble (with the most up to date
> information) is not shown. This CL changes this behaviour by allowing
> a new zoom bubble to be created, and replace the existing one.
>
> Example: load a PDF and repeatedly click the zoom +/- controls in the
> lower-right corner of the viewer.
>
> BUG=444995
>
> Committed: https://crrev.com/a95ea7031e472fd5d0968955989c963381dfaf5f
> Cr-Commit-Position: refs/heads/master@{#313564}

TBR=rohitrao@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444995

Review URL: https://codereview.chromium.org/867183006

Cr-Commit-Position: refs/heads/master@{#313785}

Changes:

a87de9b Define WIN32_LEAN_AND_MEAN in the build system, not in the code.
4a0f0c4 Change CMakeLists.txt to two-space indent.
2e38008 Define _HAS_EXCEPTIONS=0 to avoid MSVC C4530 warning.
bcc4fa8 Add unit-tests for PBKDF2.
507c1ee Honor the standard BUILD_SHARED_LIBS cmake variable.
f4600ad Add missing OPENSSL_EXPORTs.
f058dae Revert "Add a test for CONF_parse_list."
dc94b54 Clean up use of Windows Platform SDK headers.
33970e6 Enable bssl client/s_client and server/s_server on Windows.
9a9a193 Build with -fvisibility=hidden.
afdaeee Enable bssl (md5sum, sha256sum, etc.) on Windows.
2fe7f2d Initialize HMAC keys to zero.
1d75c8b Improve compatibility with CMake 3.0 and later
ed30c0d Improve the documentation in BUILDING
b7f3144 Add a style guide.
69ad27f Run x86 perlasm on UNIX with -fPIC.
36eb7d5 Fix buffer size in aead_test.c.
53cbd6c Fix unused variable warning in OPENSSL_NO_ASM build.
bed8f73 Fix build after mistake addressing comments in cca4d599.
cca4d59 Add digest sum handling to the tool.
cd5c892 Add a test for CONF_parse_list.
fd4eb60 Remove duplication of common DH parameters.
b4a494c Reformat SSL/TLS headers.

For more details see: https://boringssl.googlesource.com/boringssl/+log/347f025..a87de9b

Review URL: https://codereview.chromium.org/890443002

Cr-Commit-Position: refs/heads/master@{#313784}

Main thread can scroll with non-integral scroll offset, but Blink currently
only handles integral part of the scroll offset. For example, if main thread
scrolls by 10.5, Blink tells CC that the scroll offset is 10 (currently truncated
inside Blink) and Blink also sets fixed-position layer's position at 10.

This CL makes the non-integral scroll offset works correctly in this case:
1. Blink can tell CC the non-integral scroll offset 10.5 (truncation inside Blink
will be removed after this CL).
2. Blink sets fixed-position layer at 10.
3. CC tracks the fractional part of the scroll offset 0.5 and applied it when
computing scroll compensation for fixed-position layer during drawing.

BUG=414283

Review URL: https://codereview.chromium.org/877173002

Cr-Commit-Position: refs/heads/master@{#313783}

Windows defines GetMessage as GetMessageW.
This makes linking fail if p224_spake included after windows headers.

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/889663003

Cr-Commit-Position: refs/heads/master@{#313782}

This...
- Wires up ExtensionView. Can apply src for navigation via inline and js call.
- Adds permission for manifests.
- Add browser tests for navigation and adding ExtensionViews to DOM.

Some code is duplicated from existing GuestViews (e.g. *ViewAttribute and some GuestViewBase implementations). Based on how GuestView code will be refactored, some of this can be consolidated.

This...
- Does not run in a detached state. (Refers to CR 845363004)
- Will have more functionality and restrictions implemented in the future.

Review URL: https://codereview.chromium.org/873933002

Cr-Commit-Position: refs/heads/master@{#313781}

Revert of Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #1 id:1 of https://codereview.chromium.org/883373002/)

Reason for revert:
Wrong revert, ipc fuzzer broke because of something else.

Original issue's description:
> Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #3 id:40001 of https://codereview.chromium.org/725733002/)
>
> Reason for revert:
> Broke ipc fuzzer
>
> Original issue's description:
> > IPC::ChannelMojo: Make IPC handling robust against bad messages.
> >
> > This change replaces some DCHECK()s with real error handling.
> > They happen when it receives broken messages.
> >
> > BUG=428800
> > R=viettrungluu@chromium.org
> >
> > Committed: https://crrev.com/185ffdf58f85e47db9666d2ad9b80ff9bd7fa54b
> > Cr-Commit-Position: refs/heads/master@{#304102}
>
> TBR=viettrungluu@chromium.org,morrita@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=428800
>
> Committed: https://crrev.com/726621f93d2802dfc2c90732c7133145c9854e38
> Cr-Commit-Position: refs/heads/master@{#313778}

TBR=viettrungluu@chromium.org,morrita@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428800

Review URL: https://codereview.chromium.org/892503002

Cr-Commit-Position: refs/heads/master@{#313780}

This is a prerequisite change for supporting variable video frame sizes
in Cast.  This allows a follow-up change to remove the width/height
properties from VideoSenderConfig.  Instead, the width/height is passed
to the ctor in a separate gfx::Size argument.

BUG=451277

Review URL: https://codereview.chromium.org/883013003

Cr-Commit-Position: refs/heads/master@{#313779}

Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #3 id:40001 of https://codereview.chromium.org/725733002/)

Reason for revert:
Broke ipc fuzzer

Original issue's description:
> IPC::ChannelMojo: Make IPC handling robust against bad messages.
>
> This change replaces some DCHECK()s with real error handling.
> They happen when it receives broken messages.
>
> BUG=428800
> R=viettrungluu@chromium.org
>
> Committed: https://crrev.com/185ffdf58f85e47db9666d2ad9b80ff9bd7fa54b
> Cr-Commit-Position: refs/heads/master@{#304102}

TBR=viettrungluu@chromium.org,morrita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428800

Review URL: https://codereview.chromium.org/883373002

Cr-Commit-Position: refs/heads/master@{#313778}

BUG=450498
TEST=none
R=tengs@chromium.org
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/868133005

Cr-Commit-Position: refs/heads/master@{#313777}

Now that the text filtering feature is mature, we can remove the flag
that allows disabling it safely.

BUG=452107
TEST=manual

Review URL: https://codereview.chromium.org/878173002

Cr-Commit-Position: refs/heads/master@{#313776}

This is a missing part of https://codereview.chromium.org/873133002/ .

BUG=426751

Review URL: https://codereview.chromium.org/883183002

Cr-Commit-Position: refs/heads/master@{#313775}

Replaced occurrences of

[HyperlinkTextView setMessageAndLink:withLink:atOffset:font:
                                               messageColor:linkColor:]

with

[HyperlinkTextView setMessage:withFont:messageColor:] +
[HyperlinkTextView addLinkRange:withName:linkColor]

BUG=253755

TEST=for bookmark_sync_promo_controller.mm: Launch the Chrome browser. Click the
star icon at the right end of the omni box. In the popover window that appears,
confirm that the text at the bottom reads, “Sign in to get your bookmarks
everywhere.” and that the text “Sign in” is a clickable link that takes you to
the Chrome sign-in page.

for extension_installed_bubble_controller.mm: Launch the Chrome browser and type
chrome://extensions in the omnibox. In the page that appears click the Get more
extensions link at the bottom. Locate the Tag Assistant by Google extension and
click it. Click the “+ FREE” button in the upper-right corner of the overlay
window that appears. Click “Add” in the overlay window that appears to confirm
your action. In the bubble window that appears that says Tag Assistant has been
added to Chrome, confirm that the text at the bottom of the bubble window says,
“Sign in to Chrome to get this extension, your history, and other Chrome
settings on all your devices.”, and that “Sign in to Chrome” is a clickable link
that takes you to the Chrome sign-in page.

for exclusive_access_bubble_window_controller.mm: Launch the Chrome browser and
go to http://davidwalsh.name/demo/fullscreen.php . Click the “Launch Fullscreen”
button that appears halfway down the page. If a bubble window appears stating,
“davidwalsh.name is now full screen” click Allow. Confirm that in the next
bubble window that appears, the text at the right says, “Exit full screen (Esc)”
and that the words “Exit full screen” are a clickable link that exits full
screen mode when clicked.

Review URL: https://codereview.chromium.org/865373002

Cr-Commit-Position: refs/heads/master@{#313774}

In the rename from ScreenOrientationDelegte to ScreenOrientationController, apparently one of the files was not properly deleted. It is no longer referenced anywhere, so I'm deleting it as intended.

BUG=396760

Review URL: https://codereview.chromium.org/889603003

Cr-Commit-Position: refs/heads/master@{#313773}

availablechange event. Blink CL: https://codereview.chromium.org/832263007

BUG=412331

Review URL: https://codereview.chromium.org/839773002

Cr-Commit-Position: refs/heads/master@{#313772}

BUG=429053
TEST=gpu_unittests
R=vmiura@chromium.org

Review URL: https://codereview.chromium.org/872713004

Cr-Commit-Position: refs/heads/master@{#313771}

BUG=453195
R=thakis@chromium.org
CC=fdegans@chromium.org

Review URL: https://codereview.chromium.org/884923002

Cr-Commit-Position: refs/heads/master@{#313770}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7020f55..05dd7de

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/890713002

Cr-Commit-Position: refs/heads/master@{#313769}

gfx::Images cache different representations (such as NSImages), whereas
gfx::ImageSkias (as a representation themselves) do not. Prefer to use
gfx::Image in most icon code, so that these representations are cached.

BUG=452971

Review URL: https://codereview.chromium.org/882243002

Cr-Commit-Position: refs/heads/master@{#313768}

Reverts revert of the last roll, with included fix.

https://chromium.googlesource.com/angle/angle/+log/2a30ccefd..bc393df9cd

Previous roll range:
https://chromium.googlesource.com/angle/angle/+log/9e0478f62f..2a30ccefd0

BUG=450257,453037

Review URL: https://codereview.chromium.org/873353005

Cr-Commit-Position: refs/heads/master@{#313767}

Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005.

BUG=329552

Committed: https://crrev.com/36b7fc7f8b05ea627873e58a162c1c26784e472d
Cr-Commit-Position: refs/heads/master@{#298779}

Committed: https://crrev.com/b821b71ff0166e250ae4b30b56c1b7b6d3bd5db6
Cr-Commit-Position: refs/heads/master@{#306954}

Review URL: https://codereview.chromium.org/638653003

Cr-Commit-Position: refs/heads/master@{#313766}

Revert of Remove the use of page id from building the commit params. (patchset #4 id:60001 of https://codereview.chromium.org/839413004/)

Reason for revert:
NavigationControllerBrowserTest.ManualAndAutoSubframeNavigationTransitions fails on the --site-per-process FYI bot

Original issue's description:
> Remove the use of page id from building the commit params.
>
> BUG=369661
> TEST=tests stay green
>
> Committed: https://crrev.com/66f3ec8e5ee6c3b528b5a6054cdca85ac0b29699
> Reverted: https://crrev.com/96545af0f94ec1ac19a57c86806c95834de5d33c
>
> Committed: https://crrev.com/5fe8124cafd9ea996b99cfc88366315aad0c63b2
> Cr-Commit-Position: refs/heads/master@{#313589}

TBR=creis@chromium.org,japhet@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661

Review URL: https://codereview.chromium.org/874743003

Cr-Commit-Position: refs/heads/master@{#313765}

This change decreases our APK size by 67,065 bytes.

R=newt@chromium.org
TBR=tedchoc@chromium.org
BUG=407781

Review URL: https://codereview.chromium.org/889683002

Cr-Commit-Position: refs/heads/master@{#313764}

This fixes the linux_chromium_chromeos_ozone_rel_ng bot:

../../content/common/gpu/media/rendering_helper.cc:105:31: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
  virtual ~StubOzoneDelegate() {}
                              ^
                               override

TBR=posciak (red build)
NOTRY=true
BUG=none
TEST=linux_chromium_chromeos_ozone_rel_ng trybot

Review URL: https://codereview.chromium.org/875573004

Cr-Commit-Position: refs/heads/master@{#313763}

BUG=449748

Review URL: https://codereview.chromium.org/869073004

Cr-Commit-Position: refs/heads/master@{#313762}

When rendering in Ganesh with MSAA enabled, request that skia flush each
canvas after drawing a tile. This will cause the MSAA render targets
to be resolved to the shared texture which CC subsequently draws.

BUG=

Review URL: https://codereview.chromium.org/885883002

Cr-Commit-Position: refs/heads/master@{#313761}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5d8388b..5444393

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/880983004

Cr-Commit-Position: refs/heads/master@{#313760}

This moves the "trusted plugin" code so that all the NaCl
renderer-side code is in the same place, under
components/nacl/renderer/.  I've used the "renderer/plugin/" subdir so
that this legacy code is distinguished from the newer code that's
directly under "renderer/".

This will make further incremental cleanups easier: It will enable
closer integration between renderer/* and renderer/plugin/*.  Rather
than indirecting through PPB_NaCl_Private/PPP_PexeStreamHandler, it
would be reasonable for the two sides to share pointers to C++
objects.  Doing that will be more acceptable when the two sides live
in the same directory.

 * chrome/chrome_tests.gypi: Declaring a runtime dependency isn't
   necessary since the trusted plugin isn't a separate DSO/DLL these
   days.

 * .gitignore: Remove reference to ppGoogleNaClPluginChrome.xml, which
   no longer exists.

 * module_ppapi.h: Added an #include guard.

BUG=239656
TEST=trybots

Review URL: https://codereview.chromium.org/876483002

Cr-Commit-Position: refs/heads/master@{#313759}

BUG=453313
TBR=huangs@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/884013004

Cr-Commit-Position: refs/heads/master@{#313758}

r2029: mac: Followup to ZERO_AR_DATE, touch the -o archive, rather than expecting only one

TBR=thakis@chromium.org
BUG=342974,451499

Review URL: https://codereview.chromium.org/887753002

Cr-Commit-Position: refs/heads/master@{#313757}

Simple test that uploads and draws a texture on an offscreen surface.
The upload/draw code is run multiple times, timings are collected and the
average elapsed milliseconds are printed out using the perf_test framework.

The test target has not been added to the perf tests the are automatically run yet
and has to be manually run.

BUG=423481

Review URL: https://codereview.chromium.org/871093002

Cr-Commit-Position: refs/heads/master@{#313756}

BUG=453485
TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/871193007

Cr-Commit-Position: refs/heads/master@{#313755}

* In order to sort out dependencies between initialization of components, I am doing work only when I have a valid GCM connection going (this means all the infrastructure is up and running).
* I am also making sure that time to next token reporting is always between 0 and 12 hours.

BUG=453018

Review URL: https://codereview.chromium.org/885753002

Cr-Commit-Position: refs/heads/master@{#313754}

BUG=440579
TBR=thakis

Review URL: https://codereview.chromium.org/867483008

Cr-Commit-Position: refs/heads/master@{#313753}

Enhance the audio player tests to cover multiple loops over the data and
odd sizes of data.

R=ckehoe@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/886593005

Cr-Commit-Position: refs/heads/master@{#313752}

We are removing SkProxyCanvas, which is a subset of SkNWayCanvas.

BUG=skia:3279

Review URL: https://codereview.chromium.org/876933005

Cr-Commit-Position: refs/heads/master@{#313751}

BUG=

Review URL: https://codereview.chromium.org/887453002

Cr-Commit-Position: refs/heads/master@{#313750}

This CL also includes a small refactoring of the desktop- vs. app-remoting split.

BUG=432361

Review URL: https://codereview.chromium.org/875583002

Cr-Commit-Position: refs/heads/master@{#313749}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e9d57a2..7020f55

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/892483002

Cr-Commit-Position: refs/heads/master@{#313748}

Review URL: https://codereview.chromium.org/850853002

Cr-Commit-Position: refs/heads/master@{#313747}

On Android, instead of calling StartRepeatedVariationsSeedFetch()
in chrome_browser_main.cc, this changes the code to instead have
that be called by the first call to OnAppEnterForeground().

This will allow (in a future change) to have the caller of
OnAppEnterForeground() to first set the restrict mode param,
before fetching gets initialized. (Otherwise, fetching was
being initialized too early before the param could be set.)

BUG=452605

Review URL: https://codereview.chromium.org/880263005

Cr-Commit-Position: refs/heads/master@{#313746}