- 23 Dec, 2019 40 commits
-
-
Gabriel Charette authored
TBR=alsan@google.com Bug: 1036054 Change-Id: Ie24ccf69dcece090f2a523d2ac85a80a7d8ba7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980754Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727228}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. TBR=asanka@chromium.org Bug: 1035074 Change-Id: Ic99cc6e64039396aa96c3144b8fe9667cac0084c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980876Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727227}
-
Tom Anderson authored
This is a followup to [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1974901 TBR=sky Change-Id: I442ffe121378607bdc5e1b16c081b8d66b138955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980900Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727226}
-
Jeroen Dhollander authored
This is a temporary fix. The real fix will be to move away from the Content Service and back to |views::WebView|. This is tracked in b/146351046. - Embedded UI: - TAB and shift-TAB works for settings. - TAB and shift-TAB works for webview based Assistant response (to the query |weather|). - Open Settings, click on other window, click back on settings, verify TAB and shift-TAB still work. - Standalone UI: - TAB and shift-TAB works for settings. - TAB and shift-TAB works for webview based Assistant response (to the query |weather|). Bug: 145213680 Change-Id: If0f39d4911409f177fb1f93525205ad7392bdd35 Tests: Manually tested that: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979633Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#727225}
-
Maksim Sisov authored
For Metacity, we have a workaround which fixes unfullscreening issue. That is, we restore and maximize the window if the previous state before the fullscreen state was maximized. By that, we force metacity to leave the fullscreen. If we don't do it, it may end up in a fullscreen again. However, during our previous refactorings, a regression was introduced. Even though, we followed the same approach, the X11Window::Maximize method didn't directly call XWindow::SetFullScreen, but rather called X11Window::ToggleFullscreen, which resulted in recursive calls to the X11Window::ToggleFullscreen and crashes on X11 level. Also, this CL forces to use previous state when fullscreen is left as long as X server might not send a configure event and change our state. Thus, if it was maximized, set it to maximized. Otherwise, set it to normal as opposed to Unknown state set before. Also, we forgot to move the code that deals with restored bounds when a state change was triggered by X server. This CL restores that behaviour. PS: In a follow-up CL, I will make all state changes to be synchronous as we are doing now in Wayland. TBR=sky Bug: 1034791 Change-Id: I0725625148acf6602e7818823cb96b1d82ef9b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978637Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727224}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=tiborg@chromium.org Bug: 1035074 Change-Id: Icd179380bcba508e87cad272b6d5aee1f72f56b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980874Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727223}
-
Vikas Soni authored
Use the gles2 apis which are meant to be used with shared image mailboxes. We were using legacy mailbox gles2 apis till now here in VideoResourceUpdater::CopyHardwarePlane. It was fine since this code was only used by android video path which always creates shared image mailboxes and registers it with a legacy mailbox. Hence it works with both shared image and legacy gles2 apis. Updating this code in order to convert everything to shared images eventually and get rid of legacy mailbox system. Bug: 900973 Change-Id: I3b9c97f938cd4d15740cd1b6007eaae8f4ef2c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978907 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727222}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/08c025c5..05d3b827 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I674dfa3452b0d2b625700e342de45d65f57b93fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727221}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=alexclarke@chromium.org Bug: 1035074 Change-Id: I791a807262f2e03186776a7fbcfa1f3aeba3f93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980903Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727220}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. TBR=tedchoc@chromium.org Bug: 1035074 Change-Id: Idce57785494009c4d740f82eaa43746c8a8285fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980955Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727219}
-
Sammie Quon authored
An assortment of cleanup i noticed while working on other stuff. Test: old tests, no functional change Bug: none Change-Id: I191b53fc7646a64644f510afdb247519ff150527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980871Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#727218}
-
Nelson Billing authored
- Bring in changes that make dump_syms work for 32bit DWARF4. This, in turn, will enable Chrome Android build to use DWARF Fission to get around the 32bit linker binary size limitation. Change-Id: Ib2f0c45d916f6d173aed1422cb4ad07b3185d2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978854Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nelson Billing <nbilling@google.com> Cr-Commit-Position: refs/heads/master@{#727217}
-
Renato Silva authored
A11Y - The dictation button will now properly switch colors based on the session state in order to be visible during OOBE. Tested locally Fixed: 889446 Change-Id: I86b3ec266e123fe2808395ffb84053fd43c6ff57 Bug: 889446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974096 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#727216}
-
Clark DuVall authored
We should have enough data from this already, so no need to keep it around. Bug: 934317, 1033917 Change-Id: Ib3102b7382e47a5e2f4640090c8bfef69d27d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976823 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#727215}
-
Gabriel Charette authored
Rebased on crrev.com/727196 to add the non virtual/threaded variant of the same test. TBR=petermarshall@chromium.org Bug: 1036626 Change-Id: I03e7336020a12ed2e7241cd4a1104528278cc80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980875Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727214}
-
sczs authored
- Makes history_ui_egtest comply with eg2. Uses - Adds HistoryEntry to ChromeMatchers. - Creates ios/chrome/browser/ui/history:eg2_tests and moves history_ui_egtest to it. - Adds ios/chrome/browser/ui/history:eg2_tests to test/earl_grey BUILD.gn Change-Id: I315da4b84a99d27d281f0378771b3f7b3fd3f660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980553Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727213}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above gn files, and automatically format. This CL was uploaded by git cl split. R=joedow@chromium.org Bug: 1035074 Change-Id: I4fd20b72da6c1a8238d2b05ef237bd127fd09de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980953 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#727212}
-
Eric Willigers authored
When a desktop PWA is installed and the user requests 'Open in a window', we clear navigation history that occurred before the user most recently entered the app's scope. When the user chooses "Open in <app>" from the browser's three dot menu, we similarly prune navigation history. If the current page is the user's first page in the app, the Back button will be initially disabled. The user can still access history using chrome://history/ BookmarkAppRegistrar::IsInstalled now returns false (instead of crashing) when called with a Chrome packaged app id. Bug: 1027393 Change-Id: I4855b952801f6279607fcb52e6ed56e12725e109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978317 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727211}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=spang@chromium.org Bug: 1035074 Change-Id: I87fc8f5e0c888e350c18b3a17da8cd00f705bea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980950Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727210}
-
Haiyang Pan authored
Requires crrev.com/c/1979399 to land first Bug: 986990 Change-Id: I2e83a442b85a9c9ca494804d074b9cc51f01d669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979590Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#727209}
-
Abhijeet Singh authored
Updating the InternalConfig::visibility field to a string instead of an integer to make it compatible with the libassistant side changes. Bug: b:143715504 Change-Id: I775a4b067ae0944733bd87ecc8869641006866cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970807Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#727208}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/e223d0ec67ad..b93b64e6bec7 $ git log e223d0ec6..b93b64e6b --date=short --no-merges --format='%ad %ae %s' 2019-12-19 nharper Refactor GfeQuicCryptoServerStream so parent class owns handshaker 2019-12-19 dschinazi Add presubmit to disallow absl in /third_party/quic/ 2019-12-19 quiche-dev Created and integrated QuicIntervalDeque class for index management. Improves code readability. 2019-12-19 bnc Remove QuicHeaderList::max_header_list_size(). 2019-12-18 wub gfe-relnote: For QUIC BBRv2 flows, cut inflight_hi gradually when there is high loss from PROBE_UP. Protected by --gfe2_reloadable_flag_quic_bbr2_cut_inflight_hi_gradually. 2019-12-18 quiche-dev gfe-relnote: Migrate //gfe/test_tools/request_tools/clients/... from char* and size_t signatures to absl::string_view, a better and more modern representation of a view into a string buffer; changes the minimum number of tests to get successful compilation and runs 2019-12-18 dschinazi Make QuicSession own its perspective Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia367ccae1f60b09686b9f2945b7b6e89d3abe793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978902 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#727207}
-
Jonathan Freed authored
Change-Id: Idd5ccd907c011112e1abe9255ad6a7e9ec6ad54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979141 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#727206}
-
Darwin Huang authored
Improves the asan.md doc formatting, mostly as per review comments in https://crrev.com/c/1883615/. Change-Id: Ib4e51353b306d71f231521bd2f07944f13207c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972418 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#727205}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=dpranke@chromium.org Bug: 1035074 Change-Id: I1ac9d292b68955a38757cf90f57631ff260b388a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980893Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727204}
-
Tom Anderson authored
libinput is not available on Trusty. BUG=1034916 R=friedman Change-Id: Ic408cb7b2a1c28e6d4fec10e1c4b4a50c9c8b414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980904 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Elliott Friedman <friedman@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Elliott Friedman <friedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#727203}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. TBR=wnwen@chromium.org Bug: 1035074 Change-Id: I8a403ba2b72e76dd956072f4a5db80e4ea0f1e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980873Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727202}
-
Gaofeng Huang authored
This is the only target needed by l10n/ Bug: internal b/146428609 Test: on device Change-Id: I6b70f08fc30ecce71c342f27fca061e423e174ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979514Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727201}
-
Mike Dougherty authored
Breakpad limits the size of values attached to crash reports to 255 bytes so reduce the number of redundant data in the breadcrumb timestamps in order to upload more overall events. Bug: 1003922 Change-Id: I38a9099b90ed7364088f61da1442ecd1e44eb028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979450Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727200}
-
Gabriel Charette authored
Flakily crashes. Can't revert suspect. See bug for details. TBR=caseq@chromium.org Bug: 1036627 Change-Id: I8d0febf988d82e37d71b888b6d2c689b08a0271f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980872Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#727199}
-
Samuel Huang authored
This CL fixes resource_ids entry sample_system_web_app_resources.grd, which was added in: https://chromium-review.googlesource.com/c/chromium/src/+/1956978 The new GRD (B) displaced an entry (C) that has META "join" for mutually exclusive entries (A1 and A2). This causes the following sub-graph change: A1 <-- C ===> A1 <-------- C A2 <---+ A2 <-- B <---+ This caused A1 to collide with B when GRIT update_resource_ids runs. The problem was mitigated in https://chromium-review.googlesource.com/c/chromium/src/+/1980336 by swapping A1 and A2. However, the proper fix (implemented by this CL) is to move META "join" from C to B, so the sub-graph becomes: A1 <-- B <--- C A2 <---+ This CL also reserves more ID space for media_app_bundle_resources.grd (A1) to accommodate potential growth. Change-Id: I891b643192ef49699397b8376e4fec03e66f2f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980802Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727198}
-
Mia Glaese authored
Before: Bug resulted in tabswitcher toolbar sometimes hidden, when tapping <more tabs> Now: Toolbar is always visible in TABSWITCHER state. Added tests for SinglePane (other states already covered). Bug: 1036754 Change-Id: I1043efb703a1c6dbdc5e8c6a77bf935412f1f170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980809Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#727197}
-
Fabrice de Gans-Riberi authored
TBR=fdegans@chromium.org Bug: 1036626 Change-Id: If75d049da7c99f3994b9fef50a589fdd8ef48617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980890Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea94670809ad..09ff24ebc7be Created with: gclient setdep -r src-internal@09ff24ebc7be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: Ib1f64ece75d43c6ba4f3b46ecaca5e914edfae63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727195}
-
Min Qin authored
This reverts commit 6c4ec3c0. Reason for revert: The LOG has provided information of the crash Original change's description: > Split some download CHECK message into a LOG message > > CHECK messages are discarded for release build. > Using a separate LOG message should give us the error message > in logcat > > BUG=1029746 > > Change-Id: Ia333ee1261ca33c0d9538a5f132af92ae394e347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972233 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725688} TBR=qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029746 Change-Id: I158bc5b1ed2b337d8bd43d13379c2868702e5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980803Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727194}
-
minch authored
Remove the |clipping_window| that created as the parent of the back gesture affordance while dragging from splitview divider. Since it belongs to the container, which will not be deleted together with the back gesture affordance. This might make the clipping window above the splitview divider after SplitViewDivider::SetAlwaysOnTop be called to stack splitview divider at the bottom of the AlwaysOnTopContainer. Then the event will not be dispatched correctly to the splitview divider for resizing. - Use Layer::SetClipRect(*) to clip the affordance instead. - Remove useless parameter of CanStartGoingBack(*). - Reset |dragged_from_splitview_divider_| correctly. Bug: 1035126 Change-Id: I56af8fcb860f1aa842fe92883f0c122dcc7cedc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977967 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#727193}
-
Vlad Tsyrklevich authored
In https://crrev.com/c/1841187 I updated GWP-ASan such that support on Android is only compiled in when frame pointers are enabled (e.g. on AArch64); however, I forgot to update the stack trace collection method to use frame pointers in that case. Do so here. Bug: 973167 Change-Id: I75399d81fa1a695c3ef2c4e135316914a8c945db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979099 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#727192}
-
Fabrice de Gans-Riberi authored
The test is flaky on all platforms, not just Linux and Mac. TBR=fdegans@chromium.org Bug: 931657 Change-Id: Iffe8b086401cedbae7b39c8eb089c93a1e5a1da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980807Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727191}
-
Fabrice de Gans-Riberi authored
These tests were re-enabled but still flakily time out. TBR=antrim@chromium.org,fdegans@chromium.org Bug: 997685 Change-Id: Ia9400275968449b689f96f3cdf28c4567df128fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980889Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727190}
-
Fabrice de Gans-Riberi authored
The test is flaky on all platforms. TBR=rajendrant@chromium.org Bug: 1035057 Change-Id: I9c4735750b9724fbcdcbfebe0895ce8f58a62192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980804Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727189}
-