- 15 Oct, 2019 40 commits
-
-
Christian Dullweber authored
The UI would get updated twice when cookie blocking was enabled for a specific site. Avoid this unnecessary step by not stepping through state updates separately. Bug: 967668 Change-Id: I9d6c836031dc9ef7adf1a4888b6e8c8483c22ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862693 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55f9cba6e2e7..f22c57ddcc8c git log 55f9cba6e2e7..f22c57ddcc8c --date=short --no-merges --format='%ad %ae %s' 2019-10-15 robertphillips@google.com Centralize GrSamplerState key creation Created with: gclient setdep -r src/third_party/skia@f22c57ddcc8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I558f9193e97366ee59afb933e70f1804db7bd55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705950}
-
Marc Treib authored
The "best_matches" are now passed around in a vector instead of a map. This CL updates the last two places that accepted a map: - VotesUploader - PasswordFormMetricsRecorder Bug: 1011399 Change-Id: I42fa29549cfc02398f69b802a3d18cd1eb75e89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862448 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705949}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a3fb0505..9b58c027 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8d791cbbe6f3a597caedc240cd5c7287a7fb019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862577Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705948}
-
Virender Singh authored
This CL does code refactoring to make the intent of PdfAccessibilityTree .zoom variable clear. It stores the product of pdf zoom and system dpi. This change renames it to zoom_device_scale_factor. This change also refactors the zoom variable name in PP_PrivateAccessibilityViewportInfo to zoom_device_scale_factor. Corresponding change is also made in OutOfProcessInstance to reflect the variable name change. Bug: 1007169 Change-Id: I0a9c22f386fb4859afc80d9f281f41a15935bb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823337Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705947}
-
Maksim Sisov authored
At first, I wanted to remove these static methods, but then decided to keep them and remove later when we no longer need them. Bug: 990756 Change-Id: If6132986e25bb1c8712acdbc90ce29093616bff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860341Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#705946}
-
Thomas Tangl authored
Bug: 995720 Change-Id: I96acb6008bd074d9e68ddab1b8b4fc205ce1ab6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862689 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705945}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e84f1d15029a..8d061254d2f4 git log e84f1d15029a..8d061254d2f4 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 fmayer@google.com Merge "Add heap_graph table test." Created with: gclient setdep -r src/third_party/perfetto@8d061254d2f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icbc1f66508803e283df435e2165e4ce3a912e63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862974Reviewed-by:
-
Mikel Astiz authored
This works as a short-term solution to power certain sharing features that rely on a high-entropy per-user authentication key being available to all sync-ing clients, including transport-only clients. Bug: 1010968 Change-Id: I51613f0b3e5d91a82f688af13b61c4804057a57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841451Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705943}
-
Richard Knoll authored
Mostly mechanical change to pipe the origin through to the dialog view. The dialog shows the origin in a label with rounded corners, see screenshot: https://imgur.com/LPAWxy2 Changes the BubbleFrameView to size |header_view_| to the ContentBounds instead of centering it. Bug: 1010920,1005596 Change-Id: I72f2e163552165b39ef00aaa1d1ea7cce8ce4895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849382 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705942}
-
David Bienvenu authored
This will be used to find hard links to or copies of web_app_shim.exe for a particular installed PWA, so they can be updated or deleted when the PWA is uninstalled. Bug: 960245 Change-Id: I62d6d6e263d0fdcdb2c5d4f89435cb657dd73a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849417 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#705941}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52e19cbdc570..cc3b617bc9f8 git log 52e19cbdc570..cc3b617bc9f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 perezju@chromium.org [Telemetry] Move screenshot-on-failure tests to shared_page_state tests Created with: gclient setdep -r src/third_party/catapult@cc3b617bc9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:928275 Change-Id: I89b3b72ca31dc23ab294e751e1dc9748764cf156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862976Reviewed-by:
-
Raul Tambre authored
* map() returns an iterable instead of a list in Python 3. Convert it explicitly to a list. * xrange() is replaced in Python 3 by the functionally equivalent range(). * Simplified checking whether an object is a string and introduced string_type that's set according to Python version. Still works with Python 2. Fixed errors: Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1648, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 361, in main policy_atomic_groups = [ File "../../components/policy/tools/generate_policy_source.py", line 362, in <listcomp> PolicyAtomicGroup(group, policy_details_set, policies_already_in_group) File "../../components/policy/tools/generate_policy_source.py", line 181, in __init__ self._CheckPoliciesValidity(available_policies, policies_already_in_group) File "../../components/policy/tools/generate_policy_source.py", line 196, in _CheckPoliciesValidity raise RuntimeError('Invalid policy: ' + policy + ' in atomic group ' + RuntimeError: Invalid policy: RemoteAccessClientFirewallTraversal in atomic group RemoteAccess. Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1647, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 379, in main GenerateFile(opts.source_path, _WritePolicyConstantSource, sorted=True) File "../../components/policy/tools/generate_policy_source.py", line 372, in GenerateFile writer(sorted and sorted_policy_details or policy_details, File "../../components/policy/tools/generate_policy_source.py", line 1079, in _WritePolicyConstantSource schema_generator.GenerateAndCollectID(chrome_schema, 'root node') File "../../components/policy/tools/generate_policy_source.py", line 839, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 787, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 789, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 839, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 752, in Generate return self.GetEnumType(schema, is_sensitive_value, name) File "../../components/policy/tools/generate_policy_source.py", line 694, in GetEnumType return self.GetEnumIntegerType(schema, is_sensitive_value, name) File "../../components/policy/tools/generate_policy_source.py", line 667, in GetEnumIntegerType if self.IsConsecutiveInterval(possible_values): File "../../components/policy/tools/generate_policy_source.py", line 662, in IsConsecutiveInterval for i in xrange(len(sortedSeq) - 1)) NameError: name 'xrange' is not defined Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1648, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 379, in main GenerateFile(opts.source_path, _WritePolicyConstantSource, sorted=True) File "../../components/policy/tools/generate_policy_source.py", line 372, in GenerateFile writer(sorted and sorted_policy_details or policy_details, File "../../components/policy/tools/generate_policy_source.py", line 1080, in _WritePolicyConstantSource schema_generator.GenerateAndCollectID(chrome_schema, 'root node') File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 788, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 790, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 788, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 790, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 788, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 790, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 741, in Generate if not isinstance(schema['$ref'], types.StringTypes): AttributeError: module 'types' has no attribute 'StringTypes' Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1651, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 383, in main GenerateFile(opts.source_path, _WritePolicyConstantSource, sorted=True) File "../../components/policy/tools/generate_policy_source.py", line 376, in GenerateFile writer(sorted and sorted_policy_details or policy_details, File "../../components/policy/tools/generate_policy_source.py", line 1093, in _WritePolicyConstantSource schema_generator.FindSensitiveChildren() File "../../components/policy/tools/generate_policy_source.py", line 959, in FindSensitiveChildren self.FindSensitiveChildrenRecursive(0, set()) File "../../components/policy/tools/generate_policy_source.py", line 967, in FindSensitiveChildrenRecursive node = self.schema_nodes[index] TypeError: 'map' object is not subscriptable Bug: 941669 Change-Id: I9737aa44b1f395f6efeefadc94c39a084f82ed98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857122 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#705939}
-
Ioana Pandele authored
Bug: 983445 Change-Id: I3c5f67636397983c0765e7baf73ecb54bc45c889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862440 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#705938}
-
Hans Wennborg authored
If there is a diff, build.py will nuke the repository anyway. And in pathological circumstances (see bug), printing the diff can take a very long time. Bug: 1014241 Change-Id: Ic045dfef66c7695b07ba9099352744d5becdcdfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862916Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#705937}
-
Ian Struiksma authored
This test is failing on the linux bot consistently. Disabling it for now as we investigate. More details in the bug description. Bug: 1014333 Change-Id: I0efb42942e05606a35df73a0e4a2b508c0cc4cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861020Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#705936}
-
Tanmoy Mollik authored
With this cl it is now possible to build chrome without referencing any instance of CoreAccountId as std::string. Bug: 959157 Change-Id: I206ce350bde21d97161719690d0db243bbdbc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840236Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::TrayAction and TrayActionClient interfaces. Bug: 955171 Change-Id: I88e45f5f91634d1ce1851720330aa84bb0669fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839693 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705934}
-
Ioana Pandele authored
The file is moved from src/ to the parent folder. Change-Id: I64a805ef8855fe2c86e8af9b98b2134744083474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840631Reviewed-by:
-
Michael Lippautz authored
Change-Id: I02a5bae112eac610f189d0408a592acd0d71277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862950 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#705932}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8bbf9e2c6e40..8718afb283b7 git log 8bbf9e2c6e40..8718afb283b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 peah@webrtc.org AEC3: Made EchoAudibility multichannel 2019-10-15 saza@webrtc.org Remove AudioProcessing::gain_control() getter 2019-10-15 danilchap@webrtc.org Merge SendTask implementation for SingleThreadedTaskQueueForTesting and TaskQueueForTest 2019-10-15 mbonadei@webrtc.org Add missing RTC_EXPORT for the component build. 2019-10-15 mbonadei@webrtc.org Revert "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received" 2019-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 18d41172..88a7a882 (705754:705863) 2019-10-15 sakal@webrtc.org Add Ramprakash Jelari to AUTHORS. 2019-10-15 sprang@webrtc.org RtpRtcp modules and below: Make media, RTX and FEC SSRCs const 2019-10-15 phoglund@webrtc.org Move --resources_dir to its right place. 2019-10-15 mbonadei@webrtc.org Revert "Delete methods EncodedImage::Allocate and EncodedImageBufferInterface::Realloc" 2019-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e1ac8de..18d41172 (705654:705754) 2019-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 02833e65..2e1ac8de (705539:705654) 2019-10-14 honghaiz@webrtc.org Add a turn port prune policy to keep the first ready turn port. 2019-10-14 danilchap@webrtc.org Use GlobalLock to protect logging 2019-10-14 srte@webrtc.org Adds logging of NetworkStateEstimator estimates. 2019-10-14 jonaso@webrtc.org Add field trial to reduce STUN pings. 2019-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c1f96a7b..02833e65 (705365:705539) 2019-10-14 srte@webrtc.org Adds test for loss based controller under cross traffic induced loss. 2019-10-14 jonaso@webrtc.org Add feature to skip RELAY to non-RELAY connections 2019-10-14 danilchap@webrtc.org Remove deprecated functions in RTPSenderVideo 2019-10-14 nisse@webrtc.org Fix GetStats bytesSent/Received, wireup headerBytesSent/Received 2019-10-14 ssilkin@webrtc.org Use bitrate limits provided by encoder. 2019-10-14 elrello@microsoft.com Reland "Implement rollback for setRemoteDescription" 2019-10-14 kcwu@google.com Reject invalid spatial index 2019-10-14 nisse@webrtc.org Delete methods EncodedImage::Allocate and EncodedImageBufferInterface::Realloc Created with: gclient setdep -r src/third_party/webrtc@8718afb283b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:980875,chromium:1009172,chromium:1009073 Change-Id: Ifb1730f222fbcc49350d47bd4a66907424742f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862695Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0b7b0ccae01..b17e79b773ba Created with: gclient setdep -r src-internal@b17e79b773ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I642af6f776463747d0c7974a3c333b54b7f613ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862336Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705930}
-
Olya Kalitova authored
Adds fuzzer for policies, currently fuzzes only ChromeDeviceSettingsProto. ASan' out/libfuzzer && ninja -C out/libfuzzer policy_fuzzer && out/libfuzzer/policy_fuzzer Test: tools/mb/mb.py gen -m chromium.fuzz -b 'Libfuzzer Upload Chrome OS Bug: 811690 Change-Id: Ic4c0a923006515f75bcb51c38f00be5701ab81a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845000 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705929}
-
Anton Bikineev authored
Change-Id: I1729710a62f1cc288ec947c7532ed61721fcd720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862681Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#705928}
-
Hans Wennborg authored
Bug: 1014241 Change-Id: I6a3a6c93e93db1ed693c001b9297da5e46cacbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862394 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts MediaSessionPtr that is left only in AudioFocusRequest class to the new Mojo type. Bug: 955171 Change-Id: I8df4442456914cdeace7b3395d1596044ae4616d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850676Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Miyoung Shin authored
This CL converts MediaControllerPtr and MediaControllerImageObserverPtr in chromeos, content and services to the new Mojo type. Bug: 955171 Change-Id: I319a6e0092cdc4e2c7481fd89e92abe939af147c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849740Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cb79e7140046..e84f1d15029a git log cb79e7140046..e84f1d15029a --date=short --no-merges --format='%ad %ae %s' 2019-10-15 fmayer@google.com Remove stale comment. Created with: gclient setdep -r src/third_party/perfetto@e84f1d15029a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib7f7d7172bcf44b1d4886d9581691f64a9247063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862694Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2de9622a0398..52e19cbdc570 git log 2de9622a0398..52e19cbdc570 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 perezju@chromium.org Reland "[Telemetry] Add "ad hoc" histograms as measurements" Created with: gclient setdep -r src/third_party/catapult@52e19cbdc570 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:999484 Change-Id: Ic9f6cec044a019c1a8f0825440be4ff89cd9ed17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862696Reviewed-by:
-
Javier Ernesto Flores Robles authored
On iPad Pro the keyboard layout is 3 points above the bottom, but not one of its superview. The new checks goes up all the hierarchy until the first view that is the size of the window. Then checks that it is anchored to the bottom of the window. Change-Id: I514910cd17253f9ad1f80ba11a2ba66aff6028a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860033Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#705922}
-
Henrique Ferreiro authored
Convert the implementation and all users of the drivefs::mojom::DriveFsBootstrap, DriveFs, DriveFsDelegate and SearchQuery interfaces. Bug: 955171 Change-Id: I3881ee40feba2aaae7659398cd100dd90bbfd53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847332Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::ImeController and ImeControllerClient interfaces. Bug: 955171 Change-Id: Ic36f9bdbe9c246cd490c3ebe7e36acc597b89181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837626 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Takashi Toyoshima authored
Suppress a known failed test for the newly added virtual suite. Bug: 870173 Change-Id: I214e91d89cc57b1a9f76e078d1c6c1c30f9fb40b TBR: yhirano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862869Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#705919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/517b740d..a3fb0505 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I35bb24fc6649702a3033cb270f65b357d02b773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862575Reviewed-by:
-
Jüri Valdmann authored
GCC parses the function __attribute__ syntax a bit differently from Clang, associating the attribute with the return type instead of the function if the return type is a pointer. This leads to certain zlib symbols, such as Cr_z_zError, to fail to be properly exported from the shared library. Fix by using ZEXTERN instead of ZEXPORT for the attribute which works the same for both GCC and Clang. Bug: 819294 Change-Id: I5707d1b0627a503df08df9ac0bb65fda69453989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859788Reviewed-by:
-
Michael Lippautz authored
Change-Id: Ie7ed83aad8f43d8450546dd3d4139099935ef576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862684Reviewed-by:
-
Findit authored
This reverts commit 65d25bba. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 705841 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY1ZDI1YmJhODI3NTE4ZTExMzAxYTQzZDQ5MDZkN2I0NzdhZTE1ZmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/15757 Sample Failed Step: unit_tests Original change's description: > Adds UpgradeContainer logic to CrostiniManager. > > A call to UpgradeContainer can start off a long-running upgrade process > via the Cicerone daemon. A dbus signal UpgradeContainerProgressSignal is used > to communicate progress to Chrome, including the final success or failure of > the upgrade itself. > > Bug: 930901 > Change-Id: Ibdbd1a9be4ac852c93dd98257b387417c85b5dd1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850688 > Reviewed-by: Nic Hollingum <hollingum@google.com> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705841} Change-Id: I66abb2e1592153947dc8e82bbbedc668b73f172d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862337 Cr-Commit-Position: refs/heads/master@{#705915}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5807c24f. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I4e0215c13ca9a51864853b18e3974326e5114a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862574Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705914}
-
Mikhail Khokhlov authored
Bug: 1011813 Change-Id: I189ba4170b762e28a2de6e42969e0f2bf778d959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856518Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#705913}
-
Gauthier Ambard authored
When reconfiguring a "nil" cell, there is a DCHECK in the item. This CL makes sure that we don't reconfigure if we the cell is nil. Bug: 1013708 Change-Id: I1082a59a74fc50b0b0243a4ff9255606a3218c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862675 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
