GitLab

Add users actions to various points in the sharing hub.

Bug: 1009124
Change-Id: I92379ef1153d54d64257d4b32f369ec402119534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055689Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744032}

When dragged app item view is dropped into a folder at the end of the
drag, hide its title, and keep it hidden. Generally, the title will be
hidden at the end of the drag while the item is animating to the new
target bounds, but the item view is removed from the views model before
the bounds animations run, so AnimateToIdealBounds() will not update
the dragged view title.

BUG=1053935

Change-Id: Ief279b9f11f7c6bf7d562e4e4d9a690e89acf229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068279
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744031}

BUG=878133

Change-Id: I3b65e4013536aa7a7e28b1425d6ffa6852f26c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066390
Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744030}

https://quiche.googlesource.com/quiche.git/+log/7c89615d6dd7..5f23a2d78434

$ git log 7c89615d6..5f23a2d78 --date=short --no-merges --format='%ad %ae %s'
2020-02-20 nharper Move QuicCryptoServerStream::Helper to QuicCryptoServerStreamBase
2020-02-20 bnc Dump header name and value length (not value itself) if value too long.
2020-02-20 danzh gfe-relnote: n/a(test only) fix a GCC complier error in QUIC test utils. Not protected.
2020-02-19 dschinazi Introduce QUIC_VERSION_IETF_DRAFT_25
2020-02-19 fayang gfe-relnote: In QUIC, when arming PTO timer, ignore application data until handshake completes rather than handshake confirmed. Not affecting prod, not protected.
2020-02-19 fayang gfe-relnote: Add an IsAckFrameEmpty const method to received_packet_manager and make sure GetUpdatedAckFrame is only called to retrieve nonempty ACK frame. Refactoring only, not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I08858b30e044a162bdcb167b8819bc973151cd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068649Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744029}

https://pdfium.googlesource.com/pdfium.git/+log/d41bcabd124f..c93fa1ff0194

git log d41bcabd124f..c93fa1ff0194 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 thakis@chromium.org Fix a Wrange-loop-analysis warnings in pdfium.
2020-02-22 thestig@chromium.org Disable RenderManyRectanglesWithExternalMemory test for Skia.
2020-02-21 thestig@chromium.org Roll third_party/freetype/src/ 8930cc961..49f3394d7 (3 commits)
2020-02-21 thestig@chromium.org Add placeholder comments to DEPS to mitigate CQ interference.

Created with:
  gclient setdep -r src/third_party/pdfium@c93fa1ff0194

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1039697
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I3723464918b59eec3463ae50f8ff71cc972c9756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070436Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744028}

AppCache's net::DiskCache wrapper header currently declares a static
const kUnknownResponseDataSize in the content namespace, resulting in a
copy in each translation unit that includes the header. While the copies
are most likely eliminated by the linker due to lack of use, this
declaration still pollutes the namespace.

This CL moves the constant into the HttpResponseInfoIOBuffer class, so
it is only emitted once.

This CL doesn't introduce any functional change.

Bug: 1055133
Change-Id: Ib9c8a339e6a543a908ee4c952bb0bc1174fa7dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069842
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744027}

Bug: 1052228
Change-Id: I2c14024f760148cc8ddaec96cbeea3cdee7edf96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065319Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744026}

Kim is no longer active in this area but has done a review recently and
we want to make it easy for her to return :)

Other emeriti are not, in practice, reviewing in this area. Remove them
so that tools don't auto-suggest them for CLs that they'll only have to
bounce to someone else.

Change-Id: I5d46659e1621e526912b3b48323b2027c8878593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070563Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744025}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cb8594a9..f6d87d0f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ica9cd42176f680ef802c5421446e482d9a6b7045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070536Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744024}

This reverts commit 27ed0337.

Reason for revert: Top crasher on Windows.

Original change's description:
> Report crash-dump for GetFontFallbacks that succeed on Windows
> 
> On Windows, ShapeRuns(...) is shaping the text by trying:
>   PrimaryFont
>   GetFontFallback(...) : using DWrite
>   GetFontFallbacks(...) : using registry keys (Font Linking)
> 
> The GetFontFallbacks function is deprecated and should be
> remove. There is still a long tail of cases that succeed
> only with the use of that mechanism. This CL is making
> these cases to be reported as a crash to be analyzed
> before removing the code. The goal is to avoid breaking
> the text rendering even for a small population.
> 
> R=​robliao@chromium.org
> 
> Bug: 995789
> Change-Id: I381753ed3985779cd34dae58a34f523c2f215c9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049126
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741606}

TBR=robliao@chromium.org,etienneb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 995789
Change-Id: Ibd4e3a1dd4fadb9178511a0cab38200c8fd4ade4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068830Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744023}

Bug: 1025603
Change-Id: I061f50b6666376a9f829dd833c507ce200e31765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069853
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744022}

Add a new method so observers of the DedicatedWorkerService and
SharedWorkerService can be notified when the final response URL is
determined when fetching the worker's script.

Bug: 1048332
Change-Id: I1d6593e876e88d4c067d49e56d2cb635a2973ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063448
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744021}

Lots of tests were listening for "permission request shown" using the
same class, and I want to add another.  First refactor to a common
location to avoid yet-more-copy-and-paste.

Bug: none
Change-Id: Iabf5ff8ad250e8b50a7f97ac3e2b15e75ef6c76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068093Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744020}

TBR=jlebel@chromium.org

Bug: 1055457
Change-Id: I651b22a882ea847f5930e02e8a9a3362bf0beb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070110
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744019}

https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to
also block draw instead of just swap. This had the side of effect of
blocking draw when the browser window is minimized, which means we stop
casting tab/window contents. Switch DisableSwapUntilResize() back to
just block swap instead of draw+swap.

Bug: 1054239, b/149923568
Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744018}

We were subtracting border_padding when it wasn't present if the item
had min-size:auto but didn't qualify for the special flex min-size:auto
behavior because, for instance, it has overflow: hidden.

This fixes the telemetry_perf_unittests failure FlexNG was hitting on
the bots, which was caused by a recorded google docs page.

Change-Id: Ia6bde490651daf63e4ca77f9525870987bb9fe5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065626
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744017}

Remove SetNeedsResizeObserverUpdate, and associated flags and functions
in order to make the notification delivery process stateless. With this
change, ResizeObservation::ObservationSizeOutOfSync will determine
whether notifications should be delivered rather than
element_size_changed_ and observer_changed flags being set by
SetNeedsResizeObserverUpdate, which is called at various points in the
layout process.

Cases involving many ResizeObservers were considered, and it is decided
that it would be more desirable to have slower pages which contain
many (>10^4) observers rather than slowing down
LayoutBox::StyleDidChange with extra operations (which would have been
required for scenarios involving content box changes).

With this change, content box changes can be observed, fixing all WPT
observe.html tests.



Bug: 1034329
Change-Id: Ie2225ad2865ee15d82be548c1455949946734074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033849Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#744016}

This patch removes the --enable-web-authentication-testing-api flag. The
flag disconnected the real webauthn API and replaced it with a
simple mock.

This flag had two goals:
  * To allow developers to write tests against webauthn.
    This use has has been superseded by the WebDriver WebAuthn Testing
    API.
  * To allow WPTs to have some sort of mock that avoided timeouts.
    This is now achieved by using the testdriver WebAuthn API.

The patch also removes an inspector-protocol test that relied on a mock
authenticator being set up automatically when the flag was set.

Fixed: 1054422
Change-Id: Iddde2b7e84bd6c37eaf5365f52fb0ddd401617e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067088Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744015}

All the WebAuthn directories have OWNERS that point to a master OWNERS
in //device/fido. The Java directory was different because other team
members were less familiar with it but we expect to be doing a lot more
Android work soon.

Change-Id: Ia64abcc78aacd9bc2b99c71e8217ee48b61f6127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070562
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744014}

This CL adds splash icon fetching to InstallableManager and removes
badge icon part.

A bool valid_splash_icon is added to InstallableParams but
valid_badge_icon is not removed yet since the usages of
"params.valid_badge_icon" are not removed yet. (going to be remove in
the following CLs).
Now InstallableParams class has 9 booleans, so chromium style check
require it to have a explicit constructor. The constructor (and
associate .cc file) will be removed once valid_badge_icon is removed.

With this CL, badge icon will not be fetched even if valid_badge_icon is
set. It's ok to do so since it's not used.

Bug: 1043271
Change-Id: Ife4e99afe4fa9d94580adfff3b9ba6a6f312254c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037813
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744013}

Currently, two calls to observe with the same 'type' will result in a
console error, whereas the spec implies that this is valid, with the
later call overriding the initial one. This CL fixes that. It also fixes
a problem where disconnect would not clear the filter_options_, as shown
in https://github.com/w3c/performance-timeline/pull/161. This would not
be a problem with 'entryTypes' because this variable would be replaced
on every call to observe(). Tests are added for these two cases.

Bug: 1052509
Change-Id: I75865b2925e2fb1a7e7fd64d7e979907c3b7650c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067250Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744012}

If a download doesn't create more than 1 slices during the first attempt,
we should assume that parallel download is not supported.

BUG=1054875

Change-Id: I046ca7b32300e124527a16ec9fbc544d376d6ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068747
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744011}

https://skia.googlesource.com/skia.git/+log/108a494984da..02497d40161f

git log 108a494984da..02497d40161f --date=short --first-parent --format='%ad %ae %s'
2020-02-24 egdaniel@google.com Update nanobench and skpbench to use flush API for gpu syncing.
2020-02-24 kjlubick@google.com [canvaskit] Expose releaseResourcesAndAbandonContext on GrContext
2020-02-24 westont@google.com Update tasks.json based on Go Deps Cl.
2020-02-24 bsalomon@google.com Prevent unbounded invalidator growth on SkPathRef from GrSWPathRenderer
2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 605b00d7728f..cbf3b9df1ae1 (1 commits)
2020-02-24 csmartdalton@google.com Lift calls for setting dynamic state to Ganesh level
2020-02-24 csmartdalton@google.com Remove "setData" operations from GrMtlPipelineState::setTextures

Created with:
  gclient setdep -r src/third_party/skia@02497d40161f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I164f72adcbd657fb903e0c726db4fe6b1ef0065b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744010}

This cl adds the new fields display_globally and display_countries.

Bug: 1040145
Change-Id: Ice70d5c44537950420c9aeca822c652919d6298d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067561Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#744009}

Remove the asynchronous initialization which was not useful, and add a
method to get the output (decoded) audio config.

Merge-With: eureka-internal/367396

Bug: internal b/148685511
Change-Id: I050b97f1b55921249c0fab634a945fb9e2ac595e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069274Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744008}

ReleaseAcceleratedWidget() calls RemoveCompositor() which removes an
entry from |compositor_data_map_|. Instead of iterating over this map,
first copy the compositors to a new set.

Bug: 1042259, 1055223
Change-Id: I65e7c4255b6f0a5305667c13aab404c5eddfd92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070102Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744007}

Bug: None
TBR=kbr@chromium.org

Change-Id: Ie0e3c511480a434fb7d0e24e6cf76d3f76a98bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066932Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744006}

Fixed: 1054864
Change-Id: I41291fb5f83ac8af038d657544f394fba4bcbbc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068737
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744005}

It will be easier to make changes to the extraction code here without
affecting the AppIndexing feature in Clank. We will be using extraction
for data from Media Feeds as explained here:
https://github.com/beccahughes/media-feeds/blob/master/explainer.md

Bug: 1053598
Change-Id: Ibf5f05005fd301aed12a4814ac602ab06700f1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067612Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#744004}

In cases where drawing additional smaller quads instead of one large
quad is significantly less costly, split one quad into multiple quads.

In order to minimize the cost of drawing additional quads and resizing the quad list
we limit the when quads may be split. We limit the number of quads one
quad may be split into and enforce a minimum number of fragments saved
by splitting.

Test: viz_perftests,viz_unittests
Bug: 1022544
Change-Id: Id47c0a5b33b0de456fad10635c86b880882fb549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057289Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744003}

Bug: 1012975, 1018268
Change-Id: I4802f7576907fcfbe124e2675f98e30644c9eeba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068928Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744002}

Otherwise this leads to crashes in VTDecompressionSessionCreate.

The CL http://crrev.com/c/2013806 changed the order but
the intention was to fix an issue on Linux/Wayland. So
restore the previous behavior on Mac. Also restore the
previous behavior on other operating systems to make the
change safer. And guard the new order with OS_LINUX.

Bug: 1047643
Change-Id: I9637a684996ee095d32a336610cb65a7d0d20370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068207Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744001}

This reverts commit fafef524.

Reason for revert: Should be enough space now after crrev.com/c/2065419

Original change's description:
> Temporarily remove net_unittests from chromeos-amd64-generic-rel.
> 
> To unblock LKGM rolls. Will still run on the betty bot in the meantime.
> 
> Bug: 1053547
> Change-Id: Ifb2ffc7f06a6183265209d5e06c63a16215b1316
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065414
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742909}

TBR=stevenjb@chromium.org,bpastene@chromium.org,malaykeshav@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1053547
Change-Id: I5892a41f300425b1dd97730bad2fee72d8279870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067615Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744000}

When I initiailly created this hack in [1], the intention was to always
use fcntl() over fcntl64(), however the hack was written to invert the
_FILE_OFFSET_BITS=64, but not when it's set to a value like 32, as is
the case in some projects.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1862623

BUG=b/147463741
R=thakis

Change-Id: I4e9b58dbe45888573fa5789ca487e8ed87d8c99b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070025Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743999}

This will make it easier to move these into //components/permissions.

Bug: 1025609
Change-Id: Ic0745279a303c447beac0c3072dd59e494a15d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065620
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743998}

Doing so is a bit surprising, and makes local development not match what
users see.

Bug: 1027123
Change-Id: I5f05de15b75c0ba0bf5d022ae9be50405415df99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069544
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743997}

There are four tests that are flaky on the  Win10 FYI x64 SkiaRenderer
GL (NVIDIA) bot. The failures might be related to running the test on a
real GPU so just mark them as flaky for now.

Bug: 1026375
Change-Id: I825873b70f4ad7a2cffcfa75a30da635c144b248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070101Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743996}

This reverts commit 52dbe8bb.

Reason for revert: that broke navigation to facebook.com, see bug for details.

BUG=1055450

Original change's description:
> Move WebInsecureRequestPolicy values to mojom
> 
> This CL is a precursor to converting
> FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom.
> It moves WebInsecureRequestPolicy values to mojom to use the values
> in content and blink and removes WebInsecureRequestPolicy.
> 
> Bug: 1047284
> Change-Id: If030952dbd0c9e98bb0c4a11479ea175ade91fc5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045293
> Commit-Queue: Julie Kim <jkim@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743880}

TBR=kinuko@chromium.org,haraken@chromium.org,dtapuska@chromium.org,jkim@igalia.com

Change-Id: I6885d524a41b21fbdb0066b2cc2513408fe15943
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070109Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743995}

Right now it opens OS settings, which has the same set of sync options
as browser settings. Soon the OS sync settings page will be different,
and we want to send users to the browser settings page either way.

This also helps if a user checks both "Review sync options" and
"Review Google Play options" during OOBE. They will see two windows,
OS settings and browser settings.

Making syncSetup a browser settings, rather than OS settings, subpage
requires changing ARC++ URL handling in ChromeNewWindowClient for
mojo enum ChromePage::SYNCSETUP. I think this is OK, because it's
closer to the original ARC++ behavior before split settings, and
also I can find no usage of the SYNCSETUP code path in the ARC++
code (or anywhere else in google3).

This CL is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1977139

Bug: 1054980, 901184
Change-Id: Ide777363aa83e9a7b0f87068c318bd1f274c7e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068948Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743994}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f1834b06ad1..207c622c1ef0


Created with:
  gclient setdep -r src-internal@207c622c1ef0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I8f6c81898d87d0d4080fb0a4b1d4cd264c69acd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070430Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743993}