- 05 Aug, 2020 40 commits
-
-
Sami Kyostila authored
When the execution context is unpaused, schedule any pending idle callback timeout tasks as asynchronous tasks instead of running them directly. This is because it's not allowed to execute script directly from lifecycle callbacks. Bug: 1110503 Change-Id: I37dc6a6a41bf1f1bf7953073f7824222409cdffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335446Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794974}
-
Cherie Cheung authored
During the processing of ARCVM SharePath() request, it was retrieving the seneschal port via some Crostini functions. This was incorrect and would trigger a Crostini restart. This change will properly fix this by retrieving the correct seneschal port from ArcSessionManagerVmObserver. BUG=b:147618164 TEST=tast run <DUT> arc.Drivefs.vm Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#794973}
-
arthursonzogni authored
This is a reland of 9c96261a The fix was this synchronization: ``` with request.server.stash.lock: ``` The server is doing a read and a write to a shared state. Those operations must not unterleave with other request handlers. Original change's description: > [COOP] Access reporting. Fix the python server. > > A python server is used has a communication channel in between documents > from different browsing context group and potentially cross-origin. > > There are two methods: > - one for writing a message. > - one for reading the message. > > I initially supposed we won't need to store more than one message in the > stash. It turns out there are tests doing two write in a row without any > read in the middle. It was throwing an exception when this > happened. > > This patch makes the server to maintain a queue of messages instead. It > doesn't throw errors anymore. > > Bug: chromium:1109194 > Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865 > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791901} Bug: chromium:1109194 Change-Id: I0abbbd9d0ec3b2d3c7c25b0a182c064523c18bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322886Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#794972}
-
Sami Kyostila authored
The cricbuzz:2019 story is failing on all Android bots. NOTRY=true TBR=mythria@chromium.org Bug: 1112337 Change-Id: Iacee79aaf0bf1db62cc6b88d4bd1fac16cde0f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339076Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794971}
-
My Nguyen authored
We are working on improvements to autocorrect mechanism in ChromeOS. We need to get the information of the current position of autocorrect markers in blink. For future extensibility, add getting ime text spans at cursor position function, but only allows adding autocorrect marker for now to minimize IPC call. Design doc: http://go/cros-get-autocorrect-range Bug: 1109074 Change-Id: I6c99c15d271c558158f0adc66f35bd06e1a35aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326556Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/25b0de6bd00f..38ddebf9a771 2020-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 92a71657fcba to 8bc27a1cfbc1 (3 revisions) 2020-08-05 timvp@google.com Roll chromium_revision fb6cbaf6..ed7912a2 (790363:794870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I87ed52cea1268c12802ae07839751e1e4db4effe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794969}
-
Mikel Astiz authored
Analogous to crrev.com/c/2332703 for iOS: the recently-introduced API in base/test/test_file_util.h allows temp dirs to be created without explicit lifetime control. Tests can assume the directory will be around during the execution of the test, and it will get automatically deleted afterwards. Bug: 546640 Change-Id: I9c8dc59b8ae3963f0be692bfe302cdc8d01d9a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335194Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794968}
-
Carlos Caballero authored
Bug: 1111720 Change-Id: I6325fbfef9bc9f18495dbd3c4842571e56a356a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332656 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/807ce12a0c4f..e794555edb6f 2020-08-05 leese@chromium.org Deduplicate source mapped breakpoint 2020-08-05 patrick.brosset@microsoft.com Grid: Don't assume grid lines are straight when drawing extension lines 2020-08-05 wolfi@chromium.org Style issue bar to mimic regular console message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1068116,chromium:1096481,chromium:1105764,chromium:1112363 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I552bd39250f3109b7fd9c9ab3f739513bdb70240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338675Reviewed-by:
-
Thomas Tellier authored
This reverts commit 59d5a5a3. Reason for revert: Reland the CL by fixing the bug Original change's description: > Revert "Change hiding timer logic for password textfield on login/lock screen" > > This reverts commit 4af05312. > > Reason for revert: Breaking ash_unittests and browser_tests > on chrome os builders, see > https://bugs.chromium.org/p/chromium/issues/detail?id=1112924 > > Original change's description: > > Change hiding timer logic for password textfield on login/lock screen > > > > 5-second instead of 3-second timer for password/PIN going back to masked format. > > 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. > > > > Bug: 1101326 > > Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176 > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > Commit-Queue: Thomas Tellier <tellier@google.com> > > Cr-Commit-Position: refs/heads/master@{#794602} > > TBR=rsorokin@chromium.org,tellier@google.com > > Change-Id: I2cb94561e291ccadf623af2bd4529cd4c9bd23de > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1101326 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337388 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794721} TBR=rsorokin@chromium.org,rbpotter@chromium.org,tellier@google.com # Not skipping CQ checks because this is a reland. Bug: 1101326 Change-Id: Ib1aca0d5dfc9f8912b39c7d27de4053b80d0126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337474Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794965}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596596349-2982a3aa1ac388b8b69893b6dd544749d7f1a2d0.profdata to chrome-win32-master-1596610622-a993b1ede4201f1709aeb65ee161df429dedf1b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9a576532f0f6e05a6b5c2eb4161438d1aa7e9657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338594Reviewed-by:
-
Andreea Costinas authored
Users have the option to clear the HTTP authentication cache in the browser. System-proxy uses the proxy credentials which a user has entered in the browser to authenticate to a remote proxy. This CL implements sending a |ClearUserCredentials| request to the System-proxy service when a user clears the auth cache in the browser. Bug: 1098216 Test: browser test Change-Id: Ie2fb3020727005acb8fceca911e7587ce0d128b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317957 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794963}
-
Shik Chen authored
Quote from error message of Closure Compiler: ERROR - [JSC_MISSING_NULLABILITY_MODIFIER_JSDOC] <Type> is a reference type with no nullability modifier, which is disallowed by the style guide. Please add a ! to make it explicitly non-nullable, or a ? to make it explicitly nullable. Bug: 1112210 Test: Run Closure manually with lintChecks enabled Change-Id: Ide71fcb58275565cfc706cbcb8e9178f0657ddfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334530Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#794962}
-
Yuki Yamada authored
This makes VectorBackedLinkedListConstIterator have a pointer to a Node in container_->nodes_ to avoid a CHECK in WTF::Vector::at(). This CL is for migration of NewLinkedHashSet. See: https://crrev.com/c/2134039 Bug: 1100257 Change-Id: Icf3901eaf33f9308881feca408b4a0a5da73a756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308623Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794961}
-
Jacobo Aragunde Pérez authored
We overwrite the accessibility role of the PasswordBubbleViewBase so it has the role that ATs expect. Having that role will trigger the code that produces the correct events. Bug: 1079320 AX-Relnotes: announce the save password bubble when it shows up (Linux) Change-Id: I7e0c4b08c356488d485d3b529afbe7701e2aa5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190470 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#794960}
-
dizg authored
Bug: 1105865 Change-Id: Ic23584084629f6e318083d536130792752dc303a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332630Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#794959}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596585596-c75cdf8296e7e3f8b1db14498223f15cea6443e5.profdata to chrome-win64-master-1596606694-35c6f8535b14ce15b4839555c5550c892d549ecc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1ea1f9af130334b6081bf2a6d29f63915cb61d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338577Reviewed-by:
-
Saurabh Nijhara authored
The policy is planned for the M86 (check bug), so moving it from 'future_on' to 'supported_on' and enabling the feature. This is only applicable to ChromeOS. Bug: 1048607 Change-Id: I9f84adc5c2eee2f8b60c1c25e7c778313c2ea81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299351 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
My Nguyen authored
Bug: 1045266 Change-Id: I7021f830ee53c1c86f1149b10133cb1329d13218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308549 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794956}
-
Alex Rudenko authored
Bug: 1106681 Change-Id: Ib61221e7847c71db4c27ae74524c44cb16a2fea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332445Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794955}
-
Yunke Zhou authored
Show parental controls is not eligible for managed(edu/enterprise) account. Show different subtitle for newly created child account and existing child account. Update strings. Bug: 1101318 Change-Id: Ia4ec05cd27f1517abb27ddc728ea1bd252b2fdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332264 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1112785 Change-Id: I99a228547d7907c2e9825d72da70a9d96b1f2206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335195Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#794953}
-
Friedrich Horschig authored
This CL completes the wiring between bridge and mediator. It makes the mediator observe the PasswordCheck for finished fetches (and additional credentials) and queries already known issues. Bug: 1106726, 1101256 Change-Id: Id3dd8b0a18e6d6d4d0eeef30242f65c0e59c7340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336835 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#794952}
-
Aya Elsayed authored
This reverts commit 26f4c62b. Reason for revert: chromeos-eve-chrome build failures Original change's description: > Re-add field trial testing config for DisableLatencyRecoveryDesktop > > Based on the data gathered from running the experiment on canary/dev and > beta, it seems that the disabling latency recovery for both main and > impl threads is an overall performance win. So, we are going to > re-enable the (now-expired) experiment on stable and move forward with > its gradual rollout. > > Bug: 993895 > Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790549} TBR=mohsen@chromium.org,rkaplow@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993895, 1113101 Change-Id: Ibfebd16583e4f4670d808b80eb00360f0e744ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338214Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#794951}
-
Omer Katz authored
We use a snapshot of the hash table key to check whether a bucket is empty or deleted, but we don't use the snapshot for the actual tracing. This leads to a time-of-check vs. time-of-use issue where a bucket can become deleted while we are checking the snapshot. This CL refactors the TractTraits for KeyValuePair so that concurrent marking can use the snapshotted key as the traced key. Bug: 1110416 Change-Id: Icd758886e9e51a8af4e727ae6b853b958723fb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336073 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d5eb7e06f156..d84b21c3f04c 2020-08-05 fancl@chromium.org chromeperf: Temporarily disable SimulateAlertProcessing 2020-08-05 fancl@chromium.org chromeperf: Formatting all python code under dashboard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Ib4a8aa917635c6561bf8c6455c63c4e88326e77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338257Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e40fda83f28..171aaf4db08f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ayaelattar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ayaelattar@google.com Change-Id: Id221f91c97d1eb24ffab02bc884b9d767f8518c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338476Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794948}
-
dizg authored
Screenshot for light mode: https://drive.google.com/file/d/1cVocXW7_qV-OsW-RC5Q9_8oIc0UgAyZw/view?usp=sharing Screenshot for dark mode: https://drive.google.com/file/d/1uG2qP8ZwzqPA1NHdvtt4rgpd9vX1aY-8/view?usp=sharing The current image is temporary, it will be changed in a separate CL once it will be ready. Bug: 1105865 Change-Id: Ifea158663fa85147677c2ee0920c5a2aa2fa0bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332660 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit 6772afd3. Reason for revert: Caused test failures of PDFExtensionAccessibilityTreeDumpTest. Bug: 1113093 Original change's description: > Stops computing an artificial accessible name from inner text on Mac > > When an object on Mac is focusable but has no value or name, we compute its accessible description > from its inner text. > Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object > which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents. > If extra spaces are needed, they should be added by Blink, not by the browser. > This patch removes the code that computes the inner text completely since > no other screen reader announces focusable items unless they have an accessible name, > and it is not proper to add an accessible name if there is none. > > AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce > the text contained in a large container such as a table row if that container is focusable. > > R=dmazzoni@chromium.org > > Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794574} TBR=dmazzoni@chromium.org,nektar@chromium.org Change-Id: I10d7260e2d8be39f632213925164679f1982b3d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338694Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794946}
-
Mark Brand authored
This NOTREACHED was a poor decision, as fuzzer can directly reach this code, so it will produce spurious check failures during fuzzing. Return a 0 tag in this case instead - this will lead to the fuzzer trying to deserialize a type which is not stored in the proto, which will fail quietly instead. Bug: 1076336 Change-Id: Ie6eb826c026f0e157fe71a030a4cd612dfa794e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302630 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#794945}
-
Kent Tamura authored
NGFieldsetPainter::PaintFieldsetDecorationBackground() re-computed the legend offset without position:relative from scratch. Instead, this CL change the function so that it unapplies position:relative to |legend->Offset()|. This CL has no behavior changes. Bug: 875235 Change-Id: I933b1e6c97e1f913e0d9f1aa9525af881dbe2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332198 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#794944}
-
Aya ElAttar authored
Step "browser_tests" failing on builder "Linux Tests" because of this test. TBR: jdeblasio@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113105 Change-Id: I506498638aba27447ad5f06b1bb83caa8158c96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335196 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1d72d581076..807ce12a0c4f 2020-08-05 tmathmeyer@chromium.org Add support for displaying text track information in the Media tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090022 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05ce441749075223b13b68cc5b0d5075d0487e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338475Reviewed-by:
-
Ryan Harrison authored
Roll src/third_party/tint/src/ 88f0ae369..f18d737b4 (27 commits) https://dawn.googlesource.com/tint.git/+log/88f0ae369fef..f18d737b4e93 $ git log 88f0ae369..f18d737b4 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 rharrison Rolling 7 dependencies and fix BUILD.gn 2020-07-30 dsinclair [ast] Add texture types to the AST. 2020-07-30 dsinclair Add SamplerType to AST. 2020-07-30 dsinclair [hlsl-writer] Add loop support. 2020-07-30 dsinclair [hlsl-writer] Add if/else statements. 2020-07-30 dsinclair [hlsl-writer] Emit variable declarations. 2020-07-30 rharrison Add SPIR-V Reader Fuzzer 2020-07-30 rharrison Remove _exe suffix from sample program 2020-07-30 rharrison Change the default for BUILD.gn to build all the modules 2020-07-30 rharrison Simplify fuzzer targets to ease adding additional targets 2020-07-30 dsinclair Fixup build warnings 2020-07-30 dsinclair [wgsl-reader] Add stride support. 2020-07-30 dsinclair [wgsl-writer] Emit array stride decoration. 2020-07-30 idanr Add BlockStatement insert and non-const global_variables 2020-07-30 sarahmashay [Validator] Using pointers instead of refs 2020-07-29 dsinclair [hlsl-writer] Add member accessor emission. 2020-07-29 dsinclair [hlsl-writer] Add AsExpression to the HLSL backend. 2020-07-29 dsinclair [hlsl-writer] Add BlockStatement support. 2020-07-29 dsinclair [hlsl-writer] Emit discard. 2020-07-29 dsinclair [hlsl-writer] Emit array accessors. 2020-07-29 dsinclair [hlsl-writer] Add alias type support. 2020-07-29 dsinclair [hlsl-writer] Add constructor emission. 2020-07-29 dsinclair Add hlsl writer tests to BUILD.gn 2020-07-29 dsinclair [hlsl-writer] Add type emission. 2020-07-29 dsinclair Update some language usage. 2020-07-29 dneto [spirv-reader] Only support column-major matrices 2020-07-28 rharrison Remove binutils from DEPS and pull in changes to build.gni from Dawn Created with: roll-dep src/third_party/tint/src Roll src/third_party/SPIRV-Tools/src/ c6e6597c4..8bc27a1cf (11 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6e6597c4f51..8bc27a1cfbc1 $ git log c6e6597c4..8bc27a1cf --date=short --no-merges --format='%ad %ae %s' 2020-08-04 vasniktel spirv-fuzz: Remove OpFunctionCall operands in correct order (#3630) 2020-08-04 vasniktel spirv-fuzz: Handle capabilities during module donation (#3651) 2020-08-04 vasniktel spirv-fuzz: Refactor boilerplate in TransformationAddParameter (#3625) 2020-08-03 vasniktel spirv-fuzz: TransformationMoveInstructionDown (#3477) 2020-07-31 jaebaek Remove DebugDeclare only for target variables in ssa-rewrite (#3511) 2020-07-31 vasniktel Fix typo in ASAN CI build (#3623) 2020-07-30 stefanomil spirv-fuzz: Transformation to add loop preheader (#3599) 2020-07-30 stefanomil spirv-fuzz: Pass to replace int operands with ints of opposite signedness (#3612) 2020-07-30 jaebaek Debug info preservation in loop-unroll pass (#3548) 2020-07-30 alanbaker Validator support for non-semantic clspv reflection (#3618) 2020-07-30 vasniktel spirv-fuzz: Fix memory bugs (#3622) Created with: roll-dep src/third_party/SPIRV-Tools/src Roll src/third_party/spirv-headers/src/ 979924c8b..3fdabd0da (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/979924c8bc83..3fdabd0da293 $ git log 979924c8b..3fdabd0da --date=short --no-merges --format='%ad %ae %s' 2020-08-03 44190824+mmerecki Reserve SPIR-V token range for upcoming Intel extensions. (#165) 2020-07-29 alanbaker Update BUILD.bazel and BUILD.gn (#166) 2020-07-29 alanbaker Publish the headers for the clspv embedded reflection non-semantic extended instruction set (#164) 2020-07-29 johnkslang Update the registry in spir-v.xml to modernize and split out opcodes. (#156) Created with: roll-dep src/third_party/spirv-headers/src Roll src/third_party/dawn/ 0a4342793..076a4e582 (1 commit) https://dawn.googlesource.com/dawn.git/+log/0a4342793e0e..076a4e58205d $ git log 0a4342793..076a4e582 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 rharrison Roll 6 dependencies and bypass changed API usage Created with: roll-dep src/third_party/dawn Change-Id: I4a6dc63352de60cc422e0dea496487401dc28802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330303 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#794941}
-
Christian Dullweber authored
This reverts commit 978386ba. Reason for revert: Enable the test again to see if it still failing. Original change's description: > [Sheriff] Disable PageInfoViewTest > > These render tests are failing on different building bots. > TBR=dullweber@chromium.org > > Bug: 1112985 > Change-Id: I1590c2bad3c0042ecfd73ac46c6edbffb2f683fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337290 > Reviewed-by: Wenyu Fu <wenyufu@chromium.org> > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794795} TBR=dullweber@chromium.org,wenyufu@chromium.org Change-Id: Ida3ca24ffb5c6567941a1a4093071fc5721b167d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332728Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#794940}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I07b44e432816387cfa7d63ab2b8137ef6d06cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337581Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794939}
-
Ewann authored
On iOS 13.1 the whole TOS string responds to a TAP. On iOS 13.5, it works as expected. Bug: 1102996 Change-Id: I8f72200964ed28dad7de52d9029fb14f97725e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336609Reviewed-by:
-
Maxim Kolosovskiy authored
UI mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8de4a3b916_55_6 Screenshot: https://screenshot.googleplex.com/97hV2heWU15 TODO: Add the icon for the regular change button. https://screenshot.googleplex.com/XzOB9tPeV2X Bug: 1086114, 1092444 Change-Id: I7164bf6f6f01a3bdc2cde3bfacc5817774661611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336608 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#794937}
-
My Nguyen authored
Doesn't matter too much but it bugs me when adding new files No-Bug: drive-by Change-Id: I5ecbe0d869a5742cbb94c1eac2c2f90a0febff22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331989 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Victor-Gabriel Savu authored
Add the DeviceShowLowDiskSpaceNotification policy to control the suppression of the low disk space notification on enrolled devices. Currently no notification is shown if multiple users are present on the device. The policy will give administrators control over the notification instead. No change of behaviour if the policy is not present. Design doc: https://docs.google.com/document/d/1_mblglRZlPeWpc1cn9T8vb97rnLEmjA7waiSLp-qKcE Bug: chromium:1099604 Change-Id: I53bbed664e0f05f8f33a5cd659f0c36e51fbd21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270297 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794935}
-
