GitLab

Bug: 1012270
Change-Id: Ic35c3a7c331d353db8a938e11ea78d5ca38f6f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847792Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703794}

This CL was created automatically with tools/perf/update_wpr script

R=perezju@chromium.org

Change-Id: Iaed9dbf26f7668c758416558b82e80c015080725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837656
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703793}

In this test, we want to test that testdriver Action API supports key
and mouse action interactions. Clicking with "Ctrl" key pressed on Mac
causes a context menu open, which fails itself and prevents a
subsequent test from running. We can use other keys such as "Shift"
or "Alt", which do not open any context menu.

Change-Id: Id9b48440306eeddbd97114bc1ac0f4c9c3c012fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845994
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703792}

Bug: 995916
Change-Id: I780da4d5689a58a3002321aae8687db96ca859c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830011
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703791}

In X11, TouchEvent destructor must clear native event id mapping, created at
construction time for TOUCH_{RELEASE,CANCELLED} events.  It was doing that
using native event (i.e: XEvent) info, which is undesired [1].

This CL address it by abstracting away the pointer_details.id => native
tracking id from TouchEvent implementation, into X11-specific TouchFactory. So
when a new touch id is created (at TouchEvent's ctor for native events) a new
entry is added into TouchFactory table and removed in the destructor of the
corresponding RELEASE/CANCELLED.

Additionally, a cleanup is done, removing unneeded flag and methods as it is a
X11-only logic and it was possible to simplify its implementation.

[1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc

Bug: 965991
Change-Id: I36c568d0ef627c6d2e900e47bfecd08345a3cc48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816779
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703790}

🙄

Bug: 1005370
Change-Id: I4e73a9871572595520a908f347034cd8287c601b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845798
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703789}

Bug: 1011457
Change-Id: I39016ea24cd296b3ed0ed95a2556e7941fdb9390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845937Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703788}

This avoids immediate dereferencing when local scoped_refptr() goes out of scope.

Change-Id: Ibf7bc85ca23cd36d8c1e527edb2a70e9d081e8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846351
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Misha Efimov <mef@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703787}

This CL ensures that blank usernames display a translated version
instead of an empty string.

Bug: 1011836
Change-Id: Ic473e5adc59375c638c04b60ca81e0934891aec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847303
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703786}

Initially observed in Chrome OS Account Manager's account addition
screen, chrome://chrome-signin does not declare its encoding as UTF-8,
leading to non-ASCII localized text to be displayed incorrectly.

Fix this by declaring the encoding as UTF-8 in the HTML WebUI page.

Bug: 1012269
Change-Id: Idc598157489355f9999e60f0e45f65de07c8f582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847307Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703785}

The current approach is very brittle and requires a sentinel value.
Change to a simple vector.
Also fixes a bug where DialogClientView would crash when used
with only an extra_view and no buttons.

Change-Id: I63a7ca82138f76b96169cf1777a7aa564f2a9890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847218
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703784}

This reverts commit 0ac392fe.

Reason for revert: Settings search bar loses focus on search cancel. crbug/1011752

Original change's description:
> Prevent settings search icon from flashing when a search is cleared
>
> Bug: 1001056
> Change-Id: I326b21b3e25e472fa15dc9bd9d9c97feb688ad4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815542
> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Bailey Berro <baileyberro@chromium.org>
> Commit-Queue: Gavin Williams <gavinwill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699457}

TBR=stevenjb@chromium.org,zentaro@chromium.org,baileyberro@chromium.org,gavinwill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1001056
Change-Id: I1bcad3ef2b08fdb130d289a9c9619337078570c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847796Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703783}

This reverts commit 9413e636.

Reason for revert: cast_media_unittest failures

Original change's description:
> [Chromecast] Statically link CMA backend when possible
> 
> Merge-With: eureka-internal/321778
> 
> Bug: internal b/127963522
> Bug: internal b/141138924
> Change-Id: I08813895e48ea3e983258e3e0d316b8acda740b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842677
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703747}

TBR=spang@chromium.org,halliwell@chromium.org,kmackay@chromium.org

Change-Id: I5ab4f1257615e5d89ab815d880252544dec0767c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: internal b/127963522, internal b/141138924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846806Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703782}

In the Edge fuzzer runs, we're seeing crashes in sequence_manager_fuzzer
via ThreadManager::PostDelayedTask. The root cause appears to be the
fact that a cross-thread post can execute on one thread while the
thread where the target ThreadManager lives is executing a shutdown
task. The TestTaskQueue pointer that is held by
ThreadManager::PostDelayedTask can be deleted when the
TaskQueueWithVoters is erased from the task_queues_ vector. Keeping a
scoped_refptr on the stack allows safe use of the TestTaskQueue pointer
for the duration of the function, and the task runner infrastructure
gracefully handles posting to a TaskQueue that has gone away.

That change alone fixes the fuzzer crash, but there's still a race -
since only GetTaskQueueFor is protected by the lock (same lock is
acquired before erasing the vector entry), it's possible for the
TaskQueueWithVoters to be destroyed along with its queue before we
take the extra reference when assigning the stack scoped_refptr.
To fix this, I've converted TaskQueueWithVoters to a thread-safe
refcounted type and GetTaskQueueFor now returns a
scoped_refptr<TaskQueueWithVoters> instead of a raw pointer.

Bug: 977527

Change-Id: I9f49531bd7d8c76bae36a65ed150c32714039d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835216Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703781}

As part of X11 PlatformEvent migration effort, this CL eliminates
native_event() usage from KeyEvent::IsRepeated method, which is only
called at object initialization, this eliminating one more native event
usage after event object construction.

This corresponds to item 1.5 of PlatformEvent migration doc:
https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc

Bug: 965991
Change-Id: Ib5ad9f7da00e1d26b86616033eee343676e5a494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816777Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#703780}

By default, the NetworkService bootstraps a leaking
SystemDnsConfigChangeNotifier singleton object in
NetworkChangeNotifier::NetworkChangeNotifier().

This SystemDnsConfigChangeNotifier observes the DNS configuration (via
FilePathWatchers on /etc/resolv.conf and /etc/hosts on POSIX and via
ObjectWatchers on the registry on Windows). These watchers outlive the
BrowserTaskEnvironment of the RenderViewHostTestHarness, including it's message
queues.

If the trybots experience network changes (e.g. due to expiring DHCP leases or
other problems), it is possible that the watchers post messages to a message
queue that has been destroyed already, see crbug.com/1011275#c3.

This CL introduces a MockChangeNotifier which does not observe network changes.
This is probably fine for RenderViewHostTestHarness tests but we should
evaluate whether the network service needs to bootstrap a leaking
SystemDnsConfigChangeNotifier or whether that can be scoped to the lifetime of
the NetworkService.

Bug: 1011275
Change-Id: I50359d5c3e8631a3e03a5f2bee4e94bb7f45c53b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847215
Commit-Queue: Dominic Battré <battre@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703779}

Tests a new begin/end being added by a syncbase, and the corresponding
'end' event being fired.

Bug: 998526
Change-Id: Ie40f196d4ef2c5fb6b65fced80890a965415cace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840692
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703778}

https://android.googlesource.com/platform/external/perfetto.git/+log/f91a82bb1624..26f21f5e0ac0

git log f91a82bb1624..26f21f5e0ac0 --date=short --no-merges --format='%ad %ae %s'
2019-10-08 hjd@google.com traceconv: Update traceconv to f91a82bb16246437dc6c565b80f13158d142dde6

Created with:
  gclient setdep -r src/third_party/perfetto@26f21f5e0ac0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I811a5f62ad68b23547acfba4431a157d1b6fd9df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845482Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703777}

Bug: 1009903
Change-Id: I957152a1b6d47c898f36e34b280c29415e2c34a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846216
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703776}

Telemetry perf tests are flaky because some startup tracing data
is lost. Increase the buffer size until we have a better way to deal
with this.

Change-Id: I6341c71147472079cb5f075e4cefefe2042e55f7
Bug: 914092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847221Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703775}

This CL changes MediaToolbarButtonView to delete its
MediaToolbarButtonController in its destructor so that it's destroyed
before any of its other members. This prevents a use-after-free that
can happen because the MediaToolbarButtonController will sometimes
call methods on the MediaToolbarButtonView when it is deleted.

Bug: 1011677
Change-Id: I07b13d8ac9ea40d78a2ed42c1cce7226b568f188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845794Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703774}

Bug: 1000821
Change-Id: I8f492141e66f2048bfe2edb0daceec6d2214540e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838232Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703773}

Change-Id: I659733df1bf3ff9f05ea978df804ecca5039b713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841769Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703772}

All LayerTreeHost methods should do nothing when the delegate is removed
but these three were missed.

R=avi@chromium.org

Bug: 1011623, 419087
Change-Id: I3c9995226dfe7727e60eb132db5f91a15ca935af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847853Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703771}

https://chromium.googlesource.com/catapult.git/+log/2d30369ce6b1..f7b20a05decf

git log 2d30369ce6b1..f7b20a05decf --date=short --no-merges --format='%ad %ae %s'
2019-10-08 dberris@chromium.org Support OAuth in /add_point API
2019-10-08 dberris@chromium.org Follow-up to use correct execution name

Created with:
  gclient setdep -r src/third_party/catapult@f7b20a05decf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sadrul@google.com

Bug: chromium:1012187
Change-Id: Ia64965b7e97ccc45c03860366ecfdfd43376742c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703770}

Replaces how the title and the subtitle in the TouchToFill bottom sheet
are aligned. Before, layout_width="match_parent" with
textAlignment="center" were used. This has caused issues with device
rotation (see bug). After this change, layout_width="wrap_content" and
layout_gravity="center_horizontal" are used.

Bug: 1012224
Change-Id: I98f7cdeab9be84eee80d2dc14cc29ae820af6b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847285Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703769}

The GetVisualProperties() method is not called from
RenderWidgetHostImpl::SynchronizeVisualProperties() if the
RenderWidgetHostView is gone.

The other callers are during creation of a RenderFrame and a
RenderView. In both cases, the renderer is already known to be live
and the RenderWidgetHostView is present. For child frames we ordered
the RenderWidgetHostView after the RenderFrame, but this puts them in
the other order to allow the RenderFrame to depend on the view for
constructing VisualProperties().

R=avi@chromium.org

Bug: 419087
Change-Id: Id5cb55074f56e74d1a844b79c2eb945156fc2916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841972
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703768}

Bug: 984550
Change-Id: I2e1b888bff9fad066931c98afa19e63fa78250a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842296Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703767}

The class ServerPrintersProvider is responsible for building resultant
list of printers exposed by available print servers. It uses instances of
ServerPrintersFetcher to query print servers and builds a resultant list
of server printers. The list of server printer is then passed to
CupsPrinterManager.

BUG=chromium:896778
TEST=on local chrome build

Cq-Depend: chromium:1769161
Change-Id: If5db64ea62697a34655b05825e25bd59f98fcb6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702583Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703766}

The flakiness seem related to Windows platform, so only disable
them on Windows, see crbug.com/1010955

Bug: 1010179, 1011204
Change-Id: Id1fdebe7dc1603909173817604251e2aa50517d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846551Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703765}

The getFile() method on NativeFileSystemFileHandleImpl returned a File
that wasn't sized correctly. This caused issues when trying to use
methods on the File object that would use the bounds to do operations.

BUG=1011179

Change-Id: If900ac39be6b7bfc9d693680aa5d20b6b9c926d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845998
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703764}

Filtering out flaky tests for android-bfcache-linux.

Bug: 1007276
Change-Id: Id44e8f1c1a6afe557085a9a9774a311e8f56c1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847276Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703763}

The flakiness seem related to Windows platform, so only disable
them on Windows, see crbug.com/1010955

Bug: 1010187, 1009359
Change-Id: I219b04f1633e9b5151584371f06d92f4dc61a492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846478Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703762}

This CL deletes the unused feature that was used for the TouchToFill
bottom sheet. It has no associated flag and — according to codesearch —
no reference anywhere.

Bug: 1011185
Change-Id: I329429b5613eaebca1366cbddadd07a30ebd95d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847305Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703761}

Bug: 995916
Change-Id: Id6e45dbb397a132860b40915c1cc9cce901b0a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829649
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703760}

The first occurrence was a bug, and now has an early return if the
Default Search Provider is null.

In the second occurrence, the default search provider was checked
earlier, so I added a DCHECK at this use.

Bug: 1011899
Change-Id: Iad7640d0b6666288e8ea94119b6f203a30800444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847213Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#703759}

This code became unused after https://crrev.com/691020.

Change-Id: I9f91a36e98518ec907f63c7cfefc0503481e784b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846338
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703758}

This CL has two goals,
1. Use To<HTMLPictureElement> and DynamicTo<HTMLPictureElement> as new
   downcast helper
2. Use IsA<HTMLPictureElement>(element) in place of
   IsHTMLPictureElement(element)

Bug: 891908
Change-Id: I1e4a3a63e326bf9c93c0dd170907cb58f0a4722b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846429Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#703757}

Using wpt-import in Chromium 91795f43.
With Chromium commits locally applied on WPT:
c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors""
23748e60 "Change text directive to text="
2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
skobes@chromium.org:
  external/wpt/css/css-scroll-anchoring

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ic85b734226ce1ce879947a28b9342d63dfbcdcc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847731Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703756}

This avoids keeping corresponding resources alive indefinitely.

Bug: 1004094
Change-Id: I21fe10289ed296916feaf53e9a5934cff968eabd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819558
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703755}