GitLab

BUG=129499
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10827014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137973
TEST=none
TBR=glider
Review URL: https://chromiumcodereview.appspot.com/10821098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149077 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=139726

Review URL: https://chromiumcodereview.appspot.com/10837012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149076 0039d316-1c4b-4281-b951-d872f2087c98

Failing on buildbots, but not locally/trybots.

BUG=139726
TBR=sergeyu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149074 0039d316-1c4b-4281-b951-d872f2087c98

Precise's gcc warns about variables that are set but never used.

BUG=none
TEST=compiles on Precise.


Review URL: https://chromiumcodereview.appspot.com/10829088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149073 0039d316-1c4b-4281-b951-d872f2087c98

- Define member functions of class OutputConfigurator in the order
  they were declared.

- Made struct CachedOutputDescription to be private member of class
  OutputConfigurator.  No need for it to be exposed publicly.

- Renamed "enum State" to "enum OutputState" to be more specific.

- In places where a large if block extend to the end of the function,
  use an early return to reduce indentation.

BUG=chromium-os:32857
TEST=build successfully

Change-Id: Id39dff3b38d16b2496df0df288a332fe29b2e37b
Signed-off-by: Simon Que <sque@chromium.org>


Review URL: https://chromiumcodereview.appspot.com/10824071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149072 0039d316-1c4b-4281-b951-d872f2087c98

Fix bug in SpdySession where map.erase() was called on an iterator when the underlying map had changed, making the iterator invalid.

BUG=139518
TEST=SpdySessionSpdy*Test.CloseSessionWithTwoCreatedStreams


Review URL: https://chromiumcodereview.appspot.com/10821086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149071 0039d316-1c4b-4281-b951-d872f2087c98

is_hidden() was already added to RWHI recently and they duplicate exact functionality.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10833052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149070 0039d316-1c4b-4281-b951-d872f2087c98

does not prevent caching of responses that are not 200,
and does not delete the cached response if not really needed.

For example, we should be able to cache redirects when the
request is made using a byte range.

BUG=134267
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10829069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149069 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10830077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149068 0039d316-1c4b-4281-b951-d872f2087c98

  and lookup the classes by name. This allows the binary to work with multiple
  versions of Xcode and doesn't tile the binary to an Xcode install location.
- Fix problem where the tool could log the wrong thing since basename()
  returns an internal buffer.

Review URL: https://chromiumcodereview.appspot.com/10828070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149067 0039d316-1c4b-4281-b951-d872f2087c98

R=binji@chromium.org
BUG=139161


Review URL: https://chromiumcodereview.appspot.com/10820058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149066 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149065 0039d316-1c4b-4281-b951-d872f2087c98

This will expose the bounding box for a WebGestureEvent in WebKit.

This patch only depends on http://trac.webkit.org/changeset/123520, so it is safe to land now.

BUG=138572
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10806092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112525

Review URL: https://chromiumcodereview.appspot.com/10831061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149063 0039d316-1c4b-4281-b951-d872f2087c98

This leak was introduced in r148926.

BUG=129825,139635


Review URL: https://chromiumcodereview.appspot.com/10821091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149062 0039d316-1c4b-4281-b951-d872f2087c98

We've been seeing a bunch of issues on this driver with NULL share handles and fences failing to finish, so for now it's safest to try turning off the image transport surface texture sharing.


BUG=133924
TEST=


Review URL: https://chromiumcodereview.appspot.com/10815045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139657

Review URL: https://chromiumcodereview.appspot.com/10827090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149060 0039d316-1c4b-4281-b951-d872f2087c98

Also guard in Initialize() against bad API/card combos.

BUG=139671


Review URL: https://chromiumcodereview.appspot.com/10832067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149059 0039d316-1c4b-4281-b951-d872f2087c98

This adds a stub implementation of
GDataContactsServiceInterface to be used by
(not-yet-checked-in) unit tests.

BUG=128805
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149055 0039d316-1c4b-4281-b951-d872f2087c98

createHTMLNotification has been removed from the W3C Notifications spec. We do not want it to be exposed for web pages. However, since quite a few extensions are still using it, we would still keep it to be exposed for extensions.

BUG=98061
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10808113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149054 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149053 0039d316-1c4b-4281-b951-d872f2087c98

Relanding after rebasing.

[Sync] Remove CleanupDisabledTypes command and move purge logic into SyncManager."

Original codereview at http://codereview.chromium.org/10541079/

BUG=131433, 90868
TBR=tim@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10829086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149052 0039d316-1c4b-4281-b951-d872f2087c98

Update skia_test_expectations to account for new baselines in r124061 and r124070.

TBR=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10821095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149051 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10824050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149049 0039d316-1c4b-4281-b951-d872f2087c98

It didn't make sense to have a callback parameter, as this was a
synchronous function. Changed the function to return a pointer instead.
Along the way, rename the function to FindEntryByPathSync().

Replace GDataFileSystem::GetGDataEntryByPath() with FindEntryByPathSync().

BUG=137160
TEST=out/Release/unit_tests --gtest_filter=GData*  && out/Release/browser_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10831076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149048 0039d316-1c4b-4281-b951-d872f2087c98

This patch solves the build issues that are directly related to building crypto for the x86_64 architecture.

BUG=136072

Review URL: https://chromiumcodereview.appspot.com/10738003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149047 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

BUG=121174

Review URL: https://chromiumcodereview.appspot.com/10701026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149045 0039d316-1c4b-4281-b951-d872f2087c98

Add socket_api_unittest.cc, which calls Socket API functions directly.
This skips the whole browser_tests setup that is relatively slow and
expensive. The current test merely validates the socket-type argument
handling, but the next phase will simulate blocking socket operations.

BUG=112902
TEST=see above


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148856

Review URL: https://chromiumcodereview.appspot.com/10795052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149044 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10832068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139694
TBR=jvoung@google.com

Review URL: https://chromiumcodereview.appspot.com/10823089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149042 0039d316-1c4b-4281-b951-d872f2087c98

R=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10828082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149040 0039d316-1c4b-4281-b951-d872f2087c98

Mark down in web intents picker controller when it is part of a TabContents that is hosting a web intents service.


R=groby@chromium.org
BUG=None
TEST=WebIntentsPickerControllerBrowserTest.*


Review URL: https://chromiumcodereview.appspot.com/10805094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149039 0039d316-1c4b-4281-b951-d872f2087c98

This may be causing some synchronization problems, so disable it for now to see if that fixes it.


BUG=135546
TEST=


Review URL: https://chromiumcodereview.appspot.com/10825066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149038 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149037 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org
BUG=none
TEST=build + run

Change-Id: I502bc6f2fe72ca56c6961295a5e9fa6c27b908f9


Review URL: https://chromiumcodereview.appspot.com/10820036

TBR=sleffler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149034 0039d316-1c4b-4281-b951-d872f2087c98

Valgrind: Suppress a leak. Heapchecker: Re-enable test_shell_tests and unit_tests and see what happens.

BUG=132867,139703
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10823088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149033 0039d316-1c4b-4281-b951-d872f2087c98

Created json results store for returning results to browser
Includes name filter of rendering benchmarks

Review URL: https://chromiumcodereview.appspot.com/10537036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10821080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149030 0039d316-1c4b-4281-b951-d872f2087c98