- 15 Aug, 2019 40 commits
-
-
Ian Clelland authored
This will cause bugs to be filed when third-party WPT imports introduce new test failures. Change-Id: Ie5db9bfffede22227e2ea4ef6ef73077f010811f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756391 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#687345}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/87531182b181..eefe89513262 git log 87531182b181..eefe89513262 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 mmortensen@google.com Extend image service to support building factory image. Created with: gclient setdep -r src/third_party/chromite@eefe89513262 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie5d89e276ed4d3dd2b80474b65ef66bf3d6bf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687344}
-
Akihiro Ota authored
Bug: 923068 Change-Id: I4aab963244f8e84c5fb749794587d60a64a083f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747975Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#687343}
-
Khushal authored
This reverts commit 77418db6. Reason for revert: Temporary change landed for diagnostic purpose. Original change's description: > android: Temporarily generate crash dumps for all renderer hangs on Q. > > R=dtrainor@chromium.org > > Bug: 983310 > Change-Id: I88d7a60b2938355fb1253707ebf45ab8bffe1c82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699422 > Auto-Submit: Khushal <khushalsagar@chromium.org> > Commit-Queue: David Trainor <dtrainor@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677090} TBR=dtrainor@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983310 Change-Id: I705e5e3adc344d36fcb27c0e7e06163ef3d0b397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756393Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#687342}
-
Himanshu Jaju authored
Reuse syncer::DeviceInfo instead of SharingDeviceInfo Bug: 993780 Change-Id: I82ca01edc5dab5038394a862ff9e38c563fe8c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755909Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#687341}
-
Justin Cohen authored
Tests needed a few calls to grey_scrollInDirection for the shorter screen. Bug: 994233 Change-Id: Iee2128409e75d97ddbd6bbb2b907a50b90087090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756246 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687340}
-
Peter Wen authored
The no_build_hooks flag prevents asserts from being processed in the tab_ui module. It was added as part of the work towards async DFM modules. We will need to find an alternative approach when we restart that work. Add missing deps that were missed due to the lack of build hooks checks. Bug: 994090 Change-Id: I2ce75afecbf627338d20451dcacd38a44ea59b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755971 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687339}
-
Matthew Wang authored
If CaptivePortalDetector::Cancel() is called after CaptivePortalDetector::DetectCaptivePortal() is run but before CaptivePortalDetector::StartProbe is run, |detection_callback_| is reset but a probe is still started. This causes a DCHECK fail or null dereference. Check for null |detection_callback_| before starting a probe. Bug: 993388 Change-Id: I46cc2a5fb226cd2a96443387103648617068b065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753162Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#687338}
-
Junbo Ke authored
Bug: b/139215443 Merge-With: eureka-internal/303498 Test: TBD Change-Id: I3341a19b74e23ff276b8133e779438b6fc84917b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753469 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#687337}
-
Dana Fried authored
Design: https://docs.google.com/document/d/1fZOg120fswUdaV7tfZh8cXIlcvAL1Gg70GVrsQVXl3g This is the MVP of an animating layout. Feature supported include: - layout can animate its preferred size or fit the size given - preferred size (if applicable) and child view bounds automatically animate from one proposed layout to the next - No animation is performed if the host view's size is set externally. - No fading of views being removed or hidden is performed; a view being hidden or removed disappears right away, and a view being shown appears at the end of the animation (to prevent child views from overlapping). Future work: - Selectively animate child views when the host view's size is set externally. - Fade child views in/out as they are added/removed or shown/hidden. - Maybe handle nested animating layouts. Bug: 898632 Change-Id: I43873fabbce47ed247626613885a59fe1ca299e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742509Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#687336}
-
Vlad Tsyrklevich authored
Several tests failed on the android-asan bot. Disable the crash handler tests only on the android-asan bot, not other android bots. For the guarded page allocator tests, re-enable and use fewer threads on Android. (This will give us some more head room on non-ASan low end devices as well.) Bug: 993168 Change-Id: I290ec7d9322e862f1bd69068f1898d4fe47547fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755403 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#687335}
-
Vlad Tsyrklevich authored
Now that 32-bit Windows is no longer supported, the FPU exceptions we were previously seeing (https://crbug.com/919207) should not occur. Change-Id: I06fd3e278948ec1cf80007902f46e23c9ac3735d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701957 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
Clark DuVall authored
The AndroidX test was using a special chrome:// URL that is hardcoded to trigger safe browsing. We were not proxying chrome:// URLs through the AwProxyingURLLoaderFactory, so this prevented calling back to the AW client with the error results. Bug: 993568 Change-Id: I11b534eb0a1d40ed3340242b6ba3877da65823c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754123Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Chris Blume authored
The SkiaRenderer Vulkan Android bot was breaking frequently. We want to add it to the CQ for likely-impactful directories. This should help maintain the SKV bot. Bug: 979431 Change-Id: Id332ab4de1b2deac7ad4c53ef8e92351d176b58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753667Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#687332}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74bf49a9abc9..7a39c017c233 git log 74bf49a9abc9..7a39c017c233 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 primiano@google.com Merge "TraceProcessor: add clock-sync support at import time" 2019-08-15 khokhlov@google.com Merge "Trace processor: Parse legacy ftrace and legacy json trace events" 2019-08-15 taylori@google.com Merge "ui: Fix highlighting when selection is far to the left of screen" Created with: gclient setdep -r src/third_party/perfetto@7a39c017c233 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I07374b39803d98a11d8ba2a507f23919dfa8b149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755981Reviewed-by:
-
Daniel Cheng authored
Typically, this is done with pairs of *interfaces*, not just pairs of message pipes. Change-Id: I4e83f45fda6b9666148bdd10a7c86ae727d41682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755407 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#687330}
-
Yuke Liao authored
The corresponding project-health project was done, so this bot is not used anymore. Bug: 993424 Change-Id: I2211af8c6b3138ba979cfb45916cb947b573c87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725220Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#687329}
-
Vladimir Levin authored
This patch ensures that we don't consider the legend when painting the fieldset border, since the legend may be out of date and is considered a child of the fieldset (meaning we have to not paint it). Also updates the fieldset tests to do a double raf before running the test to ensure that everything is parsed and rendered. R=chrishtr@chromium.org, rakina@chromium.org Bug: 993755 Change-Id: I0f27ad0242ceaa76d00513aa14e94aef5ddfb04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754702Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#687328}
-
Yi Gu authored
The test should no longer be flaky after V1 being enabled by default because the problematic code path was bypassed. See [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1638283/6/content/public/test/hit_test_region_observer.cc#b158 Change-Id: I4ec1f7a087fba9318500c423603d1185ec998e9f Bug: 948372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754665Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#687327}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb5f1034aafc..d105c06506d1 Created with: gclient setdep -r src-internal@d105c06506d1 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I9db514a313cfd0c7d8fef5f5cd7bdfa512a3c6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755561Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687326}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ae0f75063c10..5f8a16aca062 git log ae0f75063c10..5f8a16aca062 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 capn@google.com Default to LLVM JIT for ARM32 CMake build 2019-08-15 chrisforbes@google.com Jettison android subzero support entirely Created with: gclient setdep -r src/third_party/swiftshader@5f8a16aca062 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/115344057,chromium:b/139147241 Change-Id: I734f9d7426291b41bf5cd8745477869f13178236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756323Reviewed-by:
-
James Cook authored
FocusOutlineManager considered the document "focused by keyboard" after window blur. This seems a little odd, and causes the OS settings sidenav menu to show the keyboard focus ring on window blur. This FocusOutlineManager behavior was added in 2015, before MD settings. We don't appear to need it anymore. It was added in: https://codereview.chromium.org/914033002 and the bug it fixed crbug.com/457165 no longer repros, even after I remove the behavior. Likewise, browser settings sidenav focus outlines continue to work properly after removing this behavior (they show after hitting tab, hide when the window loses focus, and come back when the window regains focus). So let's remove the behavior. Bug: 993677 Change-Id: If9c56ad18d50d0974cf957864c6346ebdffd0470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754505Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#687324}
-
Mike Frysinger authored
Python 3 doesn't support string_escape on bytes. It doesn't have an official supported form for this currently either. It could be done ad-hoc (iterate over every byte and build up the string ourselves), but it turns out the codecs module has an escape_encode helper that does what we need with a bit of effort. Also cleanup the associated unittest while we're here. It was mixing bytes & string data inline and expecting it to be interpreted as UTF8 encoding. Python 3 didn't like this at all. Make it a proper unicode string and use \u sequences to get the codepoints we want. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I1c4de0e3ab5c129d4999d6685887a2c54bd7ab9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755388 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#687323}
-
Ben Kirchman authored
The test overrides the TestUploadDataProvider's read method, but then adds a read to the dataProvider, which is redundant and confusing. Change-Id: I747f6637dfc6f729278950daa93f1052075c1523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753591Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#687322}
-
Michael Thiessen authored
Should be no functionality changes here. SingleTabModelSelector#openNewTab was completely unused because the only instantiation of it overwrote it. Binary-Size: This is an R8 bug, see b/139304307 Change-Id: Id9f4b8a9a4cf402194c631845632139b73f5bb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748115Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#687321}
-
Tommy Li authored
Currently, we have code to focus the omnibox when opening the NTP (New Tab Page). This is all well and good, but we also need to add a check to not do this when viewing the source of the NTP. Bug: 970185 Change-Id: Ib488e0cc8e8607bd2f9b8d2f8ddec0f0066ecee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754151Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#687320}
-
Yi Gu authored
The reasons of disabling the test are no longer valid. Bug: 599730 Change-Id: I13d74de9b332ee9b3f22bc0d9f68600772b2c642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754784Reviewed-by:
-
Yi Gu authored
Similar to crrev.com/c/1298478, this patch adds a waiter to make sure the previous RenderProcessHost get destroyed. Tested with the trick mentioned in crrev.com/c/1299976 which could cause consistent failures without the fix. Bug: 889002 Change-Id: Id142ab917038e0a13eb676887525738ea08e3876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754787Reviewed-by:
-
Adam Langley authored
As suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1752937/3/chrome/browser/ui/views/webauthn/authenticator_qr_sheet_view.cc#222 Change-Id: I3401c7c77f6b3989383ecda1d8e68c173aa5ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754709 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#687317}
-
Bailey Berro authored
When there are no nearby printers available, show a message indicating that. Bug: 991929 Change-Id: If430ff4c526120aa0b0c97f1670b6e68d6a0f1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754942Reviewed-by:
-
Peter Kasting authored
We originally did this to try and ensure tabs had sufficient contrast to be readable in all cases. However, this caused problems if the background colors were not correctly calculated, and also limited theme authors' ability to make aesthetic choices (or override us if we got something wrong). Instead, use the specified colors directly. Generate unspecified inactive tab colors by blending with the background, as we do for the default theme. No changes to how the default theme's colors are calculated. Bug: 904372 Change-Id: I90d96afbf3a1e9b095b0860a64aa044fecdad6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755142 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#687315}
-
Virender Singh authored
This CL makes following changes - Uses default keyword for dtors in ActionHandlingFakePepperPluginInstance, FakeRendererPpapiHost and PdfAccessibilityTreeTest classes. - Removes ConvertAXScrollToPdfScrollAlignment function from member variable of PdfAxActionTarget to a function in anonymous namespace. - Rephrased and moved comments in pdf_accessibility_tree_browsertest.cc and accessibility_unittest.cc files. Bug: 769940 Change-Id: If7515d09e271d867af72a2f74e10e43b10fff236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753370 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#687314}
-
Daniel Clark authored
Update input type 'date', 'datetime-local', and 'week' ControlType, LocalizedControlType, and AriaRole The html-aam spec doesn't specify values for ControlType, LocalizedControlType, or ARIA role for input date, datetime-local, or week. However, the current values for these don't really reflect the way that the user interacts with the controls. The current values are: ControlType: UIA_ListControlTypeId LocalizedControlType: "list" AriaRole: "list" The values should be changed to the following to better reflect the way that the user interacts with the control (basically as a textbox that restricts its input to valid dates), with LocalizedControlTypes that distinguish between the different types: ControlType: UIA_EditControlTypeId LocalizedControlType: "date picker" for input date, "local date and time picker" for datetime-local, "week picker" for week. AriaRole: "textbox" Note that the above refers to the textbox part of the control, not the calendar popup. Bug: 993549 Change-Id: I1071d9c69701cb312426c8cded4875ac339c57ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751975Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Alex Clarke authored
This API is not being used much and one of the tests is flaky. Rather than fix the test it has been decided to remove the API. The internal working is left untouched so it would be easy to add it back should the need arise. Bug: 970187 Change-Id: I036d5843cd41795a84ca7f0c2be2a31acc4e9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692981 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#687312}
-
Joshua Peraza authored
This is generally convenient on any Linux platform because build-ids aren't generated by default in non-official builds. Change-Id: I83584fadfe3e1374bb7ad99eb9d22b8d2a698df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755974 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/096b09187476..bacb821c428a git log 096b09187476..bacb821c428a --date=short --no-merges --format='%ad %ae %s' 2019-08-15 brianosman@google.com Fix crash in reinterpretcolorspace GM with abandoned context 2019-08-15 dtapuska@chromium.org Fix duplicate definition of kRect_ClipType. 2019-08-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@bacb821c428a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:993871 Change-Id: I606cc8b44c0461f1a146199f8d0b6d02d20f0783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756324Reviewed-by:
-
Samuel Huang authored
This reverts commit 461a68da. Reason for revert: This is no longer needed: We've decided to let each DFM load native resources (on install) in its own way, instead of relying on common infrastructure. Reverting this also fixes crbug.com/994035 Original change's description: > [Bundles] Add module_installer_backend.cc with native OnInstallModule handler. > > To prepare for handling native resource loading after DFM installation, > this CL adds a new hook in ModuleInstallerBackend.onFinished() to call > (via JNI) a new native handler for each newly installed module: > JNI_ModuleInstallerBackend_OnInstallModule() > > AsyncTask is used to make the JNI call asynchronous, taking place > outside the UI thread. This allows file access (e.g., to open native > resources) to take place in the native code, thereby preventing > assert failure in Debug builds. > > After the JNI call, |mListener.onFinished()| is called on UI thread, > just like before. > > Bug: 927131 > Change-Id: I36880cc7739a48534052b51d3d655d1ae0beb29a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702905 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680452} TBR=danakj@chromium.org,huangs@chromium.org,agrieve@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927131,994035 Change-Id: If9fdbffb35d226615135c9db596ad50960bc2958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756154Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#687309}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 4ff606217..c152cc559 (7 commits) https://quiche.googlesource.com/quiche.git/+log/4ff606217c21..c152cc559e6c $ git log 4ff606217..c152cc559 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 renjietang Prevent QuicStreamSequencer from taking in new data after the stream is reset. 2019-08-13 renjietang Early return in QuicSpdyClientSessionBase after connection is closed. 2019-08-13 danzh gfe-relnote: n/a(code clean up) inline quic::CreatePccSender() 2019-08-13 renjietang Allow creation of HTTP/3 static stream after MAX_STREAM frame is received. 2019-08-13 bnc Track unacknowledged references on the encoder stream in QpackBlockingManager. 2019-08-12 renjietang Improve hard-coded QuicSimpleServerStream's push promise id. 2019-08-12 renjietang Initialize session in quic_simple_server_stream_test. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I7be248b26644adfe330d2005f3c0192a50607d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756145 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#687308}
-
John Chen authored
When web page adds toJSON function to Array prototype, ChromeDriver incorrectly calls this function while doing JSON serialization of array objects. This is incorrect, as the W3C WebDriver spec (https://w3c.github.io/webdriver/#dfn-internal-json-clone-algorithm) explicitly specifies that implementation should check for collection before looking for the toJSON function. Bug: chromedriver:3084 Change-Id: Ib2ed0c79833a6ca557d33595687efd70ade7d8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749617 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#687307}
-
Alex Newcomer authored
Since CL 1737730, AppList visibility is now correct in tablet mode. After this change, bugs have surfaced with the shelf background. To fix this, modify HomeLauncherGestureHandler so we no longer notify observers that the animation has completed before clearing state. The specific issue was that HomeLauncherGestureHandler::IsDragInProgress returns true when observers are notified of home launcher animation completion. So, fix this, then check HomeLauncherGestureHandler::IsDragInProgress to more accurately determine the proper shelf background. Also check for widget visibility, not activation, because the widget is not activated in tablet mode when shown. Bug: 990995 Change-Id: I560a6db4c045dbbc802f18b43266e2c1f2f19e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746915Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687306}
-
