- 23 Aug, 2019 40 commits
-
-
David Bertoni authored
This also enables the manfifest key for the service worker background script and adds tests to verify expected state of some API bindings. Bug: 995601 Change-Id: I3e456b09307093d4356368083c080a51e6db813b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761524 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690120}
-
Malay Keshav authored
The expression used in dom-if for a function call must include braces. This patch adds the missing braces. Bug: 976057 Change-Id: I948cf50721c96a5642d65ffecc369fa88689650a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767489Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#690119}
-
David Black authored
Pressing the proactive suggestions view will now open Assistant UI to show the proactive suggestions response inline. See bug for demo. Bug: b:139199739 Change-Id: I10f53bc7c0fe1c5273c2e92052a492676db083bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764104Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#690118}
-
Mike Wittman authored
TBR=kevers@chromium.org Bug: 997149 Change-Id: I3ccb31de28435dfe85cf6457c9ec8acd7110ed23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769555Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#690117}
-
gogerald authored
This CL solves the issue that TabGridDialog uses wrong rect for animation when the Tabs is sorted in MRU order. It should be no-op when MRU is disabled. Bug: 996381 Change-Id: I87d93a0f66199cdef50deaf7826bee77be5f7742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764268Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#690116}
-
Daniel Rubery authored
This CL also adds a basic test for this. Bug: 980784 Change-Id: Ic8696ef13811cf2cc0135268966ee47c04c4185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769235 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#690115}
-
Steven Bingler authored
Disable DoH on desktop machines that have platform policies set so that enterprise machines will not take part in the experiment. Bug: 955454 Change-Id: I86465e85deddb1ed40a28af53d9bddd6c3d82d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764253 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#690114}
-
Jun Mukai authored
This custom layer animation element complicates the animation and causes regressions on several tests. Let's just replace it by standard animation. Bug: 996268, 994933 Test: interactive_ui_tests Change-Id: I4c93b1db4ce8f4b853915209392796e75c61df53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764755 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#690113}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/fb49e6c16449..ed2eef654373 git log fb49e6c16449..ed2eef654373 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 absl-team@google.com Googletest export 2019-08-23 krystian.kuzniarek@gmail.com Googletest export 2019-08-23 zhangxy@google.com Merge pull request #2394 from kuzkry:custom-type-traits-duplication-of-custom-index_sequence 2019-08-23 zhangxy@google.com Merge pull request #2401 from kuzkry:custom-type-traits-add_lvalue_reference 2019-08-23 zhangxy@google.com Merge pull request #2400 from kuzkry:custom-type-traits-enable_if Created with: gclient setdep -r src/third_party/googletest/src@ed2eef654373 The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: I40152e10881cf5908f9cb93702f3c4048c510c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Staphany Park <staphany@google.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690112}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fad1fa1b3234..5d51a2e48472 git log fad1fa1b3234..5d51a2e48472 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 tcwang@google.com afdo: Add/Change schedules to toolchain AFDO builders. 2019-08-23 chrome-bot@chromium.org Update config settings by config-updater. 2019-08-23 dhanyaganesh@chromium.org config: Make atlas critical 2019-08-23 saklein@chromium.org uprev_lib: Fix uprev version check. Created with: gclient setdep -r src/third_party/chromite@5d51a2e48472 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1bc7d1a03ffa24eda03418d061ad98a686c523e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769540Reviewed-by:
-
Yun Liu authored
Experiment: 50 Bug: 731759 Change-Id: I4cb77566c9500cd46a90d04884c6287233c6f1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761339 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690110}
-
Kevin Marshall authored
Fixes a regression in archive tarball construction which was archiving stripped binaries in the symbol tarball, as if it was a valid symbol source. R=fdegans@chromium.org, frousseau@google.com Bug: 996050 Change-Id: I329f10a3fc3fdf75f354d537d0923ba1cb670ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769545Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690109}
-
minch authored
CONNECTED and SUB_HEADER are actually never be used while |use_unified_theme_| is false. This cl goes to remove the unnecessary logic on |use_unified_theme_|. May do more refactoring of TrayPopupItemStyle after the simplification. TEST=IME tray and palette tray do not change visually (these are the only cases where use_unified_theme_ == false is used.) Bug: 982950 Change-Id: I71885bbff4b178cf2907e92bc539d0cdf650ce10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767095 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#690108}
-
Sophie Chang authored
This allows us to easily switch between paths in code. The next step is to add a OptimizationGuideDecider backed implementation of PreviewsOptimizationGuide and allow for switching between them behind a feature flag Bug: 969558 Change-Id: I0c50bf8dd252958b128bb14737d8dcc92775bd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765991 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#690107}
-
James Cook authored
Settings shows GAIA's notion of the user's email address. For example, if the user signed up for a Google account "Foo.Bar@gmail.com", they can login to their device with "foobar", but settings shows "Foo.Bar". Under the hood, the "canonical" email is "foobar", and this is used to create AccountId objects. signin_ui_util::GetAuthenticatedUsername() was trying to create an AccountId object using "Foo.Bar" as input, which caused the DCHECK. However, the function wants that AccountId to look up the original email with periods in it. Use ProfileHelper::Get()->GetUserByProfile(profile)->GetDisplayEmail() instead. This avoids AccountId construction entirely. See bug for details. Also set a "display email" for public accounts to fix tests (and possibly production). Bug: 994798 Test: settings opens correctly for "james.cook@gmail.com" Change-Id: Ia01f1d902d3439afa0f53c5535fe6097299ab916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757509Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#690106}
-
Harley Li authored
GetDatabaseNames() is meant to be a view-only operation with no side effects, so requesting database names on a site that does not use IndexedDB should not result in creating one by calling this method. This patch de-flakes web test storage-view-reports-quota.js (crbug 982485 comment 4). TBR=luoe@chromium.org Bug: 982485 Change-Id: I673a6097021cb2b0e8a2c5c6fb48854fb1f39938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757167 Commit-Queue: Harley Li <hhli@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690105}
-
Renjie Tang authored
Change-Id: Ie9218a235d4a3ee55acdfd4fdcf2b04a49a3d786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768979Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690104}
-
Pedro Simonetti Garcia authored
BUG=984231 Change-Id: I1ffd601338900435cd90aba29a78559eb3552f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763878 Commit-Queue: Pedro Simonetti Garcia <pedrosimonetti@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#690103}
-
Yue Zhang authored
Bug: 997192 Change-Id: If537fc55c97ea5aa6097f21b1a737aba277d47c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769216Reviewed-by:
-
Tibor Goldschwendt authored
This is achieved by adding an install_artifacts metadata that is set to the path to the APKS archive for bundles and the path of the APK for APKs. Internally, the test_runner_script target will read the metadata and passes those to the test runner. Collecting metadata always returns a list. However, for the install_artifacts that list has only a single item. In order to make metadata files compatible with @FileArg, this CL introduces a '[]' suffix for @FileArg keys that flattens a single item list to the item. Bug: 989654 Change-Id: I4bea9f03a2967557855be25fc6dad8914db4eb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769315Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690101}
-
Vitaly Buka authored
GetConsecutiveData may return pointer into internal cache. However the test always check buffer which accidentally contains the same data from the previous iteration. Found compiling with -ftrivial-auto-var-init=pattern Change-Id: Ib72585fd598d23bac6bcb976d7b3f309536a8376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769232 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#690100}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9313874349dd..e8a2c8053daa git log 9313874349dd..e8a2c8053daa --date=short --no-merges --format='%ad %ae %s' 2019-08-23 senorblanco@chromium.org Dawn: update to recent GrGpu/CopySurface changes. 2019-08-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms d7c7dd8b955e..ce4270691346 (1 commits) Created with: gclient setdep -r src/third_party/skia@e8a2c8053daa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None Change-Id: Ie8fedc8999e04ca55c0d6c07a59cf780db60077b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769537Reviewed-by:
-
Shawn Gallea authored
Add CastExternalBeginFrameClient to eventually allow 4hz refresh rate on audio-only cast devices Bug: b/139299756 Test: Compile and run cast_shell Change-Id: Ia2e1531a1035ed92ee61cee69dc24c491d6ca109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763435 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690098}
-
Devlin Cronin authored
There was an unnecessary check and graceful handling in the JSON Schema Compiler that should never have been hit. Replace it with an assert. Bug: None Change-Id: I5cfab6de46f042233ad66f98215e6737e3492afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764103 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690097}
-
Becca Hughes authored
For more context, please see the bug. This CL is two part: 1) Unconditionally remove the player from the media session 2) Do not add a pepper player if focus fails BUG=997190 Change-Id: I2f20d94762a2908c7531ce35cc2df110e5ba13aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769180 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#690096}
-
Regan Hsu authored
* Center align content * Remove drop shadow * Change color of border * Remove period * Change icon to link color https://screenshot.googleplex.com/ZO9gNHtcrwZ Change-Id: I2330bde40d6921ef9af230d96e7aa7f531337030 Bug: 996484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765657 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#690095}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be1d8500..9551b470 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9633318e63892939772ff99a3609a5e9152f06a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768790Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690094}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e5ca57ed417..195bf9a75021 Created with: gclient setdep -r src-internal@195bf9a75021 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I70bb75257a02c2b418597e210fbc82201e7c4716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768905Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690093}
-
Yusuf Sengul authored
Bug: 992616 Change-Id: I6e0ebdc646766479699c9007c781c286c2ead96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755055 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690092}
-
John Abd-El-Malek authored
Change-Id: I965bbb46ff7dcdacad89fc1584cf1fa20f7056b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768867 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#690091}
-
Alex Turner authored
Adds .CSSThirdParty, .JavaScriptThirdParty and .FontThirdParty to the HttpCache.Pattern UMA histogram Bug: 993004 Change-Id: Ic04cf0e44c14a81d8c9dab38a8758980971110c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754537Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#690090}
-
Patrick Monette authored
Bug: 993029 Change-Id: I213d5db8ab71df020ab2fd7adb000ce39f25d223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764403 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690089}
-
Lily Chen authored
Bug: 966576 Change-Id: I2cad191f2c1cc9ae1f96edc775fcbe93a8468e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768832Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#690088}
-
Patrick Monette authored
Bug: 993029 Change-Id: Ic3fa5a2b02a15b25814ad8231d7cd6d3abe78ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764404 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Sharon Yang authored
This test class isn't being used and ServiceDirectoryClient is being deprecated, so remove this class. Test: Tests throughout code base still pass. Bug: 974072 Change-Id: Ie6dc43bfb9f1cfb69bab0d52479d98d43e48ecd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768908 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Alex Leung authored
* Rendering delay is not correctly calculated since it does not account for data buffered in the backend. * Fixes sync issues with GPM Lyrics Solution until crbug/988535 is fixed. Bug: b/138451922 Change-Id: Ic7891995522870c7de8eb0f3975406e76b078a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736805 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#690085}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/659a8ea9f3a9..3367690414ae git log 659a8ea9f3a9..3367690414ae --date=short --no-merges --format='%ad %ae %s' 2019-08-23 dneto@google.com GN build: enable HLSL in Glslang (#789) Created with: gclient setdep -r src/third_party/shaderc/src@3367690414ae The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I93fd65ae2ac50c7cc39ed6047886c952ada87867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768904Reviewed-by:
-
Xing Liu authored
This CL adds a few metrics for user impression updates in notification scheduling system. TBR=dtrainor@chromium.org Bug: 963298 Change-Id: I2707ebec3df1b371e23c2d99eb132a55b7c716aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764322 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#690083}
-
Evan Stade authored
Despite the general-sounding name, this was only sent by ChromeUserManagerImpl after the list of device local accounts changed, or after cleaning up some ephemeral accounts. This changes ChromeUserManagerImpl to use NotifyLocalStateChanged() in those cases. This CL also cleans up the prefs a bit: 1. the pref name "LoggedInUsers" is shared between UserManager and ChromeUserManagerImpl, instead of duplicated. 2. the "PublicAccounts" pref, aka kDeviceLocalAccounts, is renamed and more documentation is added to clarify its use. A test is added to verify that it's functioning as intended. TBR=bartfab@chromium.org Bug: 268984 Change-Id: Id99b6a11e51058c0e0d36fc294846c102abf6b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758938Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#690082}
-
Matt Menke authored
It never really worked in the H2/QUIC case, returning the bogus HTTP/1.1 headers instead, didn't return anything in the cache case, and didn't return anything until a request was actually sent, which could (and did) lead to misuse. Fortunately, with the advent of the NetworkService, it's now only used in tests, so can fairly easily be removed. Bug: 455744 Change-Id: I1bc0c69acbf85409a71faed774c02baefc4f08a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769048Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#690081}
-
