- 16 Aug, 2018 40 commits
-
-
Dominic Mazzoni authored
CanHaveChildren() is called frequently, including from delicate situations like when a LayoutObject is being deleted. Currently it calls NativeAccessibilityRoleIgnoringAria(), which is actually somewhat expensive and calls UpdateDistribution(), and clusterfuzz found a way for that to result in a UAF. The easy solution is just to save the result of NativeAccessibilityRoleIgnoringAria when we initially compute the node's role. Then CanHaveChildren() can just check it directly rather than recomputing it each time. Bug: 852735, 852251 Change-Id: Id745d3b42c1f89434e519195e8511159621734d0 Reviewed-on: https://chromium-review.googlesource.com/1175491 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583726}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3fd614d06e50..6e5bf36ff50f git log 3fd614d06e50..6e5bf36ff50f --date=short --no-merges --format='%ad %ae %s' 2018-08-16 lfy@google.com GLES1: Fixes for Gets() test 2018-08-16 oetuaho@nvidia.com Add error messages for BlitFramebuffer related errors Created with: gclient setdep -r src/third_party/angle@6e5bf36ff50f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If4c838992b5f70151dc9ea2045d98ce889978e82 Reviewed-on: https://chromium-review.googlesource.com/1177982Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583725}
-
Jordy Greenblatt authored
This CL replaces some data types we had thought would be important for displaying the multidevice settings page that wound up being redundant with the data types we will need to receive individual feature updates from the multidevice service. Bug: 824568 Change-Id: I33b70cba332dec8cf7726630ccbf57bcf62b8655 Reviewed-on: https://chromium-review.googlesource.com/1173658 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#583724}
-
Tommy C. Li authored
Query in Omnibox is currently only implemented in Android. This CL moves the feature flag from Android-only to Android+Desktop in preparation for implementing the feature in Desktop as well. Bug: 874592 Change-Id: I7d24289d4fb07467061ae616610d9c58296e73ce Reviewed-on: https://chromium-review.googlesource.com/1176432Reviewed-by:
Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583723}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3e360453cded..5f4cd74d2693 git log 3e360453cded..5f4cd74d2693 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 hnakashima@chromium.org Do not set barcode module width and height in unittest. Created with: gclient setdep -r src/third_party/pdfium@5f4cd74d2693 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia16925d2dd70b3ebbc589270e1c5e8ed3044cb62 Reviewed-on: https://chromium-review.googlesource.com/1177981Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583722}
-
Shakti Sahu authored
Bug: 850577 Change-Id: I2be8c74324aea83f585f2332f8686a2dfd5ff141 Reviewed-on: https://chromium-review.googlesource.com/1174985Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583721}
-
Lei Zhang authored
Change-Id: I73af60b7dd9e95a0f67174dc3348999f867e4a47 Reviewed-on: https://chromium-review.googlesource.com/1176554Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583720}
-
Micah Morton authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c0be499563b8..71adbf6a5686 $ git log c0be49956..71adbf6a5 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 mortonm service_constants: Add constant for IsShillSandboxingEnabled dbus method. Created with: roll-dep src/third_party/cros_system_api Bug: chromium:649417 Change-Id: I749d030144f94ad1e30e6a62eaaf2d45007b5cb7 Reviewed-on: https://chromium-review.googlesource.com/1177883Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Micah Morton <mortonm@chromium.org> Cr-Commit-Position: refs/heads/master@{#583719}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cbd83bbd77d1..cd8689f00427 git log cbd83bbd77d1..cd8689f00427 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3fd614d06e50..f0e3c19a0c02 (1 commits) 2018-08-16 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms f1e2b45d18fa..b2fffd2ecf2e (1 commits) 2018-08-16 reed@google.com add more tests for SkCubicMap 2018-08-16 bungeman@google.com Beautify GlyphTransform sample. Created with: gclient setdep -r src/third_party/skia@cd8689f00427 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ia8adc592d5b6a755abefc85124eb8e38b977e401 Reviewed-on: https://chromium-review.googlesource.com/1178121Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583718}
-
P.Y. Laligand authored
Context: https://fuchsia.googlesource.com/garnet/+/84a4bc12b8613fa2c85c528929a65603fecb3f39 This feature allows us to transition to explicit service sandboxes. Change-Id: I158a3c454f02f6b72565d04bdc5c41e284bca301 Reviewed-on: https://chromium-review.googlesource.com/1178227 Commit-Queue: P.Y. Laligand <pylaligand@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583717}
-
Moe Ahmadi authored
Splits Autofill settings page into two separate pages, one for addresses and the other for credit cards. Bug: 860526 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8f02f93fbd54fc17c2b97e5a97d9d5a08f729197 Reviewed-on: https://chromium-review.googlesource.com/1173314 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#583716}
-
Daniel Zhang authored
Change character limit of folders from 80 to 28. 80 is considered too large. Bug: 869643 Change-Id: I05d88ea55094d9a9d175740c16ed429b1ad5a53b Reviewed-on: https://chromium-review.googlesource.com/1176643Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#583715}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/55f5d91f11f9..d694f0a82b4d $ git log 55f5d91f1..d694f0a82 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 fbarchard Document update for running android apps 2018-08-13 fbarchard ubsan fix for 16 bit scaling 2018-08-08 vapier README: fix doc links 2018-08-06 zhanglixia-hf libyuv:loongson Correct the optimization of mmi on loongson3a platform. 2018-08-10 fbarchard Add H420ToRGB565 and J420ToRGB565 unittests 2018-08-09 chz libyuv: choose matrix for YUV to RGB565 conversion 2018-08-10 phoglund Roll chromium_revision 80f0c557..35b72bf2 (536678:582080) 2018-08-10 phoglund Try reordering buckets to work around gerrit tryjob plugin bug 2018-08-10 phoglund Fix missing brace + incorrect nesting in cq.cfg. 2018-08-09 hinoka [cq.cfg] Flip all builders (except windows) to LUCI 2018-08-09 phoglund Only download Android SDK for android checkouts. 2018-08-08 hinoka Revert "Add a whitespace.txt file" 2018-07-21 martin Restore the file mode for source files 2018-08-03 fbarchard MMI ifdef guards and add source to various build files. 2018-08-02 hinoka Add a whitespace.txt file 2018-07-31 hinoka DEPS: Invoke play services hook with vpython 2018-07-31 hinoka [vpython]: Add pypiwin32 2018-07-04 zhanglixia-hf libyuv:loongson optimize compare/row/scale/rotate files with mmi. Created with: roll-dep src/third_party/libyuv Bug: libyuv:813, libyuv:812, libyuv:811, libyuv:810, libyuv:805, libyuv:796 Change-Id: Ib8ff451fefa7948e1aed2028210dc1147ffcba06 Tested: try bots Reviewed-on: https://chromium-review.googlesource.com/1176552Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#583714}
-
Andres Calderon Jaramillo authored
This CL simplifies VaapiJpegDecodeAccelerator by getting rid of the DecodeRequest struct: all the parameters that used to be in a DecodeRequest are now passed directly to the DecodeTask function. Bug: 874933 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0b09b15e5fd610eb02a9c83d90898e8619ea35af Reviewed-on: https://chromium-review.googlesource.com/1177907 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Asanka Herath authored
The test was calling TestDelegate.RunUntilComplete() after writing some data to a ChunkedUploadDataStream::Writer. However, the final write may itself result in the request being completed. The resulting TestDelegate::OnResponseCompleted() doesn't have a message loop to kill. Therefore, we now create a RunLoop and set the OnResponseCompleted closure so that an early completion will correctly mark the RunLoop as done. Bug: 873851 Change-Id: If67eaa1d141b0b3ee046d428a778106aa2287214 Reviewed-on: https://chromium-review.googlesource.com/1176632Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#583712}
-
Xida Chen authored
This reverts commit b13dc649. Reason for revert: <INSERT REASONING HERE> CL causes the crash has been reverted Original change's description: > Disable OverflowButtonActiveInkDropTest.MouseContextMenu on linux > > TBR=wjmaclean@chromium.org > NOTRY=true > > Bug: 874853 > Change-Id: I4d141e987d48df3ee4b4332c8341e5e5c7883301 > Reviewed-on: https://chromium-review.googlesource.com/1177683 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583631} TBR=xidachen@chromium.org,wjmaclean@chromium.org Change-Id: I29ec3874531c61209ffae57c47451bd822ac1de0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874853 Reviewed-on: https://chromium-review.googlesource.com/1178163Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583711}
-
Xida Chen authored
This reverts commit dd0ab32b. Reason for revert: <INSERT REASONING HERE> CL causes the crash has been reverted Original change's description: > Disable OverflowButtonInkDropTest.MouseContextMenu on linux > > TBR=wjmaclean@chromium.org > NOTRY=true > > Bug: 874853 > Change-Id: I0e28c54f5dfbfa0ae940b48ea5319914e6b49768 > Reviewed-on: https://chromium-review.googlesource.com/1177684 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583634} TBR=xidachen@chromium.org Change-Id: I8d74e83b26a7f89eb7dc11323a8198c848a36fb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874853 Reviewed-on: https://chromium-review.googlesource.com/1178262Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e9721f2f0830..fa2b2d62d77d git log e9721f2f0830..fa2b2d62d77d --date=short --no-merges --format='%ad %ae %s' 2018-08-16 nisse@webrtc.org Delete use of RtpPayloadRegistry. 2018-08-16 titovartem@webrtc.org Do not use FakeNetworkPipe::SetConfig. 2018-08-16 saza@webrtc.org Set AEC2 suppression to high by default 2018-08-16 titovartem@webrtc.org Add FakeNetworkPipe ctor from NetworkSimulationInterface. Created with: gclient setdep -r src/third_party/webrtc@fa2b2d62d77d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifca3f6ef4dc638b0a073006f6d5cad5e49ba8fec Reviewed-on: https://chromium-review.googlesource.com/1177983Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583709}
-
Nasko Oskov authored
This CL is fixing a case where a successful navigation to a regular web URL can commit in the dedicated error page process. It is one of the two ways found to cause renderer process termination described in https://crbug.com/866549. Bug: 866549 Change-Id: If7a49c47feef35b954c67e7f6bd2339641473bf7 Reviewed-on: https://chromium-review.googlesource.com/1165593 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#583708}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874959 Change-Id: I69281d15eeccb236cd8f2c1f31306c3e48224a7b Reviewed-on: https://chromium-review.googlesource.com/1178228Reviewed-by:
-
Kyle Milka authored
As the feature is enabled by default the flag is no longer necessary. The api override url is now never used and is also removed. Bug: 874095 Change-Id: I82a102ba9935b8ab25fa8a986aab9741c8ac8670 Reviewed-on: https://chromium-review.googlesource.com/1174911 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#583706}
-
Charlie Andrews authored
This reverts commit cfdb3952. Reason for revert: Story is still failing Original change's description: > Re-enable load:media:soundcloud for webview on system_health.common_mobile. > > It's passing in perf tryjobs. > > Bug: 787001 > Change-Id: Ie9a74b141d6dd610a1bfab3d9d9ea79b40dafc48 > TBR: tdresser@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1174632 > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582944} NOTRY=true TBR=sullivan@chromium.org Bug: 787001 Change-Id: If734162c4815ec7c1a988343859b80556cce6044 Reviewed-on: https://chromium-review.googlesource.com/1178001 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#583705}
-
Helen Li authored
This CL adds NetLog events to SessionCleanupCookieStore. This is based on rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 Bug: 801910 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I87a89ff265d703792a492f93ce59cb57f9f02d14 Reviewed-on: https://chromium-review.googlesource.com/1175437 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583704}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/937745b81606..fccde774f480 git log 937745b81606..fccde774f480 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 manojgupta@chromium.org Revert "cros_chrome_sdk: Invoke compiler in relative form" Created with: gclient setdep -r src/third_party/chromite@fccde774f480 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I81c80f4ae4ebe264da66ebbccac5e138aabc22e6 Reviewed-on: https://chromium-review.googlesource.com/1177984Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583703}
-
Martin Šrámek authored
...to match the Incognito NTP background color. Bug: 865786 Change-Id: I87c1ea80b8405c5003f4085f71019af925617f09 Reviewed-on: https://chromium-review.googlesource.com/1177395Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583702}
-
Xianzhu Wang authored
- Disable under-invalidation checking for the test. Animated svg sometimes fail under-invalidation checking because the forced paint by under-invalidation-checking may paint differently based on the current timer, while without under-invalidation-checking we still get image changed notification which will cause needed paint invalidation. We have already disabled under-invalidation checking in similar cases. Not sure why the test succeeded without blink-gen-property-trees, but the test does run normally in content_shell with --enable-blink-gen-property-trees. - Modify the test to test raster invalidations instead of object invalidations (which was removed in crrev.com/582462), and ensure that the reference image is invalidated after animation is advanced. Bug: 854196 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7d00d61d15cb6172e216793c14a0b29b9d56be1b Reviewed-on: https://chromium-review.googlesource.com/1176435Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583701}
-
Evan Stade authored
Only needed one small tweak to BrowserNonClientFrameViewAsh. Bug: 854704 Change-Id: Ib6536580a84bf4035279512f2e6c22c31d4cdabd Reviewed-on: https://chromium-review.googlesource.com/1176427Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#583700}
-
Denis Kuznetsov authored
Bug: 864455 Change-Id: I93548d73dcf82590bb31ad884d6af436c91e3159 Reviewed-on: https://chromium-review.googlesource.com/1167845Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#583699}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874954 Change-Id: I197eddaa975cca5edb0db359fc44c127e6d64fec Reviewed-on: https://chromium-review.googlesource.com/1178113Reviewed-by:
-
Florent Castelli authored
Bug: 787254 Change-Id: I44dd447f8799a4b1ff45da609112e46294e89747 Reviewed-on: https://chromium-review.googlesource.com/1175919 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#583697}
-
Xiaoqian Dai authored
When dragging a window from caption area in tablet mode, overview will open behind the dragged windows. When the dragged window is dragged into the preview split area, we should update the overview grid's bounds and also update the new selector item's visibility. See recorded video: https://drive.google.com/open?id=10gPVG1Wlgt4YDnZI_tPS2p6JJGYJ-ztl Bug: 873292 Change-Id: Ibc7028820bed11d61bdbb376fdc6723c26a0c262 Reviewed-on: https://chromium-review.googlesource.com/1176220 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#583696}
-
Anders Hartvoll Ruud authored
In StyleValueToCSSValue, when checking whether a certain CSSStyleValue matches the property in question, we now ask the registration (via CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw a TypeError like for normal properties. If it does match, the CSSStyleValue is stringified, tokenized, and set on the style rule as tokens. I have postponed support for <color> and <transform-function>, because CSSUnsupportedStyleValue currently does not handle registered custom properties at all. This is appropriate to fix in a separate CL. Note that, because the string version of StylePropertyMap.set also uses StyleValueToCSSValue, it will no longer be possible to set registered custom properties with a string--even if the syntax is matched. A subsequent CL will fix this. R=futhark@chromium.org Bug: 641877 Change-Id: Ie0cc2f87e39f8f59015824bfd1b81efaf402c326 Reviewed-on: https://chromium-review.googlesource.com/1175822 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#583695}
-
Katie D authored
This makes it possible to read content in menus with the Select-to-Speak tray button, for example on tablet mode. Bug: 870922 Change-Id: I3501625721c8d49a2ec422377a83b9f8f036b228 Reviewed-on: https://chromium-review.googlesource.com/1176181 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#583694}
-
Kyle Horimoto authored
This change was suggested by our UX string writer, jonann@. Bug: 872982 Change-Id: I179d7e8b7abb25db822f1828d5364731a38104e0 Reviewed-on: https://chromium-review.googlesource.com/1176822Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#583693}
-
Anders Hartvoll Ruud authored
In order to implement interpolation types for custom property lists (issue 868959), it is needed to pass along additional state to these callbacks. Hence, regular function pointers are not enough. In preparation of that, this CL changes the function pointers to base:: RepeatingCallbacks. R=flackr@chromium.org Bug: 868959 Change-Id: Ic6214d4119af69c9bc1b87a9fdc63c05ea33e05f Reviewed-on: https://chromium-review.googlesource.com/1165545Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#583692}
-
John Delaney authored
Send data use updates per resource from renderer to browser. This will allow the browser process to aggregate per-resource information and will keep feature specific logic out of core PageLoadMetrics code. Bug: 873746,851543 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I34a617c8f1212d9d9ec157de16d65379340b1697 Reviewed-on: https://chromium-review.googlesource.com/1164222 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583691}
-
Elad Alon authored
Bug: 775415 Change-Id: I24a08a3d000a5d06d2ada6a68a8d9245523ab538 Reviewed-on: https://chromium-review.googlesource.com/1177758Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#583690}
-
Sammie Quon authored
It is now black when there is a maximized window. Test: added test Bug: 850630 Change-Id: I8ea09cdc0196f2f52fe26eae63f823ca46450100 Reviewed-on: https://chromium-review.googlesource.com/1176832Reviewed-by:
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874946 Change-Id: I21c44dc3e423f28012eb0459b1b1302bfcf47b3f Reviewed-on: https://chromium-review.googlesource.com/1178106Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: If72184b571a5d550e321bf8568523a16c9fb35f0 Reviewed-on: https://chromium-review.googlesource.com/1177603 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
