GitLab

The tests are flaky across multiple buiders. While the underlying issues
are investigated, let's disable them all.

TBR=mmoskvitin@chromium.org

Bug: 1012222,1012223,1009372
Change-Id: I0375dc684547d3fd927521f25898bd26514f4723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883647
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709855}

In order to remove the WebContextMenuData dependency from chrome/browser
we need to extract all the data types used in c/b from
web_context_menu_data.h and move them to different files under
third_party/blink/public/common.

This is the first step of those migrations. We took the chance to
convert the WebContextMenuData::MediaType into a strongly typed enum
class. In order to keep the amount of changes under control we are
adding an alias (using MediaType = ContextMenuDataMediaType) to the
new structure so that no additional changes are required. A follow up
patch will remove that alias and perform the renames.

Bug: 1014517
Change-Id: I33a351a81eec1e0a7c09d783859f8078a5355778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866520Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709854}

Change-Id: I8cb125cf9ee2d2f72ba22f498248dd5fa6fd5c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865334
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709853}

ExceptionCacheFake class don't have dependencies in chrome/ and can be
useful in tests in extensions/.

Bug: 1015817
Change-Id: I91613840fa5c6f5cc2543157be3ef11997aadaea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879262Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709852}

Before this patch, all potential direct actions were reported
unconditionally. The fetch_website_actions direct action is only
required to bring up the AA stack and fetch/check for scripts once.
This patch ties this filtering to the controller being up and ready and
the first round of scripts has been checked for matching preconditions.

This will give external callers a better signal as to when AA is up to
date and when it needs to be setup first before being able to execute
actions.

Bug: b/138833619
Change-Id: I8acb0c7ea7937a0cbafe1462e92251c29153b818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879911
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709851}

Tests using BackgroundFetchDataManagerTest::MatchCache inadvetantly held
files in the profile dir open beyond the lifetime of the test function,
inhibiting ScopedTempDir's ability to clean them up during
TestBrowserContext destruction. This change causes MatchCache to wait
until the main RunLoop goes idle, thereby allowing for residual tasks to
be posted and run upon destruction of the response given to
DidMatchCache.

BUG=546640,1016662

Change-Id: I4e2a989ec2b744b61b75e3ba2d09270c0eab3c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882310Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709850}

Adds CrostiniAnsiblePlaybook cloud user external policy that allows to
specify Ansible playbook file that should be uploaded to default
Crostini container during container startup.

Based on: https://crrev.com/c/1800310

Bug: 973793
Change-Id: I756e1e6ff12a14830c19170c723587b95ce30a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872061
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709849}

This reenable:
 - SignedExchangeRequestHandlerBrowserTest.Simple
 - SignedExchangeRequestHandlerBrowserTest.VariantMatch

Histograms in this file are recorded when the RenderFrameHost is
deleted. This is triggered by a navigation. The problem is that the
deletion is never synchronous and the test wasn't waiting for this.

To fix this, wait for any RenderFrameHost to be deleted before checking
the histograms.

Along the way, flush the BackForwardCache to release the remaining
RenderFrameHost

Bug: 1016865, 965925
Change-Id: Icc0c26baf9b0e0d7f539eec1ed1e53f1e0d49ce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878770Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709848}

root output directory is actually located.

The existing fixed paths assumed the out dir is located in the chromium
src directory. Downstream projects may have their out directory located
elsewhere, for example in the chromium src dir's parent dir.

This CL calculates the relative path between the out directory and the
tool base directory, and uses that to generate the paths in the
dependency notes.

Change-Id: Ie584c3133baeaba1f2b18225a9a7e6501fce6dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879457
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709847}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/c20eb36aa7..77f2a9d8d6

TBR=aerotwist@chromium.org

Change-Id: Idb841a0cbca580699afc971ef0ebcb84661c4226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882315Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709846}

There is no longer content/browser/loader/upload_data_stream_builder.cc
since r682406.

Change-Id: I85825d2d040a3d6d9a452847069fa25253054d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880501Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709845}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be638514..e4fd34ae

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4ef4046eb0d6388078ea76a32291556f0dca29f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882936Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709844}

This CL converts URLLoaderFactory from //androdi_webview,
// chromecast, //components, //google_apis, //ios, and
// storage to new Mojo types using PendingRemote and Remote.

With this CL, URLLoaderFactory is fully converted to new
Mojo types.

Bug: 955171
Change-Id: Id1d7d75cfc8ecc99fde7ee8449d1d25993702ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872050
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709843}

The network annotation contained a special description for ChromeOS that
is no longer accurate since Unity launch in M78.

Bug: 951781
Change-Id: I56dffbd46cc0bdf8084e6e48e202c82faace726c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816541Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709842}

This also adds the definition of the os-specific path beneath which
crash dumps should be stored.

Change-Id: I500d9e0fef2844550c62dfe6a7e71bddf786f2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879261
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709841}

This is the second CL of several breaking crrev.com/c/1860025 into smaller
chunks.

Change the various classes and tests in ui/first_run/ to accept a Browser
where before they accepted a BrowserState. Spurious use of, and dependency
on, TabModel is also removed.

Change-Id: I961a684231d78036881084be0222d56787a55e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863017
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709840}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a8c4e3a48ffd..c5f1be68e3ff

git log a8c4e3a48ffd..c5f1be68e3ff --date=short --no-merges --format='%ad %ae %s'
2019-10-28 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@c5f1be68e3ff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iae99589d8abefd835ece32e87a07ca93063f9e47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883065Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709839}

During SAML flow, we might get extra information about when the
password expires from the SAML IdP, which we store so we can then
warn the user when their password expires.

However, this information is no longer relevant - and will never
be updated by the SAML IdP - if the user no longer uses SAML to log
in. In that, case, we should simply delete it.

We should also delete it if the feature that uses it is turned off -
if an admin decides this feature is not useful to them and turns it
off, then we should clear the data. Later if they decide to try and
out the feature again, they shouldn't need to worry about data
reappearing that has been stored since last time they had the
feature enabled - that data could be very stale since it will not
have been kept up to date. Stale data can lead to spurious
password-expiry notifications.

Bug: 930109
Change-Id: Ia2f6abba306adea8b64a5f756579826ded8ffc16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866750Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709838}

The factory doesn't do anything at the moment, but I'm going to move
downstream over to use this method before further changes.

Bug: 1018672
Change-Id: I35092af3d0659733eca3587d33ef064c49ca4f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881166Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709837}

This CL fixes the disabled BookmarkPersonalizedSigninPromoTest
related to launching SigninActivity in different scenarios. A
SigninActivityLauncher is created to setup the intent and
launch the SigninActivity with different account settings.

Bug: 789531
Change-Id: I09ff0419fb268b2482984c3d0bd3c5cb3227860a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868878Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709836}

The name PasswordGenerationState is kinda misleading. The class does
more than keeping the state of the generation. It also modifies the
underlying password store.

Change-Id: If21a78b11268fe7a4a2d2c8adea9c769bb4351f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882311Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709835}

This CL restricts the concatenation of the Gaia email and the local profile name
to Chrome instances with kProfileMenuRevamp enabled. This should simplify
the finch configuration for rolling out the profile menu revamp and at the same
time reduce the risk as users using the old profile menu will not be affected
by the profile name being the concatenation of the Gaia email and the local
profile name.

Bug: 1018202

Change-Id: I4c28dba17e2c3d8e13b2efeeedcd788909f550e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879291Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709834}

Introduces ease-to-use APIs to ExtendedAttributes.

Bug: 839389
Change-Id: I8f23ec9f9d6b7dddb9b17720ed2963e16fbd8cf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882252Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709833}

Before this patch the direct action list_assistant_action was used to
start autofill assistant and to return available actions. That is
misleading and this patch disconnects that by renaming
list_assistant_action to fetch_website_actions and return a success
bool instead of a list of actions.

Out of scope for this patch: the next step will be to tie the
availability of the fetch_website_actions action to controller state
and to remove perform_assistant_action entirely.

Bug: b/138833619
Change-Id: I279e5bc2e6d13a48151d5c161483a2b9662dd940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873752
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709832}

https://webrtc.googlesource.com/src.git/+log/e38e11986f00..c189ace20a43

git log e38e11986f00..c189ace20a43 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 04c3c4c8..d68d92fb (709704:709806)

Created with:
  gclient setdep -r src/third_party/webrtc@c189ace20a43

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Id48fa26113d190e49da2854a64b222949d604b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883060Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709831}

https://chromium.googlesource.com/angle/angle.git/+log/95a736bd3347..076f869ce5ac

git log 95a736bd3347..076f869ce5ac --date=short --no-merges --format='%ad %ae %s'
2019-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src b34fa731931b..ec12de913124 (2 commits)

Created with:
  gclient setdep -r src/third_party/angle@076f869ce5ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:None
Change-Id: I6e247ee432f54a85246564a13c3bd06f8ad75f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709830}

Bug: 839389
Change-Id: I3132a118c708a85cb193379b147f8f09bf8564e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882247Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709829}

This patch chagnes |ComputeNGLocal{Caret,Selection}Rect()| to utilize
|NGInlineCursor| instead of |NGPaintFragment| for prepration of migrating
|NGFragmentItem|.

Bug: 982194
Change-Id: I040c946dd405237e145af4702669304eecfe34ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877505
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709828}

This is (1) in
https://docs.google.com/document/d/1sMG4xAT-myWtFaNa0kuLjRqsyxSy12ahgRIbffy1Bxk/.

Bug: 1018050
Change-Id: I52536cb0e97ac3c60da30a946a30ee005b1a861d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880892
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709827}

The case, CreateTasksForOffTheRecordProfile, becomes flaky recently and has
been disabled on asan.

This patch enables it again by cleaning up the default browser before
the test is going to start.

Bug: 1016901
Change-Id: I52ddb58956a881409c70bb21132db066d271809f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880536Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#709826}

This patch gets rid of unused function |ClosestLeafChildForPoint()| in
|NGPhysicalLineBoxFragment| for improving code health.

This patch is follow-up of the patch[1] which gets rid of clients of
|ClosestLeafChildForPoint()|.

[1] http://crrev.com/c/1875856 Introduce NGInlineCursor version of
ClosestLeafChildForPoint() for AbstractLineBox

Change-Id: Ia626b7e77ac415c6d2164072b50f3b34fcbe6b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877874
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709825}

https://skia.googlesource.com/skia.git/+log/01b1f63d641b..428b5de64a08

git log 01b1f63d641b..428b5de64a08 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77fba58c9658..95a736bd3347 (17 commits)

Created with:
  gclient setdep -r src/third_party/skia@428b5de64a08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:None
Change-Id: Ibe66e17f8c6a4b1175cddd4d4de65a5441b7e86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883388Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709824}

Adds an error marker that can be used on summary panel items to indicate
that there are error panel items in the collapsed summary view.

Note, this is just the implementation of the error marker itself, follow
up CL will add usage of them.

Includes unit test for the error marker.

Bug: 1014771
Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel
Change-Id: I86698cb97fc0f7af19ac2177e8781873e3d21776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882196Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709823}

During shutdown of JankMonitor, when the monitor timer is fired after
MetricSource has shut down, the timer dereferences the null pointer and
crashes. Fix the crash by nulling out the pointers after the monitor
timer shut down.

Bug: 1015425
Test: JankMonitorShutdownTest.ShutdownRace_TimerFired
Change-Id: Icd9073e4527e0ac01c373fe486d88aa0985a5841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868772
Commit-Queue: Chinglin Yu <chinglinyu@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709822}

This patch fixes ellipsis by implementing IsHiddenForPaint().

Fixes ~50 failures.

Bug: 982194
Change-Id: Icabef1450f9c80132cd56db55d0ab73ad72c8ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880894Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709821}

Now that the "python_script" backend is stable, there's no huge
incentive to keep maintaining the "clang_tool"
backend. win-annotator-rel started getting compilation errors with
clang_tool recently [1], so we might as well disable it.

At the same time, this will make the waterfall bot run much faster,
which should reduce the rate of task timeouts on Windows.

[1] https://ci.chromium.org/p/chromium/builders/ci/win-annotator-rel/1917

Bug: 909867
Change-Id: Ib52cac4a32a41fe11da13fbee2ce85a2b1947c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881307
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709820}

This reverts commit 538de13d.

Reason for revert: Causing flaky failures (https://crbug.com/1018097)

Original change's description:
> [PM] Freeze Origin Trial - Remove the unknown state
> 
> Most frames won't set a freeze origin trial policy and so making
> kDefault the default state when a frame gets created will reduce the
> number of IPC calls. This could cause pages to be frozen before all
> their frames have reported their policy, a following CL will unfreeze
> frozen pages that receive an opt-out OT token.
> 
> Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#708808}

TBR=fdoray@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,masonfreed@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic0208aa6045e0e65aef59f8103688865ddb63de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882203Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709819}

I found a setter of block_mixed_plugin_content is not called from anywhere so
removed the param as preparation of Loader's Onion Soup.

Bug: 860403
Change-Id: I2a47e70f7c551727d918888977548142214b1725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883349Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709818}

These are passing on bot-run:
- linux - https://chromium-swarm.appspot.com/task?id=4829cfd28750da10
- android - https://chromium-swarm.appspot.com/task?id=4829d1fa07219910

Bug: 1007276
Change-Id: Id2d577a4bd0d87b89afe767dea0faab7a91e18f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883428Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709817}

Change-Id: I26af9df08105a4c8d6f8c25baac4cf87f2076d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880498
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Julian Watson <juwa@google.com>
Reviewed-by: Julian Watson <juwa@google.com>
Reviewed-by: Ben Wells <benwells@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709816}