GitLab

Fails flakily.

BUG=359204
NOTRY=true
NOTREECHECKS=true
TBR=dmazzoni

Review URL: https://codereview.chromium.org/315583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274489 0039d316-1c4b-4281-b951-d872f2087c98

The viewport tag makes the test fail for unknown reasons on just one
bot: win7-nvidia-release.

BUG=368495

Review URL: https://codereview.chromium.org/313513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274488 0039d316-1c4b-4281-b951-d872f2087c98

Resized the icon in the Uninstall dialog to be 64x64 px instead of
69x69px, so that it matches the icon in the App Info dialog where
it can be launched. This also removes fuzzing effects on icons
that have to be resized from 64x64 icons.
Also fixed the duplication of this constant by letting the view
resize the icon it receives, rather than having it request one size of
icon and then resize it a second time.

[Mac] XIB change:
  - Resized the icon in the Install dialogs from 69x69 to 64x64

Screenshots on bug.

BUG=379613

Review URL: https://codereview.chromium.org/301063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274487 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=378588

Review URL: https://codereview.chromium.org/309443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274486 0039d316-1c4b-4281-b951-d872f2087c98

The existing implementation in fact does not check whether the file is
writable or not (see below for the detail.)
Since the current behavior itself is fine for the use cases,
this CL renames the relevant functions, and refactors the implementation
so that the intent is clearer.

Existing implementation tries to open a file with CREATE|READ|WRITE flags
and verifies that the result is either FILE_OK or ALREADY_EXISTS.

This _succeeds_ when read-only file already existed at the location
because ALREADY_EXISTS error precedes write failure.
Considering the fact, it is essentially equivalent to open with OPEN_ALWAYS|READ
and comparing the result just against FILE_OK.

BUG=367028

Review URL: https://codereview.chromium.org/306073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274485 0039d316-1c4b-4281-b951-d872f2087c98

Did not see any problems running these two tests locally for a few
hours.

BUG=355952
TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/302313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379037

Review URL: https://codereview.chromium.org/307943009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274483 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 6cff678a.

The tests should have been fixed with these CLs:
https://codereview.chromium.org/310493002/
https://codereview.chromium.org/302153003/

BUG=chromium:379140
NOTRY=true
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/304153017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274482 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds browser tests for the new gallery.
The tests are run in the Gallery extension directly as following steps.

1. The test extension contains test cases are loaded by C++.
2. The test extension send a message to the Gallery.app.
3. Gallery.app loads a test from the test extension.

BUG=374709
TEST=run the added test.

Review URL: https://codereview.chromium.org/304683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274481 0039d316-1c4b-4281-b951-d872f2087c98

[IME] Remove the flag g_use_wrapped_extension_keyboard_layouts, and clean up the scattered & hard-coded extension IDs.

BUG=379437,379449
TEST=None

Review URL: https://codereview.chromium.org/309623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274480 0039d316-1c4b-4281-b951-d872f2087c98

Fragments (e.g. "#hoge") in document url should be stripped before it's passed
to the SW because it's not necessary to match registrations.


BUG=379048
TEST=manual (open a controlled page whose URL contains fragments)

Review URL: https://codereview.chromium.org/308053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046

Review URL: https://codereview.chromium.org/306053013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274478 0039d316-1c4b-4281-b951-d872f2087c98

ServiceWorkerDispatcher used to mint new WebServiceWorkerImpl
instances every time it was passed a representation of a Service
Worker. Ultimately, this causes user script to see distinct objects
representing the same Service Worker, which is Confusing and
Wrong. This patch makes ServiceWorkerDispatcher use its table of
existing WebServiceWorkerImpls to consistently represent a
ServiceWorker with the same object.

A chunk of this patch is concerned with making it explicit when a
ServiceWorkerHandleReference, which a WebServiceWorkerImpl wraps, is
being created in the renderer (and should send an add-ref message to
the browser) versus being adopted in the renderer.

BUG=361907
TEST=ServiceWorker*

Review URL: https://codereview.chromium.org/309503014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378338

Review URL: https://codereview.chromium.org/301353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274476 0039d316-1c4b-4281-b951-d872f2087c98

1) Fix Namespace comment in admin_policy.h
2) Mark explicit to single-argument constructors in file_highlighter.h
   and test_extensions_browser_client.h
3) Use CHECK_GT instead of CHECK in process_manager.cc

BUG=

Review URL: https://codereview.chromium.org/308913006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369703

Review URL: https://codereview.chromium.org/301353011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274474 0039d316-1c4b-4281-b951-d872f2087c98

This change moves the check of PTS & DTS >= time 0 to after any
append window filtering, as one approach for allowing full preroll
buffer discard without requiring apps start play somewhere other
than time 0.

R=acolwell@chromium.org,dalecurtis@chromium.org
BUG=377059
TEST=No regression, new test added

Review URL: https://codereview.chromium.org/294393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274473 0039d316-1c4b-4281-b951-d872f2087c98

This fixes 2 minor start warnings:
* On platforms that have no remapKeys, we used to report a 'bad remapKey'
  warning.
* If there are no hostsettings, then we used to report a 'Not an object'
  warning when trying to load the host settings.

Review URL: https://codereview.chromium.org/305393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274472 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vrk@chromium.org,jam@chromium.org
BUG=363459

Review URL: https://codereview.chromium.org/305363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274471 0039d316-1c4b-4281-b951-d872f2087c98

- PlayerTracker interface can be used by any CDM that needs to track media
  players. It can notify media players of new abailable key (to resume playback)
  or the destruction of the CDM.
- PlayerTrackerImpl is a simple implementation of PlayerTracker that can help
  any CDM to implement PlayerTracker interface.
- BrowserCdm is a common CDM interface for browser side CDMs.
- CdmFactory is renamed to BrowserCdmFactory.
- Now BrowserMediaPlayer only needs to call SetCdm() on the player and do not
  need to track CDM <-> player mapping.

TBR=damienv@chromium.org
BUG=373327
TEST=Existing test pages still work.

Review URL: https://codereview.chromium.org/308073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274470 0039d316-1c4b-4281-b951-d872f2087c98

The new test page uses the viewport tag which makes it easy to sample
pixels from the screenshot. Adding the viewport tag to pixel_css3d page
which is also used for pixel tests because it starts to fail due to
unknown reasons on random bots.

BUG=368495

Review URL: https://codereview.chromium.org/302003015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274469 0039d316-1c4b-4281-b951-d872f2087c98

This change ignores Blink's signalling of whether or not to use
LegacyFrameProcessor, and instead always uses the new, compliant,
FrameProcessor to handle SourceBuffer coded frame processing.

R=acolwell@chromium.org
TEST=Linux Debug: no media_unittest or MSE layout test regression; Linux Release with proprietary codecs: no regression of yt-dash-mse-test ToT
BUG=249422

Review URL: https://codereview.chromium.org/307263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274468 0039d316-1c4b-4281-b951-d872f2087c98

By destroying the reply message, the already-copied-out right will be unrefed
again, leading to an over-release of send rights.

This also requires that Rule(POLICY_SUBSTITUTE_PORT) users provide a send right
that can be duplicated with MACH_MSG_TYPE_COPY_SEND, rather than using MAKE_SEND.

BUG=367863
R=mark@chromium.org

Review URL: https://codereview.chromium.org/306123012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274467 0039d316-1c4b-4281-b951-d872f2087c98

alternate-protocol state is unknown.

BUG=379732

Review URL: https://codereview.chromium.org/309063010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378084,245025

Review URL: https://codereview.chromium.org/308183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274465 0039d316-1c4b-4281-b951-d872f2087c98

Creates a new media/cast/receiver directory, and consolidates all code
in media/cast/audio_receiver and media/cast/video_receiver, and some
modules from media/cast/rtp_receiver into one place.

Removed FrameReceiver proxy interface in cast_receiver.h, since there
are no special threading/lifecycle concerns.  Clients will directly call
methods in the CastReceiver interface to request frames on the MAIN
thread.

BUG=378568

Review URL: https://codereview.chromium.org/308043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/299333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274463 0039d316-1c4b-4281-b951-d872f2087c98

OverscrollController is currently only used by Aura, and there are no plans to
adopt it on other platforms.  As such, move it to RenderWidgetHostViewAura,
simplifying both RenderWidgetHostImpl and InputRouterImpl.  This move should not
affect overscroll behavior on Aura (particularly, ChromeOS) in any way.

BUG=306133

Review URL: https://codereview.chromium.org/291003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274462 0039d316-1c4b-4281-b951-d872f2087c98

Improve the verification routines especially in the case that no count
is necessary.

Also add a test.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273936

Review URL: https://codereview.chromium.org/304303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None 
CID=111426

Review URL: https://codereview.chromium.org/303393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323265

Review URL: https://codereview.chromium.org/308963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274459 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None 
CID=115567

Review URL: https://codereview.chromium.org/301243020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274458 0039d316-1c4b-4281-b951-d872f2087c98

Fingers crossed, hopefully all known bugs are fixed.

BUG=356073,371633,369204
TEST=new unittest.

Review URL: https://codereview.chromium.org/278673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274457 0039d316-1c4b-4281-b951-d872f2087c98

R=rsleevi@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/303133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274456 0039d316-1c4b-4281-b951-d872f2087c98

Ensuring that QUIC's pacing sender can have TimeUntilSend called
multiple times and behave return the same time to send.

Also add more tests to ensure the pacing sender properly makes up for
lost time, but stops doing so after application limited sending.

Merge internal change: 68257669
https://codereview.chromium.org/312573002/


Drop "Interface" from name of QUIC debug interfaces that should not be
abstract.

Drop Interface from some class names.

Merge internal change: 68257565
https://codereview.chromium.org/310693002/


QUIC flow control now based on highest received byte offset rather than
bytes buffered. No longer keep track of how many bytes we have buffered
in the QUIC flow controller - this adds complexity when we can just
track the highest received byte offset. This allows us to detect flow
control violation earlier.

QUIC flow control now based on highest received byte offset rather than
bytes buffered. Protected behind (already ENABLEd)
FLAGS_enable_quic_stream_flow_control_2

Merge internal change: 68200399
https://codereview.chromium.org/305033011/


Changes the pacing sender's alarm granularity from 1 microsecond to 5
milliseconds.

Merge internal change: 68197640
https://codereview.chromium.org/302283004/


Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always
try sending a WINDOW_UPDATE from inside AddBytesConsumed. Whenever
bytes_consumed changes we may want to send a WINDOW_UPDATE, and this CL
prevents future users calling AddBytesConsumed and forgetting
MaybeSendWindowUpdate.

QUIC: remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream

Merge internal change: 68188106
https://codereview.chromium.org/308363002/


Remove the TransmissionType argument from QuicConnection CanWrite and
SentPacketManager TimeUntilSend by generalizing the
QuicSentPackeManager's TLP alarm.

Merge internal change: 68148420
https://codereview.chromium.org/306013009/


Cleanup in QuicConnection to always cancel the send alarm when CanWrite
is consulted and use CanWrite when deciding to send in response to a
packet receipt.

Merge internal change: 68118973
https://codereview.chromium.org/304293009/


Allow QUIC's BBR congestion control to be negotiated in the crypto
handshake.

Adding an implementation of QuicFixedTagVector to QuicConfig to enable
multiple congestion control options per connection.

Merge internal change: 68114869
https://codereview.chromium.org/308273004/


Move test-only method from QuicFramer to quic_test_utils.

Merge internal change: 68110215
https://codereview.chromium.org/305343002/


Replaced options from QuicPacketCreator with members and explicit
getters/setters. A couple of small bugs fixed.

Merge internal change: 68099048
https://codereview.chromium.org/301173007/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/312553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274455 0039d316-1c4b-4281-b951-d872f2087c98

Fix aria warnings for the same controls.


Reset margin input controls error state when error is cleared. Fix aria warnings for the same controls.

BUG=354340

Review URL: https://codereview.chromium.org/308943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/301243019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369848

Review URL: https://codereview.chromium.org/294043017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380082
TBR=kaznacheev
R=kaznacheev
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/314643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274451 0039d316-1c4b-4281-b951-d872f2087c98

Multi-sided patch: 
1/3: blink-side, https://codereview.chromium.org/304053003/
2/3: chromium-side, THIS PATCH
3/3: blink-side, cleanup Not Yet.

BUG=377373

Review URL: https://codereview.chromium.org/305893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274450 0039d316-1c4b-4281-b951-d872f2087c98