- 27 Jan, 2020 40 commits
-
-
Sasha McIntosh authored
Allow overdraw tracing even when no stencil buffer is present. This allows overdraw tracing to be enabled anytime ARB_occlusion_query is available. This change impacts the value viz.overdraw metrics when there is 5x overdraw or more. Previously, 4x or more overdraw was always measured as 4 times the overdraw area. eg. the maximum value is 4x the surface area. We now measure the total pixels drawn which can exceed this value. Change-Id: Ide261ddf8f08c3a66fb143bbe8cf1ef33f450d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015588 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#735521}
-
Joe Downing authored
TBR: mseaborn@chromium.org Bug: 1046044 Change-Id: I65fef5989be8ee468d67bee7c48887ed56af6e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023228Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735520}
-
Maksim Ivanov authored
Trigger the a11y alert that reads the "Couldn’t recognize your smart card" message when the challenge-response login (a.k.a. smart card login) fails. Bug: 1004449 Test: add a smart card user onto Chromebook, remove the smart card, enable screen reader, click "Start" ("->"), check that "Couldn’t recognize your smart card" is read Change-Id: Iea19f5d8a3dd00adb1729d4c32879e1d3678890a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022952Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#735519}
-
Daniel Rubery authored
This CL adds the histogram SBClientPhishing.ClassifierNotReadyReason which records the model status whenever the classification fails because the model is not ready. This can be used to distinguish between the model not being ready due to a cold start (the model isn't fetched until a short delay after startup) and the model not being ready due to fetch failures. Change-Id: Ie131f8ef20e7b407631f1ab57033f902e176d186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016355Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#735518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0aa48cc1dec7..1248b8ef4a7b git log 0aa48cc1dec7..1248b8ef4a7b --date=short --first-parent --format='%ad %ae %s' 2020-01-27 pkasting@chromium.org Fix a python invocation that wasn't replaced with vpython. Created with: gclient setdep -r src/third_party/depot_tools@1248b8ef4a7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ice80ffc245f2646e4e6b3971b6515bb2072f9608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735517}
-
Albert J. Wong authored
Bug: none Change-Id: Iea9f7ed62af0dc08b18f0d8f6cce61547c64ee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023351 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#735516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9cbb2b2c66b..3a053d8d7edc Created with: gclient setdep -r src-internal@3a053d8d7edc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010717,chromium:1044158 Tbr: jbudorick@google.com Change-Id: Ifefa056b76dab72a57c7c6936bf99d964cb89c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735515}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ec76b32. With Chromium commits locally applied on WPT: d020e0b0 "Use assert_precondition on LayoutInstability and EventTiming" 584db3f5 "Implement onremove event for web animations." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I54f18f735da7b4175e3d751b5547f4de236bfbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021347Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735514}
-
sczs authored
Bug: 916160 Change-Id: I5e09837a97b4f8f00df18bfdf89c994f842fc69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008150 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735513}
-
Austin Orion authored
These tests open a new tab and immediately navigate to a different URL. The problem is that chrome::AddTabAt by default opens the new tab to the NTP, which takes a considerable amount of time to load. By specifying that the new tab should open to the about:blank page instead of the NTP I observed a decrease in execution time of up to 4 seconds for some of these tests. Change-Id: Ife413d2d102610012ff509a712fbfb39314d0f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019805Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735512}
-
Sigurdur Asgeirsson authored
Also CHECK on the result of setting the quota on the message pipe, as well as on the set quota on query. Bug: 1011441 Change-Id: If256de260ede9613b84296cc8edc0277bfba57ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022926 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#735511}
-
David Van Cleve authored
This is a partial revert of r715320, which changed URLPattern::MatchesURL to decline to match all invalid (!GURL::is_valid) URLs. This was an inadvertent behavior change; it wasn't clear what the intended behavior was in this case. Reverting this seems to resolve crbug.com/1041880, a bug involving some PDF loads from blob: URLs getting stuck as gray boxes. While r715320 was originally made to resolve a crash---namely, MatchesURL would crash on URLs with empty paths---the follow-up commit r718423 adds logic that will still suffice to prevent this crash (this is tested by ExtensionURLPatternTest.WildcardMatchesPathlessUrl and ExtensionURLPatternTest.NonwildcardDoesntMatchPathlessUrl). Changes: - URLPattern: revert the behavior change and update documentation to reflect that intended behavior is actually to allow the wildcard '<all_urls>' pattern to match invalid URLs - URLPattern tests: update to reflect the intended new behavior Bug: 1041880 R=devlin Change-Id: I4f4571c70d0f0dbd7b52cdadbf96a7ea6854cfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022251Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735510}
-
Joe Downing authored
This reverts commit 9da458ed. Reason for revert: Appears to have caused a buildbreak on win-archive-rel bot: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/10166 Original change's description: > Manually roll src/third_party/perfetto 0dace75a3e64..08a30f8552a1 (8 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/0dace75a3e64..08a30f8552a1 > > git log 0dace75a3e64..08a30f8552a1 --date=short --first-parent --format='%ad %ae %s' > 2020-01-27 eseckler@google.com Merge "build: add src/tracing/ipc/service to Chrome's libperfetto" > 2020-01-27 treehugger-gerrit@google.com Merge "traced_perf: re-enable linux build + add x86 regs handling" > 2020-01-27 fmayer@google.com Merge "Fix StackProfileTracker for empty callstack." > 2020-01-27 primiano@google.com Speculatively fix chromium roll > 2020-01-27 primiano@google.com Roll clang, libcxx and fuzzer > 2020-01-27 primiano@google.com Update GN and mass reformat gn files > 2020-01-27 primiano@google.com Merge "GN: clean up build files, split ipc client/service" > 2020-01-27 taylori@google.com Merge "perfetto-ui: Fix canvas limit px" > > Created with: > gclient setdep -r src/third_party/perfetto@08a30f8552a1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Change-Id: Ib610f52351d8b97a7a9f80f7c492e5a67b060c55 > Tbr: perfetto-bugs@google.com > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022646 > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Primiano Tucci <primiano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735490} TBR=primiano@chromium.org,eseckler@chromium.org Change-Id: I8de9e0549e3b7d6b22854e0e9da865a6145ea31c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023230Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735509}
-
Kevin Marshall authored
Removes chromium.far from CIPD distribution, now the downstream consumers have fully migrated to using "web_engine.far" instead. TBR=sergeyu@chromium.org Bug: 1029180 Change-Id: I2f80b641e20b7c06ec17ea7de27501d3a4eb1012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008273Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#735508}
-
sczs authored
It now uses the same approach as the Settings back button per http://crrev.com/c/2006260 Bug: 1034183 Change-Id: I74661463921132db2756b916bed74d6384ca0215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020621 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#735507}
-
David Tseng authored
Originally applied in https://chromium-review.googlesource.com/c/chromium/src/+/1996132 Change-Id: I236a50a6a4592f280cc898bc5702b6b3d44b4f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022361Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735506}
-
Devlin Cronin authored
Browser Action API tests exercise a fair amount of the "general" behavior of the extensions menu, so it's good to have extra coverage. Parameterize them (further) to run with and without the extensions menu turned on. Bug: None Change-Id: I827a4ca4a66b4df185698a0fe68a71d80b28efac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020610Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735505}
-
Andrew Grieve authored
Bug: 726475 Change-Id: Ia9068d24655c3cff62faeaf6eec7815fec4fdba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967792Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#735504}
-
Natalie Chouinard authored
Extend SettingsActivity action bar shadow to ListFragments as well. Currently, this is only used by the Search Engine Settings screen. Manual test of new UI: https://screenshot.googleplex.com/original/HLC5cp01rKb.png Fixed: 988877 Change-Id: Iabc971dbbe19e11db83818d6c937a798ce8d494f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021333Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#735503}
-
Francois Doray authored
R=mseaborn@chromium.org TBR=mseaborn@chromium.org Bug: 1046033 Change-Id: Idc13f4bf1fc4417c5deba549129ff5b8c903ecfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023268Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735502}
-
David Black authored
We currently deep link to "chrome://os-settings/lanugages" which will bring us to the languages section of top-level OS settings. The subpage that is DCHECKed against is "chrome://os-settings/languages/details" which will actually load the languages subpage. We will now deep link to the actual subpage. Bug: b:148303041 Change-Id: I4498e25d30dd890e43b8562a998d832cff4ea18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023467Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#735501}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8c79c6e1af35..2e4f440fdeb6 git log 8c79c6e1af35..2e4f440fdeb6 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 08a3245b..5a8e8ca5 (735303:735421) 2020-01-27 srte@webrtc.org Revert "Only include overhead if using send side bandwidth estimation." Created with: gclient setdep -r src/third_party/webrtc@2e4f440fdeb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice9835e6440cad1f2b666668b060d8c9aa763719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735500}
-
Sven Zheng authored
Without timeout, the wait() may block infinitely if something goes wrong during the sign in step. Bug: 1010568 Change-Id: I244d8ea43f6ed691f0d55e55cb554b48f52e4c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017645Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#735499}
-
Joe Downing authored
TBR: pdr@chromium.org Bug: 1046030 Change-Id: I0810c75544cec478ef2c71a7149a76a0cb99b487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023348Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735498}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/3bbaaf584c20..2d483ad845f1 $ git log 3bbaaf584..2d483ad84 --date=short --no-merges --format='%ad %ae %s' 2020-01-24 quiche-dev Add a ProofSource to QuicCryptoClientConfig. 2020-01-24 quiche-dev Add a ServerProofVerifier and ClientCertMode to QuicCryptoServerConfig. 2020-01-24 quiche-dev Add an enumeration of client certificate modes to quic_types.h. 2020-01-24 quiche-dev Add a ServerProofVerifier interface to QUIC. 2020-01-24 fayang gfe-relnote: In QUIC, add OnOneRttPacketAcknowledged to TLS handshaker, and this is used to allow client mark handshake confirmed when handshake done frame is not supported. Not affecting prod, not protected. 2020-01-23 renjietang For IETF QUIC, Initialize bidirectional stream limit to 0, and unidirectional stream limit to the expected number of streams. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I9c904fab3011b18a35691b931f1a3dc115ca837a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022242 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#735497}
-
Doug Arnett authored
Also renames translate::mojom::Page interface to translate::mojom::TranslateAgent No functional changes. Bug: 1043351 Change-Id: I2994e1219ff95aadd3fd650ebb1ee79e7d7b37e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007319Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#735496}
-
Adam Langley authored
Waiting for the callback explicitly is more robust than running the MessageLoop until idle and assuming that the callback has been made. Change-Id: Icebbdc8ab0e0e9d59c6ea69c7c80dd21b2df965e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005449 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#735495}
-
Ehimare Okoyomon authored
Create a new toggle that allows the ability to turn third-party cookie blocking in incognito on and off. https://screenshot.googleplex.com/LnvCaA3SB6W.png Bug: 1040091 Change-Id: Iff32a67f6415b9fe72f9c92e4946074fdc9afc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006548 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#735494}
-
Elly Fong-Jones authored
This is a reland of fd84ab8a Original change's description: > mac: roll to 10.15 SDK > > This change rolls the hermetic Xcode to 11.2.1 aka 11B53, with the > 10.15 SDK. > > Bug: 1023913 > Change-Id: I072a57b5f9c93bc08984b05d0de3ea62886a59dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964531 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#725141} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993723 > Cr-Commit-Position: refs/heads/master@{#730238} Bug: 1023913 Change-Id: Icb5ca715edd7972c8b3824aa58a8e2b8df25d15b Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022257Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735493}
-
Kent Tamura authored
The new test should not be in WPT because the HasLineIfEmpty behavior is not defined by any standards. Bug: 1044853 Change-Id: I23e26f5ae23ccf8f283c876e8aba6f9b27f6b8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014626 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#735492}
-
Francois Doray authored
R=pkasting@chromium.org TBR=pkasting@chromium.org Bug: 1046028 Change-Id: I9c9ac87c461a10f572436fa58fbb8f492d7f4534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023465Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735491}
-
Eric Seckler authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0dace75a3e64..08a30f8552a1 git log 0dace75a3e64..08a30f8552a1 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 eseckler@google.com Merge "build: add src/tracing/ipc/service to Chrome's libperfetto" 2020-01-27 treehugger-gerrit@google.com Merge "traced_perf: re-enable linux build + add x86 regs handling" 2020-01-27 fmayer@google.com Merge "Fix StackProfileTracker for empty callstack." 2020-01-27 primiano@google.com Speculatively fix chromium roll 2020-01-27 primiano@google.com Roll clang, libcxx and fuzzer 2020-01-27 primiano@google.com Update GN and mass reformat gn files 2020-01-27 primiano@google.com Merge "GN: clean up build files, split ipc client/service" 2020-01-27 taylori@google.com Merge "perfetto-ui: Fix canvas limit px" Created with: gclient setdep -r src/third_party/perfetto@08a30f8552a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Change-Id: Ib610f52351d8b97a7a9f80f7c492e5a67b060c55 Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022646Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#735490}
-
Luke Zielinski authored
TBR=robertma Change-Id: I6608231fbf21ca05685cd44770577ddf1f37a707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019385Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735489}
-
Rohit Agarwal authored
The TemplateURL were not deleted when individual history items were removed. This is deleted only via clear browsing. The fix was to delete template urls for only those origins which don't have any urls trace in the history. The deletion is now made common for individual history deletion and clear browsing data. This CL also adds a browser test, where we add an URL to the history and delete it and checks if the corresponding template url is deleted too. Bug: 87322 Change-Id: I0b51021c17b397d8ba172d0f882778436dd66c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821611 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735488}
-
Igor authored
Device is going through enrollment flow rarely, and the logs that are written by that flow should appear only once. Which means the additions in this CL will not pollute the logs too much. BUG=chromium:1021892 TEST=Manual check that logs appear as expected at enrollment. Change-Id: Ia24c11f658ad9eb869390212bb7db8590b621135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991433Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735487}
-
Mikel Astiz authored
This reverts commit 37ca67ee with various non-trivial updates to the patch due to git conflicts as well as logic having evolved meanwhile. Reason for revert: users must have migrated to prefs after 9 months. Clients that haven't migrated meanwhile will incur in additional data downloaded from sync servers, and may worst-case run into undeletions if they were unlikely enough to have pending local deletions. Original change's description: > Reintroduce sync cache GUID migration logic from directory to prefs > > After some back and forth, we've concluded that there's too much risk > involved in assuming most clients have already migrated to prefs, i.e. > cache GUID and birthday populated. > > As middle ground, we keep considering the values in prefs the > authoritative ones, but if empty, we populate them from the sync > directory. This adds some complexity, but allows us to defer the more > aggressive turndown (disable migration), which in addition can now be > guarded behind a feature toggle. > > Bug: 923285 > Change-Id: I11c4814dae1810c34c1473af36ace9a1b517067f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609242 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659030} Bug: 923285 Change-Id: I35cad35fdd398db08ee3a5cea82eaee5ebd9e980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022787 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#735486}
-
Avery Musbach authored
1. Snap the active window in clamshell mode 2. Switch to another user session 3. Switch to tablet mode 4. Switch back to the first user session The snapped window should be carried over to tablet split view. Test: manual Change-Id: I830114212b595dc44c6513e9072141cd8282dadc Fixed: 936610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021187 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#735485}
-
Oksana Zhuravlova authored
Since all chromium clients in the renderer now use BrowserInterfaceBroker, this change marks old methods returning InterfaceProvider* as deprecated. Bug: 718652 Change-Id: Ie01d60d498e9118f7817ae9a44d2533a848b4b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020677Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#735484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b1e9971eb712..28a9b122f5a5 git log b1e9971eb712..28a9b122f5a5 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 jvanverth@google.com Revert "Wrap page index packing in helper methods." Created with: gclient setdep -r src/third_party/skia@28a9b122f5a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I3c6405c8830168605003b95d89e7b762f8092035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735483}
-
Himanshu Jaju authored
Tracks if ice configs could be fetched and parsed successfully, or if we had to rely on default stun servers for creating the connection. The time taken for response is tracked on the API dashboard. Bug: 1031147 Change-Id: Ie79916fcbb50d6d762cdcb0f3915cebe4e7f9e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022707Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#735482}
-