- 23 Aug, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2255b34f..60eaabde Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie0a038a16741ed7ade6ddc89524f15c99dd752b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689938}
-
Alex Clarke authored
We are trying to prioritize loading and compositing tasks during early load but because Document::load_event_delay_timer_ is currently TaskType::kNetworking the load event ends up firing sooner than expected causing various web_tests to fail. Specifically its the relative order between different on* callbacks which is at issue. Most other callbacks use kDOMManipulation or kMediaEvent. Using kNetworking here means that we can fire it too early — using kDOMManipulation guarantees that (almost) all on*() callbacks will run in order. This change is correct per https://html.spec.whatwg.org/#delay-the-load-event which states: "Except where otherwise specified, the task source for the tasks mentioned in this section is the DOM manipulation task source." Bug: 971191 Change-Id: Id8b503a40582de6cd388be8dadc496242ac087c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765929 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689937}
-
Vladimir Levin authored
This patch ensures that we block visual overflow if the child paint is blocked. Otherwise, this can cause DCHECKs, when the visual overflow is needed for a child of a locked element. Specifically, in these cases paint is already clean. R=chrishtr@chromium.org Bug: 989939 Change-Id: I55c05a92564f4967efa542f38bce682ffa739606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766433Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689936}
-
Aga Wronska authored
Bug: 996966 Change-Id: I11dde55997ef1f8d4e9a0a31c999020b6a427bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767602Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#689935}
-
Rayan Kanso authored
TBR=estevenson@chromium.org Bug: 996320 Change-Id: I4bfd39f0bce5942167f1756b75768413ac7a657f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765849 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#689934}
-
Nico Weber authored
Bug: 961769 Change-Id: I5190c5a6b5eae4a1a7ffb9ee0fc0f52ed29186d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762762 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689933}
-
Mathias Carlen authored
This patch adds a specific test to verify that a prompt() field set in the GetPaymentInformationAction is properly sent to the UI and shown in the status bar. This is to prevent regressions like the one fixed in crrev/c/1763683 R=arbesser@google.com Bug: b/139842776 Change-Id: I6726b3fbd70b3fe1e5c9bf9b91ddbfd9c166164a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768458Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689932}
-
Kamila authored
Bug: 986737 Change-Id: I1457cf052b036c7c8f7dd2d00ac74b649126f31c TBR: jcivelli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764190 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689931}
-
Edvard Thörnros authored
Changed SMILTimeContainer to step through all times where an animation stops or ends when just playing it normally. Currently it will only add slowdowns but also makes the animations more "correct". This commit also fixes issue 688742 Bug: 688742, 986219 Change-Id: I847abedc45aba110d09123793abfb3d9c018c94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730421 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#689930}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 911640c9. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib2c3dcb7af81da4d9b3c187faa6f686705c9df9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768780Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689929}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of f9355db3 Original change's description: > Hide invisible Tab in GTS layout better > > After switching to another tab from GTS, a thumbnail of the original > tab is taken. However, the thumbnail taking would be blocked if the > web contents of the original tab is detached. Therefore, when showing > the GTS-to-Tab transition animation to another tab, we cannot detach > the original tab. > > The original tab is supposed to be invisible, but the tab decoration > was not properly hidden. > > This CL hides the decoration of that invisible tab. > > Bug: 995992 > Change-Id: Ia55cc21ddcbbc59674fa8c8268faaddc458cd4a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764660 > Reviewed-by: Mei Liang <meiliang@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689621} TBR=meiliang@chromium.org Bug: 995992 Change-Id: I33bdbf5f96bf05cd5b055d13a01c0f5e472f2b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767609 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689928}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72c32d717ae9..222a4fb01b0a Created with: gclient setdep -r src-internal@222a4fb01b0a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I079b1242e567f3c7105c0bbce6d8f520be1258e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769016Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689927}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/082dfcd1ccbe..94dbee77eb6c git log 082dfcd1ccbe..94dbee77eb6c --date=short --no-merges --format='%ad %ae %s' 2019-08-23 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@94dbee77eb6c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I87705c21c627cc7de9fc5c32f29f0c3b77748e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689926}
-
Gyuyoung Kim authored
As the first step to removing web_localized_string.h, this CL changes the WebLocalizedString::Name argument with int resource_id. Bug: 995644 Change-Id: Idbeacddb25b45749950b32a07182ca33cd8cef1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767477Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#689925}
-
Stephen McGruer authored
font-variation-settings is a map, not an array, so the order is irrelevant when comparing the actual and expected values. Add the ability to supply a custom comparison function to interpolation-testcommon.js to support properties like this. This also exposed one test which incorrectly asserted no interpolation when there should be interpolation. Bug: 900581 Change-Id: I6c336e010c9c3642b14c945b3d7ae828f94b3f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764801 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689924}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when ServiceWorkerOnUI is enabled. This CL makes most "Push*" browser_tests pass with that feature. Some tests still fail at least because content/browser/notifications also needs to be changed. Bug: 824858 Change-Id: I1d55aa2d20782b1c2f7572557c6f9d7982329fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765051Reviewed-by:
-
Peter K. Lee authored
There are no more users or implementers of this API and can be removed. Bug: 977572 Change-Id: Iec9c57eba1c7463e42f1afa1e894c670cb098c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766981Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#689922}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I21bfb56d5283cb76f4e26dd36bb5dba6f1e22960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768976Reviewed-by:
-
Jose Dapena Paz authored
The changeset "[PM] Add a dynamic tcmalloc implementation for Linux & CrOS" introduces a build regression because of naming a namespace as "linux". But in GCC that word is predefined: ../../chrome/browser/performance_manager/graph/policies/policy_features.h:62:11: error: expected identifier before numeric constant namespace linux { Bug: 819294 Change-Id: Iecaf87987bd851ec4ee130e71451d5be40fc5517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768416 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689920}
-
Marc Treib authored
It was already disabled for flakiness on Windows. TBR=kelvinjiang@chromium.org Bug: 299393 Change-Id: I8d0f46e2b05fb9fa5fd28945e4439d9dba220ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768758Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689919}
-
Anastasiia Nikolaienko authored
Frameless window type makes dialog to show up wrong in overview mode. To hide the close button - use ShouldShowCloseButton method instead of frameless type. Bug: 991022 Change-Id: I85bda3a893cddf816eb2b793569c2ba65378b0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744428Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#689918}
-
Xida Chen authored
Most of these has corresponding tests in wpt/ already, this CL adds some additional test cases that is not covered in wpt/. Bug: 900581 Change-Id: I534b55582814b31cc0e3368afcf69eeefb45e661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763250 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#689917}
-
Egor Pasko authored
On 64bit M devices avoid asserting that browser process will always share RELROs. Currently browser process fails to share RELRO on one of our bots with "RELRO mismatch" that dives deeply into how the crazylinker works (it should be refactored IMO (to make the message more informative at least), which is not quite worth the time). We will continue watching the histogram recordings to make sure this fallback does not happen often. Bug: 990551 Change-Id: Ia838e8ff7540c863bec26a739eebd988fab2cfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757942Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#689916}
-
Ioana Pandele authored
Bug: 986317 Change-Id: Iafa5c080f70eba80f8e538c286ccdc98dc70494d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768698 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#689915}
-
Kush Sinha authored
Chrome OS attempts an automatic update for extensions on the Chrome OS Signin screen which crashes because the signin screen does not have an account associated with it. Please check the attached bugs for stack trace. Bug: 996615, 996926 Change-Id: I0d4b5efed42b439057df8c65f42b463d085ae1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765691 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689914}
-
Edvard Thörnros authored
SVGSVGElement now overrides DidMoveToNewDocument to make sure there isn't a possibility that the document time is negative. The document time could be negative in the old patches when the document was moved to a different iframe when playing. This should take care of that problem. No other functionality was changed. Bug: 996196 Change-Id: I10a0737b68c8a08eeb0528cc8698405870924272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768336 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Xida Chen authored
There are already 5 corresponding tests under css/motion/animation/ for offset-path. 001--004 are almost identical with some numbers different at from or to value. This CL adds some test cases to 005.html which don't currently exist. Bug: 900581 Change-Id: I9f6995313bdaa29baec19f26b781c95449be0a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762371Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2891cbc02f12..07489b86416c git log 2891cbc02f12..07489b86416c --date=short --no-merges --format='%ad %ae %s' 2019-08-23 primiano@google.com Add base/proc_utils.h for GetProcessId(), fix Windows build 2019-08-22 hjd@google.com Merge "perfetto-ui: Controls popup" 2019-08-22 primiano@google.com Merge "Client API: allow to configure SMB size and page size" 2019-08-22 primiano@google.com Merge "Fix chromium roll (INSTANTIATE_TEST_CASE_P/SUITE)" 2019-08-22 treehugger-gerrit@google.com Merge "Temporarily disable ConcurrentProfile test." 2019-08-22 nicomazz@google.com Fix perfetto's extension listener registration 2019-08-22 primiano@google.com Merge "Fix signed-unsigned conversions" 2019-08-22 treehugger-gerrit@google.com Merge "Add support for Dvorak keyboard layout" 2019-08-22 treehugger-gerrit@google.com Merge "client api: Introduce a bare-bones TrackEvent library" 2019-08-22 primiano@google.com Merge "Speculative fix for Windows build failure" 2019-08-22 treehugger-gerrit@google.com Merge "Removing useless permissions to the extension" 2019-08-22 oysteine@google.com Merge "Separate out the parts of HeapProfiling that CPUProfiling will reuse into StackProfiling" 2019-08-22 lalitm@google.com Merge "trace_processor: add Table and Column classes" 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add UI control to record GPU sched trace events" 2019-08-21 lalitm@google.com trace_processor: add SparseVector implementation and tests 2019-08-21 lalitm@google.com trace_processor: add RowMap implementation and tests 2019-08-21 lalitm@google.com trace_processor: add bitvector implementation 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add GPU scheduling trace events" 2019-08-21 primiano@google.com Merge "Remove use of -isystem for googletest" Created with: gclient setdep -r src/third_party/perfetto@07489b86416c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:132678367,chromium:139788095,chromium:135177627,chromium:135177627,chromium:135177627 Change-Id: I2bba8f44867e4478153ad058b186308e38cb1dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768738Reviewed-by:
-
Jose Dapena Paz authored
HeaderFieldTokenizer member input_ is a const String. Even if String is noexcept for move constructor and assign operator, that does not imply const String is also noexcept. This breaks GCC compilation. Bug: 819294 Change-Id: Iff3260e089209345f8cd816389ee7bf3a2cd24dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768419Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#689910}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c7744c15114..72c32d717ae9 Created with: gclient setdep -r src-internal@72c32d717ae9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibb297a058f4a094913df2283712888bc7e1b7692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768566Reviewed-by:
-
Michael Lippautz authored
Construction of such references is prone to bugs. Make the single argument ctors explicit to make users think about this. Bug: 997110 heap: Persistent: Mark single-argument ctors as explicit Change-Id: Ia38ffff1798c1d90cb64e9cb0d69d7e75ecc51f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768638 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Nick Burris authored
For each text match found, record a match_found trace event in TextFragmentAnchorMetrics::ReportMetrics. This helps evaluate whether the correct text was matched in the case of ambiguous matches. Bug: 994766 Change-Id: Ie92bd670dd666508e3057e9d97769bba6ed5ea81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764112 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689907}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. This makes background sync code aware of the core thread rather than assuming the IO thread. This enables content_browsertests for "*BackgroundSync*" to pass when ServiceWorkerOnUI is enabled. Bug: 824858 Change-Id: I2cbba7fbf9ee2bfabacf82a05b6398260c636ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763273Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#689906}
-
Steven Bennetts authored
This CL tracks the mojo device state associated with the network in the details page and dialog so that it can be passed to elements that require it. Currently that is just network-siminfo, but network-choose-mobile will require it as well in a follow-up. Bug: 853953 Change-Id: Iac0e88cb82c5e3a46f95e154b09910e165aedf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758522 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#689905}
-
Nico Weber authored
This reverts commit 0e9a0b02. Reason for revert: Breaks Linux CFI bot, see https://crbug.com/997103 Original change's description: > build: adjust ThinLTO's memory usage for non-Android > > In the linked bug, we discovered that clean Chrome links with ThinLTO > enabled consume quite a bit of memory. In my measurements, Chrome OS x64 > links take around 49GB, and a standard Linux ThinLTO link takes around > 46GB. > > Build command: > $ /usr/bin/time -v ninja chrome > [snip] > Maximum resident set size (kbytes): 46337504 > [snip] > $ cat args.gn > target_os = "linux" > target_cpu = "x64" > use_goma = true > is_official_build = true > is_chrome_branded = true > clang_use_default_sample_profile = true > use_thin_lto = true > > (the last two args should be redundant in this case) > > Measured similarly, Android's build takes 8-9GB on ARM, so it gets to > stay at 10GB. > > Bug: 988364 > Change-Id: Ia1bbf6b441dcb9219a37842060e72eebe7ec687e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755189 > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689090} TBR=thakis@chromium.org,pcc@chromium.org,gbiv@chromium.org,inglorion@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 988364 Change-Id: Icfab0c6b2bd4d08b524d6c32a456026af15543bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768816Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689904}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2662d14861da..f388237f87d0 git log 2662d14861da..f388237f87d0 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 perezju@chromium.org [Telemetry] Start writing intermediate results Created with: gclient setdep -r src/third_party/catapult@f388237f87d0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:981349 Change-Id: Ibb75da65db322de15583b889bf5ea647acfffda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768564Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f74e5de8..2255b34f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32c0d70b0b807bf7f83eb55291b0b858bc924dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768777Reviewed-by:
-
Yi Gu authored
This function is not used. Bug: None Change-Id: If6503339c9e39d10da3cf92bb186ccf548e86f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767050Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689901}
-
Pâris MEULEMAN authored
As the linked bug shows, there are situations where PrimaryAccountMutator::SetPrimaryAccount returns false. This can happen in the following situations: - User is already authenticated - Trying to signin with an empty account_id or email - Trying to signin with an account that is not seeded This CL changes the behavior in that situation to abort the ongoing signin instead of crashing the whole browser. Bug: 995201 Change-Id: I4192c44333b295acbb8f597887a78298e97261fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763747Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689900}
-
Michael Lippautz authored
The scope needs to span the whole marking phase to allow of CrossThreadWeakPersistent to CrossThreadPersistent observe GC as a single atomic event. Otherwise, a CTWP->CTP conversion may happen after roots processing but before clearing weak references which would allow constructing a CTP from a collected object. Bug: 996729 Change-Id: Icedc4cf5bb8db4181b11cc5726103bf90d15bb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765750Reviewed-by:
-
