- 09 Apr, 2019 40 commits
-
-
Austin Eng authored
Bug: 877147 Change-Id: I524da6e8d51fa77baf06970a3c21b2228fa46dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546884Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#649105}
-
Michael Ludwig authored
This updates the DrawRPDQ functions to attempt a series of things: 1. When there are no filters, backdrops, masks, or rrect clips, it will put the quad into the texture batch. 2. If there are no backdrops, it will use the per-edge AA api to draw the quad, but use a paint with image filters and mask filters. 3. It uses Skia's expanded SaveLayerRec features to simplify how the backdrop filters are applied. This also updates the backdrop filtering code to use the rounded border box as a clip. Bug: 947243,908953 Change-Id: I6f5c0bab05db94a4e6410d943877670f0c87b329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544791 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#649104}
-
Roman Aleksandrov authored
Add overview section with clarification for managed devices and accounts. Apply text changes. Bug: 879146 Change-Id: Ifc3ae2c2189a2e0cb62616b65c6f574574f67c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474761Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#649103}
-
David Roger authored
Gaia plans to send mirror responses on redirect responses. There was no fundamental reason why this limitation was set in Chrome, it is only historical. This CL removes the limitation and supports mirror headers on all responses including redirects. Bug: 948175 Change-Id: I0a0858def215d8fae667baaa890032327bc3bf05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554671Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#649102}
-
Boris Sazonov authored
This reverts commit be0ebdb6. Reason for revert: broke VR render tests: https://crbug.com/950817. Original change's description: > Update Permission Dialog icon color > > Bug: 949668 > Change-Id: Ie494055ac3f46d389d28ed9b030479b03b1c2225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558207 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Becky Zhou <huayinz@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#648870} TBR=twellington@chromium.org,huayinz@chromium.org,sinansahin@google.com No-Presubmit: true Bug: 949668, 950817 Change-Id: I9fdb2aa621de38d32a607d578e2234a11947825c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559142 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#649101}
-
Abhijeet Kandalkar authored
This CL moves platform/wtf/ascii_ctype.{h,cc} to platform/wtf/text/ and ports other dependent files to refer to a new include path. Bug: 950147 Change-Id: Ib86f1c51d92fc0e16386b03b33fef6f980c65fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557668 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#649100}
-
Mike Reed authored
Should land after this: https://skia-review.googlesource.com/c/skia/+/206689 Bug: skia:8937 Change-Id: I1b1fcc2b9c00b87f2ba8d92c3cfad711ba20763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558576Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#649099}
-
Joshua Pawlicki authored
This reduces the build artifacts necessary to build chrome/updater from 5k to 1.7k. Change-Id: I7332c69a5f564a08786d7e21e5891448feca8f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557988 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#649098}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/304f857d260e..0086a8acd879 git log 304f857d260e..0086a8acd879 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ynovikov@chromium.org Skip LineLoopStateChangeTest.DrawElementsThenDrawArrays on Win Vulkan AMD Created with: gclient setdep -r src/third_party/angle@0086a8acd879 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I18085ac5bc8c3570654fbfb3e97f961e426ab3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559842Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649097}
-
James Cook authored
This better matches the file it extends (content_descriptors.h), and I'm going to add descriptors for other platforms in a follow-up CL. Because this is one big enum I think it's clearer to have all Chrome-layer descriptors in a single file with ifdefs, rather than introducing descriptors_chromeos.h and splitting things. Bug: 510455 Test: compiles Change-Id: Iee3190f4992123647240e9945b8b0d9eb106946c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559245Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#649096}
-
Corentin Wallez authored
This moves it from being owned by a GC object to being owned by a refcounted object. This will allow keeping a reference to it in the refcounted GPUSwapChain support classes. BUG=chromium:877147 Change-Id: I0a0b120f13c87f2fe35cd1078c1f2fa24a7b9e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559183 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649095}
-
Raul Tambre authored
The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I091d275ba48b2cd9e9e3db8b53fa9431466ac598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552850Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#649094}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I55f3c4da480b9fb8cd2f223977b4c9c1fe9fbf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559841Reviewed-by:
-
Ruslan Burakov authored
This change is required to allow modification of Jitter Buffer delay in javascript via Origin Trial Experiment. Link to experiment description: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Tgm4qiNepJc Bug: webrtc:10287 Change-Id: I5abb6eb8f02f0868253aba00693fdcbce451c7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552824 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#649092}
-
Miyoung Shin authored
This is a followup to https://crrev.com/c/1553264. Bug: 938800 Change-Id: Iaf22371234718167c2c186e2bdcf57690d17e2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559830Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649091}
-
David Benjamin authored
I was confused when I filed that bug and did not notice proxy client certificate errors were handled elsewhere. Clearing client certificate preferences works just fine. See the discussion in https://crbug.com/828965. Bug: 814911 Change-Id: I26d65969fbfe68262d8b2dba261799ae79d2a9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559259 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#649090}
-
Kent Tamura authored
- disabledStateChangedCallback ==> formDisabledCallback - restoreStateCallback ==> formStateRestoreCallback They were renamed in the latest specification PR. Bug: 905922 Change-Id: I0d790e05c53f030f749827e45d3b693e24b801f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559519 Commit-Queue: Hayato Ito <hayato@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#649089}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e255b9cdc43d..3674ce2d885b git log e255b9cdc43d..3674ce2d885b --date=short --no-merges --format='%ad %ae %s' 2019-04-09 allenwebb@google.com usergroup_baseline: Remove /var/empty from sshd home. Created with: gclient setdep -r src/third_party/chromite@3674ce2d885b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I0d991904c1d7b35dcb912ce960578c3a4acad164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559840Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfb0e026fe00..d9b8eed84814 git log cfb0e026fe00..d9b8eed84814 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 reed@google.com Revert "Do not use sub-pixel positioning for source space" 2019-04-09 reed@google.com Revert "Add maxDimension() to glyph" 2019-04-09 robertphillips@google.com Revert "Skip flush in GrDrawingManager if the specifed proxy doesn't have any work" 2019-04-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4ba1911b2d7f..eba396cc66d3 (3 commits) 2019-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 90b1865e2a8b..82418c821689 (8 commits) 2019-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src afd96fdc..79154509 (442 commits) 2019-04-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-08 fmalita@chromium.org [skottie] More snug kTop Shaper alignment 2019-04-08 gkaiser@google.com examples: Avoid undefined behavior 2019-04-08 reed@google.com undef guard for bitmap shader 2019-04-08 reed@google.com Introduce new factory for SkColorFilters 2019-04-08 herb@google.com Add maxDimension() to glyph 2019-04-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-08 csmartdalton@google.com Disable output swizzling from GrDisableColorXP 2019-04-08 brianosman@google.com Update SPIRV caching to use SkWriter32/SkReader32 and allow inspection 2019-04-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 99740cdf2835..36eeb1311a72 (1 commits) 2019-04-08 brianosman@google.com Simplify persistent cache code, make GLSL easier for tools to access 2019-04-08 csmartdalton@google.com Add a mustWriteToFragColor() workaround flag 2019-04-08 bsalomon@google.com Start on supporting transfer from GrSurface. 2019-04-08 reed@google.com add flag to stage API change 2019-04-08 herb@google.com Do not use sub-pixel positioning for source space 2019-04-08 reed@google.com extend guard to makeAsALocalMatrixShader for google3 Created with: gclient setdep -r src/third_party/skia@d9b8eed84814 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:8968 TBR=egdaniel@chromium.org Change-Id: I1e49dae525858f5b037b3860f810090bce618fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559839Reviewed-by:
-
Stephen Chenney authored
When this was added last week, I mistakenly used 2019 instead of 2020. R=rkaplow@chromium.org Change-Id: Iaf14963934844c79b2f3bb643bc45658d90cb274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556451 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649086}
-
Jordan Demeulenaere authored
Screenshot: https://screenshot.googleplex.com/eq53CdQQLEv.png (that will be in a DFM for M75). Change-Id: I6374d259c6a18b8973896ef20c313beeaea19f35 Binary-Size: Adding background images for the Autofill Assistant feature Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556842 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649085}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I6be552cecabd5a2061065541b4deca1b3fbee9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557423Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
PolicyTestServer can now simulate errors for device_attribute_update and policy fetch requests. Bug: 950471 Change-Id: I3b9bf3c84dbe500dec34254b8e8ebf06225c359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556811 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649083}
-
Jonathan Backer authored
This allows us to use TYPED_TEST and to support GLRenderer and SkiaRenderer and remove a bit of boilerplate. TBR=kylechar@chromium.org Change-Id: I30382a03165b6d25ff20a03b67ccb20034ea99f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558791 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#649082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e82336dd47a5..7ed01b7a5be9 git log e82336dd47a5..7ed01b7a5be9 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ilkos@google.com Merge "Add start_ts to process and thread tables" Created with: gclient setdep -r src/third_party/perfetto@7ed01b7a5be9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9a9fc812083453a1514678eb3fcfa524d3a41404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559834Reviewed-by:
-
Gauthier Ambard authored
This CL changes the alpha of the (dis)appearing items during a rotation. The default behavior of the MDCCollectionViewFlowLayout is to set the alpha to 1 for all those operations, creating an effect where the appearing items are displayed at the same time as the disappearing ones, both with an alpha of 1. Bug: 949659 Change-Id: Icd768e6b3f041749c335ab70bd1c9d41d7c2b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554674 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#649080}
-
Florian Uunk authored
This will help us get some idea of how useful it would be to have identity representation for our current user base, and will allow us to track if we increase it with future changes to get users to name their profiles. Change-Id: Ic47a66a2e06ec16fdbf273cd86642e4467a030e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541188Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Andrew MacPherson authored
Use AudioParameters::HardwareCapabilities to determine valid per-device min and max buffer size values. Also allow changing the hardware latency to values within this range when opening an audio device via getUserMedia using the latency constraint. Bug: 842877 Change-Id: Ib4a5c4ba63b4a079a2784421e5a6ab16cd294082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543397 Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#649078}
-
Jeremy Roman authored
Change-Id: Ie1ca6b92de96f28ef81bdadbe2be593f3617cdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559015Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79cb521bf4a0..88192dcff2d1 Created with: gclient setdep -r src-internal@88192dcff2d1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I9cb242ee03c98a120295424a4f65c5284a7dbbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649076}
-
Marc Treib authored
These have been replaced by ReadyForStartChanged(). ReenableDatatype() was more powerful, in that it could also re-enable a type after an actual data type error, while ReadyForStartChanged() is only for "unready" errors. However, those extra powers were never used/needed. The three remaining callers of ReenableDatatype() are migrated to ReadyForStartChanged(). If one of the affected data types is disabled (e.g. via turning off the relevant pref), it will now show up in sync-internals as "Datatype not ready at config time" instead of "disabled by policy", which was never true anyway. Bug: 867846 Change-Id: Ie6516b3ff37ea70da46c6a1cf0d9b3fa345ce19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557025Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649075}
-
Rouslan Solomakhin authored
Originally landed in: https://crrev.com/c/1553170 Reverted in: https://crrev.com/c/1556857 Reason for revert: |current_update_reason_| is used before initialization in PaymentRequestSpec::RecomputeSpecForDetails() and PaymentRequestShowPromiseTest.CanShipAfterCheckingAddress still flakes. Justification for the reland: Initialized |current_update_reason_| to UpdateReason::NONE in the PaymentRequestSpec constructor and removed PaymentRequestShowPromiseTest.CanShipAfterCheckingAddress test entirely. Original change description: > Spec change: > https://github.com/w3c/payment-request/pull/672/files > > Intent to implement and ship: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/Lc2qCQgqqqk/NKOqwNweBQAJ TBR=danyao@chromium.org, yusufo@chromium.org, kenrb@chromium.org Bug: 817073 Change-Id: I7333337b8e50ae12ff609fdc82690726dd6d116b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558792 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649074}
-
Lowell Manners authored
With this change, ProfileOAuth2TokenService is now constructed only when creating an IdentityManager, eliminating the need for ProfileOAuth2TokenService factories. Change-Id: Ie52e179058ef87193bbf6cb0dda45208392c9572 Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529018Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649073}
-
Boris Sazonov authored
Disables flaky test. Example of a failed build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Lollipop%20Phone%20Tester/21318 TBR=cduvall@chromium.org Bug: 950772 Change-Id: I168e55655b7dfb0dc13e057648156e89ddca89a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559320Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ed2d0537be1..79cb521bf4a0 Created with: gclient setdep -r src-internal@79cb521bf4a0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I0da29f83d38c4ec166f34626321eb6033fbbe956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559831Reviewed-by:
-
Kush Sinha authored
Screenshot: https://crbug.com/933482#c3 Bug: 933482 Change-Id: I0a260745503bb46be895896c95492a9c35815d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556794 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649070}
-
Anders Hartvoll Ruud authored
This is needed for the Cascade Project, which will use CSSPropertyName as the HashMap key. HashTraits requires the key object to support "empty" and "deleted" values. This is implemented by storing kEmptyValue and kDeletedValue in an integer which is shared with the CSSPropertyID. Constructing empty or deleted CSSPropertyNames is not advisable outside of HashTraits, hence the relevant constructor is exposed via friendship. (Inspired by PropertyHandle). BUG=947004 R=futhark@chromium.org Change-Id: I48bfb3707f73f0cadd7696075fce622352f9dee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553555Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#649069}
-
Dominic Battré authored
This reverts commit d5b00821. Reason for revert: Breaks compilation. ../../content/public/common/web_preferences.h:18:10: fatal error: 'third_party/blink/public/mojom/v8_cache_options.mojom.h' file not found #include "third_party/blink/public/mojom/v8_cache_options.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > This CL moves bluetooth folder from public/platform/modules to > public/mojom/ to gather mojom files to mojom folder with > creating web_bluetooth_mojo_bindings. > > Bug: 919393 > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#649061} TBR=kinuko@chromium.org,blundell@chromium.org,haraken@chromium.org,jbudorick@chromium.org,dougt@chromium.org,hnakashima@chromium.org,jkim@igalia.com Change-Id: I0ebd0abd67e8ed975cb2f517800296493cdda513 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559180Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649068}
-
Dominic Battre authored
This CL fixes a crash that was introduced in ~PrefNotifierImpl(). The call of pref_service_->HasInMemoryUserPrefStore() dereferenced the user_pref_store_ of the PrefService which was destroyed before the pref_notifier_ was destroyed. Bug: 942491, 946668, 945772 Change-Id: I1f5749e013311a4a13f94214435f8a1b7e99329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559138Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649067}
-
Stephen McGruer authored
Intent to ship with 3x LGTM: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/UMxgGkxhdCo/CHZ2H9DsBgAJ Bug: 948657 Change-Id: I9c9ac4969f5708c310c9a8a95120fd5a0d3cdc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553448Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649066}
-
