- 12 Nov, 2020 40 commits
-
-
Ella Ge authored
This CL adds a jni method to let QualityEnforcer notify native and send a console message for violations. We will move to use devtools issue tab instead in the near future. (TODO in quality_enforcer.cc) The warning together with the toast warning are behind a flag TRUSTED_WEB_ACTIVITY_QUALITY_ENFORCEMENT_WARNING, just in case we need to disabled them for any reason. The flag is *Enabled* for now since we have all approval on launch bug: crbug/1127892 To have a valid tab and WebContent to send the message to, moves the check of digital asset link violation to onDidFinishNavigation from onFinishNativeInitialization. This also moves the ViolationType enum to c++ part to be able to share between c++ and java. Bug: 1147479 Change-Id: If0f80fee412ea522a7202226a72b169092525cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530800 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826701}
-
Yuki Shiino authored
This reverts commit 6fe88955. Reason for revert: Suspicious about causing test failures: ProtoUtilTest.* https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/26187 Original change's description: > Feature to locally auto-dismiss the notice card in Feed V2 > > Bug: 1146458 > Change-Id: Ibca4559552d991667ea5043687845e845b251db1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527719 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826640} TBR=vincb@google.com,harringtond@chromium.org Change-Id: Ia0515d8e3d2c1af678cbf5533c4e28ac5f46ed77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531812Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#826700}
-
Clemens Arbesser authored
This adds handling for when the user taps the back button or the feedback button. This CL also makes swipe-to-dismiss a configurable trigger script action. The corresponding metric enum was moved from |Finished| to |Shown|, since this may now happen more than once per run. Bug: b/171776026 Change-Id: I6d78c15ab1378c533eeafb41b59117ba241f17ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530329Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#826699}
-
Yuki Shiino authored
This reverts commit 23c810e8. Reason for revert: Suspicious about causing test failures. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Original change's description: > removed unnecessary defderred PrepareTpmDeviceAndFinalizeProfile > > According to the current program flow, this to-be-removed branch seems a > useless special handling. > > This CL might affect how UserSessionManager utilitzes tpm manager client > in the near future. > > BUG=b:172748724 > TEST=unittests. > > Change-Id: I93f05a45409878db1138c8d49d835f1d7f0c427e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525471 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Leo Lai <cylai@google.com> > Cr-Commit-Position: refs/heads/master@{#826319} TBR=alemate@chromium.org,rsorokin@chromium.org,khmel@chromium.org,cylai@google.com Change-Id: If82cbaa7a634a6a33667ea139f0ec8e6f5055716 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172748724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534273Reviewed-by:
-
Christian Dullweber authored
UrlFormatter.formatUrlForSecurityDisplay is too strict and displays some valid URLs in punycode. Add new url formatter with the difference that non-dangerous non-ascii characters are displayed correctly and www subdomains are omitted Bug: 1077766 Change-Id: I896fbf0a4d89df36c5fc882afaf09d1366f5423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532294Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#826697}
-
Dominik Röttsches authored
The FreeType-Testing GitHub repository is a project connected to the FreeType font rasterisation library which provides a set of fuzzing-harnesses for oss-fuzz. After issue 1139963 we want to build and run a fuzzing configuration that matches the FreeType build configuration that we use for Chromium. This CL achieves that for the first harness: truetype-render-fuzzer, the main glyph rasterisation harness. The CL adds the GPL-licensed FreeType-Testing repository to third-party as a non-shipping dependency in order to be able to build the same harnesses as part of Chromium and against Chromium's freetype-harfbuzz build target. It defines a fuzzer_test build target to build the TrueTypeRenderFuzzTarget and defines which seed_corpus directory to use from the freetype-testing set of corpora. Bug: 1140584 Cq-Include-Trybots: luci.chromium.try:linux-libfuzzer-asan-rel Change-Id: Icb2ab2d4ee65fd7d1d45ebfe9ca01ff0ef3628e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529104Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#826696}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I5ec5132b286ab2f67e971abca49c72f9117870bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494401 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826695}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 05227c04. With Chromium commits locally applied on WPT: 50d5488e "Revert "webauthn: move create credential tests for residentKey/credProps to WPT"" c0e73fce "[webcodecs] Make sure callbacks aren't called after encoder.reset()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I788499f71085d09be46aae3669f32da25627f810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532998Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826694}
-
Mason Freed authored
Per more feedback [1] on the issue thread, it would be preferred to remove the state from DOMParser and add it instead to the parseFromString method. [1] https://github.com/whatwg/dom/issues/912#issuecomment-725825635 Bug: 1042130 Change-Id: I316c008b80436bdacf7d0548e4ccd891a5c15411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533848 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#826693}
-
Kent Tamura authored
This CL removes DEFINE_LAYOUT_OBJECT_TYPE_CASTS for LayoutBoxModelObject. * Remove all remaining usages of old downcast helper for LayoutBoxModelObject * Remove LayoutBoxModelObjectTest::GetPaintLayerByElementId(). It's redundant because we have |RenderingTest:: GetPaintLayerByElementId()|. * Add LayoutBoxModelObjectTest::GetLayoutBoxModelObjectByElementId() to reduce the usage of ToLayoutBoxModelObject(). This CL has no behavior changes. Bug: 891908 Change-Id: I6cbad49a2b872d8571f466b4ec5c7b3c313616e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532139 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826692}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/034eac1e..f3414dbc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide877334cefffd534ddd7415ddb2e55861ca09d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534093Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826691}
-
John Palmer authored
Call setAssistiveWindowProperties only when needed. This stops breaking ChromeVox This reverts commit a7f6e1a1. Reason for revert: Adding a fix so that ChromeVox editing notifications still work Original change's description: > Revert "Make assistive window show with autocorrect manager" > > Fixed: 1146877 > TBR=jopalmer@chromium.org > > Reason for revert: > Breaks ChromeVox; found via bisect; see bug. > > This reverts commit 6cbffa8a. > > Dependent changes (also reverted): > 73bcb673 > 84c821b5 > b197149c > > Change-Id: I65bc46c273cd64555676073cf6cd172128cfe068 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529695 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825948} Change-Id: I3d4b08c6197f287dbf55fca2d377ce577c81a617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530953Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826690}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/36fdadd1a606..e48f06fb0cca 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia237f648e215de00a287198053ce677f8ef1b16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533997Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826689}
-
Yuki Shiino authored
This reverts commit 30a60064. Reason for revert: Suspicious about causing test failures. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4433 Original change's description: > [ozone/x11] Enabled user input monitor unit tests. > > This CL adds Ozone platform initialisation to the user input monitor tests > so they can now work with Ozone enabled. > > Bug: 1109112 > Change-Id: I31f9dabf2da9eed85cd05fe27017899b0247f4bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521144 > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826638} TBR=sky@chromium.org,adunaev@igalia.com Change-Id: Ic8cd3da17dd5d2de01981aa9a8f33b6a55621c43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531810Reviewed-by:
-
Yuki Shiino authored
This reverts commit ca288e0c. Reason for revert: Suspicious about build breakage. https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/3020 Original change's description: > Offer to install Rosetta for Widevine if it's not already installed > > If a page wants a CDM and it's unavailable, show an infobar. If > the user agrees, install Rosetta for them. > > Bug: 1145792, 1142017 > Change-Id: I92f030c2dbb5d9b092b84252fddee6f7ad55a436 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527771 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826636} TBR=avi@chromium.org,pkasting@chromium.org,thakis@chromium.org,xhwang@chromium.org,ericde@google.com,rsesek@chromium.org,mark@chromium.org Change-Id: I7c7f88b0690f801cdfb990562f7938d73676bf23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145792 Bug: 1142017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534272Reviewed-by:
-
Yuki Shiino authored
This reverts commit 49dbb543. Reason for revert: Suspicious about making RepeatableQueriesServiceTest.SignedOut_Deletion flaky. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29?limit=200 Original change's description: > [NTP][RQ] Makes deletion of queries from in-memory URL DB asynchronous > > Deletion from the in-memory URL DB can be slow: http://shortn/_eSkRG8RvpV > This CL makes the deletion of queries from the in-memory URL DB async > by posting the deletion task to a sequenced task runner on the UI thread. > > Fixed: 1110077 > Change-Id: Ia8099093eea6efde952bfbb58cd182b06174f8e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531654 > Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826399} TBR=mahmadi@chromium.org,ramyan@chromium.org Change-Id: I6377c865ef669849aa9f4fa484e80f3544531280 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532543Reviewed-by:
-
Xing Liu authored
Android R starts to restrict other apps to access app's private directory on R. Based on suggestion from Android engineer, we can use a few new APIs added in Q and R to move the storage path a non private directory. Old path: /storage/$volume_id/$app_private_directory/Download New path: /storage/&volume_id/Download Bug: 1116905 Change-Id: Iecb34a08648678dbd1ff986c7ee60f3a4647c725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515262Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826685}
-
Morten Stenshorne authored
AppendSingleFragmentIgnoringPagination() is called when fragmentation gets disabled because of transforms. This needs to be fixed; see crbug.com/1058792 - in the meantime, let's at least traverse the fragment tree, to avoid DCHECK failures. Note that things aren't going to look or behave right if such nodes break into multiple fragments - neither with nor without this fix. Bug: 1146975 Change-Id: I7ded8d094185e69e39ce115b256661dee48f7e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529099Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826684}
-
Rakina Zata Amni authored
Currently we only track visibilitychange on document, but the event might bubble up to window. It's possible for web developers to add the event listener on window instead, and we should still disable sudden terminations if that's the case. Bug: 1135582 Change-Id: Iae7f783b9e1713b3409b6f385148388932f0087d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526883Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#826683}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28f538d7ea5a..74f0f62cef42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: I13b7009cf0a7396233caed00a471400da63e509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533895Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826682}
-
Glen Robertson authored
Trying to match the restrictions in the Payment Request API spec [1] (DG isn't spec'd yet). We require that the "payment" feature policy is enabled. Secure context is already ensured by the IDL. Also add some logging of errors so developers can figure out what is going wrong. [1]: https://w3c.github.io/payment-request/#dfn-payment-relevant-browsing-context Bug: 1061503 Change-Id: I2c13663148ad8736a4d9ab3ea124d96038d8e878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526872Reviewed-by:
-
Yao Xiao authored
Why: we don't want floc to change more often than the intended scheduled update cadence. What: - For each history-delete notification, if it's all-history or the time-range overlaps with the time range of the history used to compute the floc, we invalidate the floc. Otherwise, we keep using the current floc. - Remove the mechanism caching the swaa_nac_account_enabled status. It's no longer needed as we don't need to query more often than the scheduled update rate (% rare race condition). How: Store history_begin_time_/history_end_time_ fields to FlocId. Compare these fields with the history delete info. Bug: 1143597 Change-Id: I685fd1a10cbc8044e799d7a644dfa2b7bb82ddd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507454 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826680}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3f0d0cc3810..53d3c085a784 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I83d83edb52833daf49e9c25be8df478e191a5a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533728Reviewed-by:
-
Benjamin Gordon authored
The ippusb backend is the same as the airscan backend, but used over USB instead of the network. Add enum values corresponding to the same manufacturer list that we track for the airscan backend. crrev.com/c/2533675 adds the same values on the Chrome OS side. Bug: b:153544296 Bug: b:160472550 Change-Id: I0bc253f58a16231c5b995b3f8aac0c89273941bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533795Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826678}
-
dpapad authored
Moving most IDR_WEBUI_CSS_* resources from webui_resources.grd to the auto-generated webui_generated_resources.grd. Resources that rely on flattenhtml=true are not affected, since |flattenhtml| is purposefully not supported by generate_grd(). Bug: 1132403 Change-Id: Iee43d27b9d34a0f9062dab5e6a56c1c428b5cca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521930 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#826677}
-
Shannon Chen authored
Add a rightMouseKey in SyntheticMouseEvent in accessibility API to allow the option of sending the event on the selected mouse key (left, right, middle, forward, back). Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: None Change-Id: Ib5cd2b1ac30dc7a5efe41b09e0bc17650916ad7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531094 Commit-Queue: Shannon Chen <shannc@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
Add separate feature flags for video and main dcomp swap chains. Bug: 1117318 Change-Id: Ic02400c56dc831dadf1cf43c4b948cea806dd5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533836 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#826675}
-
Bartek Nowierski authored
Until now the 1st page was uncommitted only on 32-bit architectures, which looks like a mistake. It isn't used on 64-bit either and it should be uncommitted there too, in order not to waste space. Change-Id: I107dd8c064f92546bfaad01ea00747b721751172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533214Reviewed-by:
-
Mason Freed authored
This CL updates the eyedropper button from the color picker to have the correct aria name and role. Bug: 1141168 Change-Id: I6f10794027d26c38785ee47b51fb8b6f3ebe69d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528303 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#826673}
-
François Degros authored
Bug: 1056077 Change-Id: If20f3e795f64a402f4209fff53e7c65e2dc1aa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532486Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826672}
-
Xing Liu authored
Only the browser process needs to initialize Chime SDK through ChimeDelegate. Renderer process will crash and hang since we try to access the shared preference in a sandbox process. TBR=dtrainor@chromium.org Bug: 1146954 Change-Id: I21f84b4b507423d1672d6778f782666c2a384950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527530Reviewed-by:
-
rajendrant authored
This CL adds the robots rules that will be retrieved from Litepages, and some support classes to parse and apply the rules. Bug: 1144836 Change-Id: I4ae00f0b08ccbb0ddfe98007c18f041f64d8022b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518970 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#826670}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605095997-f02476ae2299d621bcc109d9e9e9e82082bcc8d2.profdata to chrome-win64-master-1605128385-e428bee778404d65a307409bc6db7ad616d50a2d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I104f5f2ff83014b0a66628d8060f9a0ed84a0d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533685Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea635f12e83e..36fdadd1a606 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e2f4394f3d4a2d69b17b11da66eadb27f6bf95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533962Reviewed-by:
-
Clark DuVall authored
This reverts commit 10e2cc6c. Reason for revert: Possibly causing crash in crbug.com/1148015. Original change's description: > Cache return values from BundleUtils.createIsolatedSplitContext() > > This avoids getting a newly created ContextImpl from every call to > Context.createContextForSplit(). > > Bug: 1126301 > Change-Id: I080841b697e2f28000d2a4d11ff197a015a1dca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527852 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825990} TBR=agrieve@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1126301, 1148015 Change-Id: I15b2f1283c8de5d6e8eee9fe17917f3399bc9e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533844Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826667}
-
rbpotter authored
Bug: 1132403 Change-Id: Ic0f6da7e726d727a323baa194221107646bd9a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530898 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826666}
-
Toni Barzic authored
The waiter was not checking whether the home launcher visibility matches the expected state before starting the wait, and was relying on HomeLauncherAnimationComplete getting called (which only works for transitions initiated by user actions - e.g. drag gesture or pressing the home button). This changes the API implementation to work for wider set of cases - for example to wait for launcher transition to end after transition to tablet mode. The implementation now: 1. Verifies that app list state is as expected before checking home launcher visibility(e.g. during tablet mode transition the app list may animate from closed to fullscreen state) 2. Home launcher state waiter now returns early if the launcher already has the target visibility. 3. Waits for the visibility state to change - the waiter remains the same in the test API, but the state change callback now runs whenever the home launcher visibility changes to a final value. BUG=1147906, 1143980 Change-Id: I3728f12d81241ad84e0db95ea50779bd2598e1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530594 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: -
kouhei authored
This CL introduces a lifecycle statemachine to AgentSchedulingGroupHost. The `AgentSchedulingGroupHost::state_` makes it explicit which lifestage the AgentSchedulingGroupHost is currently at, and checks if each method is called on one of the assumed states. This is a preparatory work to introducing AgentSchedulingGroupHost shutdown, which will add more states to the state machine. Bug: 1141459 Change-Id: Ic8c4f4f85322b52612510b3354d5ae6828311263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492281 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#826664}
-
Austin Tankiang authored
There is an Available Offline toggle already on the toolbar, so this menu item is superfluous. Bug: 1145058 Change-Id: Ifa48b9e6c40d49be181f48b30c308cc0fbf1d329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526873 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#826663}
-
Yutaka Hirano authored
No one implements the method in a meaningful way. Bug: None Change-Id: I5eb3ca12ef4dd904e680a108bd1c1156414a6dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528783Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#826662}
-
